possible deadlock in ocfs2_xattr_set

Status: upstream: reported on 2024/09/25 09:02
Reported-by: syzbot+c0d46b51c54922dc038f@syzkaller.appspotmail.com
First crash: 713d, last: 2h30m
Similar bugs (3)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-5.15 possible deadlock in ocfs2_xattr_set 4 493 3d23h 725d 0/3 upstream: reported on 2024/09/14 01:11
upstream possible deadlock in ocfs2_xattr_set prio:high ocfs2 4 9370 2d05h 729d 0/29 upstream: reported on 2024/09/10 05:07
linux-6.6 possible deadlock in ocfs2_xattr_set 4 453 15h17m 446d 0/2 upstream: reported on 2025/06/19 18:15

Sample crash report:
ocfs2: Mounting device (7,1) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.1.7656/21902 is trying to acquire lock:
ffff88805530c2c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:764 [inline]
ffff88805530c2c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_xattr_set+0xbe4/0x1390 fs/ocfs2/xattr.c:3632

but task is already holding lock:
ffff888055309538 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x491/0x1390 fs/ocfs2/xattr.c:3593

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&oi->ip_xattr_sem){++++}-{3:3}:
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_init_acl+0x307/0x770 fs/ocfs2/acl.c:365
       ocfs2_mknod+0x18e0/0x2580 fs/ocfs2/namei.c:410
       ocfs2_create+0x1b6/0x4b0 fs/ocfs2/namei.c:674
       vfs_create+0x2db/0x460 fs/namei.c:3235
       do_mknodat+0x3a1/0x4d0 fs/namei.c:4086
       __do_sys_mknod fs/namei.c:4119 [inline]
       __se_sys_mknod fs/namei.c:4117 [inline]
       __x64_sys_mknod+0x8a/0xa0 fs/namei.c:4117
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (jbd2_handle){++++}-{0:0}:
       jbd2_journal_lock_updates+0xa8/0x390 fs/jbd2/transaction.c:880
       __ocfs2_flush_truncate_log+0x2cf/0x1220 fs/ocfs2/alloc.c:6029
       ocfs2_flush_truncate_log+0x4b/0x60 fs/ocfs2/alloc.c:6076
       ocfs2_sync_fs+0x119/0x330 fs/ocfs2/super.c:402
       sync_filesystem+0x1be/0x220 fs/sync.c:66
       ocfs2_remount+0x115/0xb40 fs/ocfs2/super.c:611
       reconfigure_super+0x224/0x8d0 fs/super.c:977
       do_remount fs/namespace.c:2741 [inline]
       path_mount+0xcce/0xfb0 fs/namespace.c:3400
       do_mount fs/namespace.c:3421 [inline]
       __do_sys_mount fs/namespace.c:3629 [inline]
       __se_sys_mount+0x2e3/0x3d0 fs/namespace.c:3606
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3095 [inline]
       check_prevs_add kernel/locking/lockdep.c:3214 [inline]
       validate_chain kernel/locking/lockdep.c:3830 [inline]
       __lock_acquire+0x2d18/0x7c40 kernel/locking/lockdep.c:5063
       lock_acquire+0x1bb/0x4a0 kernel/locking/lockdep.c:5676
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:764 [inline]
       ocfs2_xattr_set+0xbe4/0x1390 fs/ocfs2/xattr.c:3632
       __vfs_setxattr+0x3d8/0x410 fs/xattr.c:182
       __vfs_setxattr_noperm+0x126/0x5e0 fs/xattr.c:216
       vfs_setxattr+0x167/0x2e0 fs/xattr.c:309
       do_setxattr fs/xattr.c:594 [inline]
       setxattr+0x2a3/0x330 fs/xattr.c:617
       path_setxattr+0x147/0x290 fs/xattr.c:636
       __do_sys_lsetxattr fs/xattr.c:659 [inline]
       __se_sys_lsetxattr fs/xattr.c:655 [inline]
       __x64_sys_lsetxattr+0xb4/0xd0 fs/xattr.c:655
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2 --> jbd2_handle --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);

 *** DEADLOCK ***

3 locks held by syz.1.7656/21902:
 #0: ffff88801ff04460 (sb_writers#21){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:402
 #1: ffff888055309808 (&sb->s_type->i_mutex_key#43){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:764 [inline]
 #1: ffff888055309808 (&sb->s_type->i_mutex_key#43){+.+.}-{3:3}, at: vfs_setxattr+0x140/0x2e0 fs/xattr.c:308
 #2: ffff888055309538 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x491/0x1390 fs/ocfs2/xattr.c:3593

stack backtrace:
CPU: 1 PID: 21902 Comm: syz.1.7656 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/24/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x24e lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3095 [inline]
 check_prevs_add kernel/locking/lockdep.c:3214 [inline]
 validate_chain kernel/locking/lockdep.c:3830 [inline]
 __lock_acquire+0x2d18/0x7c40 kernel/locking/lockdep.c:5063
 lock_acquire+0x1bb/0x4a0 kernel/locking/lockdep.c:5676
 down_write+0x36/0x60 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:764 [inline]
 ocfs2_xattr_set+0xbe4/0x1390 fs/ocfs2/xattr.c:3632
 __vfs_setxattr+0x3d8/0x410 fs/xattr.c:182
 __vfs_setxattr_noperm+0x126/0x5e0 fs/xattr.c:216
 vfs_setxattr+0x167/0x2e0 fs/xattr.c:309
 do_setxattr fs/xattr.c:594 [inline]
 setxattr+0x2a3/0x330 fs/xattr.c:617
 path_setxattr+0x147/0x290 fs/xattr.c:636
 __do_sys_lsetxattr fs/xattr.c:659 [inline]
 __se_sys_lsetxattr fs/xattr.c:655 [inline]
 __x64_sys_lsetxattr+0xb4/0xd0 fs/xattr.c:655
 do_syscall_x64 arch/x86/entry/common.c:46 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f67eb59e159
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f67ec517028 EFLAGS: 00000246 ORIG_RAX: 00000000000000bd
RAX: ffffffffffffffda RBX: 00007f67eb825fa0 RCX: 00007f67eb59e159
RDX: 0000000000000000 RSI: 0000200000000200 RDI: 0000200000000280
RBP: 00007f67eb63503b R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f67eb826038 R14: 00007f67eb825fa0 R15: 00007ffc13176bd8
 </TASK>

Crashes (956):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2026/09/09 04:44 linux-6.1.y cf82dcca9634 8387c273 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_xattr_set
2026/09/06 19:43 linux-6.1.y cf82dcca9634 4f7b22a0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_xattr_set
2026/09/04 04:58 linux-6.1.y cf82dcca9634 801f0966 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_xattr_set
2026/08/25 00:27 linux-6.1.y 05208478041c 614e416a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_xattr_set
2026/08/12 02:07 linux-6.1.y e4f7d8be268e f8d35649 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_xattr_set
2026/08/11 13:42 linux-6.1.y e4f7d8be268e 71790083 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_xattr_set
2026/08/10 11:52 linux-6.1.y e4f7d8be268e 5d63f80b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_xattr_set
2026/08/10 07:15 linux-6.1.y e4f7d8be268e 5d63f80b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_xattr_set
2026/08/06 18:57 linux-6.1.y 03f3a99e8e93 c38879ea .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_xattr_set
2026/07/27 12:32 linux-6.1.y dc5c83b7f5f8 aae9036b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_xattr_set
2026/07/20 11:25 linux-6.1.y 090666d3cc90 de6a700d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_xattr_set
2026/07/15 17:07 linux-6.1.y 090666d3cc90 a4ed0f4f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_xattr_set
2026/07/14 15:56 linux-6.1.y 090666d3cc90 2130f682 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_xattr_set
2026/07/14 00:46 linux-6.1.y 090666d3cc90 2130f682 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_xattr_set
2024/09/25 09:02 linux-6.1.y e526b12bf916 349a68c4 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_xattr_set
2026/09/07 18:02 linux-6.1.y cf82dcca9634 680aa3e1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/09/06 10:19 linux-6.1.y cf82dcca9634 4f7b22a0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/09/05 17:29 linux-6.1.y cf82dcca9634 4f7b22a0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/09/05 13:48 linux-6.1.y cf82dcca9634 4f7b22a0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/09/04 09:50 linux-6.1.y cf82dcca9634 f65209a4 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/09/04 00:49 linux-6.1.y cf82dcca9634 801f0966 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/09/02 18:20 linux-6.1.y cf82dcca9634 85995287 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/09/01 17:13 linux-6.1.y d64a499eea6b 587f6b29 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/08/31 18:43 linux-6.1.y d64a499eea6b 316d9396 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/08/31 18:40 linux-6.1.y d64a499eea6b 316d9396 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/08/31 02:30 linux-6.1.y d64a499eea6b 2f52988a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/08/30 15:37 linux-6.1.y d64a499eea6b 2f52988a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/08/29 22:37 linux-6.1.y d64a499eea6b 2f52988a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/08/28 23:31 linux-6.1.y d64a499eea6b 2f52988a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/08/28 10:02 linux-6.1.y d64a499eea6b e2fa417d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/08/27 18:00 linux-6.1.y 79a9660d699e 69a01293 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/08/23 10:58 linux-6.1.y 7e6e67054721 1e72964b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/08/19 16:18 linux-6.1.y 7e6e67054721 1e72964b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/08/19 10:37 linux-6.1.y e4f7d8be268e 1e72964b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/08/19 05:38 linux-6.1.y e4f7d8be268e 1e72964b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/08/17 12:13 linux-6.1.y e4f7d8be268e 905244d6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/08/17 06:37 linux-6.1.y e4f7d8be268e 746171ee .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/08/16 21:55 linux-6.1.y e4f7d8be268e 746171ee .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/08/15 04:42 linux-6.1.y e4f7d8be268e 746171ee .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/08/15 04:41 linux-6.1.y e4f7d8be268e 746171ee .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/08/14 05:20 linux-6.1.y e4f7d8be268e b13552fe .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/08/09 17:34 linux-6.1.y e4f7d8be268e 5d63f80b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/08/09 15:48 linux-6.1.y e4f7d8be268e 5d63f80b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/07/27 13:58 linux-6.1.y dc5c83b7f5f8 aae9036b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/07/12 18:52 linux-6.1.y 090666d3cc90 d78ea535 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/07/11 18:36 linux-6.1.y 090666d3cc90 d78ea535 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/07/11 16:42 linux-6.1.y 090666d3cc90 d78ea535 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
2026/07/11 07:03 linux-6.1.y 090666d3cc90 d78ea535 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_xattr_set
* Struck through repros no longer work on HEAD.