syzbot

overlayfs: upper fs does not support RENAME_WHITEOUT.
======================================================
WARNING: possible circular locking dependency detected
6.15.0-rc6-syzkaller-00208-g3c21441eeffc #0 Not tainted
------------------------------------------------------
syz.3.180/7657 is trying to acquire lock:
ffff88804e905f40 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
ffff88804e905f40 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{4:4}, at: ocfs2_xattr_set+0xadd/0x11f0 fs/ocfs2/xattr.c:3622

but task is already holding lock:
ffff888057b7bff8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x40f/0x11f0 fs/ocfs2/xattr.c:3583

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&oi->ip_xattr_sem){++++}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1524
       ocfs2_init_acl+0x2f9/0x720 fs/ocfs2/acl.c:366
       ocfs2_mknod+0x1321/0x2050 fs/ocfs2/namei.c:410
       ocfs2_create+0x1a5/0x440 fs/ocfs2/namei.c:673
       vfs_create+0x24b/0x400 fs/namei.c:3398
       do_mknodat+0x3c6/0x4d0 fs/namei.c:4278
       __do_sys_mknod fs/namei.c:4311 [inline]
       __se_sys_mknod fs/namei.c:4309 [inline]
       __x64_sys_mknod+0x8c/0xa0 fs/namei.c:4309
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (jbd2_handle){++++}-{0:0}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       jbd2_journal_lock_updates+0xaa/0x360 fs/jbd2/transaction.c:861
       __ocfs2_flush_truncate_log+0x2ba/0x10e0 fs/ocfs2/alloc.c:6037
       ocfs2_flush_truncate_log+0x4f/0x70 fs/ocfs2/alloc.c:6084
       ocfs2_sync_fs+0x116/0x310 fs/ocfs2/super.c:406
       sync_filesystem+0x1cc/0x230 fs/sync.c:66
       generic_shutdown_super+0x6f/0x2c0 fs/super.c:621
       kill_block_super+0x44/0x90 fs/super.c:1710
       deactivate_locked_super+0xbc/0x130 fs/super.c:473
       cleanup_mnt+0x425/0x4c0 fs/namespace.c:1431
       task_work_run+0x1d1/0x260 kernel/task_work.c:227
       resume_user_mode_work+0x5e/0x80 include/linux/resume_user_mode.h:50
       exit_to_user_mode_loop kernel/entry/common.c:114 [inline]
       exit_to_user_mode_prepare include/linux/entry-common.h:329 [inline]
       __syscall_exit_to_user_mode_work kernel/entry/common.c:207 [inline]
       syscall_exit_to_user_mode+0x9a/0x120 kernel/entry/common.c:218
       do_syscall_64+0x103/0x210 arch/x86/entry/syscall_64.c:100
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3166 [inline]
       check_prevs_add kernel/locking/lockdep.c:3285 [inline]
       validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3909
       __lock_acquire+0xaac/0xd20 kernel/locking/lockdep.c:5235
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:867 [inline]
       ocfs2_xattr_set+0xadd/0x11f0 fs/ocfs2/xattr.c:3622
       __vfs_setxattr+0x439/0x480 fs/xattr.c:200
       __vfs_setxattr_noperm+0x12d/0x660 fs/xattr.c:234
       vfs_setxattr+0x16b/0x2f0 fs/xattr.c:321
       ovl_do_setxattr fs/overlayfs/overlayfs.h:315 [inline]
       ovl_setxattr fs/overlayfs/overlayfs.h:327 [inline]
       ovl_make_workdir fs/overlayfs/super.c:715 [inline]
       ovl_get_workdir+0xb86/0x1700 fs/overlayfs/super.c:827
       ovl_fill_super+0x1386/0x35d0 fs/overlayfs/super.c:1406
       vfs_get_super fs/super.c:1280 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1299
       vfs_get_tree+0x92/0x2b0 fs/super.c:1759
       do_new_mount+0x24a/0xa40 fs/namespace.c:3881
       do_mount fs/namespace.c:4221 [inline]
       __do_sys_mount fs/namespace.c:4432 [inline]
       __se_sys_mount+0x317/0x410 fs/namespace.c:4409
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6 --> jbd2_handle --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6);

 *** DEADLOCK ***

4 locks held by syz.3.180/7657:
 #0: ffff88803316e0e0 (&type->s_umount_key#67/1){+.+.}-{4:4}, at: alloc_super+0x204/0x970 fs/super.c:344
 #1: ffff888078e40420 (sb_writers#18){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:556
 #2: ffff888057b7c2c0 (&sb->s_type->i_mutex_key#28){++++}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
 #2: ffff888057b7c2c0 (&sb->s_type->i_mutex_key#28){++++}-{4:4}, at: vfs_setxattr+0x144/0x2f0 fs/xattr.c:320
 #3: ffff888057b7bff8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x40f/0x11f0 fs/ocfs2/xattr.c:3583

stack backtrace:
CPU: 0 UID: 0 PID: 7657 Comm: syz.3.180 Not tainted 6.15.0-rc6-syzkaller-00208-g3c21441eeffc #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120
 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2079
 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2211
 check_prev_add kernel/locking/lockdep.c:3166 [inline]
 check_prevs_add kernel/locking/lockdep.c:3285 [inline]
 validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3909
 __lock_acquire+0xaac/0xd20 kernel/locking/lockdep.c:5235
 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
 down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
 inode_lock include/linux/fs.h:867 [inline]
 ocfs2_xattr_set+0xadd/0x11f0 fs/ocfs2/xattr.c:3622
 __vfs_setxattr+0x439/0x480 fs/xattr.c:200
 __vfs_setxattr_noperm+0x12d/0x660 fs/xattr.c:234
 vfs_setxattr+0x16b/0x2f0 fs/xattr.c:321
 ovl_do_setxattr fs/overlayfs/overlayfs.h:315 [inline]
 ovl_setxattr fs/overlayfs/overlayfs.h:327 [inline]
 ovl_make_workdir fs/overlayfs/super.c:715 [inline]
 ovl_get_workdir+0xb86/0x1700 fs/overlayfs/super.c:827
 ovl_fill_super+0x1386/0x35d0 fs/overlayfs/super.c:1406
 vfs_get_super fs/super.c:1280 [inline]
 get_tree_nodev+0xbb/0x150 fs/super.c:1299
 vfs_get_tree+0x92/0x2b0 fs/super.c:1759
 do_new_mount+0x24a/0xa40 fs/namespace.c:3881
 do_mount fs/namespace.c:4221 [inline]
 __do_sys_mount fs/namespace.c:4432 [inline]
 __se_sys_mount+0x317/0x410 fs/namespace.c:4409
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f344f98e969
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f344d7f6038 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f344fbb5fa0 RCX: 00007f344f98e969
RDX: 0000200000000000 RSI: 00002000000000c0 RDI: 0000000000000000
RBP: 00007f344fa10ab1 R08: 0000200000000400 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f344fbb5fa0 R15: 00007ffe6353a988
 </TASK>
overlayfs: upper fs missing required features.