syzbot

ocfs2: Mounting device (7,7) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
5.15.185-syzkaller #0 Not tainted
------------------------------------------------------
syz.7.1251/11692 is trying to acquire lock:
ffff88805eb0b488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
ffff88805eb0b488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: ocfs2_xattr_set+0xad6/0x11e0 fs/ocfs2/xattr.c:3626

but task is already holding lock:
ffff8880608fa378 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x40c/0x11e0 fs/ocfs2/xattr.c:3587

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&oi->ip_xattr_sem){++++}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_init_acl+0x2fb/0x720 fs/ocfs2/acl.c:365
       ocfs2_mknod+0x142f/0x22b0 fs/ocfs2/namei.c:410
       ocfs2_create+0x192/0x410 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3462 [inline]
       open_last_lookups fs/namei.c:3532 [inline]
       path_openat+0x11e1/0x2f30 fs/namei.c:3739
       do_filp_open+0x1b3/0x3e0 fs/namei.c:3769
       do_sys_openat2+0x142/0x4a0 fs/open.c:1253
       do_sys_open fs/open.c:1269 [inline]
       __do_sys_openat fs/open.c:1285 [inline]
       __se_sys_openat fs/open.c:1280 [inline]
       __x64_sys_openat+0x135/0x160 fs/open.c:1280
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (jbd2_handle){++++}-{0:0}:
       jbd2_journal_lock_updates+0xa1/0x380 fs/jbd2/transaction.c:881
       __ocfs2_flush_truncate_log+0x2a7/0x1060 fs/ocfs2/alloc.c:6028
       ocfs2_flush_truncate_log+0x4b/0x60 fs/ocfs2/alloc.c:6075
       ocfs2_sync_fs+0x113/0x310 fs/ocfs2/super.c:403
       sync_filesystem+0x1be/0x220 fs/sync.c:66
       generic_shutdown_super+0x6b/0x300 fs/super.c:448
       kill_block_super+0x7c/0xe0 fs/super.c:1427
       deactivate_locked_super+0x93/0xf0 fs/super.c:335
       cleanup_mnt+0x418/0x4d0 fs/namespace.c:1139
       task_work_run+0x125/0x1a0 kernel/task_work.c:188
       tracehook_notify_resume include/linux/tracehook.h:189 [inline]
       exit_to_user_mode_loop+0x10f/0x130 kernel/entry/common.c:181
       exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214
       __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
       syscall_exit_to_user_mode+0x16/0x40 kernel/entry/common.c:307
       do_syscall_64+0x58/0xa0 arch/x86/entry/common.c:86
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
       lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_xattr_set+0xad6/0x11e0 fs/ocfs2/xattr.c:3626
       __vfs_setxattr+0x3e0/0x420 fs/xattr.c:182
       __vfs_setxattr_noperm+0x129/0x5e0 fs/xattr.c:216
       vfs_setxattr+0x168/0x2f0 fs/xattr.c:303
       do_setxattr fs/xattr.c:588 [inline]
       setxattr+0x2da/0x300 fs/xattr.c:611
       path_setxattr+0x142/0x280 fs/xattr.c:630
       __do_sys_setxattr fs/xattr.c:646 [inline]
       __se_sys_setxattr fs/xattr.c:642 [inline]
       __x64_sys_setxattr+0xb7/0xd0 fs/xattr.c:642
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6 --> jbd2_handle --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6);

 *** DEADLOCK ***

3 locks held by syz.7.1251/11692:
 #0: ffff888077212460 (sb_writers#23){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:377
 #1: ffff8880608fa648 (&type->i_mutex_dir_key#17){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #1: ffff8880608fa648 (&type->i_mutex_dir_key#17){+.+.}-{3:3}, at: vfs_setxattr+0x141/0x2f0 fs/xattr.c:302
 #2: ffff8880608fa378 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x40c/0x11e0 fs/ocfs2/xattr.c:3587

stack backtrace:
CPU: 0 PID: 11692 Comm: syz.7.1251 Not tainted 5.15.185-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x230 lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
 down_write+0x38/0x60 kernel/locking/rwsem.c:1551
 inode_lock include/linux/fs.h:787 [inline]
 ocfs2_xattr_set+0xad6/0x11e0 fs/ocfs2/xattr.c:3626
 __vfs_setxattr+0x3e0/0x420 fs/xattr.c:182
 __vfs_setxattr_noperm+0x129/0x5e0 fs/xattr.c:216
 vfs_setxattr+0x168/0x2f0 fs/xattr.c:303
 do_setxattr fs/xattr.c:588 [inline]
 setxattr+0x2da/0x300 fs/xattr.c:611
 path_setxattr+0x142/0x280 fs/xattr.c:630
 __do_sys_setxattr fs/xattr.c:646 [inline]
 __se_sys_setxattr fs/xattr.c:642 [inline]
 __x64_sys_setxattr+0xb7/0xd0 fs/xattr.c:642
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f574ccc2929
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f574ab2a038 EFLAGS: 00000246 ORIG_RAX: 00000000000000bc
RAX: ffffffffffffffda RBX: 00007f574cee9fa0 RCX: 00007f574ccc2929
RDX: 0000000000000000 RSI: 0000200000000300 RDI: 00002000000002c0
RBP: 00007f574cd44b39 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f574cee9fa0 R15: 00007ffcbc454778
 </TASK>