syzbot

loop2: detected capacity change from 0 to 32768
JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,2) on (node local, slot 0) with ordered data mode.
overlayfs: upper fs does not support tmpfile.
overlayfs: upper fs does not support RENAME_WHITEOUT.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.2.287/5880 is trying to acquire lock:
ffff88805f4e42c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
ffff88805f4e42c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: ocfs2_xattr_set+0xb92/0x13e0 fs/ocfs2/xattr.c:3626

but task is already holding lock:
ffff88805f4e1538 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x464/0x13e0 fs/ocfs2/xattr.c:3587

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&oi->ip_xattr_sem){++++}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_init_acl+0x307/0x770 fs/ocfs2/acl.c:365
       ocfs2_mknod+0x15cb/0x2510 fs/ocfs2/namei.c:410
       ocfs2_create+0x192/0x420 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3470 [inline]
       open_last_lookups fs/namei.c:3540 [inline]
       path_openat+0x11db/0x2fa0 fs/namei.c:3747
       do_filp_open+0x1e2/0x410 fs/namei.c:3777
       do_sys_openat2+0x150/0x4b0 fs/open.c:1255
       do_sys_open fs/open.c:1271 [inline]
       __do_sys_open fs/open.c:1279 [inline]
       __se_sys_open fs/open.c:1275 [inline]
       __x64_sys_open+0x11b/0x140 fs/open.c:1275
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (jbd2_handle){++++}-{0:0}:
       jbd2_journal_lock_updates+0xa4/0x390 fs/jbd2/transaction.c:881
       __ocfs2_flush_truncate_log+0x2ba/0x1110 fs/ocfs2/alloc.c:6027
       ocfs2_flush_truncate_log+0x4b/0x60 fs/ocfs2/alloc.c:6074
       ocfs2_sync_fs+0x119/0x330 fs/ocfs2/super.c:403
       sync_filesystem+0x1be/0x220 fs/sync.c:66
       generic_shutdown_super+0x6b/0x300 fs/super.c:448
       kill_block_super+0x7c/0xe0 fs/super.c:1427
       deactivate_locked_super+0x93/0xf0 fs/super.c:335
       cleanup_mnt+0x42d/0x4e0 fs/namespace.c:1148
       task_work_run+0x125/0x1a0 kernel/task_work.c:188
       tracehook_notify_resume include/linux/tracehook.h:189 [inline]
       exit_to_user_mode_loop+0x10f/0x130 kernel/entry/common.c:181
       exit_to_user_mode_prepare+0xee/0x180 kernel/entry/common.c:214
       __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
       syscall_exit_to_user_mode+0x16/0x40 kernel/entry/common.c:307
       do_syscall_64+0x58/0xa0 arch/x86/entry/common.c:86
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c42/0x7d10 kernel/locking/lockdep.c:5012
       lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_xattr_set+0xb92/0x13e0 fs/ocfs2/xattr.c:3626
       __vfs_setxattr+0x3e0/0x420 fs/xattr.c:182
       __vfs_setxattr_noperm+0x129/0x5e0 fs/xattr.c:216
       vfs_setxattr+0x167/0x2e0 fs/xattr.c:303
       ovl_do_setxattr fs/overlayfs/overlayfs.h:214 [inline]
       ovl_setxattr fs/overlayfs/overlayfs.h:225 [inline]
       ovl_make_workdir fs/overlayfs/super.c:1422 [inline]
       ovl_get_workdir+0x9d3/0x1230 fs/overlayfs/super.c:1526
       ovl_fill_super+0x1824/0x2a30 fs/overlayfs/super.c:2082
       mount_nodev+0x52/0xe0 fs/super.c:1446
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1530
       do_new_mount+0x24a/0xa40 fs/namespace.c:3034
       do_mount fs/namespace.c:3377 [inline]
       __do_sys_mount fs/namespace.c:3585 [inline]
       __se_sys_mount+0x2e3/0x3d0 fs/namespace.c:3562
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8 --> jbd2_handle --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8);

 *** DEADLOCK ***

4 locks held by syz.2.287/5880:
 #0: ffff888024a500e0 (&type->s_umount_key#59/1){+.+.}-{3:3}, at: alloc_super+0x201/0x950 fs/super.c:229
 #1: ffff888023ad6460 (sb_writers#19){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:386
 #2: ffff88805f4e1808 (&sb->s_type->i_mutex_key#26){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #2: ffff88805f4e1808 (&sb->s_type->i_mutex_key#26){+.+.}-{3:3}, at: vfs_setxattr+0x140/0x2e0 fs/xattr.c:302
 #3: ffff88805f4e1538 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x464/0x13e0 fs/ocfs2/xattr.c:3587

stack backtrace:
CPU: 0 PID: 5880 Comm: syz.2.287 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/25/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x250 lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c42/0x7d10 kernel/locking/lockdep.c:5012
 lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
 down_write+0x38/0x60 kernel/locking/rwsem.c:1551
 inode_lock include/linux/fs.h:787 [inline]
 ocfs2_xattr_set+0xb92/0x13e0 fs/ocfs2/xattr.c:3626
 __vfs_setxattr+0x3e0/0x420 fs/xattr.c:182
 __vfs_setxattr_noperm+0x129/0x5e0 fs/xattr.c:216
 vfs_setxattr+0x167/0x2e0 fs/xattr.c:303
 ovl_do_setxattr fs/overlayfs/overlayfs.h:214 [inline]
 ovl_setxattr fs/overlayfs/overlayfs.h:225 [inline]
 ovl_make_workdir fs/overlayfs/super.c:1422 [inline]
 ovl_get_workdir+0x9d3/0x1230 fs/overlayfs/super.c:1526
 ovl_fill_super+0x1824/0x2a30 fs/overlayfs/super.c:2082
 mount_nodev+0x52/0xe0 fs/super.c:1446
 legacy_get_tree+0xe6/0x180 fs/fs_context.c:611
 vfs_get_tree+0x88/0x270 fs/super.c:1530
 do_new_mount+0x24a/0xa40 fs/namespace.c:3034
 do_mount fs/namespace.c:3377 [inline]
 __do_sys_mount fs/namespace.c:3585 [inline]
 __se_sys_mount+0x2e3/0x3d0 fs/namespace.c:3562
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f738a7efcb9
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f7388a4b028 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f738aa6afa0 RCX: 00007f738a7efcb9
RDX: 0000200000000b80 RSI: 0000200000000000 RDI: 0000000000000000
RBP: 00007f738a85dbf7 R08: 0000200000000780 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f738aa6b038 R14: 00007f738aa6afa0 R15: 00007fff1029ac18
 </TASK>
OCFS2: ERROR (device loop2): int ocfs2_validate_gd_parent(struct super_block *, struct ocfs2_dinode *, struct buffer_head *, int): Group descriptor #32 has bit count of 1024
On-disk corruption discovered. Please run fsck.ocfs2 once the filesystem is unmounted.
OCFS2: File system is now read-only.
(syz.2.287,5880,0):ocfs2_search_chain:1761 ERROR: status = -30
(syz.2.287,5880,0):ocfs2_search_chain:1871 ERROR: status = -30
(syz.2.287,5880,0):ocfs2_claim_suballoc_bits:1950 ERROR: status = -30
(syz.2.287,5880,0):ocfs2_claim_suballoc_bits:1993 ERROR: status = -30
(syz.2.287,5880,0):__ocfs2_claim_clusters:2365 ERROR: status = -30
(syz.2.287,5880,0):__ocfs2_claim_clusters:2373 ERROR: status = -30
(syz.2.287,5880,0):ocfs2_block_group_alloc_contig:433 ERROR: status = -30
(syz.2.287,5880,0):ocfs2_block_group_alloc:705 ERROR: status = -30
(syz.2.287,5880,0):ocfs2_block_group_alloc:758 ERROR: status = -30
(syz.2.287,5880,0):ocfs2_reserve_suballoc_bits:833 ERROR: status = -30
(syz.2.287,5880,0):ocfs2_reserve_suballoc_bits:850 ERROR: status = -30
(syz.2.287,5880,0):ocfs2_reserve_new_metadata_blocks:990 ERROR: status = -30
(syz.2.287,5880,0):ocfs2_reserve_new_metadata_blocks:1013 ERROR: status = -30
(syz.2.287,5880,0):ocfs2_init_xattr_set_ctxt:3284 ERROR: status = -30
(syz.2.287,5880,0):ocfs2_xattr_set:3641 ERROR: status = -30
overlayfs: failed to set xattr on upper
overlayfs: ...falling back to index=off,metacopy=off.
overlayfs: upper fs missing required features.