syzbot

overlayfs: upper fs does not support RENAME_WHITEOUT.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.3.129/5006 is trying to acquire lock:
ffff888054265f48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
ffff888054265f48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: ocfs2_xattr_set+0xbe4/0x1390 fs/ocfs2/xattr.c:3626

but task is already holding lock:
ffff8880541f9538 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x491/0x1390 fs/ocfs2/xattr.c:3587

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&oi->ip_xattr_sem){++++}-{3:3}:
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_init_acl+0x307/0x770 fs/ocfs2/acl.c:365
       ocfs2_mknod+0x18e0/0x2580 fs/ocfs2/namei.c:410
       vfs_mknod+0x430/0x4c0 fs/namei.c:3993
       do_mknodat+0x356/0x4d0 fs/namei.c:-1
       __do_sys_mknodat fs/namei.c:4071 [inline]
       __se_sys_mknodat fs/namei.c:4068 [inline]
       __x64_sys_mknodat+0xa5/0xc0 fs/namei.c:4068
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (jbd2_handle){++++}-{0:0}:
       jbd2_journal_lock_updates+0xa8/0x390 fs/jbd2/transaction.c:880
       __ocfs2_flush_truncate_log+0x2cf/0x1220 fs/ocfs2/alloc.c:6029
       ocfs2_flush_truncate_log+0x4b/0x60 fs/ocfs2/alloc.c:6076
       ocfs2_sync_fs+0x119/0x330 fs/ocfs2/super.c:402
       sync_filesystem+0x1be/0x220 fs/sync.c:66
       generic_shutdown_super+0x6b/0x340 fs/super.c:474
       kill_block_super+0x7c/0xe0 fs/super.c:1470
       deactivate_locked_super+0x93/0xf0 fs/super.c:332
       cleanup_mnt+0x471/0x4f0 fs/namespace.c:1191
       task_work_run+0x1d0/0x260 kernel/task_work.c:203
       resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
       exit_to_user_mode_loop+0xe6/0x110 kernel/entry/common.c:177
       exit_to_user_mode_prepare+0xee/0x180 kernel/entry/common.c:210
       __syscall_exit_to_user_mode_work kernel/entry/common.c:292 [inline]
       syscall_exit_to_user_mode+0x16/0x40 kernel/entry/common.c:303
       do_syscall_64+0x58/0xa0 arch/x86/entry/common.c:82
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2c92/0x7bd0 kernel/locking/lockdep.c:5049
       lock_acquire+0x1bb/0x4a0 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_xattr_set+0xbe4/0x1390 fs/ocfs2/xattr.c:3626
       __vfs_setxattr+0x3d8/0x410 fs/xattr.c:182
       __vfs_setxattr_noperm+0x126/0x5e0 fs/xattr.c:216
       vfs_setxattr+0x167/0x2e0 fs/xattr.c:309
       ovl_do_setxattr fs/overlayfs/overlayfs.h:252 [inline]
       ovl_setxattr fs/overlayfs/overlayfs.h:264 [inline]
       ovl_make_workdir fs/overlayfs/super.c:1435 [inline]
       ovl_get_workdir+0xd04/0x1630 fs/overlayfs/super.c:1539
       ovl_fill_super+0x1cd8/0x42f0 fs/overlayfs/super.c:2095
       mount_nodev+0x52/0xe0 fs/super.c:1489
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x247/0xa40 fs/namespace.c:3078
       do_mount fs/namespace.c:3421 [inline]
       __do_sys_mount fs/namespace.c:3629 [inline]
       __se_sys_mount+0x2e3/0x3d0 fs/namespace.c:3606
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5 --> jbd2_handle --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5);

 *** DEADLOCK ***

4 locks held by syz.3.129/5006:
 #0: ffff88807b5080e0 (&type->s_umount_key#79/1){+.+.}-{3:3}, at: alloc_super+0x1fb/0x930 fs/super.c:228
 #1: ffff88807c910460 (sb_writers#15){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:402
 #2: ffff8880541f9808 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #2: ffff8880541f9808 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: vfs_setxattr+0x140/0x2e0 fs/xattr.c:308
 #3: ffff8880541f9538 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x491/0x1390 fs/ocfs2/xattr.c:3587

stack backtrace:
CPU: 1 PID: 5006 Comm: syz.3.129 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x24e lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2c92/0x7bd0 kernel/locking/lockdep.c:5049
 lock_acquire+0x1bb/0x4a0 kernel/locking/lockdep.c:5662
 down_write+0x36/0x60 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:758 [inline]
 ocfs2_xattr_set+0xbe4/0x1390 fs/ocfs2/xattr.c:3626
 __vfs_setxattr+0x3d8/0x410 fs/xattr.c:182
 __vfs_setxattr_noperm+0x126/0x5e0 fs/xattr.c:216
 vfs_setxattr+0x167/0x2e0 fs/xattr.c:309
 ovl_do_setxattr fs/overlayfs/overlayfs.h:252 [inline]
 ovl_setxattr fs/overlayfs/overlayfs.h:264 [inline]
 ovl_make_workdir fs/overlayfs/super.c:1435 [inline]
 ovl_get_workdir+0xd04/0x1630 fs/overlayfs/super.c:1539
 ovl_fill_super+0x1cd8/0x42f0 fs/overlayfs/super.c:2095
 mount_nodev+0x52/0xe0 fs/super.c:1489
 legacy_get_tree+0xe6/0x180 fs/fs_context.c:632
 vfs_get_tree+0x88/0x270 fs/super.c:1573
 do_new_mount+0x247/0xa40 fs/namespace.c:3078
 do_mount fs/namespace.c:3421 [inline]
 __do_sys_mount fs/namespace.c:3629 [inline]
 __se_sys_mount+0x2e3/0x3d0 fs/namespace.c:3606
 do_syscall_x64 arch/x86/entry/common.c:46 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7ff95dd9ce59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ff95bff6028 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007ff95e015fa0 RCX: 00007ff95dd9ce59
RDX: 0000200000000040 RSI: 0000200000000100 RDI: 0000000000000000
RBP: 00007ff95de32e6f R08: 0000200000000280 R09: 0000000000000000
R10: 0000000000000002 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ff95e016038 R14: 00007ff95e015fa0 R15: 00007ffde5b6bdc8
 </TASK>
overlayfs: upper fs missing required features.