syzbot

loop0: detected capacity change from 0 to 64
======================================================
WARNING: possible circular locking dependency detected
6.1.146-syzkaller #0 Not tainted
------------------------------------------------------
syz.0.20/4429 is trying to acquire lock:
ffff88805d4f1af8 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}, at: hfs_extend_file+0xd7/0x1280 fs/hfs/extent.c:397

but task is already holding lock:
ffff88801e30c0b0 (&tree->tree_lock/1){+.+.}-{3:3}, at: hfs_find_init+0x15b/0x1d0 fs/hfs/bfind.c:-1

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&tree->tree_lock/1){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x120/0xaf0 kernel/locking/mutex.c:747
       hfs_find_init+0x15b/0x1d0 fs/hfs/bfind.c:-1
       hfs_ext_read_extent fs/hfs/extent.c:200 [inline]
       hfs_extend_file+0x2eb/0x1280 fs/hfs/extent.c:401
       hfs_bmap_reserve+0x103/0x420 fs/hfs/btree.c:234
       hfs_cat_create+0x1c0/0x8d0 fs/hfs/catalog.c:104
       hfs_create+0x62/0xd0 fs/hfs/dir.c:202
       lookup_open fs/namei.c:3482 [inline]
       open_last_lookups fs/namei.c:3550 [inline]
       path_openat+0x1187/0x2e70 fs/namei.c:3780
       do_filp_open+0x1c1/0x3c0 fs/namei.c:3810
       do_sys_openat2+0x142/0x490 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __x64_sys_openat+0x135/0x160 fs/open.c:1345
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
       lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x120/0xaf0 kernel/locking/mutex.c:747
       hfs_extend_file+0xd7/0x1280 fs/hfs/extent.c:397
       hfs_bmap_reserve+0x103/0x420 fs/hfs/btree.c:234
       __hfs_ext_write_extent+0x1fa/0x470 fs/hfs/extent.c:121
       hfs_ext_write_extent+0x15e/0x1e0 fs/hfs/extent.c:144
       hfs_write_inode+0x8e/0x970 fs/hfs/inode.c:434
       write_inode fs/fs-writeback.c:1460 [inline]
       __writeback_single_inode+0x75b/0x1160 fs/fs-writeback.c:1677
       writeback_single_inode+0x221/0x8b0 fs/fs-writeback.c:1733
       write_inode_now+0x15d/0x1d0 fs/fs-writeback.c:2769
       hfs_file_fsync+0xa3/0x140 fs/hfs/inode.c:682
       generic_write_sync include/linux/fs.h:2962 [inline]
       generic_file_write_iter+0x25d/0x2e0 mm/filemap.c:4010
       call_write_iter include/linux/fs.h:2265 [inline]
       new_sync_write fs/read_write.c:491 [inline]
       vfs_write+0x44c/0x960 fs/read_write.c:584
       ksys_write+0x143/0x240 fs/read_write.c:637
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&tree->tree_lock/1);
                               lock(&HFS_I(tree->inode)->extents_lock);
                               lock(&tree->tree_lock/1);
  lock(&HFS_I(tree->inode)->extents_lock);

 *** DEADLOCK ***

3 locks held by syz.0.20/4429:
 #0: ffff888078eac460 (sb_writers#13){.+.+}-{0:0}, at: vfs_write+0x256/0x960 fs/read_write.c:580
 #1: ffff88805d4f3028 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff88805d4f3028 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: hfs_file_fsync+0x99/0x140 fs/hfs/inode.c:679
 #2: ffff88801e30c0b0 (&tree->tree_lock/1){+.+.}-{3:3}, at: hfs_find_init+0x15b/0x1d0 fs/hfs/bfind.c:-1

stack backtrace:
CPU: 0 PID: 4429 Comm: syz.0.20 Not tainted 6.1.146-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x22e lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
 lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x120/0xaf0 kernel/locking/mutex.c:747
 hfs_extend_file+0xd7/0x1280 fs/hfs/extent.c:397
 hfs_bmap_reserve+0x103/0x420 fs/hfs/btree.c:234
 __hfs_ext_write_extent+0x1fa/0x470 fs/hfs/extent.c:121
 hfs_ext_write_extent+0x15e/0x1e0 fs/hfs/extent.c:144
 hfs_write_inode+0x8e/0x970 fs/hfs/inode.c:434
 write_inode fs/fs-writeback.c:1460 [inline]
 __writeback_single_inode+0x75b/0x1160 fs/fs-writeback.c:1677
 writeback_single_inode+0x221/0x8b0 fs/fs-writeback.c:1733
 write_inode_now+0x15d/0x1d0 fs/fs-writeback.c:2769
 hfs_file_fsync+0xa3/0x140 fs/hfs/inode.c:682
 generic_write_sync include/linux/fs.h:2962 [inline]
 generic_file_write_iter+0x25d/0x2e0 mm/filemap.c:4010
 call_write_iter include/linux/fs.h:2265 [inline]
 new_sync_write fs/read_write.c:491 [inline]
 vfs_write+0x44c/0x960 fs/read_write.c:584
 ksys_write+0x143/0x240 fs/read_write.c:637
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f63b338e9a9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffcfd7cd368 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f63b35b5fa0 RCX: 00007f63b338e9a9
RDX: 0000000000001006 RSI: 0000200000000940 RDI: 0000000000000008
RBP: 00007f63b3410d69 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f63b35b5fa0 R14: 00007f63b35b5fa0 R15: 0000000000000003
 </TASK>