syzbot

======================================================
WARNING: possible circular locking dependency detected
5.15.189-syzkaller #0 Not tainted
------------------------------------------------------
syz.1.344/7022 is trying to acquire lock:
ffff888022430778 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}, at: hfs_extend_file+0xd7/0x1280 fs/hfs/extent.c:397

but task is already holding lock:
ffff8881479ee0b0 (&tree->tree_lock#2/1){+.+.}-{3:3}, at: hfs_find_init+0x15b/0x1d0 fs/hfs/bfind.c:-1

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&tree->tree_lock#2/1){+.+.}-{3:3}:
       __mutex_lock_common+0x1eb/0x2390 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       hfs_find_init+0x15b/0x1d0 fs/hfs/bfind.c:-1
       hfs_ext_read_extent fs/hfs/extent.c:200 [inline]
       hfs_extend_file+0x2eb/0x1280 fs/hfs/extent.c:401
       hfs_bmap_reserve+0x103/0x420 fs/hfs/btree.c:231
       hfs_cat_move+0x18a/0xc80 fs/hfs/catalog.c:310
       hfs_rename+0x22c/0x320 fs/hfs/dir.c:299
       vfs_rename+0xbbf/0x10d0 fs/namei.c:4832
       do_renameat2+0xa83/0xf70 fs/namei.c:4985
       __do_sys_rename fs/namei.c:5031 [inline]
       __se_sys_rename fs/namei.c:5029 [inline]
       __x64_sys_rename+0x82/0x90 fs/namei.c:5029
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
       lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1eb/0x2390 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       hfs_extend_file+0xd7/0x1280 fs/hfs/extent.c:397
       hfs_bmap_reserve+0x103/0x420 fs/hfs/btree.c:231
       __hfs_ext_write_extent+0x1fa/0x470 fs/hfs/extent.c:121
       hfs_ext_write_extent+0x15e/0x1e0 fs/hfs/extent.c:144
       hfs_write_inode+0x8e/0x970 fs/hfs/inode.c:432
       write_inode fs/fs-writeback.c:1495 [inline]
       __writeback_single_inode+0x6c3/0xda0 fs/fs-writeback.c:1705
       writeback_single_inode+0x221/0x8b0 fs/fs-writeback.c:1760
       write_inode_now+0x217/0x280 fs/fs-writeback.c:2800
       hfs_file_fsync+0xa3/0x140 fs/hfs/inode.c:680
       generic_write_sync include/linux/fs.h:2989 [inline]
       generic_file_write_iter+0x157/0x1b0 mm/filemap.c:3948
       call_write_iter include/linux/fs.h:2172 [inline]
       new_sync_write fs/read_write.c:507 [inline]
       vfs_write+0x712/0xd00 fs/read_write.c:594
       ksys_write+0x14d/0x250 fs/read_write.c:647
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&tree->tree_lock#2/1);
                               lock(&HFS_I(tree->inode)->extents_lock);
                               lock(&tree->tree_lock#2/1);
  lock(&HFS_I(tree->inode)->extents_lock);

 *** DEADLOCK ***

4 locks held by syz.1.344/7022:
 #0: ffff888024360d70 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2bf/0x370 fs/file.c:1058
 #1: ffff88805ec8c460 (sb_writers#26){.+.+}-{0:0}, at: vfs_write+0x28a/0xd00 fs/read_write.c:590
 #2: ffff88805f7e8928 (&sb->s_type->i_mutex_key#37){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #2: ffff88805f7e8928 (&sb->s_type->i_mutex_key#37){+.+.}-{3:3}, at: hfs_file_fsync+0x99/0x140 fs/hfs/inode.c:677
 #3: ffff8881479ee0b0 (&tree->tree_lock
#2/1){+.+.}-{3:3}, at: hfs_find_init+0x15b/0x1d0 fs/hfs/bfind.c:-1

stack backtrace:
CPU: 0 PID: 7022 Comm: syz.1.344 Not tainted 5.15.189-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x230 lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
 __mutex_lock_common+0x1eb/0x2390 kernel/locking/mutex.c:596
 __mutex_lock kernel/locking/mutex.c:729 [inline]
 mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
 hfs_extend_file+0xd7/0x1280 fs/hfs/extent.c:397
 hfs_bmap_reserve+0x103/0x420 fs/hfs/btree.c:231
 __hfs_ext_write_extent+0x1fa/0x470 fs/hfs/extent.c:121
 hfs_ext_write_extent+0x15e/0x1e0 fs/hfs/extent.c:144
 hfs_write_inode+0x8e/0x970 fs/hfs/inode.c:432
 write_inode fs/fs-writeback.c:1495 [inline]
 __writeback_single_inode+0x6c3/0xda0 fs/fs-writeback.c:1705
 writeback_single_inode+0x221/0x8b0 fs/fs-writeback.c:1760
 write_inode_now+0x217/0x280 fs/fs-writeback.c:2800
 hfs_file_fsync+0xa3/0x140 fs/hfs/inode.c:680
 generic_write_sync include/linux/fs.h:2989 [inline]
 generic_file_write_iter+0x157/0x1b0 mm/filemap.c:3948
 call_write_iter include/linux/fs.h:2172 [inline]
 new_sync_write fs/read_write.c:507 [inline]
 vfs_write+0x712/0xd00 fs/read_write.c:594
 ksys_write+0x14d/0x250 fs/read_write.c:647
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7fd2f77cc9a9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fd2f5634038 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007fd2f79f3fa0 RCX: 00007fd2f77cc9a9
RDX: 0000000000001201 RSI: 0000200000002140 RDI: 0000000000000004
RBP: 00007fd2f784ed69 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fd2f79f3fa0 R15: 00007fff8ef310d8
 </TASK>