syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
kworker/u4:3/391 is trying to acquire lock:
ffff88807d4b41f8 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}, at: hfs_extend_file+0xfb/0x13f0 fs/hfs/extent.c:397

but task is already holding lock:
ffff8880568a00b0 (&tree->tree_lock#2/1){+.+.}-{3:3}, at: hfs_find_init+0x15b/0x1d0 fs/hfs/bfind.c:-1

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&tree->tree_lock#2/1){+.+.}-{3:3}:
       __mutex_lock_common+0x1e3/0x2400 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       hfs_find_init+0x15b/0x1d0 fs/hfs/bfind.c:-1
       hfs_ext_read_extent fs/hfs/extent.c:200 [inline]
       hfs_get_block+0x553/0xc50 fs/hfs/extent.c:366
       block_read_full_page+0x306/0xd40 fs/buffer.c:2290
       do_read_cache_page+0x8a1/0x1030 mm/filemap.c:-1
       read_mapping_page include/linux/pagemap.h:515 [inline]
       __hfs_bnode_create+0x4f0/0xbd0 fs/hfs/bnode.c:395
       hfs_bnode_find+0x220/0xd30 fs/hfs/bnode.c:444
       hfs_brec_find+0x178/0x500 fs/hfs/bfind.c:132
       hfs_brec_read+0x20/0x100 fs/hfs/bfind.c:171
       hfs_cat_find_brec+0x174/0x3f0 fs/hfs/catalog.c:194
       hfs_fill_super+0xfda/0x1590 fs/hfs/super.c:419
       mount_bdev+0x287/0x3c0 fs/super.c:1400
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1530
       do_new_mount+0x24a/0xa40 fs/namespace.c:3034
       do_mount fs/namespace.c:3377 [inline]
       __do_sys_mount fs/namespace.c:3585 [inline]
       __se_sys_mount+0x2e3/0x3d0 fs/namespace.c:3562
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c42/0x7d10 kernel/locking/lockdep.c:5012
       lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1e3/0x2400 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       hfs_extend_file+0xfb/0x13f0 fs/hfs/extent.c:397
       hfs_bmap_reserve+0x103/0x420 fs/hfs/btree.c:231
       __hfs_ext_write_extent+0x1fa/0x470 fs/hfs/extent.c:121
       hfs_ext_write_extent+0x17b/0x200 fs/hfs/extent.c:144
       hfs_write_inode+0xd8/0xa20 fs/hfs/inode.c:432
       write_inode fs/fs-writeback.c:1505 [inline]
       __writeback_single_inode+0x6c3/0xda0 fs/fs-writeback.c:1715
       writeback_sb_inodes+0xa4e/0x1680 fs/fs-writeback.c:1940
       wb_writeback+0x45d/0xbe0 fs/fs-writeback.c:2114
       wb_do_writeback fs/fs-writeback.c:2257 [inline]
       wb_workfn+0x43a/0xf20 fs/fs-writeback.c:2298
       process_one_work+0x85f/0x1010 kernel/workqueue.c:2310
       worker_thread+0xaa6/0x1290 kernel/workqueue.c:2457
       kthread+0x436/0x520 kernel/kthread.c:334
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:287

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&tree->tree_lock#2/1);
                               lock(&HFS_I(tree->inode)->extents_lock);
                               lock(&tree->tree_lock#2/1);
  lock(&HFS_I(tree->inode)->extents_lock);

 *** DEADLOCK ***

3 locks held by kworker/u4:3/391:
 #0: ffff8881421c1138 ((wq_completion)writeback){+.+.}-{0:0}, at: process_one_work+0x761/0x1010 kernel/workqueue.c:-1
 #1: ffffc90002f2fd00 ((work_completion)(&(&wb->dwork)->work)){+.+.}-{0:0}, at: process_one_work+0x79f/0x1010 kernel/workqueue.c:2285
 #2: ffff8880568a00b0 (&tree->tree_lock#2/1){+.+.}-{3:3}, at: hfs_find_init+0x15b/0x1d0 fs/hfs/bfind.c:-1

stack backtrace:
CPU: 0 PID: 391 Comm: kworker/u4:3 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2026
Workqueue: writeback wb_workfn (flush-7:3)
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x250 lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c42/0x7d10 kernel/locking/lockdep.c:5012
 lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
 __mutex_lock_common+0x1e3/0x2400 kernel/locking/mutex.c:596
 __mutex_lock kernel/locking/mutex.c:729 [inline]
 mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
 hfs_extend_file+0xfb/0x13f0 fs/hfs/extent.c:397
 hfs_bmap_reserve+0x103/0x420 fs/hfs/btree.c:231
 __hfs_ext_write_extent+0x1fa/0x470 fs/hfs/extent.c:121
 hfs_ext_write_extent+0x17b/0x200 fs/hfs/extent.c:144
 hfs_write_inode+0xd8/0xa20 fs/hfs/inode.c:432
 write_inode fs/fs-writeback.c:1505 [inline]
 __writeback_single_inode+0x6c3/0xda0 fs/fs-writeback.c:1715
 writeback_sb_inodes+0xa4e/0x1680 fs/fs-writeback.c:1940
 wb_writeback+0x45d/0xbe0 fs/fs-writeback.c:2114
 wb_do_writeback fs/fs-writeback.c:2257 [inline]
 wb_workfn+0x43a/0xf20 fs/fs-writeback.c:2298
 process_one_work+0x85f/0x1010 kernel/workqueue.c:2310
 worker_thread+0xaa6/0x1290 kernel/workqueue.c:2457
 kthread+0x436/0x520 kernel/kthread.c:334
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:287
 </TASK>
hfs: new node 0 already hashed?
------------[ cut here ]------------
WARNING: CPU: 0 PID: 391 at fs/hfs/bnode.c:530 hfs_bnode_create+0x3d1/0x450 fs/hfs/bnode.c:529
Modules linked in:
CPU: 0 PID: 391 Comm: kworker/u4:3 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2026
Workqueue: writeback wb_workfn (flush-7:3)
RIP: 0010:hfs_bnode_create+0x3d1/0x450 fs/hfs/bnode.c:530
Code: 97 3f 8a 89 ee e8 6f 65 82 07 e9 57 fd ff ff e8 a5 c4 49 ff 4c 89 ef e8 7d 7a 96 07 48 c7 c7 40 98 3f 8a 89 ee e8 4f 65 82 07 <0f> 0b eb b7 44 89 f1 80 e1 07 80 c1 03 38 c1 0f 8c 63 fc ff ff 4c
RSP: 0018:ffffc90002f2ee90 EFLAGS: 00010246
RAX: 000000000000001f RBX: ffff8880568a0000 RCX: 65a2f37cdbc12700
RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000
RBP: 0000000000000000 R08: ffff8880b9033d7f R09: 1ffff110172067af
R10: dffffc0000000000 R11: ffffed10172067b0 R12: 0000000000000000
R13: ffff8880568a00e0 R14: ffff888033a0eb00 R15: dffffc0000000000
FS:  0000000000000000(0000) GS:ffff8880b9100000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000001b3340eff8 CR3: 000000007e3fd000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 hfs_bmap_alloc+0x5b8/0x670 fs/hfs/btree.c:288
 hfs_btree_inc_height+0xfd/0xac0 fs/hfs/brec.c:490
 hfs_brec_insert+0x744/0xbd0 fs/hfs/brec.c:148
 __hfs_ext_write_extent+0x2a1/0x470 fs/hfs/extent.c:124
 hfs_ext_write_extent+0x17b/0x200 fs/hfs/extent.c:144
 hfs_write_inode+0xd8/0xa20 fs/hfs/inode.c:432
 write_inode fs/fs-writeback.c:1505 [inline]
 __writeback_single_inode+0x6c3/0xda0 fs/fs-writeback.c:1715
 writeback_sb_inodes+0xa4e/0x1680 fs/fs-writeback.c:1940
 wb_writeback+0x45d/0xbe0 fs/fs-writeback.c:2114
 wb_do_writeback fs/fs-writeback.c:2257 [inline]
 wb_workfn+0x43a/0xf20 fs/fs-writeback.c:2298
 process_one_work+0x85f/0x1010 kernel/workqueue.c:2310
 worker_thread+0xaa6/0x1290 kernel/workqueue.c:2457
 kthread+0x436/0x520 kernel/kthread.c:334
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:287
 </TASK>