syzbot

ocfs2: Mounting device (7,6) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
6.1.148-syzkaller #0 Not tainted
------------------------------------------------------
syz.6.4397/25815 is trying to acquire lock:
ffff888054e98660 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1e5/0x270 fs/ocfs2/quota_global.c:314

but task is already holding lock:
ffff888054e989c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
ffff888054e989c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1c7/0x270 fs/ocfs2/quota_global.c:313

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}:
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_lock_global_qf+0x1c7/0x270 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x2a0/0xb10 fs/ocfs2/quota_global.c:816
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       dquot_set_dqblk+0x27/0xf90 fs/quota/dquot.c:2833
       quota_setquota+0x4ac/0x530 fs/quota/quota.c:310
       __do_sys_quotactl fs/quota/quota.c:960 [inline]
       __se_sys_quotactl+0x295/0x6b0 fs/quota/quota.c:916
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #5 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x120/0xaf0 kernel/locking/mutex.c:747
       dquot_commit+0x5a/0x410 fs/quota/dquot.c:507
       ext4_write_dquot+0x1f0/0x360 fs/ext4/super.c:6790
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0xf9/0x400 fs/quota/dquot.c:412
       __dquot_alloc_space+0x5fc/0xe60 fs/quota/dquot.c:1752
       dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline]
       dquot_alloc_space include/linux/quotaops.h:313 [inline]
       dquot_alloc_block include/linux/quotaops.h:337 [inline]
       ext4_mb_new_blocks+0xf74/0x4720 fs/ext4/mballoc.c:5727
       ext4_ext_map_blocks+0x143c/0x66d0 fs/ext4/extents.c:4340
       ext4_map_blocks+0x9d1/0x1b60 fs/ext4/inode.c:679
       _ext4_get_block+0x1d7/0x4e0 fs/ext4/inode.c:822
       ext4_block_write_begin+0x637/0x12f0 fs/ext4/inode.c:1124
       ext4_write_begin+0x624/0xf50 fs/ext4/ext4_jbd2.h:-1
       generic_perform_write+0x2db/0x560 mm/filemap.c:3846
       ext4_buffered_write_iter+0x11a/0x3e0 fs/ext4/file.c:285
       ext4_file_write_iter+0x1d6/0x16e0 fs/ext4/file.c:-1
       call_write_iter include/linux/fs.h:2265 [inline]
       new_sync_write fs/read_write.c:491 [inline]
       vfs_write+0x44c/0x960 fs/read_write.c:584
       ksys_write+0x143/0x240 fs/read_write.c:637
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #4 (&ei->i_data_sem){++++}-{3:3}:
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ext4_truncate+0x987/0x1230 fs/ext4/inode.c:4284
       ext4_setattr+0x10cb/0x19f0 fs/ext4/inode.c:5631
       notify_change+0xc74/0xf40 fs/attr.c:499
       do_truncate+0x197/0x220 fs/open.c:65
       do_sys_ftruncate+0x312/0x3c0 fs/open.c:193
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #3 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x1f49/0x2150 fs/jbd2/transaction.c:463
       jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:520
       jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:559
       ocfs2_start_trans+0x372/0x6c0 fs/ocfs2/journal.c:376
       ocfs2_setattr+0x1200/0x1cf0 fs/ocfs2/file.c:1251
       notify_change+0xc74/0xf40 fs/attr.c:499
       chown_common+0x486/0x620 fs/open.c:736
       vfs_fchown fs/open.c:804 [inline]
       ksys_fchown+0xe2/0x150 fs/open.c:815
       __do_sys_fchown fs/open.c:823 [inline]
       __se_sys_fchown fs/open.c:821 [inline]
       __x64_sys_fchown+0x76/0x80 fs/open.c:821
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x366/0x6c0 fs/ocfs2/journal.c:374
       ocfs2_setattr+0x1200/0x1cf0 fs/ocfs2/file.c:1251
       notify_change+0xc74/0xf40 fs/attr.c:499
       chown_common+0x486/0x620 fs/open.c:736
       vfs_fchown fs/open.c:804 [inline]
       ksys_fchown+0xe2/0x150 fs/open.c:815
       __do_sys_fchown fs/open.c:823 [inline]
       __se_sys_fchown fs/open.c:821 [inline]
       __x64_sys_fchown+0x76/0x80 fs/open.c:821
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (sb_internal#4){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x267/0x6c0 fs/ocfs2/journal.c:372
       ocfs2_orphan_for_truncate fs/ocfs2/file.c:392 [inline]
       ocfs2_truncate_file+0x648/0x14d0 fs/ocfs2/file.c:496
       ocfs2_setattr+0x16a9/0x1cf0 fs/ocfs2/file.c:1212
       notify_change+0xc74/0xf40 fs/attr.c:499
       do_truncate+0x197/0x220 fs/open.c:65
       handle_truncate fs/namei.c:3285 [inline]
       do_open fs/namei.c:3630 [inline]
       path_openat+0x27f2/0x2e70 fs/namei.c:3783
       do_filp_open+0x1c1/0x3c0 fs/namei.c:3810
       do_sys_openat2+0x142/0x490 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_creat fs/open.c:1412 [inline]
       __se_sys_creat fs/open.c:1406 [inline]
       __x64_sys_creat+0x8c/0xb0 fs/open.c:1406
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
       lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ocfs2_lock_global_qf+0x1e5/0x270 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x2a0/0xb10 fs/ocfs2/quota_global.c:816
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       dquot_set_dqblk+0x27/0xf90 fs/quota/dquot.c:2833
       quota_setquota+0x4ac/0x530 fs/quota/quota.c:310
       __do_sys_quotactl fs/quota/quota.c:960 [inline]
       __se_sys_quotactl+0x295/0x6b0 fs/quota/quota.c:916
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &ocfs2_quota_ip_alloc_sem_key --> &dquot->dq_lock --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
                               lock(&dquot->dq_lock);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
  lock(&ocfs2_quota_ip_alloc_sem_key);

 *** DEADLOCK ***

3 locks held by syz.6.4397/25815:
 #0: ffff88805d3a60e0 (&type->s_umount_key#76){++++}-{3:3}, at: user_get_super+0x118/0x240 fs/super.c:889
 #1: ffff8880319200a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x293/0xb10 fs/ocfs2/quota_global.c:811
 #2: ffff888054e989c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #2: ffff888054e989c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1c7/0x270 fs/ocfs2/quota_global.c:313

stack backtrace:
CPU: 0 PID: 25815 Comm: syz.6.4397 Not tainted 6.1.148-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x22e lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
 lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
 down_write+0x36/0x60 kernel/locking/rwsem.c:1573
 ocfs2_lock_global_qf+0x1e5/0x270 fs/ocfs2/quota_global.c:314
 ocfs2_acquire_dquot+0x2a0/0xb10 fs/ocfs2/quota_global.c:816
 dqget+0x778/0xeb0 fs/quota/dquot.c:988
 dquot_set_dqblk+0x27/0xf90 fs/quota/dquot.c:2833
 quota_setquota+0x4ac/0x530 fs/quota/quota.c:310
 __do_sys_quotactl fs/quota/quota.c:960 [inline]
 __se_sys_quotactl+0x295/0x6b0 fs/quota/quota.c:916
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f0f8198ebe9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f0f827fb038 EFLAGS: 00000246 ORIG_RAX: 00000000000000b3
RAX: ffffffffffffffda RBX: 00007f0f81bb5fa0 RCX: 00007f0f8198ebe9
RDX: 0000000000000000 RSI: 0000200000000100 RDI: ffffffff80000800
RBP: 00007f0f81a11e19 R08: 0000000000000000 R09: 0000000000000000
R10: 0000200000000440 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f0f81bb6038 R14: 00007f0f81bb5fa0 R15: 00007ffffa6d3448
 </TASK>