syzbot

(syz.6.3612,22944,1):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0xb3775c19, computed 0x2dd1c265. Applying ECC.
JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,6) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Tainted: G             L     
------------------------------------------------------
syz.6.3612/22944 is trying to acquire lock:
ffff888090edbf60 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_lock_global_qf+0x201/0x290 fs/ocfs2/quota_global.c:314

but task is already holding lock:
ffff888090edc2c0 (&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1028 [inline]
ffff888090edc2c0 (&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_lock_global_qf+0x1da/0x290 fs/ocfs2/quota_global.c:313

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x96/0x200 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1028 [inline]
       ocfs2_lock_global_qf+0x1da/0x290 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x2a0/0xb70 fs/ocfs2/quota_global.c:828
       dqget+0x7b1/0xf10 fs/quota/dquot.c:980
       __dquot_initialize+0x3ba/0xd30 fs/quota/dquot.c:1508
       ocfs2_get_init_inode+0x147/0x1c0 fs/ocfs2/namei.c:206
       ocfs2_mknod+0xa67/0x2290 fs/ocfs2/namei.c:314
       ocfs2_create+0x195/0x490 fs/ocfs2/namei.c:677
       lookup_open fs/namei.c:4489 [inline]
       open_last_lookups fs/namei.c:4589 [inline]
       path_openat+0x1395/0x3860 fs/namei.c:4833
       do_file_open+0x23e/0x4a0 fs/namei.c:4865
       do_sys_openat2+0x113/0x200 fs/open.c:1366
       do_sys_open fs/open.c:1372 [inline]
       __do_sys_openat fs/open.c:1388 [inline]
       __se_sys_openat fs/open.c:1383 [inline]
       __x64_sys_openat+0x138/0x170 fs/open.c:1383
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (&dquot->dq_lock){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:614 [inline]
       __mutex_lock+0x19f/0x1300 kernel/locking/mutex.c:776
       wait_on_dquot fs/quota/dquot.c:357 [inline]
       dqget+0x72a/0xf10 fs/quota/dquot.c:975
       __dquot_initialize+0x3ba/0xd30 fs/quota/dquot.c:1508
       ocfs2_get_init_inode+0x147/0x1c0 fs/ocfs2/namei.c:206
       ocfs2_mknod+0xa67/0x2290 fs/ocfs2/namei.c:314
       ocfs2_create+0x195/0x490 fs/ocfs2/namei.c:677
       lookup_open fs/namei.c:4489 [inline]
       open_last_lookups fs/namei.c:4589 [inline]
       path_openat+0x1395/0x3860 fs/namei.c:4833
       do_file_open+0x23e/0x4a0 fs/namei.c:4865
       do_sys_openat2+0x113/0x200 fs/open.c:1366
       do_sys_open fs/open.c:1372 [inline]
       __do_sys_openat fs/open.c:1388 [inline]
       __se_sys_openat fs/open.c:1383 [inline]
       __x64_sys_openat+0x138/0x170 fs/open.c:1383
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x96/0x200 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1028 [inline]
       ocfs2_remove_inode fs/ocfs2/inode.c:733 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:896 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1157 [inline]
       ocfs2_evict_inode+0x1539/0x44e0 fs/ocfs2/inode.c:1299
       evict+0x61e/0xb10 fs/inode.c:846
       d_delete_notify include/linux/fsnotify.h:377 [inline]
       vfs_rmdir+0x42a/0x6e0 fs/namei.c:5357
       filename_rmdir+0x292/0x520 fs/namei.c:5399
       __do_sys_unlinkat fs/namei.c:5574 [inline]
       __se_sys_unlinkat+0x71/0x1a0 fs/namei.c:5567
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x96/0x200 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1028 [inline]
       ocfs2_del_inode_from_orphan+0x12e/0x7a0 fs/ocfs2/namei.c:2731
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2305 [inline]
       ocfs2_dio_end_io+0x543/0x1210 fs/ocfs2/aops.c:2403
       dio_complete+0x25b/0x790 fs/direct-io.c:281
       __blockdev_direct_IO+0x2cb0/0x32f0 fs/direct-io.c:1303
       ocfs2_direct_IO+0x251/0x2c0 fs/ocfs2/aops.c:2440
       generic_file_direct_write+0x1db/0x3e0 mm/filemap.c:4253
       __generic_file_write_iter+0x11d/0x230 mm/filemap.c:4422
       ocfs2_file_write_iter+0x1663/0x1ed0 fs/ocfs2/file.c:2476
       iter_file_splice_write+0x9a1/0x10f0 fs/splice.c:736
       do_splice_from fs/splice.c:936 [inline]
       direct_splice_actor+0x101/0x160 fs/splice.c:1159
       splice_direct_to_actor+0x53a/0xc70 fs/splice.c:1103
       do_splice_direct_actor fs/splice.c:1202 [inline]
       do_splice_direct+0x195/0x290 fs/splice.c:1228
       do_sendfile+0x535/0x7d0 fs/read_write.c:1372
       __do_sys_sendfile64 fs/read_write.c:1433 [inline]
       __se_sys_sendfile64+0x144/0x1a0 fs/read_write.c:1419
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
       lock_acquire+0xf0/0x2e0 kernel/locking/lockdep.c:5868
       down_write+0x96/0x200 kernel/locking/rwsem.c:1590
       ocfs2_lock_global_qf+0x201/0x290 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x2a0/0xb70 fs/ocfs2/quota_global.c:828
       dqget+0x7b1/0xf10 fs/quota/dquot.c:980
       __dquot_initialize+0x3ba/0xd30 fs/quota/dquot.c:1508
       ocfs2_get_init_inode+0x147/0x1c0 fs/ocfs2/namei.c:206
       ocfs2_mknod+0xa67/0x2290 fs/ocfs2/namei.c:314
       ocfs2_create+0x195/0x490 fs/ocfs2/namei.c:677
       lookup_open fs/namei.c:4489 [inline]
       open_last_lookups fs/namei.c:4589 [inline]
       path_openat+0x1395/0x3860 fs/namei.c:4833
       do_file_open+0x23e/0x4a0 fs/namei.c:4865
       do_sys_openat2+0x113/0x200 fs/open.c:1366
       do_sys_open fs/open.c:1372 [inline]
       __do_sys_openat fs/open.c:1388 [inline]
       __se_sys_openat fs/open.c:1383 [inline]
       __x64_sys_openat+0x138/0x170 fs/open.c:1383
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_quota_ip_alloc_sem_key --> &dquot->dq_lock --> &ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]);
                               lock(&dquot->dq_lock);
                               lock(&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]);
  lock(&ocfs2_quota_ip_alloc_sem_key);

 *** DEADLOCK ***

5 locks held by syz.6.3612/22944:
 #0: ffff8880537a4420 (sb_writers#20){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:493
 #1: ffff888057fbdf40 (&type->i_mutex_dir_key#14){++++}-{4:4}, at: inode_lock include/linux/fs.h:1028 [inline]
 #1: ffff888057fbdf40 (&type->i_mutex_dir_key#14){++++}-{4:4}, at: open_last_lookups fs/namei.c:4586 [inline]
 #1: ffff888057fbdf40 (&type->i_mutex_dir_key#14){++++}-{4:4}, at: path_openat+0xb4c/0x3860 fs/namei.c:4833
 #2: ffff888057fba640 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1028 [inline]
 #2: ffff888057fba640 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x16a/0x4940 fs/ocfs2/suballoc.c:857
 #3: ffff8880788876a8 (&dquot->dq_lock){+.+.}-{4:4}, at: ocfs2_acquire_dquot+0x293/0xb70 fs/ocfs2/quota_global.c:823
 #4: ffff888090edc2c0 (&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1028 [inline]
 #4: ffff888090edc2c0 (&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_lock_global_qf+0x1da/0x290 fs/ocfs2/quota_global.c:313

stack backtrace:
CPU: 1 UID: 0 PID: 22944 Comm: syz.6.3612 Tainted: G             L      syzkaller #0 PREEMPT(full) 
Tainted: [L]=SOFTLOCKUP
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/18/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2043
 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
 lock_acquire+0xf0/0x2e0 kernel/locking/lockdep.c:5868
 down_write+0x96/0x200 kernel/locking/rwsem.c:1590
 ocfs2_lock_global_qf+0x201/0x290 fs/ocfs2/quota_global.c:314
 ocfs2_acquire_dquot+0x2a0/0xb70 fs/ocfs2/quota_global.c:828
 dqget+0x7b1/0xf10 fs/quota/dquot.c:980
 __dquot_initialize+0x3ba/0xd30 fs/quota/dquot.c:1508
 ocfs2_get_init_inode+0x147/0x1c0 fs/ocfs2/namei.c:206
 ocfs2_mknod+0xa67/0x2290 fs/ocfs2/namei.c:314
 ocfs2_create+0x195/0x490 fs/ocfs2/namei.c:677
 lookup_open fs/namei.c:4489 [inline]
 open_last_lookups fs/namei.c:4589 [inline]
 path_openat+0x1395/0x3860 fs/namei.c:4833
 do_file_open+0x23e/0x4a0 fs/namei.c:4865
 do_sys_openat2+0x113/0x200 fs/open.c:1366
 do_sys_open fs/open.c:1372 [inline]
 __do_sys_openat fs/open.c:1388 [inline]
 __se_sys_openat fs/open.c:1383 [inline]
 __x64_sys_openat+0x138/0x170 fs/open.c:1383
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fd329f9c819
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fd32af32028 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: ffffffffffffffda RBX: 00007fd32a215fa0 RCX: 00007fd329f9c819
RDX: 0000000000143041 RSI: 0000200000000280 RDI: ffffffffffffff9c
RBP: 00007fd32a032c91 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fd32a216038 R14: 00007fd32a215fa0 R15: 00007ffcf7f01b48
 </TASK>