syzbot

JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,4) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.4.251/7800 is trying to acquire lock:
ffff88802ee2db90 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_lock_global_qf+0x201/0x290 fs/ocfs2/quota_global.c:314

but task is already holding lock:
ffff88802ee2df40 (&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1028 [inline]
ffff88802ee2df40 (&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_lock_global_qf+0x1da/0x290 fs/ocfs2/quota_global.c:313

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1028 [inline]
       ocfs2_lock_global_qf+0x1da/0x290 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x2a0/0xb20 fs/ocfs2/quota_global.c:828
       dqget+0x7b6/0xf10 fs/quota/dquot.c:980
       __dquot_initialize+0x3ba/0xd30 fs/quota/dquot.c:1508
       ocfs2_get_init_inode+0x147/0x1c0 fs/ocfs2/namei.c:206
       ocfs2_mknod+0x86f/0x2210 fs/ocfs2/namei.c:314
       ocfs2_mkdir+0x181/0x430 fs/ocfs2/namei.c:660
       vfs_mkdir+0x40b/0x630 fs/namei.c:5233
       filename_mkdirat+0x289/0x520 fs/namei.c:5266
       __do_sys_mkdirat fs/namei.c:5287 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5284
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (&dquot->dq_lock){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/rtmutex_api.c:533 [inline]
       mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:552
       wait_on_dquot fs/quota/dquot.c:357 [inline]
       dqget+0x72f/0xf10 fs/quota/dquot.c:975
       __dquot_initialize+0x3ba/0xd30 fs/quota/dquot.c:1508
       ocfs2_get_init_inode+0x147/0x1c0 fs/ocfs2/namei.c:206
       ocfs2_mknod+0x86f/0x2210 fs/ocfs2/namei.c:314
       ocfs2_mkdir+0x181/0x430 fs/ocfs2/namei.c:660
       vfs_mkdir+0x40b/0x630 fs/namei.c:5233
       filename_mkdirat+0x289/0x520 fs/namei.c:5266
       __do_sys_mkdirat fs/namei.c:5287 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5284
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1028 [inline]
       ocfs2_remove_inode fs/ocfs2/inode.c:733 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:896 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1157 [inline]
       ocfs2_evict_inode+0x1539/0x42c0 fs/ocfs2/inode.c:1299
       evict+0x61e/0xb10 fs/inode.c:837
       ocfs2_dentry_iput+0x24d/0x390 fs/ocfs2/dcache.c:407
       __dentry_kill+0x1a2/0x5e0 fs/dcache.c:670
       finish_dput+0xc9/0x480 fs/dcache.c:879
       __fput+0x6a0/0xa80 fs/file_table.c:477
       task_work_run+0x1d9/0x270 kernel/task_work.c:233
       resume_user_mode_work include/linux/resume_user_mode.h:50 [inline]
       __exit_to_user_mode_loop kernel/entry/common.c:67 [inline]
       exit_to_user_mode_loop+0xed/0x480 kernel/entry/common.c:98
       __exit_to_user_mode_prepare include/linux/irq-entry-common.h:226 [inline]
       syscall_exit_to_user_mode_prepare include/linux/irq-entry-common.h:256 [inline]
       syscall_exit_to_user_mode include/linux/entry-common.h:325 [inline]
       do_syscall_64+0x32d/0xf80 arch/x86/entry/syscall_64.c:100
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1028 [inline]
       ocfs2_del_inode_from_orphan+0x12e/0x7a0 fs/ocfs2/namei.c:2731
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2306 [inline]
       ocfs2_dio_end_io+0x545/0x1210 fs/ocfs2/aops.c:2404
       dio_complete+0x25e/0x790 fs/direct-io.c:281
       __blockdev_direct_IO+0x2d0e/0x3330 fs/direct-io.c:1303
       ocfs2_direct_IO+0x253/0x2c0 fs/ocfs2/aops.c:2441
       generic_file_direct_write+0x1dc/0x3e0 mm/filemap.c:4248
       __generic_file_write_iter+0x120/0x240 mm/filemap.c:4417
       ocfs2_file_write_iter+0x1666/0x1e30 fs/ocfs2/file.c:2476
       do_iter_readv_writev+0x62b/0x8d0 fs/read_write.c:-1
       vfs_writev+0x345/0x9a0 fs/read_write.c:1059
       do_writev+0x15a/0x2e0 fs/read_write.c:1105
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
       lock_acquire+0x106/0x330 kernel/locking/lockdep.c:5868
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1590
       ocfs2_lock_global_qf+0x201/0x290 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x2a0/0xb20 fs/ocfs2/quota_global.c:828
       dqget+0x7b6/0xf10 fs/quota/dquot.c:980
       __dquot_initialize+0x3ba/0xd30 fs/quota/dquot.c:1508
       ocfs2_get_init_inode+0x147/0x1c0 fs/ocfs2/namei.c:206
       ocfs2_mknod+0x86f/0x2210 fs/ocfs2/namei.c:314
       ocfs2_mkdir+0x181/0x430 fs/ocfs2/namei.c:660
       vfs_mkdir+0x40b/0x630 fs/namei.c:5233
       filename_mkdirat+0x289/0x520 fs/namei.c:5266
       __do_sys_mkdirat fs/namei.c:5287 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5284
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_quota_ip_alloc_sem_key --> &dquot->dq_lock --> &ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]);
                               lock(&dquot->dq_lock);
                               lock(&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]);
  lock(&ocfs2_quota_ip_alloc_sem_key);

 *** DEADLOCK ***

5 locks held by syz.4.251/7800:
 #0: ffff88803d88c480 (sb_writers#31){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:493
 #1: ffff88803dd0bdc0 (&type->i_mutex_dir_key#20/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:1073 [inline]
 #1: ffff88803dd0bdc0 (&type->i_mutex_dir_key#20/1){+.+.}-{4:4}, at: __start_dirop fs/namei.c:2923 [inline]
 #1: ffff88803dd0bdc0 (&type->i_mutex_dir_key#20/1){+.+.}-{4:4}, at: start_dirop fs/namei.c:2934 [inline]
 #1: ffff88803dd0bdc0 (&type->i_mutex_dir_key#20/1){+.+.}-{4:4}, at: filename_create+0x200/0x370 fs/namei.c:4922
 #2: ffff88802ee20b80 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1028 [inline]
 #2: ffff88802ee20b80 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x16f/0x4790 fs/ocfs2/suballoc.c:789
 #3: ffff88805fbf6098 (&dquot->dq_lock){+.+.}-{4:4}, at: ocfs2_acquire_dquot+0x293/0xb20 fs/ocfs2/quota_global.c:823
 #4: ffff88802ee2df40 (&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1028 [inline]
 #4: ffff88802ee2df40 (&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_lock_global_qf+0x1da/0x290 fs/ocfs2/quota_global.c:313

stack backtrace:
CPU: 1 UID: 0 PID: 7800 Comm: syz.4.251 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/24/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2043
 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
 lock_acquire+0x106/0x330 kernel/locking/lockdep.c:5868
 down_write+0x3a/0x50 kernel/locking/rwsem.c:1590
 ocfs2_lock_global_qf+0x201/0x290 fs/ocfs2/quota_global.c:314
 ocfs2_acquire_dquot+0x2a0/0xb20 fs/ocfs2/quota_global.c:828
 dqget+0x7b6/0xf10 fs/quota/dquot.c:980
 __dquot_initialize+0x3ba/0xd30 fs/quota/dquot.c:1508
 ocfs2_get_init_inode+0x147/0x1c0 fs/ocfs2/namei.c:206
 ocfs2_mknod+0x86f/0x2210 fs/ocfs2/namei.c:314
 ocfs2_mkdir+0x181/0x430 fs/ocfs2/namei.c:660
 vfs_mkdir+0x40b/0x630 fs/namei.c:5233
 filename_mkdirat+0x289/0x520 fs/namei.c:5266
 __do_sys_mkdirat fs/namei.c:5287 [inline]
 __se_sys_mkdirat+0x35/0x150 fs/namei.c:5284
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fe99c27ae57
Code: 00 66 90 48 89 f2 b9 00 01 00 00 48 89 fe bf 9c ff ff ff e9 db f7 ff ff 66 2e 0f 1f 84 00 00 00 00 00 90 b8 02 01 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe99a4d5e58 EFLAGS: 00000246 ORIG_RAX: 0000000000000102
RAX: ffffffffffffffda RBX: 00007fe99a4d5ee0 RCX: 00007fe99c27ae57
RDX: 00000000000001ff RSI: 0000200000000040 RDI: 00000000ffffff9c
RBP: 0000200000000000 R08: 0000200000000040 R09: 0000000000000000
R10: 0000200000000000 R11: 0000000000000246 R12: 0000200000000040
R13: 00007fe99a4d5ea0 R14: 0000000000000000 R15: 0000000000000000
 </TASK>