syzbot

mmap: syz-executor350 (4247) uses deprecated remap_file_pages() syscall. See Documentation/mm/remap_file_pages.rst.
======================================================
WARNING: possible circular locking dependency detected
6.1.120-syzkaller-00773-g52f863f820fd #0 Tainted: G        W         
------------------------------------------------------
syz-executor350/4247 is trying to acquire lock:
ffff88807cc1b510 (&sb->s_type->i_mutex_key#12){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
ffff88807cc1b510 (&sb->s_type->i_mutex_key#12){+.+.}-{3:3}, at: process_measurement+0x446/0x21b0 security/integrity/ima/ima_main.c:242

but task is already holding lock:
ffff888030c67958 (&mm->mmap_lock){++++}-{3:3}, at: mmap_write_lock_killable include/linux/mmap_lock.h:87 [inline]
ffff888030c67958 (&mm->mmap_lock){++++}-{3:3}, at: __do_sys_remap_file_pages mm/mmap.c:2981 [inline]
ffff888030c67958 (&mm->mmap_lock){++++}-{3:3}, at: __se_sys_remap_file_pages+0x207/0x8b0 mm/mmap.c:2956

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&mm->mmap_lock){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_read_killable+0xc6/0xd10 kernel/locking/rwsem.c:1543
       mmap_read_lock_killable+0x1d/0x60 include/linux/mmap_lock.h:126
       get_mmap_lock_carefully mm/memory.c:5331 [inline]
       lock_mm_and_find_vma+0x2a7/0x2e0 mm/memory.c:5382
       do_user_addr_fault arch/x86/mm/fault.c:1312 [inline]
       handle_page_fault arch/x86/mm/fault.c:1431 [inline]
       exc_page_fault+0x169/0x620 arch/x86/mm/fault.c:1487
       asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:608
       fault_in_readable+0x1c8/0x340
       fault_in_iov_iter_readable+0xdb/0x270 lib/iov_iter.c:356
       generic_perform_write+0x207/0x5e0 mm/filemap.c:3835
       __generic_file_write_iter+0x176/0x400 mm/filemap.c:3973
       generic_file_write_iter+0xab/0x310 mm/filemap.c:4005
       call_write_iter include/linux/fs.h:2265 [inline]
       new_sync_write fs/read_write.c:491 [inline]
       vfs_write+0x857/0xbc0 fs/read_write.c:584
       ksys_write+0x19c/0x2c0 fs/read_write.c:637
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&sb->s_type->i_mutex_key#12){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
       __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       process_measurement+0x446/0x21b0 security/integrity/ima/ima_main.c:242
       ima_file_mmap+0x121/0x1c0 security/integrity/ima/ima_main.c:429
       __do_sys_remap_file_pages mm/mmap.c:3024 [inline]
       __se_sys_remap_file_pages+0x67a/0x8b0 mm/mmap.c:2956
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&mm->mmap_lock);
                               lock(&sb->s_type->i_mutex_key#12);
                               lock(&mm->mmap_lock);
  lock(&sb->s_type->i_mutex_key#12);

 *** DEADLOCK ***

1 lock held by syz-executor350/4247:
 #0: ffff888030c67958 (&mm->mmap_lock){++++}-{3:3}, at: mmap_write_lock_killable include/linux/mmap_lock.h:87 [inline]
 #0: ffff888030c67958 (&mm->mmap_lock){++++}-{3:3}, at: __do_sys_remap_file_pages mm/mmap.c:2981 [inline]
 #0: ffff888030c67958 (&mm->mmap_lock){++++}-{3:3}, at: __se_sys_remap_file_pages+0x207/0x8b0 mm/mmap.c:2956

stack backtrace:
CPU: 1 PID: 4247 Comm: syz-executor350 Tainted: G        W          6.1.120-syzkaller-00773-g52f863f820fd #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
 down_write+0x36/0x60 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:758 [inline]
 process_measurement+0x446/0x21b0 security/integrity/ima/ima_main.c:242
 ima_file_mmap+0x121/0x1c0 security/integrity/ima/ima_main.c:429
 __do_sys_remap_file_pages mm/mmap.c:3024 [inline]
 __se_sys_remap_file_pages+0x67a/0x8b0 mm/mmap.c:2956
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7ff04a0a92c9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ff04a028228 EFLAGS: 00000246 ORIG_RAX: 00000000000000d8
RAX: ffffffffffffffda RBX: 00007ff04a133328 RCX: 00007ff04a0a92c9
RDX: 0000000000000000 RSI: 0000000000200000 RDI: 00000000202ec000
RBP: 00007ff04a133320 R08: 0000000000000000 R09: 00007ff04a0286c0
R10: 0000000000000000 R11: 0000000000000246 R12: 00007ff04a13332c
R13: 00000000fffffd9d R14: 00656d69745f7974 R15: 00007ffe9d6d59c8
 </TASK>