syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
kworker/u4:6/4439 is trying to acquire lock:
ffff0000ea2b3120 (&oi->ip_alloc_sem){++++}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xb4/0x2e4 fs/ocfs2/refcounttree.c:932

but task is already holding lock:
ffff0000ea2b31b8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xa8/0x2e4 fs/ocfs2/refcounttree.c:931

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_xattr_sem){++++}-{3:3}:
       down_read+0x64/0x300 kernel/locking/rwsem.c:1520
       ocfs2_init_acl+0x264/0x61c fs/ocfs2/acl.c:365
       ocfs2_mknod+0x129c/0x2110 fs/ocfs2/namei.c:410
       ocfs2_create+0x19c/0x4f8 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3490 [inline]
       open_last_lookups fs/namei.c:3558 [inline]
       path_openat+0xe18/0x26bc fs/namei.c:3788
       do_filp_open+0x194/0x384 fs/namei.c:3818
       do_sys_openat2+0x134/0x3f4 fs/open.c:1320
       do_sys_open fs/open.c:1336 [inline]
       __do_sys_openat fs/open.c:1352 [inline]
       __se_sys_openat fs/open.c:1347 [inline]
       __arm64_sys_openat+0x118/0x14c fs/open.c:1347
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b4 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x130 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x128 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x64/0x300 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x374/0x6cc fs/ocfs2/journal.c:374
       ocfs2_modify_bh+0xd8/0x44c fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x107c/0x1378 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x6c4/0xa24 fs/quota/dquot.c:2470
       dquot_load_quota_inode+0x274/0x4e4 fs/quota/dquot.c:2507
       ocfs2_enable_quotas+0x17c/0x3c0 fs/ocfs2/super.c:926
       ocfs2_fill_super+0x34ec/0x436c fs/ocfs2/super.c:1139
       mount_bdev+0x264/0x358 fs/super.c:1443
       ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1186
       legacy_get_tree+0xd4/0x16c fs/fs_context.c:632
       vfs_get_tree+0x90/0x274 fs/super.c:1573
       do_new_mount+0x228/0x810 fs/namespace.c:3078
       path_mount+0x5bc/0xe80 fs/namespace.c:3408
       do_mount fs/namespace.c:3421 [inline]
       __do_sys_mount fs/namespace.c:3629 [inline]
       __se_sys_mount fs/namespace.c:3606 [inline]
       __arm64_sys_mount+0x49c/0x59c fs/namespace.c:3606
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b4 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x130 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x128 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #1 (sb_internal#2){.+.+}-{0:0}:
       __lock_release kernel/locking/lockdep.c:5376 [inline]
       lock_release+0x308/0x908 kernel/locking/lockdep.c:5682
       up_write+0x48/0x5bc kernel/locking/rwsem.c:1625
       inode_unlock include/linux/fs.h:763 [inline]
       ocfs2_free_ac_resource fs/ocfs2/suballoc.c:126 [inline]
       ocfs2_free_alloc_context+0x94/0x188 fs/ocfs2/suballoc.c:140
       ocfs2_write_begin_nolock+0x39ac/0x3a44 fs/ocfs2/aops.c:1825
       ocfs2_dio_wr_get_block+0x768/0x14f4 fs/ocfs2/aops.c:2239
       get_more_blocks fs/direct-io.c:659 [inline]
       do_direct_IO fs/direct-io.c:947 [inline]
       __blockdev_direct_IO+0x1100/0x3184 fs/direct-io.c:1260
       ocfs2_direct_IO+0x208/0x280 fs/ocfs2/aops.c:2468
       generic_file_direct_write+0x104/0x2b8 mm/filemap.c:3787
       __generic_file_write_iter+0x144/0x250 mm/filemap.c:3945
       ocfs2_file_write_iter+0x138c/0x1c64 fs/ocfs2/file.c:2469
       call_write_iter include/linux/fs.h:2265 [inline]
       new_sync_write fs/read_write.c:491 [inline]
       vfs_write+0x3ec/0x7f0 fs/read_write.c:584
       ksys_write+0x12c/0x224 fs/read_write.c:637
       __do_sys_write fs/read_write.c:649 [inline]
       __se_sys_write fs/read_write.c:646 [inline]
       __arm64_sys_write+0x7c/0x90 fs/read_write.c:646
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b4 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x130 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x128 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #0 (&oi->ip_alloc_sem){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2880/0x6800 kernel/locking/lockdep.c:5049
       lock_acquire+0x20c/0x63c kernel/locking/lockdep.c:5662
       down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
       ocfs2_try_remove_refcount_tree+0xb4/0x2e4 fs/ocfs2/refcounttree.c:932
       ocfs2_truncate_file+0xd24/0x14f8 fs/ocfs2/file.c:517
       ocfs2_recover_orphans fs/ocfs2/journal.c:2309 [inline]
       ocfs2_complete_recovery+0xe4c/0x21a8 fs/ocfs2/journal.c:1340
       process_one_work+0x7f8/0x13a4 kernel/workqueue.c:2292
       worker_thread+0x8c4/0xfec kernel/workqueue.c:2439
       kthread+0x250/0x2d8 kernel/kthread.c:376
       ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:850

other info that might help us debug this:

Chain exists of:
  &oi->ip_alloc_sem --> &journal->j_trans_barrier --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(&journal->j_trans_barrier);
                               lock(&oi->ip_xattr_sem);
  lock(&oi->ip_alloc_sem);

 *** DEADLOCK ***

4 locks held by kworker/u4:6/4439:
 #0: ffff0000deabd138 ((wq_completion)ocfs2_wq){+.+.}-{0:0}, at: process_one_work+0x6b8/0x13a4 kernel/workqueue.c:2265
 #1: ffff800020e67c20 ((work_completion)(&journal->j_recovery_work)){+.+.}-{0:0}, at: process_one_work+0x6fc/0x13a4 kernel/workqueue.c:2267
 #2: ffff0000ea2b3488 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #2: ffff0000ea2b3488 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: ocfs2_recover_orphans fs/ocfs2/journal.c:2290 [inline]
 #2: ffff0000ea2b3488 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: ocfs2_complete_recovery+0xc2c/0x21a8 fs/ocfs2/journal.c:1340
 #3: ffff0000ea2b31b8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xa8/0x2e4 fs/ocfs2/refcounttree.c:931

stack backtrace:
CPU: 1 PID: 4439 Comm: kworker/u4:6 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/03/2025
Workqueue: ocfs2_wq ocfs2_complete_recovery
Call trace:
 dump_backtrace+0x1c0/0x1ec arch/arm64/kernel/stacktrace.c:158
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
 __dump_stack+0x30/0x40 lib/dump_stack.c:88
 dump_stack_lvl+0xf4/0x15c lib/dump_stack.c:106
 dump_stack+0x1c/0x5c lib/dump_stack.c:113
 print_circular_bug+0x148/0x1b0 kernel/locking/lockdep.c:2048
 check_noncircular+0x264/0x2f8 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2880/0x6800 kernel/locking/lockdep.c:5049
 lock_acquire+0x20c/0x63c kernel/locking/lockdep.c:5662
 down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
 ocfs2_try_remove_refcount_tree+0xb4/0x2e4 fs/ocfs2/refcounttree.c:932
 ocfs2_truncate_file+0xd24/0x14f8 fs/ocfs2/file.c:517
 ocfs2_recover_orphans fs/ocfs2/journal.c:2309 [inline]
 ocfs2_complete_recovery+0xe4c/0x21a8 fs/ocfs2/journal.c:1340
 process_one_work+0x7f8/0x13a4 kernel/workqueue.c:2292
 worker_thread+0x8c4/0xfec kernel/workqueue.c:2439
 kthread+0x250/0x2d8 kernel/kthread.c:376
 ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:850