syzbot

======================================================
WARNING: possible circular locking dependency detected
6.1.138-syzkaller #0 Not tainted
------------------------------------------------------
syz.5.2390/15787 is trying to acquire lock:
ffff888073eee6d8 (&ei->i_data_sem/1){+.+.}-{3:3}, at: ext4_move_extents+0x325/0xb90 fs/ext4/move_extent.c:615

but task is already holding lock:
ffff88807029c8c0 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_double_down_write_data_sem+0x28/0x40 fs/ext4/move_extent.c:-1

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ei->i_data_sem/2){++++}-{3:3}:
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ext4_map_blocks+0x903/0x1b60 fs/ext4/inode.c:672
       ext4_getblk+0x1ab/0x6d0 fs/ext4/inode.c:890
       ext4_bread+0x26/0x170 fs/ext4/inode.c:946
       ext4_quota_write+0x230/0x570 fs/ext4/super.c:7189
       write_blk fs/quota/quota_tree.c:70 [inline]
       find_free_dqentry+0x673/0xc20 fs/quota/quota_tree.c:318
       do_insert_tree+0x70d/0x1040 fs/quota/quota_tree.c:400
       do_insert_tree+0x9ae/0x1040 fs/quota/quota_tree.c:402
       do_insert_tree+0x9ae/0x1040 fs/quota/quota_tree.c:402
       do_insert_tree+0x9ae/0x1040 fs/quota/quota_tree.c:402
       dq_insert_tree fs/quota/quota_tree.c:432 [inline]
       qtree_write_dquot+0x48d/0x5b0 fs/quota/quota_tree.c:451
       v2_write_dquot+0x108/0x190 fs/quota/quota_v2.c:361
       dquot_acquire+0x2d5/0x520 fs/quota/dquot.c:472
       ext4_acquire_dquot+0x2d9/0x4a0 fs/ext4/super.c:6798
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       __dquot_initialize+0x328/0xcb0 fs/quota/dquot.c:1517
       ext4_create+0x8c/0x460 fs/ext4/namei.c:2876
       lookup_open fs/namei.c:3482 [inline]
       open_last_lookups fs/namei.c:3550 [inline]
       path_openat+0x1187/0x2e70 fs/namei.c:3780
       do_filp_open+0x1c1/0x3c0 fs/namei.c:3810
       do_sys_openat2+0x142/0x490 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __x64_sys_openat+0x135/0x160 fs/open.c:1345
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}:
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       v2_read_dquot+0x4a/0x110 fs/quota/quota_v2.c:335
       dquot_acquire+0x152/0x520 fs/quota/dquot.c:463
       ext4_acquire_dquot+0x2d9/0x4a0 fs/ext4/super.c:6798
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       __dquot_initialize+0x3b6/0xcb0 fs/quota/dquot.c:1517
       ext4_file_open+0x2cb/0x6a0 fs/ext4/file.c:872
       do_dentry_open+0x7e9/0x10d0 fs/open.c:882
       do_open fs/namei.c:3626 [inline]
       path_openat+0x25c6/0x2e70 fs/namei.c:3783
       do_filp_open+0x1c1/0x3c0 fs/namei.c:3810
       do_sys_openat2+0x142/0x490 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_open fs/open.c:1342 [inline]
       __se_sys_open fs/open.c:1338 [inline]
       __x64_sys_open+0x11b/0x140 fs/open.c:1338
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x120/0xaf0 kernel/locking/mutex.c:747
       dquot_commit+0x5a/0x410 fs/quota/dquot.c:507
       ext4_write_dquot+0x1f0/0x360 fs/ext4/super.c:6778
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0xf9/0x400 fs/quota/dquot.c:412
       __dquot_free_space+0x7ec/0xbc0 fs/quota/dquot.c:1942
       dquot_free_space_nodirty include/linux/quotaops.h:379 [inline]
       dquot_free_space+0x1b/0x30 include/linux/quotaops.h:384
       swap_inode_boot_loader+0xc77/0x1100 fs/ext4/ioctl.c:492
       __ext4_ioctl fs/ext4/ioctl.c:1424 [inline]
       ext4_ioctl+0x1bd0/0x3dd0 fs/ext4/ioctl.c:1614
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:870 [inline]
       __se_sys_ioctl+0xfa/0x170 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ei->i_data_sem/1){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
       lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
       down_write_nested+0x39/0x60 kernel/locking/rwsem.c:1689
       ext4_move_extents+0x325/0xb90 fs/ext4/move_extent.c:615
       __ext4_ioctl fs/ext4/ioctl.c:1358 [inline]
       ext4_ioctl+0x3501/0x3dd0 fs/ext4/ioctl.c:1614
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:870 [inline]
       __se_sys_ioctl+0xfa/0x170 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &ei->i_data_sem/1 --> &s->s_dquot.dqio_sem --> &ei->i_data_sem/2

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ei->i_data_sem/2);
                               lock(&s->s_dquot.dqio_sem);
                               lock(&ei->i_data_sem/2);
  lock(&ei->i_data_sem/1);

 *** DEADLOCK ***

4 locks held by syz.5.2390/15787:
 #0: ffff88807b00c460 (sb_writers#4){++++}-{0:0}, at: mnt_want_write_file+0x5c/0x200 fs/namespace.c:437
 #1: ffff88807029ca38 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff88807029ca38 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: lock_two_nondirectories+0xd5/0x150 fs/inode.c:1208
 #2: ffff888073eee850 (&sb->s_type->i_mutex_key#8/4){+.+.}-{3:3}, at: ext4_move_extents+0x30a/0xb90 fs/ext4/move_extent.c:608
 #3: ffff88807029c8c0 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_double_down_write_data_sem+0x28/0x40 fs/ext4/move_extent.c:-1

stack backtrace:
CPU: 1 PID: 15787 Comm: syz.5.2390 Not tainted 6.1.138-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/19/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x22e lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
 lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
 down_write_nested+0x39/0x60 kernel/locking/rwsem.c:1689
 ext4_move_extents+0x325/0xb90 fs/ext4/move_extent.c:615
 __ext4_ioctl fs/ext4/ioctl.c:1358 [inline]
 ext4_ioctl+0x3501/0x3dd0 fs/ext4/ioctl.c:1614
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:870 [inline]
 __se_sys_ioctl+0xfa/0x170 fs/ioctl.c:856
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f47b878e969
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f47b9549038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f47b89b5fa0 RCX: 00007f47b878e969
RDX: 0000200000000040 RSI: 00000000c028660f RDI: 000000000000000c
RBP: 00007f47b8810ab1 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f47b89b5fa0 R15: 00007ffde2a4c1d8
 </TASK>