syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.4.254/5259 is trying to acquire lock:
ffff888019690650 (sb_internal#7){.+.+}-{0:0}, at: ocfs2_write_begin_inline fs/ocfs2/aops.c:1481 [inline]
ffff888019690650 (sb_internal#7){.+.+}-{0:0}, at: ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1584 [inline]
ffff888019690650 (sb_internal#7){.+.+}-{0:0}, at: ocfs2_write_begin_nolock+0x1ca5/0x4270 fs/ocfs2/aops.c:1670

but task is already holding lock:
ffff88806fe83120 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_write_begin+0x195/0x300 fs/ocfs2/aops.c:1902

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}:
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_read_virt_blocks+0x265/0x950 fs/ocfs2/extent_map.c:984
       ocfs2_read_dir_block+0xd3/0x4d0 fs/ocfs2/dir.c:508
       ocfs2_dir_foreach_blk_el fs/ocfs2/dir.c:1842 [inline]
       ocfs2_dir_foreach_blk+0x27e/0x1990 fs/ocfs2/dir.c:1928
       ocfs2_dir_foreach+0x15d/0x1b0 fs/ocfs2/dir.c:1938
       ocfs2_empty_dir+0xfe/0x5f0 fs/ocfs2/dir.c:2156
       ocfs2_rename+0x212c/0x3820 fs/ocfs2/namei.c:1499
       vfs_rename+0xbbf/0x10d0 fs/namei.c:4882
       do_renameat2+0x89d/0xc70 fs/namei.c:5035
       __do_sys_rename fs/namei.c:5081 [inline]
       __se_sys_rename fs/namei.c:5079 [inline]
       __x64_sys_rename+0x82/0x90 fs/namei.c:5079
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x1f49/0x2150 fs/jbd2/transaction.c:463
       jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:520
       jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:559
       ocfs2_start_trans+0x372/0x6c0 fs/ocfs2/journal.c:376
       ocfs2_fileattr_set+0x2fe/0x7d0 fs/ocfs2/ioctl.c:119
       vfs_fileattr_set+0x842/0xaf0 fs/ioctl.c:696
       ioctl_setflags fs/ioctl.c:728 [inline]
       do_vfs_ioctl+0x16c1/0x1d10 fs/ioctl.c:839
       __do_sys_ioctl fs/ioctl.c:868 [inline]
       __se_sys_ioctl+0x83/0x170 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x366/0x6c0 fs/ocfs2/journal.c:374
       ocfs2_fileattr_set+0x2fe/0x7d0 fs/ocfs2/ioctl.c:119
       vfs_fileattr_set+0x842/0xaf0 fs/ioctl.c:696
       ioctl_setflags fs/ioctl.c:728 [inline]
       do_vfs_ioctl+0x16c1/0x1d10 fs/ioctl.c:839
       __do_sys_ioctl fs/ioctl.c:868 [inline]
       __se_sys_ioctl+0x83/0x170 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (sb_internal#7){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
       lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x267/0x6c0 fs/ocfs2/journal.c:372
       ocfs2_write_begin_inline fs/ocfs2/aops.c:1481 [inline]
       ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1584 [inline]
       ocfs2_write_begin_nolock+0x1ca5/0x4270 fs/ocfs2/aops.c:1670
       ocfs2_write_begin+0x1b8/0x300 fs/ocfs2/aops.c:1904
       generic_perform_write+0x2db/0x560 mm/filemap.c:3846
       __generic_file_write_iter+0x172/0x430 mm/filemap.c:3974
       ocfs2_file_write_iter+0x1593/0x1df0 fs/ocfs2/file.c:2469
       call_write_iter include/linux/fs.h:2265 [inline]
       new_sync_write fs/read_write.c:491 [inline]
       vfs_write+0x44c/0x960 fs/read_write.c:584
       ksys_write+0x143/0x240 fs/read_write.c:637
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  sb_internal#7 --> jbd2_handle --> &ocfs2_file_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_file_ip_alloc_sem_key);
                               lock(jbd2_handle);
                               lock(&ocfs2_file_ip_alloc_sem_key);
  lock(sb_internal#7);

 *** DEADLOCK ***

4 locks held by syz.4.254/5259:
 #0: ffff88807c713268 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2ae/0x360 fs/file.c:1038
 #1: ffff888019690460 (sb_writers#22){.+.+}-{0:0}, at: vfs_write+0x256/0x960 fs/read_write.c:580
 #2: ffff88806fe83488 (&sb->s_type->i_mutex_key#32){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #2: ffff88806fe83488 (&sb->s_type->i_mutex_key#32){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x438/0x1df0 fs/ocfs2/file.c:2399
 #3: ffff88806fe83120 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_write_begin+0x195/0x300 fs/ocfs2/aops.c:1902

stack backtrace:
CPU: 0 PID: 5259 Comm: syz.4.254 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x22e lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
 lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1891 [inline]
 sb_start_intwrite include/linux/fs.h:2013 [inline]
 ocfs2_start_trans+0x267/0x6c0 fs/ocfs2/journal.c:372
 ocfs2_write_begin_inline fs/ocfs2/aops.c:1481 [inline]
 ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1584 [inline]
 ocfs2_write_begin_nolock+0x1ca5/0x4270 fs/ocfs2/aops.c:1670
 ocfs2_write_begin+0x1b8/0x300 fs/ocfs2/aops.c:1904
 generic_perform_write+0x2db/0x560 mm/filemap.c:3846
 __generic_file_write_iter+0x172/0x430 mm/filemap.c:3974
 ocfs2_file_write_iter+0x1593/0x1df0 fs/ocfs2/file.c:2469
 call_write_iter include/linux/fs.h:2265 [inline]
 new_sync_write fs/read_write.c:491 [inline]
 vfs_write+0x44c/0x960 fs/read_write.c:584
 ksys_write+0x143/0x240 fs/read_write.c:637
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7fdbe1f8f6c9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fdbe2daa038 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007fdbe21e5fa0 RCX: 00007fdbe1f8f6c9
RDX: 0000000000000020 RSI: 00002000000002c0 RDI: 0000000000000004
RBP: 00007fdbe2011f91 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fdbe21e6038 R14: 00007fdbe21e5fa0 R15: 00007fff800d5c28
 </TASK>