syzbot

ocfs2: Mounting device (7,5) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
6.1.140-syzkaller #0 Not tainted
------------------------------------------------------
syz.5.4828/21799 is trying to acquire lock:
ffff888079394650 (sb_internal#4){.+.+}-{0:0}, at: ocfs2_write_begin_inline fs/ocfs2/aops.c:1481 [inline]
ffff888079394650 (sb_internal#4){.+.+}-{0:0}, at: ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1584 [inline]
ffff888079394650 (sb_internal#4){.+.+}-{0:0}, at: ocfs2_write_begin_nolock+0x1ca5/0x4270 fs/ocfs2/aops.c:1670

but task is already holding lock:
ffff888045dd8660 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_write_begin+0x195/0x300 fs/ocfs2/aops.c:1902

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ocfs2_lock_global_qf+0x1e5/0x270 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x2a0/0xb10 fs/ocfs2/quota_global.c:816
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       __dquot_initialize+0x3b6/0xcb0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x138/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x8be/0x2350 fs/ocfs2/namei.c:310
       ocfs2_mkdir+0x1b6/0x4a0 fs/ocfs2/namei.c:657
       vfs_mkdir+0x387/0x570 fs/namei.c:4106
       do_mkdirat+0x1d0/0x430 fs/namei.c:4131
       __do_sys_mkdirat fs/namei.c:4146 [inline]
       __se_sys_mkdirat fs/namei.c:4144 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}:
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_lock_global_qf+0x1c7/0x270 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x2a0/0xb10 fs/ocfs2/quota_global.c:816
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       __dquot_initialize+0x3b6/0xcb0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x138/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x8be/0x2350 fs/ocfs2/namei.c:310
       ocfs2_mkdir+0x1b6/0x4a0 fs/ocfs2/namei.c:657
       vfs_mkdir+0x387/0x570 fs/namei.c:4106
       do_mkdirat+0x1d0/0x430 fs/namei.c:4131
       __do_sys_mkdirat fs/namei.c:4146 [inline]
       __se_sys_mkdirat fs/namei.c:4144 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #4 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x120/0xaf0 kernel/locking/mutex.c:747
       dquot_commit+0x5a/0x410 fs/quota/dquot.c:507
       ext4_write_dquot+0x1f0/0x360 fs/ext4/super.c:6778
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0xf9/0x400 fs/quota/dquot.c:412
       __dquot_free_space+0x7ec/0xbc0 fs/quota/dquot.c:1942
       dquot_free_space_nodirty include/linux/quotaops.h:379 [inline]
       dquot_free_space include/linux/quotaops.h:384 [inline]
       dquot_free_block include/linux/quotaops.h:395 [inline]
       ext4_mb_clear_bb fs/ext4/mballoc.c:6143 [inline]
       ext4_free_blocks+0x1bab/0x2640 fs/ext4/mballoc.c:6273
       ext4_remove_blocks fs/ext4/extents.c:2507 [inline]
       ext4_ext_rm_leaf fs/ext4/extents.c:2691 [inline]
       ext4_ext_remove_space+0x1dd3/0x4490 fs/ext4/extents.c:2939
       ext4_ext_truncate+0x211/0x370 fs/ext4/extents.c:4469
       ext4_truncate+0xa0b/0x1230 fs/ext4/inode.c:4289
       ext4_setattr+0x10cb/0x19f0 fs/ext4/inode.c:5630
       notify_change+0xc74/0xf40 fs/attr.c:499
       do_truncate+0x197/0x220 fs/open.c:65
       handle_truncate fs/namei.c:3285 [inline]
       do_open fs/namei.c:3630 [inline]
       path_openat+0x27f2/0x2e70 fs/namei.c:3783
       do_filp_open+0x1c1/0x3c0 fs/namei.c:3810
       do_sys_openat2+0x142/0x490 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_creat fs/open.c:1412 [inline]
       __se_sys_creat fs/open.c:1406 [inline]
       __x64_sys_creat+0x8c/0xb0 fs/open.c:1406
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #3 (&ei->i_data_sem){++++}-{3:3}:
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ext4_truncate+0x987/0x1230 fs/ext4/inode.c:4284
       ext4_setattr+0x10cb/0x19f0 fs/ext4/inode.c:5630
       notify_change+0xc74/0xf40 fs/attr.c:499
       do_truncate+0x197/0x220 fs/open.c:65
       do_sys_ftruncate+0x312/0x3c0 fs/open.c:193
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x1f49/0x2150 fs/jbd2/transaction.c:463
       jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:520
       jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:559
       ocfs2_start_trans+0x372/0x6c0 fs/ocfs2/journal.c:376
       ocfs2_mknod+0xe6a/0x2350 fs/ocfs2/namei.c:361
       ocfs2_mkdir+0x1b6/0x4a0 fs/ocfs2/namei.c:657
       vfs_mkdir+0x387/0x570 fs/namei.c:4106
       do_mkdirat+0x1d0/0x430 fs/namei.c:4131
       __do_sys_mkdirat fs/namei.c:4146 [inline]
       __se_sys_mkdirat fs/namei.c:4144 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x366/0x6c0 fs/ocfs2/journal.c:374
       ocfs2_mknod+0xe6a/0x2350 fs/ocfs2/namei.c:361
       ocfs2_mkdir+0x1b6/0x4a0 fs/ocfs2/namei.c:657
       vfs_mkdir+0x387/0x570 fs/namei.c:4106
       do_mkdirat+0x1d0/0x430 fs/namei.c:4131
       __do_sys_mkdirat fs/namei.c:4146 [inline]
       __se_sys_mkdirat fs/namei.c:4144 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (sb_internal#4){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
       lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x267/0x6c0 fs/ocfs2/journal.c:372
       ocfs2_write_begin_inline fs/ocfs2/aops.c:1481 [inline]
       ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1584 [inline]
       ocfs2_write_begin_nolock+0x1ca5/0x4270 fs/ocfs2/aops.c:1670
       ocfs2_write_begin+0x1b8/0x300 fs/ocfs2/aops.c:1904
       generic_perform_write+0x2db/0x560 mm/filemap.c:3846
       __generic_file_write_iter+0x172/0x430 mm/filemap.c:3974
       ocfs2_file_write_iter+0x1593/0x1df0 fs/ocfs2/file.c:2469
       call_write_iter include/linux/fs.h:2265 [inline]
       new_sync_write fs/read_write.c:491 [inline]
       vfs_write+0x44c/0x960 fs/read_write.c:584
       ksys_write+0x143/0x240 fs/read_write.c:637
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  sb_internal#4 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_quota_ip_alloc_sem_key);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
                               lock(&ocfs2_quota_ip_alloc_sem_key);
  lock(sb_internal#4);

 *** DEADLOCK ***

4 locks held by syz.5.4828/21799:
 #0: ffff88807b48e0e8 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2ae/0x360 fs/file.c:1040
 #1: ffff888079394460 (sb_writers#28){.+.+}-{0:0}, at: vfs_write+0x256/0x960 fs/read_write.c:580
 #2: ffff888045dd89c8 (&sb->s_type->i_mutex_key#40){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #2: ffff888045dd89c8 (&sb->s_type->i_mutex_key#40){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x438/0x1df0 fs/ocfs2/file.c:2399
 #3: ffff888045dd8660 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_write_begin+0x195/0x300 fs/ocfs2/aops.c:1902

stack backtrace:
CPU: 1 PID: 21799 Comm: syz.5.4828 Not tainted 6.1.140-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x22e lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
 lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1891 [inline]
 sb_start_intwrite include/linux/fs.h:2013 [inline]
 ocfs2_start_trans+0x267/0x6c0 fs/ocfs2/journal.c:372
 ocfs2_write_begin_inline fs/ocfs2/aops.c:1481 [inline]
 ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1584 [inline]
 ocfs2_write_begin_nolock+0x1ca5/0x4270 fs/ocfs2/aops.c:1670
 ocfs2_write_begin+0x1b8/0x300 fs/ocfs2/aops.c:1904
 generic_perform_write+0x2db/0x560 mm/filemap.c:3846
 __generic_file_write_iter+0x172/0x430 mm/filemap.c:3974
 ocfs2_file_write_iter+0x1593/0x1df0 fs/ocfs2/file.c:2469
 call_write_iter include/linux/fs.h:2265 [inline]
 new_sync_write fs/read_write.c:491 [inline]
 vfs_write+0x44c/0x960 fs/read_write.c:584
 ksys_write+0x143/0x240 fs/read_write.c:637
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f4e2238e969
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f4e231f0038 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f4e225b5fa0 RCX: 00007f4e2238e969
RDX: 0000000000000020 RSI: 00002000000001c0 RDI: 0000000000000004
RBP: 00007f4e22410ab1 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f4e225b5fa0 R15: 00007ffc6993dad8
 </TASK>