syzbot

=======================================================
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.17/4506 is trying to acquire lock:
ffff88805b8a06f8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_init_acl+0x2fb/0x720 fs/ocfs2/acl.c:365

but task is already holding lock:
ffff88801b724990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x1312/0x15a0 fs/jbd2/transaction.c:462

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x1338/0x15a0 fs/jbd2/transaction.c:464
       jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:521
       jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:560
       ocfs2_start_trans+0x374/0x6c0 fs/ocfs2/journal.c:376
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:681 [inline]
       ocfs2_reserve_suballoc_bits+0x713/0x4350 fs/ocfs2/suballoc.c:828
       ocfs2_reserve_new_metadata_blocks+0x400/0x940 fs/ocfs2/suballoc.c:978
       ocfs2_init_xattr_set_ctxt+0x2e1/0x6c0 fs/ocfs2/xattr.c:3281
       ocfs2_xattr_set+0xb69/0x11e0 fs/ocfs2/xattr.c:3638
       ocfs2_set_acl+0x4e1/0x590 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x16f/0x270 fs/ocfs2/acl.c:285
       set_posix_acl fs/posix_acl.c:947 [inline]
       posix_acl_xattr_set+0x36f/0x3e0 fs/posix_acl.c:966
       __vfs_setxattr+0x3e0/0x420 fs/xattr.c:182
       __vfs_setxattr_noperm+0x129/0x5e0 fs/xattr.c:216
       vfs_setxattr+0x168/0x2f0 fs/xattr.c:303
       do_setxattr fs/xattr.c:588 [inline]
       setxattr+0x2da/0x300 fs/xattr.c:611
       path_setxattr+0x142/0x280 fs/xattr.c:630
       __do_sys_setxattr fs/xattr.c:646 [inline]
       __se_sys_setxattr fs/xattr.c:642 [inline]
       __x64_sys_setxattr+0xb7/0xd0 fs/xattr.c:642
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #3 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_start_trans+0x368/0x6c0 fs/ocfs2/journal.c:374
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:681 [inline]
       ocfs2_reserve_suballoc_bits+0x713/0x4350 fs/ocfs2/suballoc.c:828
       ocfs2_reserve_new_metadata_blocks+0x400/0x940 fs/ocfs2/suballoc.c:978
       ocfs2_init_xattr_set_ctxt+0x2e1/0x6c0 fs/ocfs2/xattr.c:3281
       ocfs2_xattr_set+0xb69/0x11e0 fs/ocfs2/xattr.c:3638
       ocfs2_set_acl+0x4e1/0x590 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x16f/0x270 fs/ocfs2/acl.c:285
       set_posix_acl fs/posix_acl.c:947 [inline]
       posix_acl_xattr_set+0x36f/0x3e0 fs/posix_acl.c:966
       __vfs_setxattr+0x3e0/0x420 fs/xattr.c:182
       __vfs_setxattr_noperm+0x129/0x5e0 fs/xattr.c:216
       vfs_setxattr+0x168/0x2f0 fs/xattr.c:303
       do_setxattr fs/xattr.c:588 [inline]
       setxattr+0x2da/0x300 fs/xattr.c:611
       path_setxattr+0x142/0x280 fs/xattr.c:630
       __do_sys_setxattr fs/xattr.c:646 [inline]
       __se_sys_setxattr fs/xattr.c:642 [inline]
       __x64_sys_setxattr+0xb7/0xd0 fs/xattr.c:642
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #2 (sb_internal#2){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1811 [inline]
       sb_start_intwrite include/linux/fs.h:1928 [inline]
       ocfs2_start_trans+0x269/0x6c0 fs/ocfs2/journal.c:372
       ocfs2_xattr_set+0xd62/0x11e0 fs/ocfs2/xattr.c:3647
       ocfs2_set_acl+0x4e1/0x590 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x16f/0x270 fs/ocfs2/acl.c:285
       set_posix_acl fs/posix_acl.c:947 [inline]
       posix_acl_xattr_set+0x36f/0x3e0 fs/posix_acl.c:966
       __vfs_setxattr+0x3e0/0x420 fs/xattr.c:182
       __vfs_setxattr_noperm+0x129/0x5e0 fs/xattr.c:216
       vfs_setxattr+0x168/0x2f0 fs/xattr.c:303
       do_setxattr fs/xattr.c:588 [inline]
       setxattr+0x2da/0x300 fs/xattr.c:611
       path_setxattr+0x142/0x280 fs/xattr.c:630
       __do_sys_setxattr fs/xattr.c:646 [inline]
       __se_sys_setxattr fs/xattr.c:642 [inline]
       __x64_sys_setxattr+0xb7/0xd0 fs/xattr.c:642
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_reserve_suballoc_bits+0x161/0x4350 fs/ocfs2/suballoc.c:782
       ocfs2_reserve_new_metadata_blocks+0x400/0x940 fs/ocfs2/suballoc.c:978
       ocfs2_init_xattr_set_ctxt+0x2e1/0x6c0 fs/ocfs2/xattr.c:3281
       ocfs2_xattr_set+0xb69/0x11e0 fs/ocfs2/xattr.c:3638
       ocfs2_set_acl+0x4e1/0x590 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x16f/0x270 fs/ocfs2/acl.c:285
       set_posix_acl fs/posix_acl.c:947 [inline]
       posix_acl_xattr_set+0x36f/0x3e0 fs/posix_acl.c:966
       __vfs_setxattr+0x3e0/0x420 fs/xattr.c:182
       __vfs_setxattr_noperm+0x129/0x5e0 fs/xattr.c:216
       vfs_setxattr+0x168/0x2f0 fs/xattr.c:303
       do_setxattr fs/xattr.c:588 [inline]
       setxattr+0x2da/0x300 fs/xattr.c:611
       path_setxattr+0x142/0x280 fs/xattr.c:630
       __do_sys_setxattr fs/xattr.c:646 [inline]
       __se_sys_setxattr fs/xattr.c:642 [inline]
       __x64_sys_setxattr+0xb7/0xd0 fs/xattr.c:642
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&oi->ip_xattr_sem){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
       lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_init_acl+0x2fb/0x720 fs/ocfs2/acl.c:365
       ocfs2_mknod+0x142f/0x22b0 fs/ocfs2/namei.c:410
       ocfs2_create+0x192/0x410 fs/ocfs2/namei.c:674
       vfs_create+0x2db/0x460 fs/namei.c:3170
       do_mknodat+0x39d/0x620 fs/namei.c:4002
       __do_sys_mknod fs/namei.c:4035 [inline]
       __se_sys_mknod fs/namei.c:4033 [inline]
       __x64_sys_mknod+0x8a/0xa0 fs/namei.c:4033
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  &oi->ip_xattr_sem --> &journal->j_trans_barrier --> jbd2_handle

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(jbd2_handle);
                               lock(&journal->j_trans_barrier);
                               lock(jbd2_handle);
  lock(&oi->ip_xattr_sem);

 *** DEADLOCK ***

8 locks held by syz.0.17/4506:
 #0: ffff888071de6460 (sb_writers#13){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:386
 #1: ffff88805b8a09c8 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:822 [inline]
 #1: ffff88805b8a09c8 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: filename_create+0x1f2/0x450 fs/namei.c:3843
 #2: ffff88805b9209c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #2: ffff88805b9209c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x161/0x4350 fs/ocfs2/suballoc.c:782
 #3: ffff88805b8a6d88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #3: ffff88805b8a6d88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x161/0x4350 fs/ocfs2/suballoc.c:782
 #4: ffff88805b922648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #4: ffff88805b922648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0x122/0x24c0 fs/ocfs2/localalloc.c:635
 #5: ffff888071de6650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_mknod+0xe2f/0x22b0 fs/ocfs2/namei.c:361
 #6: ffff88801ebeece8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x368/0x6c0 fs/ocfs2/journal.c:374
 #7: ffff88801b724990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x1312/0x15a0 fs/jbd2/transaction.c:462

stack backtrace:
CPU: 0 PID: 4506 Comm: syz.0.17 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x230 lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
 down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
 ocfs2_init_acl+0x2fb/0x720 fs/ocfs2/acl.c:365
 ocfs2_mknod+0x142f/0x22b0 fs/ocfs2/namei.c:410
 ocfs2_create+0x192/0x410 fs/ocfs2/namei.c:674
 vfs_create+0x2db/0x460 fs/namei.c:3170
 do_mknodat+0x39d/0x620 fs/namei.c:4002
 __do_sys_mknod fs/namei.c:4035 [inline]
 __se_sys_mknod fs/namei.c:4033 [inline]
 __x64_sys_mknod+0x8a/0xa0 fs/namei.c:4033
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7fd6f3e24fc9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffffd4448f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000085
RAX: ffffffffffffffda RBX: 00007fd6f407bfa0 RCX: 00007fd6f3e24fc9
RDX: 0000000000000700 RSI: 0000000000000fff RDI: 0000200000000140
RBP: 00007fd6f3ea7f91 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fd6f407bfa0 R14: 00007fd6f407bfa0 R15: 0000000000000003
 </TASK>
syz.0.17 (4506) used greatest stack depth: 20680 bytes left