syzbot

(syz.0.17,5947,0):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0xb3775c19, computed 0x2dd1c265. Applying ECC.
JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
6.6.101-syzkaller #0 Not tainted
------------------------------------------------------
syz.0.17/5947 is trying to acquire lock:
ffff88805ed306f8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_init_acl+0x2fa/0x720 fs/ocfs2/acl.c:366

but task is already holding lock:
ffff88802e66c990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x1e7d/0x20c0 fs/jbd2/transaction.c:448

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x1e9d/0x20c0 fs/jbd2/transaction.c:448
       jbd2__journal_start+0x2bb/0x5b0 fs/jbd2/transaction.c:505
       jbd2_journal_start+0x2a/0x40 fs/jbd2/transaction.c:544
       ocfs2_start_trans+0x376/0x6c0 fs/ocfs2/journal.c:374
       ocfs2_modify_bh+0xe9/0x470 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x13fd/0x1770 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x757/0xb80 fs/quota/dquot.c:2468
       dquot_load_quota_inode+0x2dc/0x5d0 fs/quota/dquot.c:2505
       ocfs2_enable_quotas+0x1c7/0x440 fs/ocfs2/super.c:926
       ocfs2_fill_super+0x3f6d/0x4d90 fs/ocfs2/super.c:1141
       mount_bdev+0x22b/0x2d0 fs/super.c:1643
       legacy_get_tree+0xea/0x180 fs/fs_context.c:662
       vfs_get_tree+0x8c/0x280 fs/super.c:1764
       do_new_mount+0x24b/0xa40 fs/namespace.c:3371
       do_mount fs/namespace.c:3711 [inline]
       __do_sys_mount fs/namespace.c:3920 [inline]
       __se_sys_mount+0x2da/0x3c0 fs/namespace.c:3897
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #3 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x36a/0x6c0 fs/ocfs2/journal.c:372
       ocfs2_modify_bh+0xe9/0x470 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x13fd/0x1770 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x757/0xb80 fs/quota/dquot.c:2468
       dquot_load_quota_inode+0x2dc/0x5d0 fs/quota/dquot.c:2505
       ocfs2_enable_quotas+0x1c7/0x440 fs/ocfs2/super.c:926
       ocfs2_fill_super+0x3f6d/0x4d90 fs/ocfs2/super.c:1141
       mount_bdev+0x22b/0x2d0 fs/super.c:1643
       legacy_get_tree+0xea/0x180 fs/fs_context.c:662
       vfs_get_tree+0x8c/0x280 fs/super.c:1764
       do_new_mount+0x24b/0xa40 fs/namespace.c:3371
       do_mount fs/namespace.c:3711 [inline]
       __do_sys_mount fs/namespace.c:3920 [inline]
       __se_sys_mount+0x2da/0x3c0 fs/namespace.c:3897
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (sb_internal#2){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1633 [inline]
       sb_start_intwrite include/linux/fs.h:1755 [inline]
       ocfs2_start_trans+0x26b/0x6c0 fs/ocfs2/journal.c:370
       ocfs2_xattr_set+0xd66/0x11f0 fs/ocfs2/xattr.c:3643
       ocfs2_set_acl+0x4e1/0x590 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x1ab/0x2a0 fs/ocfs2/acl.c:286
       set_posix_acl fs/posix_acl.c:956 [inline]
       vfs_set_acl+0x803/0xa60 fs/posix_acl.c:1135
       do_set_acl+0xf5/0x180 fs/posix_acl.c:1280
       do_setxattr fs/xattr.c:627 [inline]
       path_setxattr+0x39f/0x550 fs/xattr.c:659
       __do_sys_setxattr fs/xattr.c:677 [inline]
       __se_sys_setxattr fs/xattr.c:673 [inline]
       __x64_sys_setxattr+0xbb/0xd0 fs/xattr.c:673
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}:
       down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_reserve_suballoc_bits+0x165/0x4360 fs/ocfs2/suballoc.c:782
       ocfs2_reserve_new_metadata_blocks+0x404/0x940 fs/ocfs2/suballoc.c:978
       ocfs2_init_xattr_set_ctxt+0x2f8/0x6e0 fs/ocfs2/xattr.c:3277
       ocfs2_xattr_set+0xb6d/0x11f0 fs/ocfs2/xattr.c:3634
       ocfs2_set_acl+0x4e1/0x590 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x1ab/0x2a0 fs/ocfs2/acl.c:286
       set_posix_acl fs/posix_acl.c:956 [inline]
       vfs_set_acl+0x803/0xa60 fs/posix_acl.c:1135
       do_set_acl+0xf5/0x180 fs/posix_acl.c:1280
       do_setxattr fs/xattr.c:627 [inline]
       path_setxattr+0x39f/0x550 fs/xattr.c:659
       __do_sys_setxattr fs/xattr.c:677 [inline]
       __se_sys_setxattr fs/xattr.c:673 [inline]
       __x64_sys_setxattr+0xbb/0xd0 fs/xattr.c:673
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&oi->ip_xattr_sem){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
       lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ocfs2_init_acl+0x2fa/0x720 fs/ocfs2/acl.c:366
       ocfs2_mknod+0x12e5/0x20f0 fs/ocfs2/namei.c:410
       ocfs2_mkdir+0x196/0x410 fs/ocfs2/namei.c:657
       vfs_mkdir+0x296/0x440 fs/namei.c:4113
       do_mkdirat+0x1d4/0x440 fs/namei.c:4136
       __do_sys_mkdirat fs/namei.c:4151 [inline]
       __se_sys_mkdirat fs/namei.c:4149 [inline]
       __x64_sys_mkdirat+0x89/0xa0 fs/namei.c:4149
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &oi->ip_xattr_sem --> &journal->j_trans_barrier --> jbd2_handle

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(jbd2_handle);
                               lock(&journal->j_trans_barrier);
                               lock(jbd2_handle);
  rlock(&oi->ip_xattr_sem);

 *** DEADLOCK ***

8 locks held by syz.0.17/5947:
 #0: ffff88807a9da418 (sb_writers#13){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:403
 #1: ffff88805ed309d8 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:839 [inline]
 #1: ffff88805ed309d8 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: filename_create+0x1f6/0x460 fs/namei.c:3882
 #2: ffff88805ed3a658 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #2: ffff88805ed3a658 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x165/0x4360 fs/ocfs2/suballoc.c:782
 #3: ffff88805ed39818 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #3: ffff88805ed39818 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x165/0x4360 fs/ocfs2/suballoc.c:782
 #4: ffff88805ed3c2d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #4: ffff88805ed3c2d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0x126/0x24b0 fs/ocfs2/localalloc.c:635
 #5: ffff88807a9da608 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_mknod+0xe47/0x20f0 fs/ocfs2/namei.c:361
 #6: ffff8880601bc8e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x36a/0x6c0 fs/ocfs2/journal.c:372
 #7: ffff88802e66c990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x1e7d/0x20c0 fs/jbd2/transaction.c:448

stack backtrace:
CPU: 1 PID: 5947 Comm: syz.0.17 Not tainted 6.6.101-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x16c/0x230 lib/dump_stack.c:106
 check_noncircular+0x2bd/0x3c0 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
 lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
 down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
 ocfs2_init_acl+0x2fa/0x720 fs/ocfs2/acl.c:366
 ocfs2_mknod+0x12e5/0x20f0 fs/ocfs2/namei.c:410
 ocfs2_mkdir+0x196/0x410 fs/ocfs2/namei.c:657
 vfs_mkdir+0x296/0x440 fs/namei.c:4113
 do_mkdirat+0x1d4/0x440 fs/namei.c:4136
 __do_sys_mkdirat fs/namei.c:4151 [inline]
 __se_sys_mkdirat fs/namei.c:4149 [inline]
 __x64_sys_mkdirat+0x89/0xa0 fs/namei.c:4149
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7fabe418ebe9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffd32bb68f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000102
RAX: ffffffffffffffda RBX: 00007fabe43b5fa0 RCX: 00007fabe418ebe9
RDX: 0000000000000000 RSI: 0000200000000100 RDI: ffffffffffffff9c
RBP: 00007fabe4211e19 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fabe43b5fa0 R14: 00007fabe43b5fa0 R15: 0000000000000003
 </TASK>