syzbot

(syz-executor111,5305,0):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0xb3775c19, computed 0x2dd1c265. Applying ECC.
JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
6.15.0-rc4-syzkaller-00011-gf15d97df5afa #0 Not tainted
------------------------------------------------------
syz-executor111/5305 is trying to acquire lock:
ffff8880437986f8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_init_acl+0x2f9/0x720 fs/ocfs2/acl.c:366

but task is already holding lock:
ffff888042a7c950 (jbd2_handle){.+.+}-{0:0}, at: start_this_handle+0x1f87/0x21c0 fs/jbd2/transaction.c:444

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (jbd2_handle){.+.+}-{0:0}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       start_this_handle+0x1fa7/0x21c0 fs/jbd2/transaction.c:444
       jbd2__journal_start+0x2c1/0x5b0 fs/jbd2/transaction.c:501
       jbd2_journal_start+0x2a/0x40 fs/jbd2/transaction.c:540
       ocfs2_start_trans+0x376/0x6d0 fs/ocfs2/journal.c:352
       ocfs2_modify_bh+0xe8/0x470 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x1465/0x17e0 fs/ocfs2/quota_local.c:771
       dquot_load_quota_sb+0x78e/0xbd0 fs/quota/dquot.c:2459
       dquot_load_quota_inode+0x2e1/0x5d0 fs/quota/dquot.c:2496
       ocfs2_enable_quotas+0x1c6/0x450 fs/ocfs2/super.c:930
       ocfs2_fill_super+0x5115/0x63d0 fs/ocfs2/super.c:1140
       get_tree_bdev_flags+0x40b/0x4d0 fs/super.c:1636
       vfs_get_tree+0x8f/0x2b0 fs/super.c:1759
       do_new_mount+0x24a/0xa40 fs/namespace.c:3884
       do_mount fs/namespace.c:4224 [inline]
       __do_sys_mount fs/namespace.c:4435 [inline]
       __se_sys_mount+0x317/0x410 fs/namespace.c:4412
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (&journal->j_trans_barrier){.+.+}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1524
       ocfs2_start_trans+0x36a/0x6d0 fs/ocfs2/journal.c:350
       ocfs2_modify_bh+0xe8/0x470 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x1465/0x17e0 fs/ocfs2/quota_local.c:771
       dquot_load_quota_sb+0x78e/0xbd0 fs/quota/dquot.c:2459
       dquot_load_quota_inode+0x2e1/0x5d0 fs/quota/dquot.c:2496
       ocfs2_enable_quotas+0x1c6/0x450 fs/ocfs2/super.c:930
       ocfs2_fill_super+0x5115/0x63d0 fs/ocfs2/super.c:1140
       get_tree_bdev_flags+0x40b/0x4d0 fs/super.c:1636
       vfs_get_tree+0x8f/0x2b0 fs/super.c:1759
       do_new_mount+0x24a/0xa40 fs/namespace.c:3884
       do_mount fs/namespace.c:4224 [inline]
       __do_sys_mount fs/namespace.c:4435 [inline]
       __se_sys_mount+0x317/0x410 fs/namespace.c:4412
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (sb_internal#2){.+.+}-{0:0}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       percpu_down_read include/linux/percpu-rwsem.h:52 [inline]
       __sb_start_write include/linux/fs.h:1783 [inline]
       sb_start_intwrite include/linux/fs.h:1966 [inline]
       ocfs2_start_trans+0x26b/0x6d0 fs/ocfs2/journal.c:348
       ocfs2_xattr_set+0xd69/0x11f0 fs/ocfs2/xattr.c:3643
       ocfs2_set_acl+0x701/0x7b0 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x1aa/0x2a0 fs/ocfs2/acl.c:286
       set_posix_acl fs/posix_acl.c:954 [inline]
       vfs_set_acl+0x884/0xb00 fs/posix_acl.c:1133
       do_set_acl+0xf6/0x190 fs/posix_acl.c:1278
       do_setxattr fs/xattr.c:633 [inline]
       filename_setxattr+0x2e0/0x600 fs/xattr.c:665
       path_setxattrat+0x364/0x3a0 fs/xattr.c:713
       __do_sys_setxattr fs/xattr.c:747 [inline]
       __se_sys_setxattr fs/xattr.c:743 [inline]
       __x64_sys_setxattr+0xbc/0xe0 fs/xattr.c:743
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:867 [inline]
       ocfs2_reserve_suballoc_bits+0x15e/0x45f0 fs/ocfs2/suballoc.c:786
       ocfs2_reserve_new_metadata_blocks+0x403/0x940 fs/ocfs2/suballoc.c:982
       ocfs2_init_xattr_set_ctxt+0x307/0x700 fs/ocfs2/xattr.c:3277
       ocfs2_xattr_set+0xb70/0x11f0 fs/ocfs2/xattr.c:3634
       ocfs2_set_acl+0x701/0x7b0 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x1aa/0x2a0 fs/ocfs2/acl.c:286
       set_posix_acl fs/posix_acl.c:954 [inline]
       vfs_set_acl+0x884/0xb00 fs/posix_acl.c:1133
       do_set_acl+0xf6/0x190 fs/posix_acl.c:1278
       do_setxattr fs/xattr.c:633 [inline]
       filename_setxattr+0x2e0/0x600 fs/xattr.c:665
       path_setxattrat+0x364/0x3a0 fs/xattr.c:713
       __do_sys_setxattr fs/xattr.c:747 [inline]
       __se_sys_setxattr fs/xattr.c:743 [inline]
       __x64_sys_setxattr+0xbc/0xe0 fs/xattr.c:743
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&oi->ip_xattr_sem){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3166 [inline]
       check_prevs_add kernel/locking/lockdep.c:3285 [inline]
       validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3909
       __lock_acquire+0xaac/0xd20 kernel/locking/lockdep.c:5235
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1524
       ocfs2_init_acl+0x2f9/0x720 fs/ocfs2/acl.c:366
       ocfs2_mknod+0x1321/0x2050 fs/ocfs2/namei.c:410
       vfs_mknod+0x37c/0x3c0 fs/namei.c:4228
       do_mknodat+0x385/0x4d0 fs/namei.c:-1
       __do_sys_mknodat fs/namei.c:4306 [inline]
       __se_sys_mknodat fs/namei.c:4303 [inline]
       __x64_sys_mknodat+0xa7/0xc0 fs/namei.c:4303
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &oi->ip_xattr_sem --> &journal->j_trans_barrier --> jbd2_handle

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(jbd2_handle);
                               lock(&journal->j_trans_barrier);
                               lock(jbd2_handle);
  rlock(&oi->ip_xattr_sem);

 *** DEADLOCK ***

8 locks held by syz-executor111/5305:
 #0: ffff88803e994420 (sb_writers#8){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:556
 #1: ffff8880437989c0 (&type->i_mutex_dir_key#6/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:902 [inline]
 #1: ffff8880437989c0 (&type->i_mutex_dir_key#6/1){+.+.}-{4:4}, at: filename_create+0x1f9/0x470 fs/namei.c:4132
 #2: ffff888043762640 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
 #2: ffff888043762640 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x15e/0x45f0 fs/ocfs2/suballoc.c:786
 #3: ffff888043761800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
 #3: ffff888043761800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x15e/0x45f0 fs/ocfs2/suballoc.c:786
 #4: ffff8880437642c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
 #4: ffff8880437642c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{4:4}, at: ocfs2_reserve_local_alloc_bits+0x125/0x24e0 fs/ocfs2/localalloc.c:636
 #5: ffff88803e994610 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_mknod+0xe93/0x2050 fs/ocfs2/namei.c:361
 #6: ffff8880110dece8 (&journal->j_trans_barrier){.+.+}-{4:4}, at: ocfs2_start_trans+0x36a/0x6d0 fs/ocfs2/journal.c:350
 #7: ffff888042a7c950 (jbd2_handle){.+.+}-{0:0}, at: start_this_handle+0x1f87/0x21c0 fs/jbd2/transaction.c:444

stack backtrace:
CPU: 0 UID: 0 PID: 5305 Comm: syz-executor111 Not tainted 6.15.0-rc4-syzkaller-00011-gf15d97df5afa #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120
 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2079
 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2211
 check_prev_add kernel/locking/lockdep.c:3166 [inline]
 check_prevs_add kernel/locking/lockdep.c:3285 [inline]
 validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3909
 __lock_acquire+0xaac/0xd20 kernel/locking/lockdep.c:5235
 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
 down_read+0x46/0x2e0 kernel/locking/rwsem.c:1524
 ocfs2_init_acl+0x2f9/0x720 fs/ocfs2/acl.c:366
 ocfs2_mknod+0x1321/0x2050 fs/ocfs2/namei.c:410
 vfs_mknod+0x37c/0x3c0 fs/namei.c:4228
 do_mknodat+0x385/0x4d0 fs/namei.c:-1
 __do_sys_mknodat fs/namei.c:4306 [inline]
 __se_sys_mknodat fs/namei.c:4303 [inline]
 __x64_sys_mknodat+0xa7/0xc0 fs/namei.c:4303
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fb79609aea9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffe74b0fe18 EFLAGS: 00000246 ORIG_RAX: 0000000000000103
RAX: ffffffffffffffda RBX: 0030656c69662f2e RCX: 00007fb79609aea9
RDX: 000000000000c000 RSI: 00002000000003c0 RDI: 0000000000000003
RBP: 00007fb7961135f0 R08: 000055556a8ef4c0 R09: 000055556a8ef4c0
R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffe74b0fe40
R13: 00007ffe74b10068 R14: 431bde82d7b634db R15: 00007fb7960e401d
 </TASK>