KCSAN: data-race in generic_permission / kernfs_iop_permission

Status: moderation: reported on 2026/11/20 00:03
Subsystems: kernfs
Labels: prio:low race:benign
[Documentation on labels]
Reported-by: syzbot+5a5937e5f82f0e8fa8ec@syzkaller.appspotmail.com
First crash: 2d07h, last: 4h35m
✨ AI-generated root cause summary:

kernfs_iop_permission() in fs/kernfs/inode.c acquires only a shared read lock (down_read(&root->kernfs_iattr_rwsem)) before calling kernfs_refresh_inode(kn, inode) and generic_permission(). Because down_read() permits concurrent execution on the same inode, one task's plain 2-byte write to inode->i_mode in kernfs_refresh_inode() races with another task's plain 2-byte read of inode->i_mode in acl_permission_check() (via generic_permission()), as well as with concurrent kernfs_refresh_inode() calls in kernfs_iop_permission() and kernfs_iop_getattr().

▶ ▼ ✨ Full AI root cause analysis
Based on kernel commit 8dac6df92a2e:

Root Cause Analysis

The KCSAN data race occurs because kernfs_iop_permission() in fs/kernfs/inode.c mutates fields of the shared VFS struct inode while holding only a shared reader lock (down_read(&root->kernfs_iattr_rwsem)), allowing concurrent VFS lookups on the same kernfs node to read and write inode->i_mode without synchronization.

Technical Mechanism

  1. Shared locking in kernfs_iop_permission() (fs/kernfs/inode.c:273-292):

    • When VFS path traversal (link_path_walk() -> may_lookup() -> inode_permission() -> do_inode_permission()) checks permissions on a kernfs inode (in non-RCU mode, i.e., without MAY_NOT_BLOCK), it invokes inode->i_op->permission, which points to kernfs_iop_permission() (registered in kernfs_iops, kernfs_dir_iops, and kernfs_symlink_iops).
    • kernfs_iop_permission() acquires root->kernfs_iattr_rwsem for reading:
      down_read(&root->kernfs_iattr_rwsem);
      kernfs_refresh_inode(kn, inode);
      ret = generic_permission(&nop_mnt_idmap, inode, mask);
      up_read(&root->kernfs_iattr_rwsem);
      
    • kernfs_iop_getattr() (fs/kernfs/inode.c:182-196) follows the same pattern, calling kernfs_refresh_inode() and generic_fillattr() under down_read(&root->kernfs_iattr_rwsem).
  2. Unprotected writes in kernfs_refresh_inode() (fs/kernfs/inode.c:165-180):

    • Because root->kernfs_iattr_rwsem is only acquired for reading, multiple tasks can enter kernfs_iop_permission() (and kernfs_iop_getattr()) simultaneously for the same struct kernfs_node (kn) and struct inode (inode).
    • kernfs_refresh_inode() unconditionally performs plain (non-atomic) writes to inode fields:
      • inode->i_mode = kn->mode; (fs/kernfs/inode.c:169), a 2-byte umode_t write at offset 0 of struct inode.
      • set_inode_attr(inode, attrs); (fs/kernfs/inode.c:176), which writes inode->i_uid, inode->i_gid, and timestamps.
      • set_nlink(inode, kn->dir.subdirs + 2); (fs/kernfs/inode.c:179), which writes inode->__i_nlink for active directories.
  3. Concurrent read in generic_permission() / acl_permission_check() (fs/namei.c:438-531):

    • After kernfs_refresh_inode(), kernfs_iop_permission() calls generic_permission(&nop_mnt_idmap, inode, mask) (fs/kernfs/inode.c:288), which calls acl_permission_check() (fs/namei.c:529).
    • acl_permission_check() performs a plain 2-byte read of inode->i_mode (unsigned int mode = inode->i_mode; at fs/namei.c:441) and may also read inode->i_uid and inode->i_gid.
    • In the reported trace, Task 3731 (openat -> kernfs_iop_permission() -> kernfs_refresh_inode() at fs/kernfs/inode.c:169) writes 2 bytes to inode->i_mode (0xffff888107516f88) concurrently with Task 3010 (readlink -> kernfs_iop_permission() -> generic_permission() -> acl_permission_check() at fs/namei.c:441) reading those 2 bytes.

Lifecycle and Invariants

  • Modifications to kn->mode (via __kernfs_setattr() in kernfs_setattr() / kernfs_iop_setattr()) and kn->iattr attributes are serialized under down_write(&root->kernfs_iattr_rwsem).
  • kernfs_iattr_rwsem protects the kernfs_node attributes against concurrent setattr, but it does not serialize the copy/refresh of those attributes from kn into the VFS struct inode, nor does kernfs_iop_permission() hold inode->i_lock or inode->i_rwsem exclusively. Consequently, any two concurrent readers executing kernfs_iop_permission() or kernfs_iop_getattr() on the same kernfs inode violate the C memory model invariant against unsynchronized concurrent read/write (and write/write) accesses to inode->i_mode (as well as i_uid, i_gid, and __i_nlink).
▶ ▼ ✨ AI Jobs (2)
ID Workflow Result Correct Bug Created Started Finished Revision
42e55d2e assessment-security DenialOfService: ❌ Exploitable: ❌ FilesystemTrigger: ❌ FuzzingArtifact: ❌ MemoryCorruption: ❌ NetworkNeedsSetup: ❌ NetworkTrigger: ❌ PeripheralTrigger: ❌ RemoteTrigger: ❌ Unprivileged: ✅ UserNamespace: ✅ VMGuestTrigger: ❌ VMHostTrigger: ❌ ❓ KCSAN: data-race in generic_permission / kernfs_iop_permission 2026/11/19 20:48 2026/11/19 20:48 2026/11/19 20:50 229865fb
051200b2 assessment-kcsan Benign: ✅ ❓ KCSAN: data-race in generic_permission / kernfs_iop_permission 2026/11/19 20:47 2026/11/19 20:47 2026/11/19 21:08 229865fb

Sample crash report:
==================================================================
BUG: KCSAN: data-race in generic_permission / kernfs_iop_permission

write to 0xffff888107516f88 of 2 bytes by task 3731 on cpu 1:
 kernfs_refresh_inode fs/kernfs/inode.c:169 [inline]
 kernfs_iop_permission+0x9d/0x220 fs/kernfs/inode.c:287
 do_inode_permission fs/namei.c:583 [inline]
 inode_permission+0x2b4/0x3c0 fs/namei.c:653
 lookup_inode_permission_may_exec fs/namei.c:-1 [inline]
 may_lookup fs/namei.c:1967 [inline]
 link_path_walk+0x881/0xde0 fs/namei.c:2610
 path_openat+0x142/0x11e0 fs/namei.c:5012
 do_file_open+0x16c/0x290 fs/namei.c:5045
 do_sys_openat2+0xa1/0x140 fs/open.c:1443
 do_sys_open fs/open.c:1449 [inline]
 __do_sys_openat fs/open.c:1465 [inline]
 __se_sys_openat fs/open.c:1460 [inline]
 __x64_sys_openat+0xf2/0x120 fs/open.c:1460
 x64_sys_call+0x1f72/0x2550 arch/x86/include/generated/asm/syscalls_64.h:258
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x11e/0x3a0 arch/x86/entry/syscall_64.c:89
 entry_SYSCALL_64_after_hwframe+0x77/0x7f

read to 0xffff888107516f88 of 2 bytes by task 3010 on cpu 0:
 acl_permission_check fs/namei.c:441 [inline]
 generic_permission+0x2a/0x470 fs/namei.c:529
 kernfs_iop_permission+0x1fd/0x220 fs/kernfs/inode.c:288
 do_inode_permission fs/namei.c:583 [inline]
 inode_permission+0x2b4/0x3c0 fs/namei.c:653
 lookup_inode_permission_may_exec fs/namei.c:-1 [inline]
 may_lookup fs/namei.c:1967 [inline]
 link_path_walk+0x881/0xde0 fs/namei.c:2610
 path_lookupat+0x53/0x4c0 fs/namei.c:2818
 filename_lookup+0x18f/0x390 fs/namei.c:2848
 do_readlinkat+0x74/0x2f0 fs/stat.c:575
 __do_sys_readlink fs/stat.c:609 [inline]
 __se_sys_readlink fs/stat.c:606 [inline]
 __x64_sys_readlink+0x47/0x60 fs/stat.c:606
 x64_sys_call+0x1d41/0x2550 arch/x86/include/generated/asm/syscalls_64.h:90
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x11e/0x3a0 arch/x86/entry/syscall_64.c:89
 entry_SYSCALL_64_after_hwframe+0x77/0x7f

Reported by Kernel Concurrency Sanitizer on:
CPU: 0 UID: 0 PID: 3010 Comm: udevd Not tainted syzkaller #0 PREEMPT(lazy) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/06/2026
==================================================================

Crashes (7):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2026/11/19 20:20 upstream 8dac6df92a2e 229865fb .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in generic_permission / kernfs_iop_permission
2026/11/19 20:20 upstream 8dac6df92a2e 229865fb .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in generic_permission / kernfs_iop_permission
2026/11/19 07:23 upstream 4405c18c95d2 f138241c .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in generic_permission / kernfs_iop_permission
2026/11/18 20:32 upstream 4405c18c95d2 2006bdcc .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in generic_permission / kernfs_iop_permission
2026/11/18 18:56 upstream 20eef29b7c84 2006bdcc .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in generic_permission / kernfs_iop_permission
2026/11/17 21:23 upstream 63fdb511c27a 122f94d5 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in generic_permission / kernfs_iop_permission
2026/11/17 17:01 upstream 666539eecdf4 122f94d5 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in generic_permission / kernfs_iop_permission
* Struck through repros no longer work on HEAD.