syzbot

ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.17/5931 is trying to acquire lock:
ffff888071762658 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
ffff888071762658 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_remove_inode fs/ocfs2/inode.c:655 [inline]
ffff888071762658 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline]
ffff888071762658 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
ffff888071762658 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_evict_inode+0x1daa/0x41a0 fs/ocfs2/inode.c:1219

but task is already holding lock:
ffff8880717609d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
ffff8880717609d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: ocfs2_wipe_inode fs/ocfs2/inode.c:776 [inline]
ffff8880717609d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
ffff8880717609d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: ocfs2_evict_inode+0x2d0a/0x41a0 fs/ocfs2/inode.c:1219

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}:
       down_write+0x97/0x200 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_del_inode_from_orphan+0x12f/0x7b0 fs/ocfs2/namei.c:2716
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2407 [inline]
       ocfs2_dio_end_io+0x107a/0x13f0 fs/ocfs2/aops.c:2446
       dio_complete+0x24c/0x710 fs/direct-io.c:282
       __blockdev_direct_IO+0x2c42/0x32e0 fs/direct-io.c:1308
       ocfs2_direct_IO+0x235/0x2a0 fs/ocfs2/aops.c:2483
       generic_file_direct_write+0x1c9/0x3e0 mm/filemap.c:3961
       __generic_file_write_iter+0x11b/0x230 mm/filemap.c:4117
       ocfs2_file_write_iter+0x1724/0x1ef0 fs/ocfs2/file.c:2468
       do_iter_readv_writev fs/read_write.c:-1 [inline]
       do_iter_write+0x747/0xc50 fs/read_write.c:860
       vfs_writev fs/read_write.c:933 [inline]
       do_pwritev+0x242/0x3a0 fs/read_write.c:1030
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}:
       down_write+0x97/0x200 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_reserve_suballoc_bits+0x171/0x44a0 fs/ocfs2/suballoc.c:782
       ocfs2_reserve_new_metadata_blocks+0x416/0x9a0 fs/ocfs2/suballoc.c:978
       ocfs2_mknod+0xea5/0x2310 fs/ocfs2/namei.c:347
       ocfs2_create+0x196/0x430 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3496 [inline]
       open_last_lookups fs/namei.c:3564 [inline]
       path_openat+0x1705/0x3270 fs/namei.c:3794
       do_filp_open+0x1f2/0x430 fs/namei.c:3824
       do_sys_openat2+0x134/0x1d0 fs/open.c:1421
       do_sys_open fs/open.c:1436 [inline]
       __do_sys_open fs/open.c:1444 [inline]
       __se_sys_open fs/open.c:1440 [inline]
       __x64_sys_open+0x11f/0x140 fs/open.c:1440
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x37ef/0x7d80 kernel/locking/lockdep.c:5137
       lock_acquire+0x19e/0x420 kernel/locking/lockdep.c:5754
       down_write+0x97/0x200 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_remove_inode fs/ocfs2/inode.c:655 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
       ocfs2_evict_inode+0x1daa/0x41a0 fs/ocfs2/inode.c:1219
       evict+0x4b7/0x8a0 fs/inode.c:705
       d_delete_notify include/linux/fsnotify.h:269 [inline]
       vfs_rmdir+0x378/0x4b0 fs/namei.c:4217
       do_rmdir+0x29f/0x590 fs/namei.c:4263
       __do_sys_rmdir fs/namei.c:4282 [inline]
       __se_sys_rmdir fs/namei.c:4280 [inline]
       __x64_sys_rmdir+0x49/0x50 fs/namei.c:4280
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);

 *** DEADLOCK ***

4 locks held by syz.0.17/5931:
 #0: ffff88807e2a4418 (sb_writers#13){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:412
 #1: ffff8880717589d8 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:839 [inline]
 #1: ffff8880717589d8 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: do_rmdir+0x1c6/0x590 fs/namei.c:4251
 #2: ffff888027008bd0 (&osb->nfs_sync_rwlock){.+.+}-{3:3}, at: ocfs2_nfs_sync_lock+0x107/0x270 fs/ocfs2/dlmglue.c:2876
 #3: ffff8880717609d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #3: ffff8880717609d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: ocfs2_wipe_inode fs/ocfs2/inode.c:776 [inline]
 #3: ffff8880717609d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
 #3: ffff8880717609d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: ocfs2_evict_inode+0x2d0a/0x41a0 fs/ocfs2/inode.c:1219

stack backtrace:
CPU: 0 PID: 5931 Comm: syz.0.17 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x18c/0x250 lib/dump_stack.c:106
 check_noncircular+0x2fc/0x400 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x37ef/0x7d80 kernel/locking/lockdep.c:5137
 lock_acquire+0x19e/0x420 kernel/locking/lockdep.c:5754
 down_write+0x97/0x200 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:804 [inline]
 ocfs2_remove_inode fs/ocfs2/inode.c:655 [inline]
 ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline]
 ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
 ocfs2_evict_inode+0x1daa/0x41a0 fs/ocfs2/inode.c:1219
 evict+0x4b7/0x8a0 fs/inode.c:705
 d_delete_notify include/linux/fsnotify.h:269 [inline]
 vfs_rmdir+0x378/0x4b0 fs/namei.c:4217
 do_rmdir+0x29f/0x590 fs/namei.c:4263
 __do_sys_rmdir fs/namei.c:4282 [inline]
 __se_sys_rmdir fs/namei.c:4280 [inline]
 __x64_sys_rmdir+0x49/0x50 fs/namei.c:4280
 do_syscall_x64 arch/x86/entry/common.c:46 [inline]
 do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7fc42b39ce59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc2f407678 EFLAGS: 00000246 ORIG_RAX: 0000000000000054
RAX: ffffffffffffffda RBX: 00007fc42b615fa0 RCX: 00007fc42b39ce59
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000200000000400
RBP: 00007fc42b432e6f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fc42b615fac R14: 00007fc42b615fa0 R15: 00007fc42b615fa0
 </TASK>
syz.0.17 (5931) used greatest stack depth: 19480 bytes left