syzbot

ocfs2: Mounting device (7,0) on (node local, slot 0) with writeback data mode.
======================================================
WARNING: possible circular locking dependency detected
6.15.0-rc6-syzkaller-00208-g3c21441eeffc #0 Not tainted
------------------------------------------------------
syz.0.225/8024 is trying to acquire lock:
ffff8880528ab480 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
ffff8880528ab480 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{4:4}, at: ocfs2_remove_inode fs/ocfs2/inode.c:669 [inline]
ffff8880528ab480 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{4:4}, at: ocfs2_wipe_inode fs/ocfs2/inode.c:832 [inline]
ffff8880528ab480 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{4:4}, at: ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline]
ffff8880528ab480 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{4:4}, at: ocfs2_evict_inode+0x153d/0x40e0 fs/ocfs2/inode.c:1230

but task is already holding lock:
ffff888059316d80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
ffff888059316d80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: ocfs2_wipe_inode fs/ocfs2/inode.c:790 [inline]
ffff888059316d80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline]
ffff888059316d80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: ocfs2_evict_inode+0xf86/0x40e0 fs/ocfs2/inode.c:1230

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:867 [inline]
       ocfs2_del_inode_from_orphan+0x134/0x740 fs/ocfs2/namei.c:2727
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2303 [inline]
       ocfs2_dio_end_io+0x479/0x10f0 fs/ocfs2/aops.c:2401
       dio_complete+0x25b/0x790 fs/direct-io.c:281
       __blockdev_direct_IO+0x2cd4/0x3310 fs/direct-io.c:1303
       ocfs2_direct_IO+0x25f/0x2d0 fs/ocfs2/aops.c:2438
       generic_file_direct_write+0x1d8/0x3e0 mm/filemap.c:4037
       __generic_file_write_iter+0x11d/0x230 mm/filemap.c:4206
       ocfs2_file_write_iter+0x157a/0x1d10 fs/ocfs2/file.c:2469
       iter_file_splice_write+0x937/0x1000 fs/splice.c:738
       do_splice_from fs/splice.c:935 [inline]
       direct_splice_actor+0xfe/0x160 fs/splice.c:1158
       splice_direct_to_actor+0x5a8/0xcc0 fs/splice.c:1102
       do_splice_direct_actor fs/splice.c:1201 [inline]
       do_splice_direct+0x181/0x270 fs/splice.c:1227
       do_sendfile+0x4da/0x7d0 fs/read_write.c:1368
       __do_sys_sendfile64 fs/read_write.c:1429 [inline]
       __se_sys_sendfile64+0x13e/0x190 fs/read_write.c:1415
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
       ocfs2_create_local_dquot+0x19d/0x1a40 fs/ocfs2/quota_local.c:1227
       ocfs2_acquire_dquot+0x80f/0xb30 fs/ocfs2/quota_global.c:883
       dqget+0x7b1/0xf10 fs/quota/dquot.c:977
       dquot_set_dqblk+0x2b/0xfa0 fs/quota/dquot.c:2820
       quota_setquota+0x4b4/0x540 fs/quota/quota.c:310
       __do_sys_quotactl fs/quota/quota.c:961 [inline]
       __se_sys_quotactl+0x279/0x950 fs/quota/quota.c:917
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&dquot->dq_lock){+.+.}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       __mutex_lock_common kernel/locking/mutex.c:601 [inline]
       __mutex_lock+0x182/0xe80 kernel/locking/mutex.c:746
       wait_on_dquot fs/quota/dquot.c:354 [inline]
       dqget+0x72a/0xf10 fs/quota/dquot.c:972
       __dquot_initialize+0x3b3/0xcb0 fs/quota/dquot.c:1505
       ocfs2_get_init_inode+0x13b/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x863/0x2050 fs/ocfs2/namei.c:310
       ocfs2_create+0x1a5/0x440 fs/ocfs2/namei.c:673
       lookup_open fs/namei.c:3701 [inline]
       open_last_lookups fs/namei.c:3800 [inline]
       path_openat+0x14f1/0x3830 fs/namei.c:4036
       do_filp_open+0x1fa/0x410 fs/namei.c:4066
       do_sys_openat2+0x121/0x1c0 fs/open.c:1429
       do_sys_open fs/open.c:1444 [inline]
       __do_sys_open fs/open.c:1452 [inline]
       __se_sys_open fs/open.c:1448 [inline]
       __x64_sys_open+0x11e/0x150 fs/open.c:1448
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3166 [inline]
       check_prevs_add kernel/locking/lockdep.c:3285 [inline]
       validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3909
       __lock_acquire+0xaac/0xd20 kernel/locking/lockdep.c:5235
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:867 [inline]
       ocfs2_remove_inode fs/ocfs2/inode.c:669 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:832 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline]
       ocfs2_evict_inode+0x153d/0x40e0 fs/ocfs2/inode.c:1230
       evict+0x501/0x9c0 fs/inode.c:810
       d_delete_notify include/linux/fsnotify.h:402 [inline]
       vfs_rmdir+0x3ec/0x520 fs/namei.c:4467
       do_rmdir+0x2ac/0x630 fs/namei.c:4509
       __do_sys_rmdir fs/namei.c:4528 [inline]
       __se_sys_rmdir fs/namei.c:4526 [inline]
       __x64_sys_rmdir+0x47/0x50 fs/namei.c:4526
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5 --> &ocfs2_quota_ip_alloc_sem_key --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);
                               lock(&ocfs2_quota_ip_alloc_sem_key);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5);

 *** DEADLOCK ***

4 locks held by syz.0.225/8024:
 #0: ffff88803409c420 (sb_writers#30){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:556
 #1: ffff888059315f40 (&type->i_mutex_dir_key#19/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:902 [inline]
 #1: ffff888059315f40 (&type->i_mutex_dir_key#19/1){+.+.}-{4:4}, at: do_rmdir+0x1b2/0x630 fs/namei.c:4501
 #2: ffff888030374bd0 (&osb->nfs_sync_rwlock){.+.+}-{4:4}, at: ocfs2_nfs_sync_lock+0x106/0x250 fs/ocfs2/dlmglue.c:2875
 #3: ffff888059316d80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
 #3: ffff888059316d80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: ocfs2_wipe_inode fs/ocfs2/inode.c:790 [inline]
 #3: ffff888059316d80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline]
 #3: ffff888059316d80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: ocfs2_evict_inode+0xf86/0x40e0 fs/ocfs2/inode.c:1230

stack backtrace:
CPU: 1 UID: 0 PID: 8024 Comm: syz.0.225 Not tainted 6.15.0-rc6-syzkaller-00208-g3c21441eeffc #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120
 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2079
 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2211
 check_prev_add kernel/locking/lockdep.c:3166 [inline]
 check_prevs_add kernel/locking/lockdep.c:3285 [inline]
 validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3909
 __lock_acquire+0xaac/0xd20 kernel/locking/lockdep.c:5235
 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
 down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
 inode_lock include/linux/fs.h:867 [inline]
 ocfs2_remove_inode fs/ocfs2/inode.c:669 [inline]
 ocfs2_wipe_inode fs/ocfs2/inode.c:832 [inline]
 ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline]
 ocfs2_evict_inode+0x153d/0x40e0 fs/ocfs2/inode.c:1230
 evict+0x501/0x9c0 fs/inode.c:810
 d_delete_notify include/linux/fsnotify.h:402 [inline]
 vfs_rmdir+0x3ec/0x520 fs/namei.c:4467
 do_rmdir+0x2ac/0x630 fs/namei.c:4509
 __do_sys_rmdir fs/namei.c:4528 [inline]
 __se_sys_rmdir fs/namei.c:4526 [inline]
 __x64_sys_rmdir+0x47/0x50 fs/namei.c:4526
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f6153f8e969
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f6154e37038 EFLAGS: 00000246 ORIG_RAX: 0000000000000054
RAX: ffffffffffffffda RBX: 00007f61541b5fa0 RCX: 00007f6153f8e969
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000200000000780
RBP: 00007f6154010ab1 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f61541b5fa0 R15: 00007fff12d37b48
 </TASK>