syzbot


possible deadlock in ocfs2_del_inode_from_orphan (2)

Status: upstream: reported on 2025/06/23 09:47
Reported-by: syzbot+a2336a54076fe963f465@syzkaller.appspotmail.com
First crash: 2d13h, last: 2d13h
Similar bugs (3)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-5.15 possible deadlock in ocfs2_del_inode_from_orphan 1 170d 170d 0/3 auto-obsoleted due to no activity on 2025/04/16 07:13
linux-6.1 possible deadlock in ocfs2_del_inode_from_orphan 4 100d 196d 0/3 auto-obsoleted due to no activity on 2025/06/25 04:24
upstream possible deadlock in ocfs2_del_inode_from_orphan ocfs2 C inconclusive 1431 23m 265d 0/29 upstream: reported C repro on 2024/10/03 02:18

Sample crash report:
ocfs2: Mounting device (7,2) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
5.15.185-syzkaller #0 Not tainted
------------------------------------------------------
syz.2.270/5605 is trying to acquire lock:
ffff0000e9f1d108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
ffff0000e9f1d108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: ocfs2_del_inode_from_orphan+0x100/0x608 fs/ocfs2/namei.c:2713

but task is already holding lock:
ffff0000e9f13120 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io_write fs/ocfs2/aops.c:2325 [inline]
ffff0000e9f13120 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io+0x334/0xee8 fs/ocfs2/aops.c:2431

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
       ocfs2_lock_global_qf+0x1a8/0x22c fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x244/0xa2c fs/ocfs2/quota_global.c:816
       dqget+0x658/0xcf4 fs/quota/dquot.c:988
       __dquot_initialize+0x2d4/0xa80 fs/quota/dquot.c:1517
       dquot_initialize+0x24/0x34 fs/quota/dquot.c:1579
       ocfs2_get_init_inode+0x134/0x1a8 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x758/0x1e88 fs/ocfs2/namei.c:310
       ocfs2_mkdir+0x180/0x468 fs/ocfs2/namei.c:657
       vfs_mkdir+0x314/0x4d4 fs/namei.c:4065
       do_mkdirat+0x1bc/0x508 fs/namei.c:4090
       __do_sys_mkdirat fs/namei.c:4105 [inline]
       __se_sys_mkdirat fs/namei.c:4103 [inline]
       __arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4103
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x78/0x1e0 arch/arm64/kernel/entry-common.c:608
       el0t_64_sync_handler+0xcc/0xe4 arch/arm64/kernel/entry-common.c:626
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #3 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}:
       down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_lock_global_qf+0x18c/0x22c fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x244/0xa2c fs/ocfs2/quota_global.c:816
       dqget+0x658/0xcf4 fs/quota/dquot.c:988
       __dquot_initialize+0x2d4/0xa80 fs/quota/dquot.c:1517
       dquot_initialize+0x24/0x34 fs/quota/dquot.c:1579
       ocfs2_get_init_inode+0x134/0x1a8 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x758/0x1e88 fs/ocfs2/namei.c:310
       ocfs2_mkdir+0x180/0x468 fs/ocfs2/namei.c:657
       vfs_mkdir+0x314/0x4d4 fs/namei.c:4065
       do_mkdirat+0x1bc/0x508 fs/namei.c:4090
       __do_sys_mkdirat fs/namei.c:4105 [inline]
       __se_sys_mkdirat fs/namei.c:4103 [inline]
       __arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4103
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x78/0x1e0 arch/arm64/kernel/entry-common.c:608
       el0t_64_sync_handler+0xcc/0xe4 arch/arm64/kernel/entry-common.c:626
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #2 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common+0x194/0x1edc kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0xac/0x11c kernel/locking/mutex.c:743
       wait_on_dquot fs/quota/dquot.c:356 [inline]
       dqget+0x5e8/0xcf4 fs/quota/dquot.c:983
       __dquot_initialize+0x2d4/0xa80 fs/quota/dquot.c:1517
       dquot_initialize+0x24/0x34 fs/quota/dquot.c:1579
       ocfs2_get_init_inode+0x134/0x1a8 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x758/0x1e88 fs/ocfs2/namei.c:310
       ocfs2_mkdir+0x180/0x468 fs/ocfs2/namei.c:657
       vfs_mkdir+0x314/0x4d4 fs/namei.c:4065
       do_mkdirat+0x1bc/0x508 fs/namei.c:4090
       __do_sys_mkdirat fs/namei.c:4105 [inline]
       __se_sys_mkdirat fs/namei.c:4103 [inline]
       __arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4103
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x78/0x1e0 arch/arm64/kernel/entry-common.c:608
       el0t_64_sync_handler+0xcc/0xe4 arch/arm64/kernel/entry-common.c:626
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}:
       down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_remove_inode fs/ocfs2/inode.c:655 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
       ocfs2_evict_inode+0x10d8/0x395c fs/ocfs2/inode.c:1216
       evict+0x3c8/0x810 fs/inode.c:647
       iput_final fs/inode.c:1769 [inline]
       iput+0x6c4/0x77c fs/inode.c:1795
       ocfs2_dentry_iput+0x1d4/0x2d4 fs/ocfs2/dcache.c:418
       dentry_unlink_inode+0x348/0x438 fs/dcache.c:378
       __dentry_kill+0x320/0x598 fs/dcache.c:586
       dentry_kill+0xc8/0x248 fs/dcache.c:-1
       dput+0x23c/0x458 fs/dcache.c:893
       do_renameat2+0x75c/0xcdc fs/namei.c:4987
       __do_sys_renameat2 fs/namei.c:5018 [inline]
       __se_sys_renameat2 fs/namei.c:5015 [inline]
       __arm64_sys_renameat2+0xe0/0xfc fs/namei.c:5015
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x78/0x1e0 arch/arm64/kernel/entry-common.c:608
       el0t_64_sync_handler+0xcc/0xe4 arch/arm64/kernel/entry-common.c:626
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2928/0x651c kernel/locking/lockdep.c:5012
       lock_acquire+0x1f4/0x620 kernel/locking/lockdep.c:5623
       down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_del_inode_from_orphan+0x100/0x608 fs/ocfs2/namei.c:2713
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2333 [inline]
       ocfs2_dio_end_io+0x3f4/0xee8 fs/ocfs2/aops.c:2431
       dio_complete+0x204/0x68c fs/direct-io.c:272
       do_blockdev_direct_IO fs/direct-io.c:1336 [inline]
       __blockdev_direct_IO+0x21d0/0x26e0 fs/direct-io.c:1368
       ocfs2_direct_IO+0x208/0x280 fs/ocfs2/aops.c:2468
       generic_file_direct_write+0x30c/0x608 mm/filemap.c:3687
       __generic_file_write_iter+0x28c/0x454 mm/filemap.c:3869
       ocfs2_file_write_iter+0x12e0/0x1b84 fs/ocfs2/file.c:2472
       call_write_iter include/linux/fs.h:2172 [inline]
       new_sync_write fs/read_write.c:507 [inline]
       vfs_write+0x7c8/0xa2c fs/read_write.c:594
       ksys_write+0x120/0x210 fs/read_write.c:647
       __do_sys_write fs/read_write.c:659 [inline]
       __se_sys_write fs/read_write.c:656 [inline]
       __arm64_sys_write+0x7c/0x90 fs/read_write.c:656
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x78/0x1e0 arch/arm64/kernel/entry-common.c:608
       el0t_64_sync_handler+0xcc/0xe4 arch/arm64/kernel/entry-common.c:626
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type] --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_quota_ip_alloc_sem_key);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
                               lock(&ocfs2_quota_ip_alloc_sem_key);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);

 *** DEADLOCK ***

4 locks held by syz.2.270/5605:
 #0: ffff0000dce81270 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x118/0x170 fs/file.c:1058
 #1: ffff0000c7ef2460 (sb_writers#24){.+.+}-{0:0}, at: vfs_write+0x228/0xa2c fs/read_write.c:590
 #2: ffff0000e9f13488 (&sb->s_type->i_mutex_key#30){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #2: ffff0000e9f13488 (&sb->s_type->i_mutex_key#30){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x388/0x1b84 fs/ocfs2/file.c:2402
 #3: ffff0000e9f13120 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io_write fs/ocfs2/aops.c:2325 [inline]
 #3: ffff0000e9f13120 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io+0x334/0xee8 fs/ocfs2/aops.c:2431

stack backtrace:
CPU: 1 PID: 5605 Comm: syz.2.270 Not tainted 5.15.185-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call trace:
 dump_backtrace+0x0/0x43c arch/arm64/kernel/stacktrace.c:152
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
 __dump_stack+0x30/0x40 lib/dump_stack.c:88
 dump_stack_lvl+0xf8/0x160 lib/dump_stack.c:106
 dump_stack+0x1c/0x5c lib/dump_stack.c:113
 print_circular_bug+0x148/0x1b0 kernel/locking/lockdep.c:2011
 check_noncircular+0x240/0x2d4 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2928/0x651c kernel/locking/lockdep.c:5012
 lock_acquire+0x1f4/0x620 kernel/locking/lockdep.c:5623
 down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
 inode_lock include/linux/fs.h:787 [inline]
 ocfs2_del_inode_from_orphan+0x100/0x608 fs/ocfs2/namei.c:2713
 ocfs2_dio_end_io_write fs/ocfs2/aops.c:2333 [inline]
 ocfs2_dio_end_io+0x3f4/0xee8 fs/ocfs2/aops.c:2431
 dio_complete+0x204/0x68c fs/direct-io.c:272
 do_blockdev_direct_IO fs/direct-io.c:1336 [inline]
 __blockdev_direct_IO+0x21d0/0x26e0 fs/direct-io.c:1368
 ocfs2_direct_IO+0x208/0x280 fs/ocfs2/aops.c:2468
 generic_file_direct_write+0x30c/0x608 mm/filemap.c:3687
 __generic_file_write_iter+0x28c/0x454 mm/filemap.c:3869
 ocfs2_file_write_iter+0x12e0/0x1b84 fs/ocfs2/file.c:2472
 call_write_iter include/linux/fs.h:2172 [inline]
 new_sync_write fs/read_write.c:507 [inline]
 vfs_write+0x7c8/0xa2c fs/read_write.c:594
 ksys_write+0x120/0x210 fs/read_write.c:647
 __do_sys_write fs/read_write.c:659 [inline]
 __se_sys_write fs/read_write.c:656 [inline]
 __arm64_sys_write+0x7c/0x90 fs/read_write.c:656
 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
 invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
 el0_svc+0x78/0x1e0 arch/arm64/kernel/entry-common.c:608
 el0t_64_sync_handler+0xcc/0xe4 arch/arm64/kernel/entry-common.c:626
 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

Crashes (1):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2025/06/23 09:46 linux-5.15.y 1c700860e8bc d6cdfb8a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ocfs2_del_inode_from_orphan
* Struck through repros no longer work on HEAD.