syzbot

======================================================
WARNING: possible circular locking dependency detected
6.6.102-syzkaller #0 Not tainted
------------------------------------------------------
syz.1.155/6757 is trying to acquire lock:
ffff88805cf0d118 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
ffff88805cf0d118 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: ocfs2_del_inode_from_orphan+0x135/0x740 fs/ocfs2/namei.c:2716

but task is already holding lock:
ffff88805cf0bf60 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io_write fs/ocfs2/aops.c:2325 [inline]
ffff88805cf0bf60 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io+0x38c/0x10f0 fs/ocfs2/aops.c:2431

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
       ocfs2_create_local_dquot+0x1a4/0x1790 fs/ocfs2/quota_local.c:1224
       ocfs2_acquire_dquot+0x7cf/0xaf0 fs/ocfs2/quota_global.c:871
       dqget+0x77c/0xeb0 fs/quota/dquot.c:988
       __dquot_initialize+0x3ba/0xcb0 fs/quota/dquot.c:1516
       ocfs2_get_init_inode+0x13c/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x867/0x20f0 fs/ocfs2/namei.c:310
       ocfs2_create+0x196/0x410 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3488 [inline]
       open_last_lookups fs/namei.c:3556 [inline]
       path_openat+0x1277/0x3190 fs/namei.c:3786
       do_filp_open+0x1c5/0x3d0 fs/namei.c:3816
       do_sys_openat2+0x12c/0x1c0 fs/open.c:1419
       do_sys_open fs/open.c:1434 [inline]
       __do_sys_open fs/open.c:1442 [inline]
       __se_sys_open fs/open.c:1438 [inline]
       __x64_sys_open+0x11f/0x140 fs/open.c:1438
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x129/0xcc0 kernel/locking/mutex.c:747
       wait_on_dquot fs/quota/dquot.c:356 [inline]
       dqget+0x6fc/0xeb0 fs/quota/dquot.c:983
       __dquot_initialize+0x3ba/0xcb0 fs/quota/dquot.c:1516
       ocfs2_get_init_inode+0x13c/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x867/0x20f0 fs/ocfs2/namei.c:310
       ocfs2_create+0x196/0x410 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3488 [inline]
       open_last_lookups fs/namei.c:3556 [inline]
       path_openat+0x1277/0x3190 fs/namei.c:3786
       do_filp_open+0x1c5/0x3d0 fs/namei.c:3816
       do_sys_openat2+0x12c/0x1c0 fs/open.c:1419
       do_sys_open fs/open.c:1434 [inline]
       __do_sys_open fs/open.c:1442 [inline]
       __se_sys_open fs/open.c:1438 [inline]
       __x64_sys_open+0x11f/0x140 fs/open.c:1438
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}:
       down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_remove_inode fs/ocfs2/inode.c:655 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
       ocfs2_evict_inode+0x1313/0x3e60 fs/ocfs2/inode.c:1216
       evict+0x486/0x870 fs/inode.c:705
       ocfs2_dentry_iput+0x248/0x370 fs/ocfs2/dcache.c:418
       __dentry_kill+0x431/0x650 fs/dcache.c:611
       dentry_kill+0xb8/0x290 fs/dcache.c:-1
       dput+0xfe/0x1e0 fs/dcache.c:918
       ovl_check_rename_whiteout fs/overlayfs/super.c:652 [inline]
       ovl_make_workdir fs/overlayfs/super.c:751 [inline]
       ovl_get_workdir+0xa6a/0x1740 fs/overlayfs/super.c:874
       ovl_fill_super+0x1345/0x3560 fs/overlayfs/super.c:1427
       vfs_get_super fs/super.c:1346 [inline]
       get_tree_nodev+0xb5/0x140 fs/super.c:1365
       vfs_get_tree+0x8c/0x280 fs/super.c:1764
       do_new_mount+0x24b/0xa40 fs/namespace.c:3371
       do_mount fs/namespace.c:3711 [inline]
       __do_sys_mount fs/namespace.c:3920 [inline]
       __se_sys_mount+0x2da/0x3c0 fs/namespace.c:3897
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
       lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
       down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_del_inode_from_orphan+0x135/0x740 fs/ocfs2/namei.c:2716
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2333 [inline]
       ocfs2_dio_end_io+0x47b/0x10f0 fs/ocfs2/aops.c:2431
       dio_complete+0x254/0x710 fs/direct-io.c:282
       __blockdev_direct_IO+0x2dc8/0x3420 fs/direct-io.c:1308
       ocfs2_direct_IO+0x240/0x2b0 fs/ocfs2/aops.c:2468
       generic_file_direct_write+0x1d4/0x3e0 mm/filemap.c:3941
       __generic_file_write_iter+0x11b/0x230 mm/filemap.c:4097
       ocfs2_file_write_iter+0x1582/0x1d00 fs/ocfs2/file.c:2468
       do_iter_readv_writev fs/read_write.c:-1 [inline]
       do_iter_write+0x79a/0xc70 fs/read_write.c:860
       vfs_writev fs/read_write.c:933 [inline]
       do_pwritev+0x205/0x340 fs/read_write.c:1030
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type] --> &dquot->dq_lock --> &ocfs2_quota_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_quota_ip_alloc_sem_key);
                               lock(&dquot->dq_lock);
                               lock(&ocfs2_quota_ip_alloc_sem_key);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);

 *** DEADLOCK ***

3 locks held by syz.1.155/6757:
 #0: ffff888059e16418 (sb_writers#14){.+.+}-{0:0}, at: vfs_writev fs/read_write.c:932 [inline]
 #0: ffff888059e16418 (sb_writers#14){.+.+}-{0:0}, at: do_pwritev+0x1f3/0x340 fs/read_write.c:1030
 #1: ffff88805cf0c2d8 (&sb->s_type->i_mutex_key#24){++++}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #1: ffff88805cf0c2d8 (&sb->s_type->i_mutex_key#24){++++}-{3:3}, at: ocfs2_file_write_iter+0x40b/0x1d00 fs/ocfs2/file.c:2398
 #2: ffff88805cf0bf60 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io_write fs/ocfs2/aops.c:2325 [inline]
 #2: ffff88805cf0bf60 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io+0x38c/0x10f0 fs/ocfs2/aops.c:2431

stack backtrace:
CPU: 1 PID: 6757 Comm: syz.1.155 Not tainted 6.6.102-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x16c/0x230 lib/dump_stack.c:106
 check_noncircular+0x2bd/0x3c0 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
 lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
 down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:804 [inline]
 ocfs2_del_inode_from_orphan+0x135/0x740 fs/ocfs2/namei.c:2716
 ocfs2_dio_end_io_write fs/ocfs2/aops.c:2333 [inline]
 ocfs2_dio_end_io+0x47b/0x10f0 fs/ocfs2/aops.c:2431
 dio_complete+0x254/0x710 fs/direct-io.c:282
 __blockdev_direct_IO+0x2dc8/0x3420 fs/direct-io.c:1308
 ocfs2_direct_IO+0x240/0x2b0 fs/ocfs2/aops.c:2468
 generic_file_direct_write+0x1d4/0x3e0 mm/filemap.c:3941
 __generic_file_write_iter+0x11b/0x230 mm/filemap.c:4097
 ocfs2_file_write_iter+0x1582/0x1d00 fs/ocfs2/file.c:2468
 do_iter_readv_writev fs/read_write.c:-1 [inline]
 do_iter_write+0x79a/0xc70 fs/read_write.c:860
 vfs_writev fs/read_write.c:933 [inline]
 do_pwritev+0x205/0x340 fs/read_write.c:1030
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7fe68ed8ebe9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe68fc29038 EFLAGS: 00000246 ORIG_RAX: 0000000000000148
RAX: ffffffffffffffda RBX: 00007fe68efb5fa0 RCX: 00007fe68ed8ebe9
RDX: 0000000000000001 RSI: 0000200000000240 RDI: 0000000000000004
RBP: 00007fe68ee11e19 R08: 0000000000000000 R09: 0000000000000003
R10: 0000000000007000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fe68efb6038 R14: 00007fe68efb5fa0 R15: 00007ffda5333448
 </TASK>