syzbot

(syz.1.903,8984,0):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0xb3775c19, computed 0x2dd1c265. Applying ECC.
JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,1) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.1.903/8984 is trying to acquire lock:
ffff88805fecd118 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
ffff88805fecd118 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: ocfs2_del_inode_from_orphan+0x12f/0x7b0 fs/ocfs2/namei.c:2716

but task is already holding lock:
ffff88805fecb498 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
ffff88805fecb498 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x171/0x44a0 fs/ocfs2/suballoc.c:804

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}:
       down_write+0x97/0x200 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_reserve_suballoc_bits+0x171/0x44a0 fs/ocfs2/suballoc.c:804
       ocfs2_reserve_new_metadata_blocks+0x416/0x9a0 fs/ocfs2/suballoc.c:1000
       ocfs2_mknod+0xea5/0x2310 fs/ocfs2/namei.c:347
       ocfs2_create+0x196/0x430 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3496 [inline]
       open_last_lookups fs/namei.c:3564 [inline]
       path_openat+0x1705/0x3270 fs/namei.c:3794
       do_filp_open+0x1f2/0x430 fs/namei.c:3824
       do_sys_openat2+0x134/0x1d0 fs/open.c:1422
       do_sys_open fs/open.c:1437 [inline]
       __do_sys_openat fs/open.c:1453 [inline]
       __se_sys_openat fs/open.c:1448 [inline]
       __x64_sys_openat+0x139/0x160 fs/open.c:1448
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}:
       down_write+0x97/0x200 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_remove_inode fs/ocfs2/inode.c:655 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
       ocfs2_evict_inode+0x1daa/0x41a0 fs/ocfs2/inode.c:1219
       evict+0x4b7/0x8a0 fs/inode.c:705
       ocfs2_dentry_iput+0x24e/0x390 fs/ocfs2/dcache.c:418
       __dentry_kill+0x412/0x630 fs/dcache.c:611
       dentry_kill+0xb8/0x290 fs/dcache.c:-1
       dput+0xfe/0x1e0 fs/dcache.c:918
       do_renameat2+0x8c0/0xc80 fs/namei.c:5035
       __do_sys_rename fs/namei.c:5079 [inline]
       __se_sys_rename fs/namei.c:5077 [inline]
       __x64_sys_rename+0x86/0x90 fs/namei.c:5077
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x37ef/0x7d80 kernel/locking/lockdep.c:5137
       lock_acquire+0x19e/0x420 kernel/locking/lockdep.c:5754
       down_write+0x97/0x200 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_del_inode_from_orphan+0x12f/0x7b0 fs/ocfs2/namei.c:2716
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2407 [inline]
       ocfs2_dio_end_io+0x107a/0x13f0 fs/ocfs2/aops.c:2446
       dio_complete+0x24c/0x710 fs/direct-io.c:282
       __blockdev_direct_IO+0x2c42/0x32e0 fs/direct-io.c:1308
       ocfs2_direct_IO+0x235/0x2a0 fs/ocfs2/aops.c:2483
       generic_file_direct_write+0x1c9/0x3e0 mm/filemap.c:3961
       __generic_file_write_iter+0x11b/0x230 mm/filemap.c:4117
       ocfs2_file_write_iter+0x1724/0x1ef0 fs/ocfs2/file.c:2468
       do_iter_readv_writev fs/read_write.c:-1 [inline]
       do_iter_write+0x747/0xc50 fs/read_write.c:860
       iter_file_splice_write+0x6b6/0xcf0 fs/splice.c:736
       do_splice_from fs/splice.c:933 [inline]
       direct_splice_actor+0xe8/0x130 fs/splice.c:1142
       splice_direct_to_actor+0x30b/0x8e0 fs/splice.c:1088
       do_splice_direct+0x1d5/0x2f0 fs/splice.c:1194
       do_sendfile+0x52b/0xe80 fs/read_write.c:1254
       __do_sys_sendfile64 fs/read_write.c:1322 [inline]
       __se_sys_sendfile64+0x145/0x1a0 fs/read_write.c:1308
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type] --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);

 *** DEADLOCK ***

3 locks held by syz.1.903/8984:
 #0: ffff888025cc4418 (sb_writers#18){.+.+}-{0:0}, at: do_sendfile+0x506/0xe80 fs/read_write.c:1253
 #1: ffff88805cd342d8 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #1: ffff88805cd342d8 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x441/0x1ef0 fs/ocfs2/file.c:2398
 #2: ffff88805fecb498 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #2: ffff88805fecb498 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x171/0x44a0 fs/ocfs2/suballoc.c:804

stack backtrace:
CPU: 1 PID: 8984 Comm: syz.1.903 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x18c/0x250 lib/dump_stack.c:106
 check_noncircular+0x2fc/0x400 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x37ef/0x7d80 kernel/locking/lockdep.c:5137
 lock_acquire+0x19e/0x420 kernel/locking/lockdep.c:5754
 down_write+0x97/0x200 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:804 [inline]
 ocfs2_del_inode_from_orphan+0x12f/0x7b0 fs/ocfs2/namei.c:2716
 ocfs2_dio_end_io_write fs/ocfs2/aops.c:2407 [inline]
 ocfs2_dio_end_io+0x107a/0x13f0 fs/ocfs2/aops.c:2446
 dio_complete+0x24c/0x710 fs/direct-io.c:282
 __blockdev_direct_IO+0x2c42/0x32e0 fs/direct-io.c:1308
 ocfs2_direct_IO+0x235/0x2a0 fs/ocfs2/aops.c:2483
 generic_file_direct_write+0x1c9/0x3e0 mm/filemap.c:3961
 __generic_file_write_iter+0x11b/0x230 mm/filemap.c:4117
 ocfs2_file_write_iter+0x1724/0x1ef0 fs/ocfs2/file.c:2468
 do_iter_readv_writev fs/read_write.c:-1 [inline]
 do_iter_write+0x747/0xc50 fs/read_write.c:860
 iter_file_splice_write+0x6b6/0xcf0 fs/splice.c:736
 do_splice_from fs/splice.c:933 [inline]
 direct_splice_actor+0xe8/0x130 fs/splice.c:1142
 splice_direct_to_actor+0x30b/0x8e0 fs/splice.c:1088
 do_splice_direct+0x1d5/0x2f0 fs/splice.c:1194
 do_sendfile+0x52b/0xe80 fs/read_write.c:1254
 __do_sys_sendfile64 fs/read_write.c:1322 [inline]
 __se_sys_sendfile64+0x145/0x1a0 fs/read_write.c:1308
 do_syscall_x64 arch/x86/entry/common.c:46 [inline]
 do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f036019de59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f036114a028 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007f0360425fa0 RCX: 00007f036019de59
RDX: 0000000000000000 RSI: 0000000000000005 RDI: 0000000000000004
RBP: 00007f0360233e6f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000fffe82 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f0360426038 R14: 00007f0360425fa0 R15: 00007fff67c2c348
 </TASK>