syzbot

loop1: detected capacity change from 0 to 32768
ocfs2: Mounting device (7,1) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
6.15.0-rc4-syzkaller-00147-gebd297a2affa #0 Not tainted
------------------------------------------------------
syz.1.1802/12182 is trying to acquire lock:
ffff888057452378 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_calc_xattr_init+0x5e5/0xc90 fs/ocfs2/xattr.c:627

but task is already holding lock:
ffff888078deed80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
ffff888078deed80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x11c/0x48d0 fs/ocfs2/suballoc.c:786

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}:
       down_write+0x92/0x200 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:867 [inline]
       ocfs2_remove_inode+0x15b/0x8a0 fs/ocfs2/inode.c:669
       ocfs2_wipe_inode+0x446/0x1210 fs/ocfs2/inode.c:832
       ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline]
       ocfs2_evict_inode+0x6e0/0x1680 fs/ocfs2/inode.c:1230
       evict+0x3e6/0x920 fs/inode.c:810
       iput_final fs/inode.c:1898 [inline]
       iput fs/inode.c:1924 [inline]
       iput+0x521/0x880 fs/inode.c:1910
       ocfs2_dentry_iput+0x139/0x330 fs/ocfs2/dcache.c:407
       dentry_unlink_inode+0x282/0x480 fs/dcache.c:455
       __dentry_kill+0x1d0/0x600 fs/dcache.c:660
       dput.part.0+0x4b1/0x9b0 fs/dcache.c:902
       dput+0x1f/0x30 fs/dcache.c:892
       ovl_check_rename_whiteout fs/overlayfs/super.c:605 [inline]
       ovl_make_workdir fs/overlayfs/super.c:704 [inline]
       ovl_get_workdir fs/overlayfs/super.c:827 [inline]
       ovl_fill_super+0x134f/0x6780 fs/overlayfs/super.c:1406
       vfs_get_super fs/super.c:1280 [inline]
       get_tree_nodev+0xdd/0x190 fs/super.c:1299
       vfs_get_tree+0x8e/0x340 fs/super.c:1759
       do_new_mount fs/namespace.c:3884 [inline]
       path_mount+0x14d4/0x1f20 fs/namespace.c:4211
       do_mount fs/namespace.c:4224 [inline]
       __do_sys_mount fs/namespace.c:4435 [inline]
       __se_sys_mount fs/namespace.c:4412 [inline]
       __x64_sys_mount+0x28d/0x310 fs/namespace.c:4412
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x260 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}:
       down_write+0x92/0x200 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:867 [inline]
       ocfs2_del_inode_from_orphan+0x112/0x700 fs/ocfs2/namei.c:2727
       ocfs2_dio_end_io_write+0x2cb/0xf30 fs/ocfs2/aops.c:2303
       ocfs2_dio_end_io+0x136/0x2c0 fs/ocfs2/aops.c:2401
       dio_complete+0x224/0x970 fs/direct-io.c:281
       __blockdev_direct_IO+0x33eb/0x4080 fs/direct-io.c:1303
       ocfs2_direct_IO+0x263/0x360 fs/ocfs2/aops.c:2438
       generic_file_direct_write+0x19a/0x410 mm/filemap.c:4037
       __generic_file_write_iter+0x11b/0x240 mm/filemap.c:4206
       ocfs2_file_write_iter+0xbc4/0x21b0 fs/ocfs2/file.c:2469
       iter_file_splice_write+0x91f/0x1150 fs/splice.c:738
       do_splice_from fs/splice.c:935 [inline]
       direct_splice_actor+0x192/0x6c0 fs/splice.c:1158
       splice_direct_to_actor+0x345/0xa30 fs/splice.c:1102
       do_splice_direct_actor fs/splice.c:1201 [inline]
       do_splice_direct+0x174/0x240 fs/splice.c:1227
       do_sendfile+0xafd/0xe50 fs/read_write.c:1368
       __do_sys_sendfile64 fs/read_write.c:1429 [inline]
       __se_sys_sendfile64 fs/read_write.c:1415 [inline]
       __x64_sys_sendfile64+0x1d8/0x220 fs/read_write.c:1415
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x260 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&oi->ip_alloc_sem){++++}-{4:4}:
       down_write+0x92/0x200 kernel/locking/rwsem.c:1577
       ocfs2_try_remove_refcount_tree+0xa7/0x320 fs/ocfs2/refcounttree.c:932
       ocfs2_truncate_file+0xbba/0x17c0 fs/ocfs2/file.c:521
       ocfs2_setattr+0x1594/0x2560 fs/ocfs2/file.c:1212
       notify_change+0x6a9/0x1230 fs/attr.c:552
       do_truncate+0x15b/0x220 fs/open.c:65
       handle_truncate fs/namei.c:3501 [inline]
       do_open fs/namei.c:3884 [inline]
       path_openat+0x2761/0x2d40 fs/namei.c:4039
       do_filp_open+0x20b/0x470 fs/namei.c:4066
       do_sys_openat2+0x11b/0x1d0 fs/open.c:1429
       do_sys_open fs/open.c:1444 [inline]
       __do_sys_openat fs/open.c:1460 [inline]
       __se_sys_openat fs/open.c:1455 [inline]
       __x64_sys_openat+0x174/0x210 fs/open.c:1455
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x260 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&oi->ip_xattr_sem){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3166 [inline]
       check_prevs_add kernel/locking/lockdep.c:3285 [inline]
       validate_chain kernel/locking/lockdep.c:3909 [inline]
       __lock_acquire+0x1173/0x1ba0 kernel/locking/lockdep.c:5235
       lock_acquire kernel/locking/lockdep.c:5866 [inline]
       lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5823
       down_read+0x9b/0x480 kernel/locking/rwsem.c:1524
       ocfs2_calc_xattr_init+0x5e5/0xc90 fs/ocfs2/xattr.c:627
       ocfs2_mknod+0xa2b/0x2540 fs/ocfs2/namei.c:330
       ocfs2_mkdir+0x17c/0x490 fs/ocfs2/namei.c:656
       vfs_mkdir+0x593/0x8c0 fs/namei.c:4359
       do_mkdirat+0x304/0x3e0 fs/namei.c:4392
       __do_sys_mkdirat fs/namei.c:4409 [inline]
       __se_sys_mkdirat fs/namei.c:4407 [inline]
       __x64_sys_mkdirat+0x83/0xb0 fs/namei.c:4407
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x260 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &oi->ip_xattr_sem --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type] --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);
  rlock(&oi->ip_xattr_sem);

 *** DEADLOCK ***

3 locks held by syz.1.1802/12182:
 #0: ffff888058006420 (sb_writers#13){.+.+}-{0:0}, at: filename_create+0x10e/0x4a0 fs/namei.c:4125
 #1: ffff888057452640 (&type->i_mutex_dir_key#9/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:902 [inline]
 #1: ffff888057452640 (&type->i_mutex_dir_key#9/1){+.+.}-{4:4}, at: filename_create+0x1bb/0x4a0 fs/namei.c:4132
 #2: ffff888078deed80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
 #2: ffff888078deed80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x11c/0x48d0 fs/ocfs2/suballoc.c:786

stack backtrace:
CPU: 0 UID: 0 PID: 12182 Comm: syz.1.1802 Not tainted 6.15.0-rc4-syzkaller-00147-gebd297a2affa #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/19/2025
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 print_circular_bug+0x275/0x350 kernel/locking/lockdep.c:2079
 check_noncircular+0x14c/0x170 kernel/locking/lockdep.c:2211
 check_prev_add kernel/locking/lockdep.c:3166 [inline]
 check_prevs_add kernel/locking/lockdep.c:3285 [inline]
 validate_chain kernel/locking/lockdep.c:3909 [inline]
 __lock_acquire+0x1173/0x1ba0 kernel/locking/lockdep.c:5235
 lock_acquire kernel/locking/lockdep.c:5866 [inline]
 lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5823
 down_read+0x9b/0x480 kernel/locking/rwsem.c:1524
 ocfs2_calc_xattr_init+0x5e5/0xc90 fs/ocfs2/xattr.c:627
 ocfs2_mknod+0xa2b/0x2540 fs/ocfs2/namei.c:330
 ocfs2_mkdir+0x17c/0x490 fs/ocfs2/namei.c:656
 vfs_mkdir+0x593/0x8c0 fs/namei.c:4359
 do_mkdirat+0x304/0x3e0 fs/namei.c:4392
 __do_sys_mkdirat fs/namei.c:4409 [inline]
 __se_sys_mkdirat fs/namei.c:4407 [inline]
 __x64_sys_mkdirat+0x83/0xb0 fs/namei.c:4407
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xcd/0x260 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f7090b8d1d7
Code: 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 02 01 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f7091977e68 EFLAGS: 00000246 ORIG_RAX: 0000000000000102
RAX: ffffffffffffffda RBX: 00007f7091977ef0 RCX: 00007f7090b8d1d7
RDX: 00000000000001ff RSI: 0000200000000000 RDI: 00000000ffffff9c
RBP: 0000200000000180 R08: 0000200000000000 R09: 0000000000000000
R10: 0000200000000180 R11: 0000000000000246 R12: 0000200000000000
R13: 00007f7091977eb0 R14: 0000000000000000 R15: 0000200000000100
 </TASK>
(syz.1.1802,12182,0):ocfs2_rename:1699 ERROR: status = -39