syzbot

loop5: detected capacity change from 0 to 32768
ocfs2: Slot 0 on device (7,5) was already allocated to this node!
ocfs2: Mounting device (7,5) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.5.1293/10976 is trying to acquire lock:
ffff888052184e38 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_calc_xattr_init+0x208/0xd80 fs/ocfs2/xattr.c:627

but task is already holding lock:
ffff888052166d98 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
ffff888052166d98 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x165/0x4360 fs/ocfs2/suballoc.c:782

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}:
       down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_remove_inode fs/ocfs2/inode.c:655 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
       ocfs2_evict_inode+0x1313/0x3e70 fs/ocfs2/inode.c:1219
       evict+0x486/0x870 fs/inode.c:705
       do_unlinkat+0x37b/0x570 fs/namei.c:4406
       __do_sys_unlinkat fs/namei.c:4442 [inline]
       __se_sys_unlinkat fs/namei.c:4435 [inline]
       __x64_sys_unlinkat+0xd5/0xe0 fs/namei.c:4435
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}:
       down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_del_inode_from_orphan+0x135/0x740 fs/ocfs2/namei.c:2716
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2333 [inline]
       ocfs2_dio_end_io+0x47b/0x10f0 fs/ocfs2/aops.c:2431
       dio_complete+0x254/0x710 fs/direct-io.c:282
       __blockdev_direct_IO+0x2dc8/0x3420 fs/direct-io.c:1308
       ocfs2_direct_IO+0x240/0x2b0 fs/ocfs2/aops.c:2468
       generic_file_direct_write+0x1d4/0x3e0 mm/filemap.c:3956
       __generic_file_write_iter+0x11b/0x230 mm/filemap.c:4112
       ocfs2_file_write_iter+0x1582/0x1d00 fs/ocfs2/file.c:2468
       do_iter_readv_writev fs/read_write.c:-1 [inline]
       do_iter_write+0x79a/0xc70 fs/read_write.c:860
       iter_file_splice_write+0x66f/0xc50 fs/splice.c:736
       do_splice_from fs/splice.c:933 [inline]
       direct_splice_actor+0xe8/0x130 fs/splice.c:1142
       splice_direct_to_actor+0x2f0/0x870 fs/splice.c:1088
       do_splice_direct+0x1b7/0x2c0 fs/splice.c:1194
       do_sendfile+0x5dc/0xf70 fs/read_write.c:1254
       __do_sys_sendfile64 fs/read_write.c:1322 [inline]
       __se_sys_sendfile64+0x13f/0x190 fs/read_write.c:1308
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&oi->ip_alloc_sem){++++}-{3:3}:
       down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
       ocfs2_try_remove_refcount_tree+0xb7/0x320 fs/ocfs2/refcounttree.c:932
       ocfs2_truncate_file+0xd84/0x13a0 fs/ocfs2/file.c:521
       ocfs2_setattr+0x150d/0x1b20 fs/ocfs2/file.c:1211
       notify_change+0xb0d/0xe10 fs/attr.c:499
       do_truncate+0x19b/0x220 fs/open.c:66
       handle_truncate fs/namei.c:3299 [inline]
       do_open fs/namei.c:3644 [inline]
       path_openat+0x298c/0x3190 fs/namei.c:3797
       do_filp_open+0x1c5/0x3d0 fs/namei.c:3824
       do_sys_openat2+0x12c/0x1c0 fs/open.c:1421
       do_sys_open fs/open.c:1436 [inline]
       __do_sys_open fs/open.c:1444 [inline]
       __se_sys_open fs/open.c:1440 [inline]
       __x64_sys_open+0x11f/0x140 fs/open.c:1440
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&oi->ip_xattr_sem){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
       lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ocfs2_calc_xattr_init+0x208/0xd80 fs/ocfs2/xattr.c:627
       ocfs2_mknod+0xc57/0x20f0 fs/ocfs2/namei.c:330
       ocfs2_mkdir+0x196/0x410 fs/ocfs2/namei.c:657
       vfs_mkdir+0x296/0x440 fs/namei.c:4121
       do_mkdirat+0x1d4/0x440 fs/namei.c:4144
       __do_sys_mkdirat fs/namei.c:4159 [inline]
       __se_sys_mkdirat fs/namei.c:4157 [inline]
       __x64_sys_mkdirat+0x89/0xa0 fs/namei.c:4157
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &oi->ip_xattr_sem --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type] --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);
  rlock(&oi->ip_xattr_sem);

 *** DEADLOCK ***

3 locks held by syz.5.1293/10976:
 #0: ffff8880626d2418 (sb_writers#16){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:412
 #1: ffff888052185118 (&type->i_mutex_dir_key#9/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:839 [inline]
 #1: ffff888052185118 (&type->i_mutex_dir_key#9/1){+.+.}-{3:3}, at: filename_create+0x1f6/0x460 fs/namei.c:3890
 #2: ffff888052166d98 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #2: ffff888052166d98 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x165/0x4360 fs/ocfs2/suballoc.c:782

stack backtrace:
CPU: 0 PID: 10976 Comm: syz.5.1293 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/25/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x16c/0x230 lib/dump_stack.c:106
 check_noncircular+0x2bd/0x3c0 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
 lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
 down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
 ocfs2_calc_xattr_init+0x208/0xd80 fs/ocfs2/xattr.c:627
 ocfs2_mknod+0xc57/0x20f0 fs/ocfs2/namei.c:330
 ocfs2_mkdir+0x196/0x410 fs/ocfs2/namei.c:657
 vfs_mkdir+0x296/0x440 fs/namei.c:4121
 do_mkdirat+0x1d4/0x440 fs/namei.c:4144
 __do_sys_mkdirat fs/namei.c:4159 [inline]
 __se_sys_mkdirat fs/namei.c:4157 [inline]
 __x64_sys_mkdirat+0x89/0xa0 fs/namei.c:4157
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f9091d8f749
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f9092c57038 EFLAGS: 00000246 ORIG_RAX: 0000000000000102
RAX: ffffffffffffffda RBX: 00007f9091fe6090 RCX: 00007f9091d8f749
RDX: 00000000000001c0 RSI: 0000200000000080 RDI: ffffffffffffff9c
RBP: 00007f9091e13f91 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f9091fe6128 R14: 00007f9091fe6090 R15: 00007ffe64f46fe8
 </TASK>