syzbot

gfs2: fsid=syz:syz.0: found 1 quota changes
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.3.283/5396 is trying to acquire lock:
ffff88807d5ecae0 (&sdp->sd_quota_mutex){+.+.}-{3:3}, at: do_qc+0xc0/0x6c0 fs/gfs2/quota.c:678

but task is already holding lock:
ffff88805e6dd080 (&ip->i_rw_mutex){++++}-{3:3}, at: sweep_bh_for_rgrps fs/gfs2/bmap.c:1531 [inline]
ffff88805e6dd080 (&ip->i_rw_mutex){++++}-{3:3}, at: punch_hole+0x272a/0x3700 fs/gfs2/bmap.c:1856

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ip->i_rw_mutex){++++}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       __gfs2_iomap_get+0x164/0x1390 fs/gfs2/bmap.c:864
       gfs2_iomap_get fs/gfs2/bmap.c:1415 [inline]
       gfs2_block_map+0x299/0x6f0 fs/gfs2/bmap.c:1230
       bh_get+0x275/0x650 fs/gfs2/quota.c:385
       qdsb_get+0x21c/0x3c0 fs/gfs2/quota.c:518
       gfs2_quota_hold+0x18d/0x5b0 fs/gfs2/quota.c:604
       punch_hole+0xe27/0x3700 fs/gfs2/bmap.c:1817
       gfs2_iomap_end+0x4a1/0x7b0 fs/gfs2/bmap.c:1176
       iomap_iter+0x213/0xda0 fs/iomap/iter.c:62
       iomap_file_buffered_write+0x520/0x630 fs/iomap/buffered-io.c:814
       gfs2_file_buffered_write+0x45d/0x910 fs/gfs2/file.c:1058
       gfs2_file_write_iter+0x4a9/0x11f0 fs/gfs2/file.c:1166
       call_write_iter include/linux/fs.h:2173 [inline]
       new_sync_write fs/read_write.c:507 [inline]
       vfs_write+0x748/0xd70 fs/read_write.c:594
       ksys_write+0x153/0x260 fs/read_write.c:647
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&sdp->sd_quota_mutex){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c66/0x7b50 kernel/locking/lockdep.c:5012
       lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1e5/0x2400 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       do_qc+0xc0/0x6c0 fs/gfs2/quota.c:678
       gfs2_quota_change+0x293/0x7a0 fs/gfs2/quota.c:1295
       punch_hole+0x310b/0x3700 fs/gfs2/bmap.c:1957
       gfs2_iomap_end+0x4a1/0x7b0 fs/gfs2/bmap.c:1176
       iomap_iter+0x213/0xda0 fs/iomap/iter.c:62
       iomap_file_buffered_write+0x520/0x630 fs/iomap/buffered-io.c:814
       gfs2_file_buffered_write+0x45d/0x910 fs/gfs2/file.c:1058
       gfs2_file_write_iter+0x4a9/0x11f0 fs/gfs2/file.c:1166
       call_write_iter include/linux/fs.h:2173 [inline]
       new_sync_write fs/read_write.c:507 [inline]
       vfs_write+0x748/0xd70 fs/read_write.c:594
       ksys_write+0x153/0x260 fs/read_write.c:647
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ip->i_rw_mutex);
                               lock(&sdp->sd_quota_mutex);
                               lock(&ip->i_rw_mutex);
  lock(&sdp->sd_quota_mutex);

 *** DEADLOCK ***

6 locks held by syz.3.283/5396:
 #0: ffff88801ee93270 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2bf/0x370 fs/file.c:1056
 #1: ffff88807cf5e460 (sb_writers#19){.+.+}-{0:0}, at: vfs_write+0x296/0xd70 fs/read_write.c:590
 #2: ffff88805e6dcbe8 (&sb->s_type->i_mutex_key#26){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #2: ffff88805e6dcbe8 (&sb->s_type->i_mutex_key#26){+.+.}-{3:3}, at: gfs2_file_write_iter+0x360/0x11f0 fs/gfs2/file.c:1123
 #3: ffff88807cf5e650 (sb_internal#6){.+.+}-{0:0}, at: gfs2_trans_begin+0x6b/0xe0 fs/gfs2/trans.c:118
 #4: ffff88807d5ed0a8 (&sdp->sd_log_flush_lock){.+.+}-{3:3}, at: __gfs2_trans_begin+0x535/0x8b0 fs/gfs2/trans.c:87
 #5: ffff88805e6dd080 (&ip->i_rw_mutex){++++}-{3:3}, at: sweep_bh_for_rgrps fs/gfs2/bmap.c:1531 [inline]
 #5: ffff88805e6dd080 (&ip->i_rw_mutex){++++}-{3:3}, at: punch_hole+0x272a/0x3700 fs/gfs2/bmap.c:1856

stack backtrace:
CPU: 1 PID: 5396 Comm: syz.3.283 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x250 lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c66/0x7b50 kernel/locking/lockdep.c:5012
 lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
 __mutex_lock_common+0x1e5/0x2400 kernel/locking/mutex.c:596
 __mutex_lock kernel/locking/mutex.c:729 [inline]
 mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
 do_qc+0xc0/0x6c0 fs/gfs2/quota.c:678
 gfs2_quota_change+0x293/0x7a0 fs/gfs2/quota.c:1295
 punch_hole+0x310b/0x3700 fs/gfs2/bmap.c:1957
 gfs2_iomap_end+0x4a1/0x7b0 fs/gfs2/bmap.c:1176
 iomap_iter+0x213/0xda0 fs/iomap/iter.c:62
 iomap_file_buffered_write+0x520/0x630 fs/iomap/buffered-io.c:814
 gfs2_file_buffered_write+0x45d/0x910 fs/gfs2/file.c:1058
 gfs2_file_write_iter+0x4a9/0x11f0 fs/gfs2/file.c:1166
 call_write_iter include/linux/fs.h:2173 [inline]
 new_sync_write fs/read_write.c:507 [inline]
 vfs_write+0x748/0xd70 fs/read_write.c:594
 ksys_write+0x153/0x260 fs/read_write.c:647
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7fb5f8e95e59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fb5f70ef028 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007fb5f910efa0 RCX: 00007fb5f8e95e59
RDX: 0000000000010010 RSI: 000020000000e0c0 RDI: 0000000000000005
RBP: 00007fb5f8f2be6f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fb5f910f038 R14: 00007fb5f910efa0 R15: 00007ffc765a06f8
 </TASK>
==================================================================
BUG: KASAN: stack-out-of-bounds in should_fault_in_pages fs/gfs2/file.c:785 [inline]
BUG: KASAN: stack-out-of-bounds in gfs2_file_buffered_write+0x56a/0x910 fs/gfs2/file.c:1070
Read of size 8 at addr ffffc900032efd50 by task syz.3.283/5396

CPU: 0 PID: 5396 Comm: syz.3.283 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x250 lib/dump_stack.c:106
 print_address_description+0x60/0x2d0 mm/kasan/report.c:248
 __kasan_report mm/kasan/report.c:434 [inline]
 kasan_report+0xdf/0x130 mm/kasan/report.c:451
 should_fault_in_pages fs/gfs2/file.c:785 [inline]
 gfs2_file_buffered_write+0x56a/0x910 fs/gfs2/file.c:1070
 gfs2_file_write_iter+0x4a9/0x11f0 fs/gfs2/file.c:1166
 call_write_iter include/linux/fs.h:2173 [inline]
 new_sync_write fs/read_write.c:507 [inline]
 vfs_write+0x748/0xd70 fs/read_write.c:594
 ksys_write+0x153/0x260 fs/read_write.c:647
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7fb5f8e95e59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fb5f70ef028 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007fb5f910efa0 RCX: 00007fb5f8e95e59
RDX: 0000000000010010 RSI: 000020000000e0c0 RDI: 0000000000000005
RBP: 00007fb5f8f2be6f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fb5f910f038 R14: 00007fb5f910efa0 R15: 00007ffc765a06f8
 </TASK>


addr ffffc900032efd50 is located in stack of task syz.3.283/5396 at offset 48 in frame:
 vfs_write+0x0/0xd70

this frame has 3 objects:
 [32, 48) 'iov.i'
 [64, 112) 'kiocb.i'
 [144, 184) 'iter.i'

Memory state around the buggy address:
 ffffc900032efc00: 00 00 00 00 00 00 00 f3 f3 f3 f3 f3 00 00 00 00
 ffffc900032efc80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>ffffc900032efd00: 00 00 00 00 f1 f1 f1 f1 00 00 f2 f2 00 00 00 00
                                                 ^
 ffffc900032efd80: 00 00 f2 f2 f2 f2 00 00 00 00 00 f3 f3 f3 f3 f3
 ffffc900032efe00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
==================================================================