syzbot

gfs2: fsid=syz:syz.0: first mount done, others may mount
gfs2: fsid=syz:syz.0: found 1 quota changes
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.6.1998/15073 is trying to acquire lock:
ffff888053054ae8 (&sdp->sd_quota_mutex){+.+.}-{3:3}, at: do_qc+0xaf/0x670 fs/gfs2/quota.c:689

but task is already holding lock:
ffff888076f56ab0 (&ip->i_rw_mutex){++++}-{3:3}, at: sweep_bh_for_rgrps fs/gfs2/bmap.c:1526 [inline]
ffff888076f56ab0 (&ip->i_rw_mutex){++++}-{3:3}, at: punch_hole+0x1c7d/0x2d70 fs/gfs2/bmap.c:1850

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ip->i_rw_mutex){++++}-{3:3}:
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       __gfs2_iomap_get+0x159/0x13f0 fs/gfs2/bmap.c:856
       gfs2_iomap_get+0xc5/0x120 fs/gfs2/bmap.c:1410
       bh_get+0x225/0x710 fs/gfs2/quota.c:401
       qdsb_get+0x210/0x330 fs/gfs2/quota.c:535
       gfs2_quota_hold+0x198/0x5e0 fs/gfs2/quota.c:615
       punch_hole+0x974/0x2d70 fs/gfs2/bmap.c:1811
       do_shrink fs/gfs2/bmap.c:2031 [inline]
       gfs2_setattr_size+0xc0b/0xfc0 fs/gfs2/bmap.c:2147
       gfs2_setattr+0x244/0x3f0 fs/gfs2/inode.c:2025
       notify_change+0xb0d/0xe10 fs/attr.c:499
       do_truncate+0x19b/0x220 fs/open.c:66
       handle_truncate fs/namei.c:3299 [inline]
       do_open fs/namei.c:3644 [inline]
       path_openat+0x298c/0x3190 fs/namei.c:3797
       do_filp_open+0x1c5/0x3d0 fs/namei.c:3824
       do_sys_openat2+0x12c/0x1c0 fs/open.c:1421
       do_sys_open fs/open.c:1436 [inline]
       __do_sys_openat fs/open.c:1452 [inline]
       __se_sys_openat fs/open.c:1447 [inline]
       __x64_sys_openat+0x139/0x160 fs/open.c:1447
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&sdp->sd_quota_mutex){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
       lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x129/0xcc0 kernel/locking/mutex.c:747
       do_qc+0xaf/0x670 fs/gfs2/quota.c:689
       gfs2_quota_change+0x2b9/0x800 fs/gfs2/quota.c:1289
       punch_hole+0x280c/0x2d70 fs/gfs2/bmap.c:1951
       do_shrink fs/gfs2/bmap.c:2031 [inline]
       gfs2_setattr_size+0xc0b/0xfc0 fs/gfs2/bmap.c:2147
       gfs2_setattr+0x244/0x3f0 fs/gfs2/inode.c:2025
       notify_change+0xb0d/0xe10 fs/attr.c:499
       do_truncate+0x19b/0x220 fs/open.c:66
       handle_truncate fs/namei.c:3299 [inline]
       do_open fs/namei.c:3644 [inline]
       path_openat+0x298c/0x3190 fs/namei.c:3797
       do_filp_open+0x1c5/0x3d0 fs/namei.c:3824
       do_sys_openat2+0x12c/0x1c0 fs/open.c:1421
       do_sys_open fs/open.c:1436 [inline]
       __do_sys_openat fs/open.c:1452 [inline]
       __se_sys_openat fs/open.c:1447 [inline]
       __x64_sys_openat+0x139/0x160 fs/open.c:1447
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ip->i_rw_mutex);
                               lock(&sdp->sd_quota_mutex);
                               lock(&ip->i_rw_mutex);
  lock(&sdp->sd_quota_mutex);

 *** DEADLOCK ***

5 locks held by syz.6.1998/15073:
 #0: ffff88807a50a418 (sb_writers#35){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:412
 #1: ffff888076f56628 (&sb->s_type->i_mutex_key#41){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #1: ffff888076f56628 (&sb->s_type->i_mutex_key#41){+.+.}-{3:3}, at: do_truncate+0x187/0x220 fs/open.c:64
 #2: ffff88807a50a608 (sb_internal#7){.+.+}-{0:0}, at: gfs2_trans_begin+0x6f/0xe0 fs/gfs2/trans.c:118
 #3: ffff888053055060 (&sdp->sd_log_flush_lock){++++}-{3:3}, at: __gfs2_trans_begin+0x511/0x880 fs/gfs2/trans.c:87
 #4: ffff888076f56ab0 (&ip->i_rw_mutex){++++}-{3:3}, at: sweep_bh_for_rgrps fs/gfs2/bmap.c:1526 [inline]
 #4: ffff888076f56ab0 (&ip->i_rw_mutex){++++}-{3:3}, at: punch_hole+0x1c7d/0x2d70 fs/gfs2/bmap.c:1850

stack backtrace:
CPU: 0 PID: 15073 Comm: syz.6.1998 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/25/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x16c/0x230 lib/dump_stack.c:106
 check_noncircular+0x2bd/0x3c0 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
 lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x129/0xcc0 kernel/locking/mutex.c:747
 do_qc+0xaf/0x670 fs/gfs2/quota.c:689
 gfs2_quota_change+0x2b9/0x800 fs/gfs2/quota.c:1289
 punch_hole+0x280c/0x2d70 fs/gfs2/bmap.c:1951
 do_shrink fs/gfs2/bmap.c:2031 [inline]
 gfs2_setattr_size+0xc0b/0xfc0 fs/gfs2/bmap.c:2147
 gfs2_setattr+0x244/0x3f0 fs/gfs2/inode.c:2025
 notify_change+0xb0d/0xe10 fs/attr.c:499
 do_truncate+0x19b/0x220 fs/open.c:66
 handle_truncate fs/namei.c:3299 [inline]
 do_open fs/namei.c:3644 [inline]
 path_openat+0x298c/0x3190 fs/namei.c:3797
 do_filp_open+0x1c5/0x3d0 fs/namei.c:3824
 do_sys_openat2+0x12c/0x1c0 fs/open.c:1421
 do_sys_open fs/open.c:1436 [inline]
 __do_sys_openat fs/open.c:1452 [inline]
 __se_sys_openat fs/open.c:1447 [inline]
 __x64_sys_openat+0x139/0x160 fs/open.c:1447
 do_syscall_x64 arch/x86/entry/common.c:46 [inline]
 do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f654818f749
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f6548f67038 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: ffffffffffffffda RBX: 00007f65483e5fa0 RCX: 00007f654818f749
RDX: 0000000000183341 RSI: 0000200000000080 RDI: ffffffffffffff9c
RBP: 00007f6548213f91 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f65483e6038 R14: 00007f65483e5fa0 R15: 00007fffc9c8b7b8
 </TASK>