input: Steam Controller as /devices/platform/dummy_hcd.2/usb3/3-1/3-1:0.0/0003:28DE:1102.0027/input/input19 ====================================================== WARNING: possible circular locking dependency detected 6.1.129-syzkaller #0 Not tainted ------------------------------------------------------ syz.2.4012/19785 is trying to acquire lock: ffffffff8e03ce88 (input_mutex){+.+.}-{3:3}, at: input_register_device+0xb54/0x1250 drivers/input/input.c:2463 but task is already holding lock: ffff888056a65e18 (&hdev->ll_open_lock){+.+.}-{3:3}, at: hid_hw_close+0x2c/0xd0 drivers/hid/hid-core.c:2364 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&hdev->ll_open_lock){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 hid_hw_open+0x24/0x160 drivers/hid/hid-core.c:2338 input_open_device+0x188/0x2d0 drivers/input/input.c:650 kbd_connect+0xe5/0x120 drivers/tty/vt/keyboard.c:1593 input_attach_handler drivers/input/input.c:1060 [inline] input_register_device+0xd65/0x1250 drivers/input/input.c:2470 hidinput_connect+0x2375/0x2be0 drivers/hid/hid-input.c:2334 hid_connect+0x47e/0x1a90 drivers/hid/hid-core.c:2188 hid_hw_start+0x99/0x100 drivers/hid/hid-core.c:2301 hid_device_probe+0x335/0x3a0 drivers/hid/hid-core.c:2636 really_probe+0x2ab/0xcb0 drivers/base/dd.c:639 __driver_probe_device+0x1a2/0x3d0 drivers/base/dd.c:785 driver_probe_device+0x50/0x420 drivers/base/dd.c:815 __device_attach_driver+0x2cf/0x510 drivers/base/dd.c:943 bus_for_each_drv+0x183/0x200 drivers/base/bus.c:429 __device_attach+0x359/0x570 drivers/base/dd.c:1015 bus_probe_device+0xba/0x1e0 drivers/base/bus.c:489 device_add+0xb48/0xfd0 drivers/base/core.c:3696 hid_add_device+0x3a5/0x510 drivers/hid/hid-core.c:2784 usbhid_probe+0xc09/0xfc0 drivers/hid/usbhid/hid-core.c:1424 usb_probe_interface+0x5c0/0xaf0 drivers/usb/core/driver.c:396 really_probe+0x2ab/0xcb0 drivers/base/dd.c:639 __driver_probe_device+0x1a2/0x3d0 drivers/base/dd.c:785 driver_probe_device+0x50/0x420 drivers/base/dd.c:815 __device_attach_driver+0x2cf/0x510 drivers/base/dd.c:943 bus_for_each_drv+0x183/0x200 drivers/base/bus.c:429 __device_attach+0x359/0x570 drivers/base/dd.c:1015 bus_probe_device+0xba/0x1e0 drivers/base/bus.c:489 device_add+0xb48/0xfd0 drivers/base/core.c:3696 usb_set_configuration+0x19dd/0x2020 drivers/usb/core/message.c:2165 usb_generic_driver_probe+0x84/0x140 drivers/usb/core/generic.c:238 usb_probe_device+0x130/0x260 drivers/usb/core/driver.c:293 really_probe+0x2ab/0xcb0 drivers/base/dd.c:639 __driver_probe_device+0x1a2/0x3d0 drivers/base/dd.c:785 driver_probe_device+0x50/0x420 drivers/base/dd.c:815 __device_attach_driver+0x2cf/0x510 drivers/base/dd.c:943 bus_for_each_drv+0x183/0x200 drivers/base/bus.c:429 __device_attach+0x359/0x570 drivers/base/dd.c:1015 bus_probe_device+0xba/0x1e0 drivers/base/bus.c:489 device_add+0xb48/0xfd0 drivers/base/core.c:3696 usb_new_device+0xbdd/0x1900 drivers/usb/core/hub.c:2631 hub_port_connect drivers/usb/core/hub.c:5489 [inline] hub_port_connect_change drivers/usb/core/hub.c:5629 [inline] port_event drivers/usb/core/hub.c:5785 [inline] hub_event+0x2efe/0x5730 drivers/usb/core/hub.c:5867 process_one_work+0x917/0x1260 kernel/workqueue.c:2292 worker_thread+0xa47/0x1200 kernel/workqueue.c:2439 kthread+0x28d/0x320 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295 -> #1 (&dev->mutex#2){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 input_register_handle+0x69/0x3a0 drivers/input/input.c:2629 kbd_connect+0xbb/0x120 drivers/tty/vt/keyboard.c:1589 input_attach_handler drivers/input/input.c:1060 [inline] input_register_device+0xd65/0x1250 drivers/input/input.c:2470 acpi_button_add+0x62a/0x9f0 drivers/acpi/button.c:570 acpi_device_probe+0xa0/0x2f0 drivers/acpi/bus.c:1023 really_probe+0x2ab/0xcb0 drivers/base/dd.c:639 __driver_probe_device+0x1a2/0x3d0 drivers/base/dd.c:785 driver_probe_device+0x50/0x420 drivers/base/dd.c:815 __driver_attach+0x458/0x6f0 drivers/base/dd.c:1201 bus_for_each_dev+0x17c/0x1f0 drivers/base/bus.c:303 bus_add_driver+0x334/0x600 drivers/base/bus.c:620 driver_register+0x2bf/0x3a0 drivers/base/driver.c:246 do_one_initcall+0x265/0x8f0 init/main.c:1298 do_initcall_level+0x157/0x207 init/main.c:1371 do_initcalls+0x49/0x86 init/main.c:1387 kernel_init_freeable+0x45c/0x60f init/main.c:1626 kernel_init+0x19/0x290 init/main.c:1514 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295 -> #0 (input_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 input_register_device+0xb54/0x1250 drivers/input/input.c:2463 steam_input_register+0x96b/0xbf0 drivers/hid/hid-steam.c:469 hid_hw_close+0xa4/0xd0 drivers/hid/hid-core.c:2366 drop_ref drivers/hid/hidraw.c:343 [inline] hidraw_release+0x46d/0x6c0 drivers/hid/hidraw.c:367 __fput+0x3f6/0x8d0 fs/file_table.c:320 task_work_run+0x246/0x300 kernel/task_work.c:203 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] exit_to_user_mode_loop+0xde/0x100 kernel/entry/common.c:177 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:210 __syscall_exit_to_user_mode_work kernel/entry/common.c:292 [inline] syscall_exit_to_user_mode+0x60/0x270 kernel/entry/common.c:303 do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:87 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Chain exists of: input_mutex --> &dev->mutex#2 --> &hdev->ll_open_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&hdev->ll_open_lock); lock(&dev->mutex#2); lock(&hdev->ll_open_lock); lock(input_mutex); *** DEADLOCK *** 2 locks held by syz.2.4012/19785: #0: ffffffff8e3bccd0 (minors_rwsem){++++}-{3:3}, at: hidraw_release+0x70/0x6c0 drivers/hid/hidraw.c:355 #1: ffff888056a65e18 (&hdev->ll_open_lock){+.+.}-{3:3}, at: hid_hw_close+0x2c/0xd0 drivers/hid/hid-core.c:2364 stack backtrace: CPU: 1 PID: 19785 Comm: syz.2.4012 Not tainted 6.1.129-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 input_register_device+0xb54/0x1250 drivers/input/input.c:2463 steam_input_register+0x96b/0xbf0 drivers/hid/hid-steam.c:469 hid_hw_close+0xa4/0xd0 drivers/hid/hid-core.c:2366 drop_ref drivers/hid/hidraw.c:343 [inline] hidraw_release+0x46d/0x6c0 drivers/hid/hidraw.c:367 __fput+0x3f6/0x8d0 fs/file_table.c:320 task_work_run+0x246/0x300 kernel/task_work.c:203 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] exit_to_user_mode_loop+0xde/0x100 kernel/entry/common.c:177 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:210 __syscall_exit_to_user_mode_work kernel/entry/common.c:292 [inline] syscall_exit_to_user_mode+0x60/0x270 kernel/entry/common.c:303 do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:87 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7fb1ea78d169 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffce475dc78 EFLAGS: 00000246 ORIG_RAX: 00000000000001b4 RAX: 0000000000000000 RBX: 00000000001a2335 RCX: 00007fb1ea78d169 RDX: 0000000000000000 RSI: 000000000000001e RDI: 0000000000000003 RBP: 00007fb1ea9a7ba0 R08: 0000000000000001 R09: 00000007e475df6f R10: 00007fb1ea400000 R11: 0000000000000246 R12: 00007fb1ea9a5fac R13: 00007fb1ea9a5fa0 R14: ffffffffffffffff R15: 00007ffce475dd90