loop0: detected capacity change from 0 to 8192
======================================================
WARNING: possible circular locking dependency detected
6.13.0-rc2-syzkaller-00130-g150b567e0d57 #0 Not tainted
------------------------------------------------------
syz.0.893/9388 is trying to acquire lock:
ffff88805a0d5430 (&sb->s_type->i_mutex_key#21){++++}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline]
ffff88805a0d5430 (&sb->s_type->i_mutex_key#21){++++}-{4:4}, at: __generic_file_fsync+0xb0/0x1f0 fs/libfs.c:1536

but task is already holding lock:
ffff88814334f608 (&q->q_usage_counter(io)#26){++++}-{0:0}, at: loop_set_status+0x1d9/0x700 drivers/block/loop.c:1267

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&q->q_usage_counter(io)#26){++++}-{0:0}:
       bio_queue_enter block/blk.h:75 [inline]
       blk_mq_submit_bio+0x1fb6/0x24c0 block/blk-mq.c:3092
       __submit_bio+0x384/0x540 block/blk-core.c:629
       __submit_bio_noacct_mq block/blk-core.c:710 [inline]
       submit_bio_noacct_nocheck+0x698/0xd70 block/blk-core.c:739
       submit_bio_noacct+0x93a/0x1e20 block/blk-core.c:868
       submit_bio_wait+0x10a/0x240 block/bio.c:1391
       blkdev_issue_discard+0xfd/0x190 block/blk-lib.c:95
       sb_issue_discard include/linux/blkdev.h:1138 [inline]
       fat_free_clusters+0x364/0xa60 fs/fat/fatent.c:588
       fat_free fs/fat/file.c:376 [inline]
       fat_truncate_blocks+0x53a/0xbe0 fs/fat/file.c:394
       fat_evict_inode+0x8d/0x280 fs/fat/inode.c:656
       evict+0x40c/0x960 fs/inode.c:796
       iput_final fs/inode.c:1946 [inline]
       iput fs/inode.c:1972 [inline]
       iput+0x52a/0x890 fs/inode.c:1958
       dentry_unlink_inode+0x29c/0x480 fs/dcache.c:422
       __dentry_kill+0x1d0/0x600 fs/dcache.c:625
       dput.part.0+0x4b1/0x9b0 fs/dcache.c:867
       dput+0x1f/0x30 fs/dcache.c:857
       do_renameat2+0xc6f/0xdd0 fs/namei.c:5226
       __do_sys_renameat2 fs/namei.c:5258 [inline]
       __se_sys_renameat2 fs/namei.c:5255 [inline]
       __x64_sys_renameat2+0xe7/0x130 fs/namei.c:5255
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&sbi->fat_lock){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:585 [inline]
       __mutex_lock+0x19b/0xa60 kernel/locking/mutex.c:735
       lock_fat fs/fat/fatent.c:281 [inline]
       fat_alloc_clusters+0x1b9/0xf80 fs/fat/fatent.c:477
       fat_add_cluster+0x79/0x100 fs/fat/inode.c:107
       __fat_get_block fs/fat/inode.c:154 [inline]
       fat_get_block+0x38e/0xaf0 fs/fat/inode.c:189
       __block_write_begin_int+0x4fe/0x16e0 fs/buffer.c:2116
       block_write_begin+0x9a/0x1d0 fs/buffer.c:2226
       cont_write_begin+0x61d/0x950 fs/buffer.c:2577
       fat_write_begin+0x66/0x150 fs/fat/inode.c:228
       generic_perform_write+0x2bd/0x920 mm/filemap.c:4055
       __generic_file_write_iter+0x1f7/0x240 mm/filemap.c:4156
       generic_file_write_iter+0xe1/0x340 mm/filemap.c:4182
       do_iter_readv_writev+0x535/0x7f0 fs/read_write.c:820
       vfs_writev+0x363/0xdd0 fs/read_write.c:1050
       do_writev+0x133/0x340 fs/read_write.c:1096
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&sb->s_type->i_mutex_key#21){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3161 [inline]
       check_prevs_add kernel/locking/lockdep.c:3280 [inline]
       validate_chain kernel/locking/lockdep.c:3904 [inline]
       __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5226
       lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5849
       down_write+0x93/0x200 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:818 [inline]
       __generic_file_fsync+0xb0/0x1f0 fs/libfs.c:1536
       fat_file_fsync+0x70/0x210 fs/fat/file.c:191
       vfs_fsync_range fs/sync.c:187 [inline]
       vfs_fsync+0x12d/0x1f0 fs/sync.c:201
       __loop_update_dio+0x182/0x570 drivers/block/loop.c:204
       loop_set_status+0x2a4/0x700 drivers/block/loop.c:1289
       loop_set_status_old+0x163/0x1d0 drivers/block/loop.c:1388
       lo_ioctl+0x65c/0x18b0 drivers/block/loop.c:1541
       blkdev_ioctl+0x279/0x6d0 block/ioctl.c:693
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:906 [inline]
       __se_sys_ioctl fs/ioctl.c:892 [inline]
       __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:892
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &sb->s_type->i_mutex_key#21 --> &sbi->fat_lock --> &q->q_usage_counter(io)#26

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&q->q_usage_counter(io)#26);
                               lock(&sbi->fat_lock);
                               lock(&q->q_usage_counter(io)#26);
  lock(&sb->s_type->i_mutex_key#21);

 *** DEADLOCK ***

3 locks held by syz.0.893/9388:
 #0: ffff888025ae8b60 (&lo->lo_mutex){+.+.}-{4:4}, at: loop_set_status+0x2a/0x700 drivers/block/loop.c:1251
 #1: ffff88814334f608 (&q->q_usage_counter(io)#26){++++}-{0:0}, at: loop_set_status+0x1d9/0x700 drivers/block/loop.c:1267
 #2: ffff88814334f640 (&q->q_usage_counter(queue)#10){+.+.}-{0:0}, at: loop_set_status+0x1d9/0x700 drivers/block/loop.c:1267

stack backtrace:
CPU: 1 UID: 0 PID: 9388 Comm: syz.0.893 Not tainted 6.13.0-rc2-syzkaller-00130-g150b567e0d57 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/25/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 print_circular_bug+0x419/0x5d0 kernel/locking/lockdep.c:2074
 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2206
 check_prev_add kernel/locking/lockdep.c:3161 [inline]
 check_prevs_add kernel/locking/lockdep.c:3280 [inline]
 validate_chain kernel/locking/lockdep.c:3904 [inline]
 __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5226
 lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5849
 down_write+0x93/0x200 kernel/locking/rwsem.c:1577
 inode_lock include/linux/fs.h:818 [inline]
 __generic_file_fsync+0xb0/0x1f0 fs/libfs.c:1536
 fat_file_fsync+0x70/0x210 fs/fat/file.c:191
 vfs_fsync_range fs/sync.c:187 [inline]
 vfs_fsync+0x12d/0x1f0 fs/sync.c:201
 __loop_update_dio+0x182/0x570 drivers/block/loop.c:204
 loop_set_status+0x2a4/0x700 drivers/block/loop.c:1289
 loop_set_status_old+0x163/0x1d0 drivers/block/loop.c:1388
 lo_ioctl+0x65c/0x18b0 drivers/block/loop.c:1541
 blkdev_ioctl+0x279/0x6d0 block/ioctl.c:693
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:906 [inline]
 __se_sys_ioctl fs/ioctl.c:892 [inline]
 __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:892
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f3815585d19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f3816384038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f3815775fa0 RCX: 00007f3815585d19
RDX: 0000000020000480 RSI: 0000000000004c02 RDI: 0000000000000004
RBP: 00007f3815601a20 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f3815775fa0 R15: 00007ffee9ce5f18
 </TASK>