====================================================== WARNING: possible circular locking dependency detected 6.13.0-rc2-syzkaller-00018-g7cb1b4663150 #0 Not tainted ------------------------------------------------------ syz.1.893/9276 is trying to acquire lock: ffff888025a64810 (set->srcu){.+.+}-{0:0}, at: srcu_lock_sync include/linux/srcu.h:170 [inline] ffff888025a64810 (set->srcu){.+.+}-{0:0}, at: __synchronize_srcu+0x99/0x2a0 kernel/rcu/srcutree.c:1418 but task is already holding lock: ffff888025ae9968 (&q->sysfs_lock){+.+.}-{4:4}, at: blk_mq_elv_switch_none block/blk-mq.c:4925 [inline] ffff888025ae9968 (&q->sysfs_lock){+.+.}-{4:4}, at: __blk_mq_update_nr_hw_queues+0x446/0x14e0 block/blk-mq.c:5003 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&q->sysfs_lock){+.+.}-{4:4}: __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x19b/0xa60 kernel/locking/mutex.c:735 blk_mq_elv_switch_none block/blk-mq.c:4925 [inline] __blk_mq_update_nr_hw_queues+0x446/0x14e0 block/blk-mq.c:5003 blk_mq_update_nr_hw_queues+0x2a/0x40 block/blk-mq.c:5063 nbd_start_device+0x15b/0xd70 drivers/block/nbd.c:1413 nbd_start_device_ioctl drivers/block/nbd.c:1464 [inline] __nbd_ioctl drivers/block/nbd.c:1539 [inline] nbd_ioctl+0x21a/0xfd0 drivers/block/nbd.c:1579 blkdev_ioctl+0x276/0x6d0 block/ioctl.c:693 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:906 [inline] __se_sys_ioctl fs/ioctl.c:892 [inline] __x64_sys_ioctl+0x190/0x200 fs/ioctl.c:892 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #5 (&q->q_usage_counter(io)#50){++++}-{0:0}: bio_queue_enter block/blk.h:75 [inline] blk_mq_submit_bio+0x1fb6/0x24c0 block/blk-mq.c:3092 __submit_bio+0x384/0x540 block/blk-core.c:629 __submit_bio_noacct_mq block/blk-core.c:710 [inline] submit_bio_noacct_nocheck+0x698/0xd70 block/blk-core.c:739 submit_bio_noacct+0x93a/0x1e20 block/blk-core.c:868 mpage_bio_submit_read fs/mpage.c:75 [inline] mpage_readahead+0x41d/0x590 fs/mpage.c:377 read_pages+0x1a8/0xdc0 mm/readahead.c:160 page_cache_ra_unbounded+0x3dc/0x750 mm/readahead.c:295 do_page_cache_ra mm/readahead.c:325 [inline] force_page_cache_ra+0x24b/0x340 mm/readahead.c:354 page_cache_sync_ra+0x110/0x9c0 mm/readahead.c:566 page_cache_sync_readahead include/linux/pagemap.h:1397 [inline] filemap_get_pages+0xd7b/0x1be0 mm/filemap.c:2546 filemap_read+0x3ca/0xd70 mm/filemap.c:2646 blkdev_read_iter+0x187/0x480 block/fops.c:770 new_sync_read fs/read_write.c:484 [inline] vfs_read+0x87f/0xbe0 fs/read_write.c:565 ksys_read+0x12b/0x250 fs/read_write.c:708 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #4 (mapping.invalidate_lock#2){++++}-{4:4}: down_read+0x9a/0x330 kernel/locking/rwsem.c:1524 filemap_invalidate_lock_shared include/linux/fs.h:873 [inline] page_cache_ra_unbounded+0x173/0x750 mm/readahead.c:226 do_page_cache_ra mm/readahead.c:325 [inline] page_cache_ra_order+0x8f2/0xc80 mm/readahead.c:524 do_sync_mmap_readahead mm/filemap.c:3203 [inline] filemap_fault+0x14a5/0x2820 mm/filemap.c:3344 __do_fault+0x10a/0x490 mm/memory.c:4907 do_read_fault mm/memory.c:5322 [inline] do_fault mm/memory.c:5456 [inline] do_pte_missing+0xebd/0x3e00 mm/memory.c:3979 handle_pte_fault mm/memory.c:5801 [inline] __handle_mm_fault+0x103c/0x2a40 mm/memory.c:5944 handle_mm_fault+0x3fa/0xaa0 mm/memory.c:6112 do_user_addr_fault+0x7a3/0x13f0 arch/x86/mm/fault.c:1389 handle_page_fault arch/x86/mm/fault.c:1481 [inline] exc_page_fault+0x5c/0xc0 arch/x86/mm/fault.c:1539 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623 copy_user_generic arch/x86/include/asm/uaccess_64.h:126 [inline] raw_copy_from_user arch/x86/include/asm/uaccess_64.h:141 [inline] copy_from_user_iter lib/iov_iter.c:55 [inline] iterate_ubuf include/linux/iov_iter.h:30 [inline] iterate_and_advance2 include/linux/iov_iter.h:300 [inline] iterate_and_advance include/linux/iov_iter.h:328 [inline] __copy_from_iter lib/iov_iter.c:249 [inline] _copy_from_iter+0x384/0x1560 lib/iov_iter.c:260 copy_from_iter include/linux/uio.h:219 [inline] copy_from_iter_full include/linux/uio.h:236 [inline] skb_do_copy_data_nocache include/net/sock.h:2187 [inline] skb_copy_to_page_nocache include/net/sock.h:2213 [inline] tcp_sendmsg_locked+0x193b/0x3770 net/ipv4/tcp.c:1222 tcp_sendmsg+0x2e/0x50 net/ipv4/tcp.c:1358 inet_sendmsg+0xb9/0x140 net/ipv4/af_inet.c:851 sock_sendmsg_nosec net/socket.c:711 [inline] __sock_sendmsg net/socket.c:726 [inline] ____sys_sendmsg+0x98c/0xc90 net/socket.c:2583 ___sys_sendmsg+0x135/0x1e0 net/socket.c:2637 __sys_sendmsg+0x16e/0x220 net/socket.c:2669 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #3 (sk_lock-AF_INET){+.+.}-{0:0}: lock_sock_nested+0x3a/0xf0 net/core/sock.c:3622 lock_sock include/net/sock.h:1617 [inline] inet_shutdown+0x67/0x440 net/ipv4/af_inet.c:905 nbd_mark_nsock_dead+0xae/0x5d0 drivers/block/nbd.c:314 recv_work+0x691/0xaa0 drivers/block/nbd.c:957 process_one_work+0x9c5/0x1ba0 kernel/workqueue.c:3229 process_scheduled_works kernel/workqueue.c:3310 [inline] worker_thread+0x6c8/0xf00 kernel/workqueue.c:3391 kthread+0x2c1/0x3a0 kernel/kthread.c:389 ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 -> #2 (&nsock->tx_lock){+.+.}-{4:4}: __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x19b/0xa60 kernel/locking/mutex.c:735 nbd_handle_cmd drivers/block/nbd.c:1079 [inline] nbd_queue_rq+0x424/0x1220 drivers/block/nbd.c:1143 blk_mq_dispatch_rq_list+0x443/0x1dc0 block/blk-mq.c:2120 __blk_mq_do_dispatch_sched block/blk-mq-sched.c:170 [inline] blk_mq_do_dispatch_sched block/blk-mq-sched.c:184 [inline] __blk_mq_sched_dispatch_requests+0xcdf/0x1620 block/blk-mq-sched.c:309 blk_mq_sched_dispatch_requests+0xd8/0x1b0 block/blk-mq-sched.c:331 blk_mq_run_hw_queue+0x239/0x670 block/blk-mq.c:2354 blk_mq_dispatch_plug_list block/blk-mq.c:2864 [inline] blk_mq_flush_plug_list+0x673/0x1c60 block/blk-mq.c:2915 __blk_flush_plug+0x2c5/0x4b0 block/blk-core.c:1213 blk_finish_plug block/blk-core.c:1240 [inline] blk_finish_plug block/blk-core.c:1237 [inline] __submit_bio+0x439/0x540 block/blk-core.c:637 __submit_bio_noacct_mq block/blk-core.c:710 [inline] submit_bio_noacct_nocheck+0x698/0xd70 block/blk-core.c:739 submit_bio_noacct+0x93a/0x1e20 block/blk-core.c:868 submit_bh fs/buffer.c:2819 [inline] block_read_full_folio+0x812/0xa50 fs/buffer.c:2446 filemap_read_folio+0xc6/0x2a0 mm/filemap.c:2366 do_read_cache_folio+0x263/0x5c0 mm/filemap.c:3826 read_mapping_folio include/linux/pagemap.h:1011 [inline] read_part_sector+0xd4/0x310 block/partitions/core.c:722 adfspart_check_ICS+0x94/0x940 block/partitions/acorn.c:360 check_partition block/partitions/core.c:141 [inline] blk_add_partitions block/partitions/core.c:589 [inline] bdev_disk_changed+0x71f/0x1520 block/partitions/core.c:693 blkdev_get_whole+0x187/0x290 block/bdev.c:707 bdev_open+0x2c7/0xe20 block/bdev.c:916 blkdev_open+0x329/0x400 block/fops.c:627 do_dentry_open+0xf59/0x1ea0 fs/open.c:945 vfs_open+0x82/0x3f0 fs/open.c:1075 do_open fs/namei.c:3828 [inline] path_openat+0x1e6a/0x2d60 fs/namei.c:3987 do_filp_open+0x20c/0x470 fs/namei.c:4014 do_sys_openat2+0x17a/0x1e0 fs/open.c:1402 do_sys_open fs/open.c:1417 [inline] __do_sys_openat fs/open.c:1433 [inline] __se_sys_openat fs/open.c:1428 [inline] __x64_sys_openat+0x175/0x210 fs/open.c:1428 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&cmd->lock){+.+.}-{4:4}: __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x19b/0xa60 kernel/locking/mutex.c:735 nbd_queue_rq+0xbe/0x1220 drivers/block/nbd.c:1135 blk_mq_dispatch_rq_list+0x443/0x1dc0 block/blk-mq.c:2120 __blk_mq_do_dispatch_sched block/blk-mq-sched.c:170 [inline] blk_mq_do_dispatch_sched block/blk-mq-sched.c:184 [inline] __blk_mq_sched_dispatch_requests+0xcdf/0x1620 block/blk-mq-sched.c:309 blk_mq_sched_dispatch_requests+0xd8/0x1b0 block/blk-mq-sched.c:331 blk_mq_run_hw_queue+0x239/0x670 block/blk-mq.c:2354 blk_mq_dispatch_plug_list block/blk-mq.c:2864 [inline] blk_mq_flush_plug_list+0x673/0x1c60 block/blk-mq.c:2915 __blk_flush_plug+0x2c5/0x4b0 block/blk-core.c:1213 blk_finish_plug block/blk-core.c:1240 [inline] blk_finish_plug block/blk-core.c:1237 [inline] __submit_bio+0x439/0x540 block/blk-core.c:637 __submit_bio_noacct_mq block/blk-core.c:710 [inline] submit_bio_noacct_nocheck+0x698/0xd70 block/blk-core.c:739 submit_bio_noacct+0x93a/0x1e20 block/blk-core.c:868 submit_bh fs/buffer.c:2819 [inline] block_read_full_folio+0x812/0xa50 fs/buffer.c:2446 filemap_read_folio+0xc6/0x2a0 mm/filemap.c:2366 do_read_cache_folio+0x263/0x5c0 mm/filemap.c:3826 read_mapping_folio include/linux/pagemap.h:1011 [inline] read_part_sector+0xd4/0x310 block/partitions/core.c:722 adfspart_check_ICS+0x94/0x940 block/partitions/acorn.c:360 check_partition block/partitions/core.c:141 [inline] blk_add_partitions block/partitions/core.c:589 [inline] bdev_disk_changed+0x71f/0x1520 block/partitions/core.c:693 blkdev_get_whole+0x187/0x290 block/bdev.c:707 bdev_open+0x2c7/0xe20 block/bdev.c:916 blkdev_open+0x329/0x400 block/fops.c:627 do_dentry_open+0xf59/0x1ea0 fs/open.c:945 vfs_open+0x82/0x3f0 fs/open.c:1075 do_open fs/namei.c:3828 [inline] path_openat+0x1e6a/0x2d60 fs/namei.c:3987 do_filp_open+0x20c/0x470 fs/namei.c:4014 do_sys_openat2+0x17a/0x1e0 fs/open.c:1402 do_sys_open fs/open.c:1417 [inline] __do_sys_openat fs/open.c:1433 [inline] __se_sys_openat fs/open.c:1428 [inline] __x64_sys_openat+0x175/0x210 fs/open.c:1428 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (set->srcu){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain kernel/locking/lockdep.c:3904 [inline] __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5226 lock_sync+0xf5/0x190 kernel/locking/lockdep.c:5897 srcu_lock_sync include/linux/srcu.h:170 [inline] __synchronize_srcu+0xa9/0x2a0 kernel/rcu/srcutree.c:1418 blk_mq_wait_quiesce_done block/blk-mq.c:291 [inline] blk_mq_wait_quiesce_done block/blk-mq.c:288 [inline] blk_mq_quiesce_queue block/blk-mq.c:311 [inline] blk_mq_quiesce_queue+0x149/0x1b0 block/blk-mq.c:306 elevator_disable+0x70/0x490 block/elevator.c:671 blk_mq_elv_switch_none block/blk-mq.c:4939 [inline] __blk_mq_update_nr_hw_queues+0x3bb/0x14e0 block/blk-mq.c:5003 blk_mq_update_nr_hw_queues+0x2a/0x40 block/blk-mq.c:5063 nbd_start_device+0x15b/0xd70 drivers/block/nbd.c:1413 nbd_start_device_ioctl drivers/block/nbd.c:1464 [inline] __nbd_ioctl drivers/block/nbd.c:1539 [inline] nbd_ioctl+0x21a/0xfd0 drivers/block/nbd.c:1579 blkdev_ioctl+0x276/0x6d0 block/ioctl.c:693 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:906 [inline] __se_sys_ioctl fs/ioctl.c:892 [inline] __x64_sys_ioctl+0x190/0x200 fs/ioctl.c:892 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: set->srcu --> &q->q_usage_counter(io)#50 --> &q->sysfs_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&q->sysfs_lock); lock(&q->q_usage_counter(io)#50); lock(&q->sysfs_lock); sync(set->srcu); *** DEADLOCK *** 5 locks held by syz.1.893/9276: #0: ffff888025b9f998 (&nbd->config_lock){+.+.}-{4:4}, at: nbd_ioctl+0x151/0xfd0 drivers/block/nbd.c:1572 #1: ffff888025b9f8d8 (&set->tag_list_lock){+.+.}-{4:4}, at: blk_mq_update_nr_hw_queues+0x20/0x40 block/blk-mq.c:5062 #2: ffff888025ae9438 (&q->q_usage_counter(io)#50){++++}-{0:0}, at: blk_mq_freeze_queue block/blk-mq.c:213 [inline] #2: ffff888025ae9438 (&q->q_usage_counter(io)#50){++++}-{0:0}, at: __blk_mq_update_nr_hw_queues+0x1fc/0x14e0 block/blk-mq.c:4996 #3: ffff888025ae9470 (&q->q_usage_counter(queue)#34){+.+.}-{0:0}, at: blk_mq_freeze_queue block/blk-mq.c:213 [inline] #3: ffff888025ae9470 (&q->q_usage_counter(queue)#34){+.+.}-{0:0}, at: __blk_mq_update_nr_hw_queues+0x1fc/0x14e0 block/blk-mq.c:4996 #4: ffff888025ae9968 (&q->sysfs_lock){+.+.}-{4:4}, at: blk_mq_elv_switch_none block/blk-mq.c:4925 [inline] #4: ffff888025ae9968 (&q->sysfs_lock){+.+.}-{4:4}, at: __blk_mq_update_nr_hw_queues+0x446/0x14e0 block/blk-mq.c:5003 stack backtrace: CPU: 1 UID: 0 PID: 9276 Comm: syz.1.893 Not tainted 6.13.0-rc2-syzkaller-00018-g7cb1b4663150 #0 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120 print_circular_bug+0x419/0x5d0 kernel/locking/lockdep.c:2074 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain kernel/locking/lockdep.c:3904 [inline] __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5226 lock_sync+0xf5/0x190 kernel/locking/lockdep.c:5897 srcu_lock_sync include/linux/srcu.h:170 [inline] __synchronize_srcu+0xa9/0x2a0 kernel/rcu/srcutree.c:1418 blk_mq_wait_quiesce_done block/blk-mq.c:291 [inline] blk_mq_wait_quiesce_done block/blk-mq.c:288 [inline] blk_mq_quiesce_queue block/blk-mq.c:311 [inline] blk_mq_quiesce_queue+0x149/0x1b0 block/blk-mq.c:306 elevator_disable+0x70/0x490 block/elevator.c:671 blk_mq_elv_switch_none block/blk-mq.c:4939 [inline] __blk_mq_update_nr_hw_queues+0x3bb/0x14e0 block/blk-mq.c:5003 blk_mq_update_nr_hw_queues+0x2a/0x40 block/blk-mq.c:5063 nbd_start_device+0x15b/0xd70 drivers/block/nbd.c:1413 nbd_start_device_ioctl drivers/block/nbd.c:1464 [inline] __nbd_ioctl drivers/block/nbd.c:1539 [inline] nbd_ioctl+0x21a/0xfd0 drivers/block/nbd.c:1579 blkdev_ioctl+0x276/0x6d0 block/ioctl.c:693 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:906 [inline] __se_sys_ioctl fs/ioctl.c:892 [inline] __x64_sys_ioctl+0x190/0x200 fs/ioctl.c:892 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fef3877ff19 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fef3962f058 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007fef38946080 RCX: 00007fef3877ff19 RDX: 0000000000000000 RSI: 000000000000ab03 RDI: 0000000000000008 RBP: 00007fef387f3cc8 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007fef38946080 R15: 00007ffc6c6f0c28