======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.4.84/4883 is trying to acquire lock:
ffff88805624b1b8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_init_acl+0x307/0x770 fs/ocfs2/acl.c:365

but task is already holding lock:
ffff888058224990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x2014/0x2240 fs/jbd2/transaction.c:463

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (jbd2_handle){++++}-{0:0}:
       jbd2_journal_lock_updates+0xa8/0x390 fs/jbd2/transaction.c:880
       __ocfs2_flush_truncate_log+0x2cf/0x1220 fs/ocfs2/alloc.c:6029
       ocfs2_flush_truncate_log+0x4b/0x60 fs/ocfs2/alloc.c:6076
       ocfs2_sync_fs+0x119/0x330 fs/ocfs2/super.c:402
       sync_filesystem+0x1be/0x220 fs/sync.c:66
       ocfs2_remount+0x115/0xb40 fs/ocfs2/super.c:611
       reconfigure_super+0x224/0x8d0 fs/super.c:977
       do_remount fs/namespace.c:2741 [inline]
       path_mount+0xcce/0xfb0 fs/namespace.c:3400
       do_mount fs/namespace.c:3421 [inline]
       __do_sys_mount fs/namespace.c:3629 [inline]
       __se_sys_mount+0x2e3/0x3d0 fs/namespace.c:3606
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}:
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_xattr_set+0xbe4/0x1390 fs/ocfs2/xattr.c:3626
       __vfs_setxattr+0x3d8/0x410 fs/xattr.c:182
       __vfs_setxattr_noperm+0x126/0x5e0 fs/xattr.c:216
       vfs_setxattr+0x167/0x2e0 fs/xattr.c:309
       do_setxattr fs/xattr.c:594 [inline]
       setxattr+0x2a3/0x330 fs/xattr.c:617
       __do_sys_fsetxattr fs/xattr.c:673 [inline]
       __se_sys_fsetxattr+0x15e/0x1d0 fs/xattr.c:662
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&oi->ip_xattr_sem){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3095 [inline]
       check_prevs_add kernel/locking/lockdep.c:3214 [inline]
       validate_chain kernel/locking/lockdep.c:3830 [inline]
       __lock_acquire+0x2d18/0x7c40 kernel/locking/lockdep.c:5063
       lock_acquire+0x1bb/0x4a0 kernel/locking/lockdep.c:5676
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_init_acl+0x307/0x770 fs/ocfs2/acl.c:365
       ocfs2_mknod+0x18e0/0x2580 fs/ocfs2/namei.c:410
       ocfs2_create+0x1b6/0x4b0 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3490 [inline]
       open_last_lookups fs/namei.c:3558 [inline]
       path_openat+0x11b9/0x2f10 fs/namei.c:3788
       do_filp_open+0x1ee/0x420 fs/namei.c:3818
       do_sys_openat2+0x14b/0x4f0 fs/open.c:1320
       do_sys_open fs/open.c:1336 [inline]
       __do_sys_open fs/open.c:1344 [inline]
       __se_sys_open fs/open.c:1340 [inline]
       __x64_sys_open+0x11b/0x140 fs/open.c:1340
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &oi->ip_xattr_sem --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6 --> jbd2_handle

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(jbd2_handle);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6);
                               lock(jbd2_handle);
  lock(&oi->ip_xattr_sem);

 *** DEADLOCK ***

8 locks held by syz.4.84/4883:
 #0: ffff8880276f0460 (sb_writers#21){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:402
 #1: ffff88805624b488 (&type->i_mutex_dir_key#18){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff88805624b488 (&type->i_mutex_dir_key#18){+.+.}-{3:3}, at: open_last_lookups fs/namei.c:3555 [inline]
 #1: ffff88805624b488 (&type->i_mutex_dir_key#18){+.+.}-{3:3}, at: path_openat+0x7e8/0x2f10 fs/namei.c:3788
 #2: ffff88804f865f48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #2: ffff88804f865f48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x16a/0x4810 fs/ocfs2/suballoc.c:804
 #3: ffff8880560b89c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #3: ffff8880560b89c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x16a/0x4810 fs/ocfs2/suballoc.c:804
 #4: ffff88804f865108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #4: ffff88804f865108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0x11e/0x2770 fs/ocfs2/localalloc.c:635
 #5: ffff8880276f0650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_mknod+0x1273/0x2580 fs/ocfs2/namei.c:361
 #6: ffff88805898d8e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x3a4/0x6f0 fs/ocfs2/journal.c:374
 #7: ffff888058224990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x2014/0x2240 fs/jbd2/transaction.c:463

stack backtrace:
CPU: 1 PID: 4883 Comm: syz.4.84 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/24/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x24e lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3095 [inline]
 check_prevs_add kernel/locking/lockdep.c:3214 [inline]
 validate_chain kernel/locking/lockdep.c:3830 [inline]
 __lock_acquire+0x2d18/0x7c40 kernel/locking/lockdep.c:5063
 lock_acquire+0x1bb/0x4a0 kernel/locking/lockdep.c:5676
 down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
 ocfs2_init_acl+0x307/0x770 fs/ocfs2/acl.c:365
 ocfs2_mknod+0x18e0/0x2580 fs/ocfs2/namei.c:410
 ocfs2_create+0x1b6/0x4b0 fs/ocfs2/namei.c:674
 lookup_open fs/namei.c:3490 [inline]
 open_last_lookups fs/namei.c:3558 [inline]
 path_openat+0x11b9/0x2f10 fs/namei.c:3788
 do_filp_open+0x1ee/0x420 fs/namei.c:3818
 do_sys_openat2+0x14b/0x4f0 fs/open.c:1320
 do_sys_open fs/open.c:1336 [inline]
 __do_sys_open fs/open.c:1344 [inline]
 __se_sys_open fs/open.c:1340 [inline]
 __x64_sys_open+0x11b/0x140 fs/open.c:1340
 do_syscall_x64 arch/x86/entry/common.c:46 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f7ef1b9e0d9
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f7ef29de028 EFLAGS: 00000246 ORIG_RAX: 0000000000000002
RAX: ffffffffffffffda RBX: 00007f7ef1e25fa0 RCX: 00007f7ef1b9e0d9
RDX: 0000000000000086 RSI: 0000000000064842 RDI: 0000200000000080
RBP: 00007f7ef1c35024 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f7ef1e26038 R14: 00007f7ef1e25fa0 R15: 00007ffd3995aa78
 </TASK>