overlayfs: upper fs does not support RENAME_WHITEOUT. ====================================================== WARNING: possible circular locking dependency detected syzkaller #0 Not tainted ------------------------------------------------------ syz.5.2769/12843 is trying to acquire lock: ffff8880678f1808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline] ffff8880678f1808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_xattr_set+0xad6/0x11e0 fs/ocfs2/xattr.c:3626 but task is already holding lock: ffff88805f122378 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x40c/0x11e0 fs/ocfs2/xattr.c:3587 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (&oi->ip_xattr_sem){++++}-{3:3}: down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498 ocfs2_init_acl+0x2fb/0x720 fs/ocfs2/acl.c:365 ocfs2_mknod+0x142f/0x22b0 fs/ocfs2/namei.c:410 ocfs2_mkdir+0x192/0x410 fs/ocfs2/namei.c:657 vfs_mkdir+0x387/0x570 fs/namei.c:4065 do_mkdirat+0x1d7/0x5a0 fs/namei.c:4090 __do_sys_mkdirat fs/namei.c:4105 [inline] __se_sys_mkdirat fs/namei.c:4103 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4103 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #3 (jbd2_handle){++++}-{0:0}: start_this_handle+0x1338/0x15a0 fs/jbd2/transaction.c:464 jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:521 jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:560 ocfs2_start_trans+0x374/0x6c0 fs/ocfs2/journal.c:376 ocfs2_shutdown_local_alloc+0x1fd/0xa10 fs/ocfs2/localalloc.c:416 ocfs2_dismount_volume+0x1de/0x880 fs/ocfs2/super.c:1885 generic_shutdown_super+0x130/0x300 fs/super.c:475 kill_block_super+0x7c/0xe0 fs/super.c:1427 deactivate_locked_super+0x93/0xf0 fs/super.c:335 cleanup_mnt+0x418/0x4d0 fs/namespace.c:1139 task_work_run+0x125/0x1a0 kernel/task_work.c:188 tracehook_notify_resume include/linux/tracehook.h:189 [inline] exit_to_user_mode_loop+0x10f/0x130 kernel/entry/common.c:181 exit_to_user_mode_prepare+0xee/0x180 kernel/entry/common.c:214 __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline] syscall_exit_to_user_mode+0x16/0x40 kernel/entry/common.c:307 do_syscall_64+0x58/0xa0 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #2 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498 ocfs2_start_trans+0x368/0x6c0 fs/ocfs2/journal.c:374 ocfs2_shutdown_local_alloc+0x1fd/0xa10 fs/ocfs2/localalloc.c:416 ocfs2_dismount_volume+0x1de/0x880 fs/ocfs2/super.c:1885 generic_shutdown_super+0x130/0x300 fs/super.c:475 kill_block_super+0x7c/0xe0 fs/super.c:1427 deactivate_locked_super+0x93/0xf0 fs/super.c:335 cleanup_mnt+0x418/0x4d0 fs/namespace.c:1139 task_work_run+0x125/0x1a0 kernel/task_work.c:188 tracehook_notify_resume include/linux/tracehook.h:189 [inline] exit_to_user_mode_loop+0x10f/0x130 kernel/entry/common.c:181 exit_to_user_mode_prepare+0xee/0x180 kernel/entry/common.c:214 __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline] syscall_exit_to_user_mode+0x16/0x40 kernel/entry/common.c:307 do_syscall_64+0x58/0xa0 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #1 (sb_internal#4){.+.+}-{0:0}: percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1811 [inline] sb_start_intwrite include/linux/fs.h:1928 [inline] ocfs2_start_trans+0x269/0x6c0 fs/ocfs2/journal.c:372 ocfs2_remove_btree_range+0x7db/0x1480 fs/ocfs2/alloc.c:5753 ocfs2_commit_truncate+0xab3/0x1b30 fs/ocfs2/alloc.c:7347 ocfs2_truncate_for_delete fs/ocfs2/inode.c:623 [inline] ocfs2_wipe_inode fs/ocfs2/inode.c:790 [inline] ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline] ocfs2_evict_inode+0xef2/0x3e40 fs/ocfs2/inode.c:1216 evict+0x485/0x870 fs/inode.c:647 do_unlinkat+0x3d8/0x6f0 fs/namei.c:4355 __do_sys_unlinkat fs/namei.c:4391 [inline] __se_sys_unlinkat fs/namei.c:4384 [inline] __x64_sys_unlinkat+0xd1/0xe0 fs/namei.c:4384 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 inode_lock include/linux/fs.h:787 [inline] ocfs2_xattr_set+0xad6/0x11e0 fs/ocfs2/xattr.c:3626 __vfs_setxattr+0x3e0/0x420 fs/xattr.c:182 __vfs_setxattr_noperm+0x129/0x5e0 fs/xattr.c:216 vfs_setxattr+0x168/0x2f0 fs/xattr.c:303 ovl_do_setxattr fs/overlayfs/overlayfs.h:214 [inline] ovl_setxattr fs/overlayfs/overlayfs.h:225 [inline] ovl_make_workdir fs/overlayfs/super.c:1422 [inline] ovl_get_workdir+0x948/0x11a0 fs/overlayfs/super.c:1526 ovl_fill_super+0x1925/0x2ae0 fs/overlayfs/super.c:2082 mount_nodev+0x52/0xe0 fs/super.c:1446 legacy_get_tree+0xe6/0x180 fs/fs_context.c:611 vfs_get_tree+0x88/0x270 fs/super.c:1530 do_new_mount+0x24a/0xa40 fs/namespace.c:3025 do_mount fs/namespace.c:3368 [inline] __do_sys_mount fs/namespace.c:3576 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3553 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2 --> jbd2_handle --> &oi->ip_xattr_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->ip_xattr_sem); lock(jbd2_handle); lock(&oi->ip_xattr_sem); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2); *** DEADLOCK *** 4 locks held by syz.5.2769/12843: #0: ffff888050da00e0 (&type->s_umount_key#60/1){+.+.}-{3:3}, at: alloc_super+0x201/0x950 fs/super.c:229 #1: ffff88807b4f4460 (sb_writers#26){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:377 #2: ffff88805f122648 (&sb->s_type->i_mutex_key#39){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline] #2: ffff88805f122648 (&sb->s_type->i_mutex_key#39){+.+.}-{3:3}, at: vfs_setxattr+0x141/0x2f0 fs/xattr.c:302 #3: ffff88805f122378 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x40c/0x11e0 fs/ocfs2/xattr.c:3587 stack backtrace: CPU: 0 PID: 12843 Comm: syz.5.2769 Not tainted syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025 Call Trace: dump_stack_lvl+0x168/0x230 lib/dump_stack.c:106 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 inode_lock include/linux/fs.h:787 [inline] ocfs2_xattr_set+0xad6/0x11e0 fs/ocfs2/xattr.c:3626 __vfs_setxattr+0x3e0/0x420 fs/xattr.c:182 __vfs_setxattr_noperm+0x129/0x5e0 fs/xattr.c:216 vfs_setxattr+0x168/0x2f0 fs/xattr.c:303 ovl_do_setxattr fs/overlayfs/overlayfs.h:214 [inline] ovl_setxattr fs/overlayfs/overlayfs.h:225 [inline] ovl_make_workdir fs/overlayfs/super.c:1422 [inline] ovl_get_workdir+0x948/0x11a0 fs/overlayfs/super.c:1526 ovl_fill_super+0x1925/0x2ae0 fs/overlayfs/super.c:2082 mount_nodev+0x52/0xe0 fs/super.c:1446 legacy_get_tree+0xe6/0x180 fs/fs_context.c:611 vfs_get_tree+0x88/0x270 fs/super.c:1530 do_new_mount+0x24a/0xa40 fs/namespace.c:3025 do_mount fs/namespace.c:3368 [inline] __do_sys_mount fs/namespace.c:3576 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3553 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7f2138447fc9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f21366af038 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007f213869efa0 RCX: 00007f2138447fc9 RDX: 0000200000000100 RSI: 00002000000000c0 RDI: 0000000000000000 RBP: 00007f21384caf91 R08: 0000200000000080 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007f213869f038 R14: 00007f213869efa0 R15: 00007ffc0ab5b548 overlayfs: upper fs missing required features.