====================================================== WARNING: possible circular locking dependency detected syzkaller #0 Not tainted ------------------------------------------------------ syz.0.2360/16603 is trying to acquire lock: ffff8880535442c0 (&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline] ffff8880535442c0 (&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_del_inode_from_orphan+0x112/0x700 fs/ocfs2/namei.c:2730 but task is already holding lock: ffff88804624a2e0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_dio_end_io_write+0x1a6/0xf30 fs/ocfs2/aops.c:2298 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}: down_write+0x92/0x200 kernel/locking/rwsem.c:1590 ocfs2_create_local_dquot+0x157/0xb30 fs/ocfs2/quota_local.c:1227 ocfs2_acquire_dquot+0x626/0xb00 fs/ocfs2/quota_global.c:883 dqget+0x693/0x1180 fs/quota/dquot.c:977 __dquot_initialize+0x586/0xd50 fs/quota/dquot.c:1505 ocfs2_get_init_inode+0xe7/0x1b0 fs/ocfs2/namei.c:205 ocfs2_mknod+0x974/0x2540 fs/ocfs2/namei.c:313 ocfs2_create+0x17c/0x460 fs/ocfs2/namei.c:676 vfs_create fs/namei.c:3405 [inline] vfs_create+0x4e0/0x7a0 fs/namei.c:3389 do_mknodat+0x3d3/0x5d0 fs/namei.c:4285 __do_sys_mknod fs/namei.c:4318 [inline] __se_sys_mknod fs/namei.c:4316 [inline] __x64_sys_mknod+0x87/0xb0 fs/namei.c:4316 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (&dquot->dq_lock){+.+.}-{4:4}: __mutex_lock_common kernel/locking/mutex.c:598 [inline] __mutex_lock+0x193/0x1060 kernel/locking/mutex.c:760 wait_on_dquot fs/quota/dquot.c:354 [inline] dqget+0x5f1/0x1180 fs/quota/dquot.c:972 __dquot_initialize+0x586/0xd50 fs/quota/dquot.c:1505 ocfs2_get_init_inode+0xe7/0x1b0 fs/ocfs2/namei.c:205 ocfs2_mknod+0x974/0x2540 fs/ocfs2/namei.c:313 ocfs2_create+0x17c/0x460 fs/ocfs2/namei.c:676 vfs_create fs/namei.c:3405 [inline] vfs_create+0x4e0/0x7a0 fs/namei.c:3389 do_mknodat+0x3d3/0x5d0 fs/namei.c:4285 __do_sys_mknod fs/namei.c:4318 [inline] __se_sys_mknod fs/namei.c:4316 [inline] __x64_sys_mknod+0x87/0xb0 fs/namei.c:4316 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}: down_write+0x92/0x200 kernel/locking/rwsem.c:1590 inode_lock include/linux/fs.h:869 [inline] ocfs2_remove_inode+0x15b/0x8a0 fs/ocfs2/inode.c:731 ocfs2_wipe_inode+0x446/0x1210 fs/ocfs2/inode.c:894 ocfs2_delete_inode fs/ocfs2/inode.c:1155 [inline] ocfs2_evict_inode+0x6e0/0x1680 fs/ocfs2/inode.c:1292 evict+0x3e6/0x920 fs/inode.c:810 iput_final fs/inode.c:1897 [inline] iput fs/inode.c:1923 [inline] iput+0x521/0x880 fs/inode.c:1909 ocfs2_dentry_iput+0x139/0x330 fs/ocfs2/dcache.c:407 dentry_unlink_inode+0x282/0x480 fs/dcache.c:464 __dentry_kill+0x1d0/0x600 fs/dcache.c:669 dput.part.0+0x4b1/0x9b0 fs/dcache.c:911 dput+0x1f/0x30 fs/dcache.c:901 do_renameat2+0x809/0xc50 fs/namei.c:5280 __do_sys_renameat2 fs/namei.c:5312 [inline] __se_sys_renameat2 fs/namei.c:5309 [inline] __x64_sys_renameat2+0xe7/0x130 fs/namei.c:5309 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain kernel/locking/lockdep.c:3908 [inline] __lock_acquire+0x12a6/0x1ce0 kernel/locking/lockdep.c:5237 lock_acquire kernel/locking/lockdep.c:5868 [inline] lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5825 down_write+0x92/0x200 kernel/locking/rwsem.c:1590 inode_lock include/linux/fs.h:869 [inline] ocfs2_del_inode_from_orphan+0x112/0x700 fs/ocfs2/namei.c:2730 ocfs2_dio_end_io_write+0x2cb/0xf30 fs/ocfs2/aops.c:2306 ocfs2_dio_end_io+0x136/0x2c0 fs/ocfs2/aops.c:2404 dio_complete+0x224/0x970 fs/direct-io.c:281 __blockdev_direct_IO+0x3027/0x3c40 fs/direct-io.c:1303 ocfs2_direct_IO+0x263/0x360 fs/ocfs2/aops.c:2441 generic_file_direct_write+0x19a/0x410 mm/filemap.c:4109 __generic_file_write_iter+0x11b/0x240 mm/filemap.c:4278 ocfs2_file_write_iter+0xbc4/0x21b0 fs/ocfs2/file.c:2469 iter_file_splice_write+0xa24/0x12e0 fs/splice.c:738 do_splice_from fs/splice.c:938 [inline] direct_splice_actor+0x192/0x6c0 fs/splice.c:1161 splice_direct_to_actor+0x345/0xa30 fs/splice.c:1105 do_splice_direct_actor fs/splice.c:1204 [inline] do_splice_direct+0x174/0x240 fs/splice.c:1230 do_sendfile+0xb06/0xe50 fs/read_write.c:1370 __do_sys_sendfile64 fs/read_write.c:1431 [inline] __se_sys_sendfile64 fs/read_write.c:1417 [inline] __x64_sys_sendfile64+0x1d8/0x220 fs/read_write.c:1417 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE] --> &dquot->dq_lock --> &ocfs2_quota_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_quota_ip_alloc_sem_key); lock(&dquot->dq_lock); lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]); *** DEADLOCK *** 3 locks held by syz.0.2360/16603: #0: ffff888025bac428 (sb_writers#13){.+.+}-{0:0}, at: splice_direct_to_actor+0x345/0xa30 fs/splice.c:1105 #1: ffff88804624a640 (&sb->s_type->i_mutex_key#20){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline] #1: ffff88804624a640 (&sb->s_type->i_mutex_key#20){+.+.}-{4:4}, at: ocfs2_file_write_iter+0x11cd/0x21b0 fs/ocfs2/file.c:2399 #2: ffff88804624a2e0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_dio_end_io_write+0x1a6/0xf30 fs/ocfs2/aops.c:2298 stack backtrace: CPU: 0 UID: 0 PID: 16603 Comm: syz.0.2360 Not tainted syzkaller #0 PREEMPT(full) Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120 print_circular_bug+0x275/0x350 kernel/locking/lockdep.c:2043 check_noncircular+0x14c/0x170 kernel/locking/lockdep.c:2175 check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain kernel/locking/lockdep.c:3908 [inline] __lock_acquire+0x12a6/0x1ce0 kernel/locking/lockdep.c:5237 lock_acquire kernel/locking/lockdep.c:5868 [inline] lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5825 down_write+0x92/0x200 kernel/locking/rwsem.c:1590 inode_lock include/linux/fs.h:869 [inline] ocfs2_del_inode_from_orphan+0x112/0x700 fs/ocfs2/namei.c:2730 ocfs2_dio_end_io_write+0x2cb/0xf30 fs/ocfs2/aops.c:2306 ocfs2_dio_end_io+0x136/0x2c0 fs/ocfs2/aops.c:2404 dio_complete+0x224/0x970 fs/direct-io.c:281 __blockdev_direct_IO+0x3027/0x3c40 fs/direct-io.c:1303 ocfs2_direct_IO+0x263/0x360 fs/ocfs2/aops.c:2441 generic_file_direct_write+0x19a/0x410 mm/filemap.c:4109 __generic_file_write_iter+0x11b/0x240 mm/filemap.c:4278 ocfs2_file_write_iter+0xbc4/0x21b0 fs/ocfs2/file.c:2469 iter_file_splice_write+0xa24/0x12e0 fs/splice.c:738 do_splice_from fs/splice.c:938 [inline] direct_splice_actor+0x192/0x6c0 fs/splice.c:1161 splice_direct_to_actor+0x345/0xa30 fs/splice.c:1105 do_splice_direct_actor fs/splice.c:1204 [inline] do_splice_direct+0x174/0x240 fs/splice.c:1230 do_sendfile+0xb06/0xe50 fs/read_write.c:1370 __do_sys_sendfile64 fs/read_write.c:1431 [inline] __se_sys_sendfile64 fs/read_write.c:1417 [inline] __x64_sys_sendfile64+0x1d8/0x220 fs/read_write.c:1417 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7ff602f8ebe9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ff603dd2038 EFLAGS: 00000246 ORIG_RAX: 0000000000000028 RAX: ffffffffffffffda RBX: 00007ff6031b5fa0 RCX: 00007ff602f8ebe9 RDX: 0000000000000000 RSI: 0000000000000006 RDI: 0000000000000005 RBP: 00007ff603011e19 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000020fffe82 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ff6031b6038 R14: 00007ff6031b5fa0 R15: 00007ffd55b70dc8