======================================================
WARNING: possible circular locking dependency detected
6.15.0-rc2-syzkaller-gc72692105976 #0 Not tainted
------------------------------------------------------
syz.0.117/7369 is trying to acquire lock:
ffff0000d8c238f8 (&sbi->alloc_mutex){+.+.}-{4:4}, at: hfsplus_block_allocate+0x8c/0x728 fs/hfsplus/bitmap.c:35

but task is already holding lock:
ffff0000d4c587c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_extend+0x1d0/0x1544 fs/hfsplus/extents.c:458

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}:
       __mutex_lock_common+0x1f0/0x2604 kernel/locking/mutex.c:601
       __mutex_lock kernel/locking/mutex.c:746 [inline]
       mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:798
       hfsplus_get_block+0x2c4/0x1168 fs/hfsplus/extents.c:260
       block_read_full_folio+0x2e8/0x824 fs/buffer.c:2392
       hfsplus_read_folio+0x28/0x38 fs/hfsplus/inode.c:28
       filemap_read_folio+0x108/0x318 mm/filemap.c:2400
       do_read_cache_folio+0x368/0x5c0 mm/filemap.c:3884
       do_read_cache_page mm/filemap.c:3950 [inline]
       read_cache_page+0x6c/0x15c mm/filemap.c:3959
       read_mapping_page include/linux/pagemap.h:989 [inline]
       hfsplus_block_allocate+0xe4/0x728 fs/hfsplus/bitmap.c:37
       hfsplus_file_extend+0x7b4/0x1544 fs/hfsplus/extents.c:469
       hfsplus_get_block+0x398/0x1168 fs/hfsplus/extents.c:245
       __block_write_begin_int+0x4c4/0x1610 fs/buffer.c:2116
       block_write_begin fs/buffer.c:2227 [inline]
       cont_write_begin+0x634/0x984 fs/buffer.c:2566
       hfsplus_write_begin+0x7c/0xc4 fs/hfsplus/inode.c:46
       generic_perform_write+0x280/0x894 mm/filemap.c:4102
       __generic_file_write_iter+0xfc/0x204 mm/filemap.c:4219
       generic_file_write_iter+0x108/0x4b4 mm/filemap.c:4245
       new_sync_write fs/read_write.c:591 [inline]
       vfs_write+0x704/0xa9c fs/read_write.c:684
       ksys_write+0x15c/0x26c fs/read_write.c:736
       __do_sys_write fs/read_write.c:747 [inline]
       __se_sys_write fs/read_write.c:744 [inline]
       __arm64_sys_write+0x7c/0x90 fs/read_write.c:744
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #0 (&sbi->alloc_mutex){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3166 [inline]
       check_prevs_add kernel/locking/lockdep.c:3285 [inline]
       validate_chain kernel/locking/lockdep.c:3909 [inline]
       __lock_acquire+0x17b8/0x32c4 kernel/locking/lockdep.c:5235
       lock_acquire+0x150/0x2e8 kernel/locking/lockdep.c:5866
       __mutex_lock_common+0x1f0/0x2604 kernel/locking/mutex.c:601
       __mutex_lock kernel/locking/mutex.c:746 [inline]
       mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:798
       hfsplus_block_allocate+0x8c/0x728 fs/hfsplus/bitmap.c:35
       hfsplus_file_extend+0x7b4/0x1544 fs/hfsplus/extents.c:469
       hfsplus_bmap_reserve+0xec/0x474 fs/hfsplus/btree.c:358
       hfsplus_rename_cat+0x1ac/0xf30 fs/hfsplus/catalog.c:456
       hfsplus_rename+0x120/0x1b0 fs/hfsplus/dir.c:552
       vfs_rename+0x9bc/0xc84 fs/namei.c:5086
       do_renameat2+0x948/0xd94 fs/namei.c:5235
       __do_sys_renameat2 fs/namei.c:5269 [inline]
       __se_sys_renameat2 fs/namei.c:5266 [inline]
       __arm64_sys_renameat2+0xd8/0xf4 fs/namei.c:5266
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&sbi->alloc_mutex);
                               lock(&HFSPLUS_I(inode)->extents_lock);
  lock(&sbi->alloc_mutex);

 *** DEADLOCK ***

5 locks held by syz.0.117/7369:
 #0: ffff0000d0d2c420 (sb_writers#14){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:556
 #1: ffff0000d4c59738 (&type->i_mutex_dir_key#13/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:902 [inline]
 #1: ffff0000d4c59738 (&type->i_mutex_dir_key#13/1){+.+.}-{4:4}, at: lock_rename fs/namei.c:3230 [inline]
 #1: ffff0000d4c59738 (&type->i_mutex_dir_key#13/1){+.+.}-{4:4}, at: do_renameat2+0x4fc/0xd94 fs/namei.c:5181
 #2: ffff0000f8661738 (&sb->s_type->i_mutex_key#21){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
 #2: ffff0000f8661738 (&sb->s_type->i_mutex_key#21){+.+.}-{4:4}, at: vfs_rename+0x5e4/0xc84 fs/namei.c:5051
 #3: ffff0000ef5800b0 (&tree->tree_lock){+.+.}-{4:4}, at: hfsplus_find_init+0x144/0x1bc fs/hfsplus/bfind.c:28
 #4: ffff0000d4c587c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_extend+0x1d0/0x1544 fs/hfsplus/extents.c:458

stack backtrace:
CPU: 1 UID: 0 PID: 7369 Comm: syz.0.117 Not tainted 6.15.0-rc2-syzkaller-gc72692105976 #0 PREEMPT 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025
Call trace:
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:466 (C)
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0xe4/0x150 lib/dump_stack.c:120
 dump_stack+0x1c/0x1028 lib/dump_stack.c:129
 print_circular_bug+0x32c/0x334 kernel/locking/lockdep.c:2079
 check_noncircular+0x15c/0x178 kernel/locking/lockdep.c:2211
 check_prev_add kernel/locking/lockdep.c:3166 [inline]
 check_prevs_add kernel/locking/lockdep.c:3285 [inline]
 validate_chain kernel/locking/lockdep.c:3909 [inline]
 __lock_acquire+0x17b8/0x32c4 kernel/locking/lockdep.c:5235
 lock_acquire+0x150/0x2e8 kernel/locking/lockdep.c:5866
 __mutex_lock_common+0x1f0/0x2604 kernel/locking/mutex.c:601
 __mutex_lock kernel/locking/mutex.c:746 [inline]
 mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:798
 hfsplus_block_allocate+0x8c/0x728 fs/hfsplus/bitmap.c:35
 hfsplus_file_extend+0x7b4/0x1544 fs/hfsplus/extents.c:469
 hfsplus_bmap_reserve+0xec/0x474 fs/hfsplus/btree.c:358
 hfsplus_rename_cat+0x1ac/0xf30 fs/hfsplus/catalog.c:456
 hfsplus_rename+0x120/0x1b0 fs/hfsplus/dir.c:552
 vfs_rename+0x9bc/0xc84 fs/namei.c:5086
 do_renameat2+0x948/0xd94 fs/namei.c:5235
 __do_sys_renameat2 fs/namei.c:5269 [inline]
 __se_sys_renameat2 fs/namei.c:5266 [inline]
 __arm64_sys_renameat2+0xd8/0xf4 fs/namei.c:5266
 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
 invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600