======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.6.248/6415 is trying to acquire lock:
ffff88804f042650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_setattr+0xaa6/0x1cf0 fs/ocfs2/file.c:1263

but task is already holding lock:
ffff888049235be0 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_setattr+0xa97/0x1cf0 fs/ocfs2/file.c:1262

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&oi->ip_alloc_sem){+.+.}-{3:3}:
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ocfs2_try_remove_refcount_tree+0xb3/0x320 fs/ocfs2/refcounttree.c:932
       ocfs2_xattr_set+0x592/0x11e0 fs/ocfs2/xattr.c:3673
       ocfs2_set_acl+0x4e1/0x590 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x16f/0x270 fs/ocfs2/acl.c:285
       set_posix_acl fs/posix_acl.c:1160 [inline]
       posix_acl_xattr_set+0x387/0x3f0 fs/posix_acl.c:1189
       __vfs_removexattr+0x3b7/0x3f0 fs/xattr.c:479
       __vfs_removexattr_locked+0x1e4/0x230 fs/xattr.c:514
       vfs_removexattr+0x7d/0x1b0 fs/xattr.c:536
       ovl_do_removexattr fs/overlayfs/overlayfs.h:270 [inline]
       ovl_workdir_create+0x3fb/0x7a0 fs/overlayfs/super.c:821
       ovl_make_workdir fs/overlayfs/super.c:1389 [inline]
       ovl_get_workdir+0x388/0x1540 fs/overlayfs/super.c:1539
       ovl_fill_super+0x1925/0x2ae0 fs/overlayfs/super.c:2095
       mount_nodev+0x52/0xe0 fs/super.c:1489
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x24a/0xa40 fs/namespace.c:3078
       do_mount fs/namespace.c:3421 [inline]
       __do_sys_mount fs/namespace.c:3629 [inline]
       __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3606
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #3 (&oi->ip_xattr_sem){++++}-{3:3}:
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_init_acl+0x2fb/0x720 fs/ocfs2/acl.c:365
       ocfs2_mknod+0x1463/0x2350 fs/ocfs2/namei.c:410
       ocfs2_create+0x1b6/0x4a0 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3490 [inline]
       open_last_lookups fs/namei.c:3558 [inline]
       path_openat+0x1187/0x2e70 fs/namei.c:3788
       do_filp_open+0x1c1/0x3c0 fs/namei.c:3818
       do_sys_openat2+0x142/0x490 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __x64_sys_openat+0x135/0x160 fs/open.c:1345
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x1f49/0x2150 fs/jbd2/transaction.c:463
       jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:520
       jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:559
       ocfs2_start_trans+0x372/0x6c0 fs/ocfs2/journal.c:376
       ocfs2_mknod+0xe6a/0x2350 fs/ocfs2/namei.c:361
       ocfs2_create+0x1b6/0x4a0 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3490 [inline]
       open_last_lookups fs/namei.c:3558 [inline]
       path_openat+0x1187/0x2e70 fs/namei.c:3788
       do_filp_open+0x1c1/0x3c0 fs/namei.c:3818
       do_sys_openat2+0x142/0x490 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __x64_sys_openat+0x135/0x160 fs/open.c:1345
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x366/0x6c0 fs/ocfs2/journal.c:374
       ocfs2_mknod+0xe6a/0x2350 fs/ocfs2/namei.c:361
       ocfs2_create+0x1b6/0x4a0 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3490 [inline]
       open_last_lookups fs/namei.c:3558 [inline]
       path_openat+0x1187/0x2e70 fs/namei.c:3788
       do_filp_open+0x1c1/0x3c0 fs/namei.c:3818
       do_sys_openat2+0x142/0x490 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __x64_sys_openat+0x135/0x160 fs/open.c:1345
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (sb_internal#5){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
       lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x267/0x6c0 fs/ocfs2/journal.c:372
       ocfs2_setattr+0xaa6/0x1cf0 fs/ocfs2/file.c:1263
       notify_change+0xc74/0xf40 fs/attr.c:499
       ovl_do_notify_change fs/overlayfs/overlayfs.h:142 [inline]
       ovl_workdir_create+0x5e1/0x7a0 fs/overlayfs/super.c:833
       ovl_make_workdir fs/overlayfs/super.c:1389 [inline]
       ovl_get_workdir+0x388/0x1540 fs/overlayfs/super.c:1539
       ovl_fill_super+0x1925/0x2ae0 fs/overlayfs/super.c:2095
       mount_nodev+0x52/0xe0 fs/super.c:1489
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x24a/0xa40 fs/namespace.c:3078
       do_mount fs/namespace.c:3421 [inline]
       __do_sys_mount fs/namespace.c:3629 [inline]
       __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3606
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  sb_internal#5 --> &oi->ip_xattr_sem --> &oi->ip_alloc_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_alloc_sem);
                               lock(&oi->ip_xattr_sem);
                               lock(&oi->ip_alloc_sem);
  lock(sb_internal#5);

 *** DEADLOCK ***

5 locks held by syz.6.248/6415:
 #0: ffff888078ea40e0 (&type->s_umount_key#60/1){+.+.}-{3:3}, at: alloc_super+0x1fa/0x930 fs/super.c:228
 #1: ffff88804f042460 (sb_writers#28){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:402
 #2: ffff888049235108 (&sb->s_type->i_mutex_key#34/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline]
 #2: ffff888049235108 (&sb->s_type->i_mutex_key#34/1){+.+.}-{3:3}, at: ovl_workdir_create+0x150/0x7a0 fs/overlayfs/super.c:771
 #3: ffff888049235f48 (&sb->s_type->i_mutex_key#34){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #3: ffff888049235f48 (&sb->s_type->i_mutex_key#34){+.+.}-{3:3}, at: ovl_workdir_create+0x55a/0x7a0 fs/overlayfs/super.c:832
 #4: ffff888049235be0 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_setattr+0xa97/0x1cf0 fs/ocfs2/file.c:1262

stack backtrace:
CPU: 1 PID: 6415 Comm: syz.6.248 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x22e lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
 lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1891 [inline]
 sb_start_intwrite include/linux/fs.h:2013 [inline]
 ocfs2_start_trans+0x267/0x6c0 fs/ocfs2/journal.c:372
 ocfs2_setattr+0xaa6/0x1cf0 fs/ocfs2/file.c:1263
 notify_change+0xc74/0xf40 fs/attr.c:499
 ovl_do_notify_change fs/overlayfs/overlayfs.h:142 [inline]
 ovl_workdir_create+0x5e1/0x7a0 fs/overlayfs/super.c:833
 ovl_make_workdir fs/overlayfs/super.c:1389 [inline]
 ovl_get_workdir+0x388/0x1540 fs/overlayfs/super.c:1539
 ovl_fill_super+0x1925/0x2ae0 fs/overlayfs/super.c:2095
 mount_nodev+0x52/0xe0 fs/super.c:1489
 legacy_get_tree+0xe6/0x180 fs/fs_context.c:632
 vfs_get_tree+0x88/0x270 fs/super.c:1573
 do_new_mount+0x24a/0xa40 fs/namespace.c:3078
 do_mount fs/namespace.c:3421 [inline]
 __do_sys_mount fs/namespace.c:3629 [inline]
 __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3606
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f250098efc9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f250181b038 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f2500be5fa0 RCX: 00007f250098efc9
RDX: 0000200000000440 RSI: 0000200000000100 RDI: 0000000000000000
RBP: 00007f2500a11f91 R08: 0000200000000200 R09: 0000000000000000
R10: 0000000000000008 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f2500be6038 R14: 00007f2500be5fa0 R15: 00007ffdd4203c98
 </TASK>
overlayfs: upper fs does not support tmpfile.
overlayfs: upper fs does not support RENAME_WHITEOUT.
------------[ cut here ]------------
kernel BUG at fs/ocfs2/suballoc.c:1387!
invalid opcode: 0000 [#1] PREEMPT SMP KASAN
CPU: 0 PID: 6415 Comm: syz.6.248 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025
RIP: 0010:ocfs2_find_victim_chain fs/ocfs2/suballoc.c:1387 [inline]
RIP: 0010:ocfs2_claim_suballoc_bits+0x2153/0x22d0 fs/ocfs2/suballoc.c:1927
Code: b3 92 8a fe e9 66 fb ff ff e8 49 63 3a fe 0f 0b e8 42 63 3a fe 0f 0b e8 3b 63 3a fe 0f 0b e8 34 63 3a fe 0f 0b e8 2d 63 3a fe <0f> 0b e8 26 63 3a fe 0f 0b 4d 89 f4 65 44 8b 35 59 a6 bb 7c 48 c7
RSP: 0018:ffffc90003d86820 EFLAGS: 00010246

RAX: ffffffff83467333 RBX: 0000000000000000 RCX: 0000000000080000
RDX: ffffc9000c8d9000 RSI: 000000000007ffff RDI: 0000000000080000
RBP: ffffc90003d86ab0 R08: ffffc90003d86b40 R09: ffffc90003d86b40
R10: fffff520007b0d6c R11: 1ffff920007b0d68 R12: ffff888047e9ae00
R13: ffff8880282f3308 R14: 0000000000000255 R15: dffffc0000000000
FS:  00007f250181b6c0(0000) GS:ffff8880b8e00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fc993556a10 CR3: 00000000242ab000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 __ocfs2_claim_clusters+0x2fe/0x900 fs/ocfs2/suballoc.c:2338
 ocfs2_claim_clusters fs/ocfs2/suballoc.c:2375 [inline]
 ocfs2_block_group_alloc_contig fs/ocfs2/suballoc.c:428 [inline]
 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:695 [inline]
 ocfs2_reserve_suballoc_bits+0xf04/0x4630 fs/ocfs2/suballoc.c:828
 ocfs2_reserve_new_metadata_blocks+0x400/0x940 fs/ocfs2/suballoc.c:978
 ocfs2_init_xattr_set_ctxt+0x2f8/0x750 fs/ocfs2/xattr.c:3281
 ocfs2_xattr_set+0xb69/0x11e0 fs/ocfs2/xattr.c:3638
 __vfs_setxattr+0x3e0/0x420 fs/xattr.c:182
 __vfs_setxattr_noperm+0x129/0x5e0 fs/xattr.c:216
 vfs_setxattr+0x168/0x2f0 fs/xattr.c:309
 ovl_do_setxattr fs/overlayfs/overlayfs.h:252 [inline]
 ovl_setxattr fs/overlayfs/overlayfs.h:264 [inline]
 ovl_make_workdir fs/overlayfs/super.c:1435 [inline]
 ovl_get_workdir+0xc18/0x1540 fs/overlayfs/super.c:1539
 ovl_fill_super+0x1925/0x2ae0 fs/overlayfs/super.c:2095
 mount_nodev+0x52/0xe0 fs/super.c:1489
 legacy_get_tree+0xe6/0x180 fs/fs_context.c:632
 vfs_get_tree+0x88/0x270 fs/super.c:1573
 do_new_mount+0x24a/0xa40 fs/namespace.c:3078
 do_mount fs/namespace.c:3421 [inline]
 __do_sys_mount fs/namespace.c:3629 [inline]
 __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3606
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f250098efc9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f250181b038 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f2500be5fa0 RCX: 00007f250098efc9
RDX: 0000200000000440 RSI: 0000200000000100 RDI: 0000000000000000
RBP: 00007f2500a11f91 R08: 0000200000000200 R09: 0000000000000000
R10: 0000000000000008 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f2500be6038 R14: 00007f2500be5fa0 R15: 00007ffdd4203c98
 </TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:ocfs2_find_victim_chain fs/ocfs2/suballoc.c:1387 [inline]
RIP: 0010:ocfs2_claim_suballoc_bits+0x2153/0x22d0 fs/ocfs2/suballoc.c:1927
Code: b3 92 8a fe e9 66 fb ff ff e8 49 63 3a fe 0f 0b e8 42 63 3a fe 0f 0b e8 3b 63 3a fe 0f 0b e8 34 63 3a fe 0f 0b e8 2d 63 3a fe <0f> 0b e8 26 63 3a fe 0f 0b 4d 89 f4 65 44 8b 35 59 a6 bb 7c 48 c7
RSP: 0018:ffffc90003d86820 EFLAGS: 00010246
RAX: ffffffff83467333 RBX: 0000000000000000 RCX: 0000000000080000
RDX: ffffc9000c8d9000 RSI: 000000000007ffff RDI: 0000000000080000
RBP: ffffc90003d86ab0 R08: ffffc90003d86b40 R09: ffffc90003d86b40
R10: fffff520007b0d6c R11: 1ffff920007b0d68 R12: ffff888047e9ae00
R13: ffff8880282f3308 R14: 0000000000000255 R15: dffffc0000000000
FS:  00007f250181b6c0(0000) GS:ffff8880b8f00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f2d9d1b3ad8 CR3: 00000000242ab000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400