====================================================== WARNING: possible circular locking dependency detected 6.1.139-syzkaller #0 Not tainted ------------------------------------------------------ syz.9.779/10405 is trying to acquire lock: ffff0000f675cae0 (&sdp->sd_quota_mutex){+.+.}-{3:3}, at: do_qc+0xb8/0x648 fs/gfs2/quota.c:682 but task is already holding lock: ffff0000fce69358 (&ip->i_rw_mutex){++++}-{3:3}, at: __gfs2_iomap_alloc+0x1e8/0x13e0 fs/gfs2/bmap.c:679 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ip->i_rw_mutex){++++}-{3:3}: down_read+0x64/0x304 kernel/locking/rwsem.c:1520 __gfs2_iomap_get+0x10c/0x100c fs/gfs2/bmap.c:856 gfs2_iomap_get+0xc0/0x120 fs/gfs2/bmap.c:1396 bh_get+0x1d8/0x5e4 fs/gfs2/quota.c:385 qdsb_get+0x1d4/0x37c fs/gfs2/quota.c:522 gfs2_quota_hold+0x16c/0x558 fs/gfs2/quota.c:608 gfs2_quota_lock+0xbc/0x748 fs/gfs2/quota.c:1076 gfs2_quota_lock_check fs/gfs2/quota.h:50 [inline] alloc_dinode+0x130/0x3fc fs/gfs2/inode.c:393 gfs2_create_inode+0xa20/0x10d4 fs/gfs2/inode.c:711 gfs2_atomic_open+0xc8/0x1c4 fs/gfs2/inode.c:1292 atomic_open fs/namei.c:3345 [inline] lookup_open fs/namei.c:3453 [inline] open_last_lookups fs/namei.c:3550 [inline] path_openat+0xb40/0x2680 fs/namei.c:3780 do_filp_open+0x174/0x344 fs/namei.c:3810 do_sys_openat2+0x128/0x3d8 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __arm64_sys_openat+0x120/0x154 fs/open.c:1345 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #0 (&sdp->sd_quota_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x293c/0x6544 kernel/locking/lockdep.c:5049 lock_acquire+0x20c/0x644 kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x1f38 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 do_qc+0xb8/0x648 fs/gfs2/quota.c:682 gfs2_quota_change+0x238/0x718 fs/gfs2/quota.c:1295 gfs2_alloc_blocks+0x13bc/0x1abc fs/gfs2/rgrp.c:2494 __gfs2_iomap_alloc+0x37c/0x13e0 fs/gfs2/bmap.c:705 gfs2_iomap_begin_write fs/gfs2/bmap.c:1047 [inline] gfs2_iomap_begin+0x964/0x12a8 fs/gfs2/bmap.c:1112 iomap_iter+0x5d4/0x10ec fs/iomap/iter.c:91 iomap_file_buffered_write+0x17c/0x680 fs/iomap/buffered-io.c:846 gfs2_file_buffered_write+0x488/0x7e8 fs/gfs2/file.c:1057 gfs2_file_write_iter+0x40c/0xc58 fs/gfs2/file.c:1158 call_write_iter include/linux/fs.h:2265 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x5ac/0x7c4 fs/read_write.c:584 ksys_pwrite64 fs/read_write.c:699 [inline] __do_sys_pwrite64 fs/read_write.c:709 [inline] __se_sys_pwrite64 fs/read_write.c:706 [inline] __arm64_sys_pwrite64+0x170/0x200 fs/read_write.c:706 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); *** DEADLOCK *** 5 locks held by syz.9.779/10405: #0: ffff0000d2ed0460 (sb_writers#33){.+.+}-{0:0}, at: vfs_write+0x23c/0x7c4 fs/read_write.c:580 #1: ffff0000fce68ec0 (&sb->s_type->i_mutex_key#32){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #1: ffff0000fce68ec0 (&sb->s_type->i_mutex_key#32){+.+.}-{3:3}, at: gfs2_file_write_iter+0x2f8/0xc58 fs/gfs2/file.c:1115 #2: ffff0000d2ed0650 (sb_internal#5){.+.+}-{0:0}, at: gfs2_trans_begin+0xa8/0x114 fs/gfs2/trans.c:118 #3: ffff0000f675d058 (&sdp->sd_log_flush_lock){.+.+}-{3:3}, at: __gfs2_trans_begin+0x4f0/0x85c fs/gfs2/trans.c:87 #4: ffff0000fce69358 (&ip->i_rw_mutex){++++}-{3:3}, at: __gfs2_iomap_alloc+0x1e8/0x13e0 fs/gfs2/bmap.c:679 stack backtrace: CPU: 0 PID: 10405 Comm: syz.9.779 Not tainted 6.1.139-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack+0x30/0x40 lib/dump_stack.c:88 dump_stack_lvl+0xf8/0x160 lib/dump_stack.c:106 dump_stack+0x1c/0x5c lib/dump_stack.c:113 print_circular_bug+0x148/0x1b0 kernel/locking/lockdep.c:2048 check_noncircular+0x240/0x2d4 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x293c/0x6544 kernel/locking/lockdep.c:5049 lock_acquire+0x20c/0x644 kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x1f38 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 do_qc+0xb8/0x648 fs/gfs2/quota.c:682 gfs2_quota_change+0x238/0x718 fs/gfs2/quota.c:1295 gfs2_alloc_blocks+0x13bc/0x1abc fs/gfs2/rgrp.c:2494 __gfs2_iomap_alloc+0x37c/0x13e0 fs/gfs2/bmap.c:705 gfs2_iomap_begin_write fs/gfs2/bmap.c:1047 [inline] gfs2_iomap_begin+0x964/0x12a8 fs/gfs2/bmap.c:1112 iomap_iter+0x5d4/0x10ec fs/iomap/iter.c:91 iomap_file_buffered_write+0x17c/0x680 fs/iomap/buffered-io.c:846 gfs2_file_buffered_write+0x488/0x7e8 fs/gfs2/file.c:1057 gfs2_file_write_iter+0x40c/0xc58 fs/gfs2/file.c:1158 call_write_iter include/linux/fs.h:2265 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x5ac/0x7c4 fs/read_write.c:584 ksys_pwrite64 fs/read_write.c:699 [inline] __do_sys_pwrite64 fs/read_write.c:709 [inline] __se_sys_pwrite64 fs/read_write.c:706 [inline] __arm64_sys_pwrite64+0x170/0x200 fs/read_write.c:706 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585