vxcan0: j1939_tp_rxtimer: 0x0000000039464c6b: abort rx timeout. Force session deactivation
======================================================
WARNING: possible circular locking dependency detected
5.15.135-syzkaller #0 Not tainted
------------------------------------------------------
syz-fuzzer/3998 is trying to acquire lock:
ffff0000dc2a5088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:368 [inline]
ffff0000dc2a5088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
ffff0000dc2a5088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_activate+0x60/0x388 net/can/j1939/transport.c:1564

but task is already holding lock:
ffff0000d84ce5d0 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:368 [inline]
ffff0000d84ce5d0 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: j1939_sk_queue_activate_next+0x60/0x3b4 net/can/j1939/socket.c:207

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&jsk->sk_session_queue_lock){+.-.}-{2:2}:
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
       _raw_spin_lock_bh+0x124/0x1c4 kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:368 [inline]
       j1939_sk_queue_drop_all+0x4c/0x200 net/can/j1939/socket.c:139
       j1939_sk_netdev_event_netdown+0xe0/0x144 net/can/j1939/socket.c:1280
       j1939_netdev_notify+0xf0/0x144 net/can/j1939/main.c:377
       notifier_call_chain kernel/notifier.c:83 [inline]
       raw_notifier_call_chain+0xd4/0x164 kernel/notifier.c:391
       __dev_notify_flags+0x2ac/0x534
       dev_change_flags+0xc8/0x154 net/core/dev.c:8863
       do_setlink+0xaa4/0x3164 net/core/rtnetlink.c:2741
       __rtnl_newlink net/core/rtnetlink.c:3429 [inline]
       rtnl_newlink+0x12fc/0x1af4 net/core/rtnetlink.c:3549
       rtnetlink_rcv_msg+0xa74/0xdac net/core/rtnetlink.c:5630
       netlink_rcv_skb+0x20c/0x3b8 net/netlink/af_netlink.c:2505
       rtnetlink_rcv+0x28/0x38 net/core/rtnetlink.c:5648
       netlink_unicast_kernel net/netlink/af_netlink.c:1330 [inline]
       netlink_unicast+0x664/0x938 net/netlink/af_netlink.c:1356
       netlink_sendmsg+0x844/0xb38 net/netlink/af_netlink.c:1924
       sock_sendmsg_nosec net/socket.c:704 [inline]
       __sock_sendmsg net/socket.c:716 [inline]
       ____sys_sendmsg+0x584/0x870 net/socket.c:2429
       ___sys_sendmsg+0x214/0x294 net/socket.c:2483
       __sys_sendmsg net/socket.c:2512 [inline]
       __do_sys_sendmsg net/socket.c:2521 [inline]
       __se_sys_sendmsg net/socket.c:2519 [inline]
       __arm64_sys_sendmsg+0x1ac/0x25c net/socket.c:2519
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:596
       el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:614
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #1 (&priv->j1939_socks_lock){+.-.}-{2:2}:
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
       _raw_spin_lock_bh+0x124/0x1c4 kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:368 [inline]
       j1939_sk_errqueue+0x90/0x144 net/can/j1939/socket.c:1081
       __j1939_session_release net/can/j1939/transport.c:294 [inline]
       kref_put include/linux/kref.h:65 [inline]
       j1939_session_put+0xf8/0x4f0 net/can/j1939/transport.c:299
       j1939_session_deactivate_locked net/can/j1939/transport.c:1086 [inline]
       j1939_cancel_active_session+0x2ec/0x414 net/can/j1939/transport.c:2194
       j1939_netdev_notify+0xe8/0x144 net/can/j1939/main.c:376
       notifier_call_chain kernel/notifier.c:83 [inline]
       raw_notifier_call_chain+0xd4/0x164 kernel/notifier.c:391
       __dev_notify_flags+0x2ac/0x534
       dev_change_flags+0xc8/0x154 net/core/dev.c:8863
       do_setlink+0xaa4/0x3164 net/core/rtnetlink.c:2741
       __rtnl_newlink net/core/rtnetlink.c:3429 [inline]
       rtnl_newlink+0x12fc/0x1af4 net/core/rtnetlink.c:3549
       rtnetlink_rcv_msg+0xa74/0xdac net/core/rtnetlink.c:5630
       netlink_rcv_skb+0x20c/0x3b8 net/netlink/af_netlink.c:2505
       rtnetlink_rcv+0x28/0x38 net/core/rtnetlink.c:5648
       netlink_unicast_kernel net/netlink/af_netlink.c:1330 [inline]
       netlink_unicast+0x664/0x938 net/netlink/af_netlink.c:1356
       netlink_sendmsg+0x844/0xb38 net/netlink/af_netlink.c:1924
       sock_sendmsg_nosec net/socket.c:704 [inline]
       __sock_sendmsg net/socket.c:716 [inline]
       ____sys_sendmsg+0x584/0x870 net/socket.c:2429
       ___sys_sendmsg+0x214/0x294 net/socket.c:2483
       __sys_sendmsg net/socket.c:2512 [inline]
       __do_sys_sendmsg net/socket.c:2521 [inline]
       __se_sys_sendmsg net/socket.c:2519 [inline]
       __arm64_sys_sendmsg+0x1ac/0x25c net/socket.c:2519
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:596
       el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:614
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #0 (&priv->active_session_list_lock){+.-.}-{2:2}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3787 [inline]
       __lock_acquire+0x32cc/0x7620 kernel/locking/lockdep.c:5011
       lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5622
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
       _raw_spin_lock_bh+0x124/0x1c4 kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:368 [inline]
       j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
       j1939_session_activate+0x60/0x388 net/can/j1939/transport.c:1564
       j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline]
       j1939_sk_queue_activate_next+0x230/0x3b4 net/can/j1939/socket.c:208
       j1939_session_deactivate_activate_next net/can/j1939/transport.c:1108 [inline]
       j1939_tp_rxtimer+0x198/0x36c net/can/j1939/transport.c:1236
       __run_hrtimer kernel/time/hrtimer.c:1685 [inline]
       __hrtimer_run_queues+0x484/0xca4 kernel/time/hrtimer.c:1749
       hrtimer_run_softirq+0x158/0x220 kernel/time/hrtimer.c:1766
       __do_softirq+0x344/0xe20 kernel/softirq.c:558
       do_softirq_own_stack include/asm-generic/softirq_stack.h:10 [inline]
       invoke_softirq kernel/softirq.c:439 [inline]
       __irq_exit_rcu+0x28c/0x534 kernel/softirq.c:637
       irq_exit+0x14/0x88 kernel/softirq.c:661
       handle_domain_irq+0xf4/0x178 kernel/irq/irqdesc.c:710
       gic_handle_irq+0x78/0x1c8 drivers/irqchip/irq-gic-v3.c:758
       call_on_irq_stack+0x24/0x4c arch/arm64/kernel/entry.S:899
       do_interrupt_handler+0x74/0x94 arch/arm64/kernel/entry-common.c:267
       el0_interrupt+0x98/0x2d4 arch/arm64/kernel/entry-common.c:671
       __el0_irq_handler_common+0x18/0x24 arch/arm64/kernel/entry-common.c:678
       el0t_64_irq_handler+0x10/0x1c arch/arm64/kernel/entry-common.c:683
       el0t_64_irq+0x1a0/0x1a4 arch/arm64/kernel/entry.S:585

other info that might help us debug this:

Chain exists of:
  &priv->active_session_list_lock --> &priv->j1939_socks_lock --> &jsk->sk_session_queue_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&jsk->sk_session_queue_lock);
                               lock(&priv->j1939_socks_lock);
                               lock(&jsk->sk_session_queue_lock);
  lock(&priv->active_session_list_lock);

 *** DEADLOCK ***

1 lock held by syz-fuzzer/3998:
 #0: ffff0000d84ce5d0 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:368 [inline]
 #0: ffff0000d84ce5d0 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: j1939_sk_queue_activate_next+0x60/0x3b4 net/can/j1939/socket.c:207

stack backtrace:
CPU: 1 PID: 3998 Comm: syz-fuzzer Not tainted 5.15.135-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023
Call trace:
 dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
 dump_stack+0x1c/0x58 lib/dump_stack.c:113
 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011
 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3787 [inline]
 __lock_acquire+0x32cc/0x7620 kernel/locking/lockdep.c:5011
 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5622
 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
 _raw_spin_lock_bh+0x124/0x1c4 kernel/locking/spinlock.c:178
 spin_lock_bh include/linux/spinlock.h:368 [inline]
 j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
 j1939_session_activate+0x60/0x388 net/can/j1939/transport.c:1564
 j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline]
 j1939_sk_queue_activate_next+0x230/0x3b4 net/can/j1939/socket.c:208
 j1939_session_deactivate_activate_next net/can/j1939/transport.c:1108 [inline]
 j1939_tp_rxtimer+0x198/0x36c net/can/j1939/transport.c:1236
 __run_hrtimer kernel/time/hrtimer.c:1685 [inline]
 __hrtimer_run_queues+0x484/0xca4 kernel/time/hrtimer.c:1749
 hrtimer_run_softirq+0x158/0x220 kernel/time/hrtimer.c:1766
 __do_softirq+0x344/0xe20 kernel/softirq.c:558
 do_softirq_own_stack include/asm-generic/softirq_stack.h:10 [inline]
 invoke_softirq kernel/softirq.c:439 [inline]
 __irq_exit_rcu+0x28c/0x534 kernel/softirq.c:637
 irq_exit+0x14/0x88 kernel/softirq.c:661
 handle_domain_irq+0xf4/0x178 kernel/irq/irqdesc.c:710
 gic_handle_irq+0x78/0x1c8 drivers/irqchip/irq-gic-v3.c:758
 call_on_irq_stack+0x24/0x4c arch/arm64/kernel/entry.S:899
 do_interrupt_handler+0x74/0x94 arch/arm64/kernel/entry-common.c:267
 el0_interrupt+0x98/0x2d4 arch/arm64/kernel/entry-common.c:671
 __el0_irq_handler_common+0x18/0x24 arch/arm64/kernel/entry-common.c:678
 el0t_64_irq_handler+0x10/0x1c arch/arm64/kernel/entry-common.c:683
 el0t_64_irq+0x1a0/0x1a4 arch/arm64/kernel/entry.S:585