======================================================
WARNING: possible circular locking dependency detected
6.15.0-rc5-syzkaller #0 Not tainted
------------------------------------------------------
syz.6.190/8502 is trying to acquire lock:
ffff88804a6c80f8 (&sbi->alloc_mutex){+.+.}-{4:4}, at: hfsplus_block_free+0xc3/0x4c0 fs/hfsplus/bitmap.c:182

but task is already holding lock:
ffff888029a5b708 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_truncate+0x294/0xb40 fs/hfsplus/extents.c:577

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       __mutex_lock_common kernel/locking/mutex.c:601 [inline]
       __mutex_lock+0x182/0xe80 kernel/locking/mutex.c:746
       hfsplus_get_block+0x39e/0x1530 fs/hfsplus/extents.c:260
       block_read_full_folio+0x29c/0x830 fs/buffer.c:2427
       filemap_read_folio+0x114/0x380 mm/filemap.c:2401
       do_read_cache_folio+0x354/0x590 mm/filemap.c:3885
       do_read_cache_page mm/filemap.c:3951 [inline]
       read_cache_page+0x5d/0x170 mm/filemap.c:3960
       read_mapping_page include/linux/pagemap.h:989 [inline]
       hfsplus_block_allocate+0xff/0x8e0 fs/hfsplus/bitmap.c:37
       hfsplus_file_extend+0xae3/0x1990 fs/hfsplus/extents.c:469
       hfsplus_get_block+0x411/0x1530 fs/hfsplus/extents.c:245
       __block_write_begin_int+0x6b2/0x1900 fs/buffer.c:2151
       block_write_begin fs/buffer.c:2262 [inline]
       cont_write_begin+0x789/0xb50 fs/buffer.c:2601
       hfsplus_write_begin+0x66/0xb0 fs/hfsplus/inode.c:46
       page_symlink+0x240/0x3d0 fs/namei.c:5480
       hfsplus_symlink+0xca/0x260 fs/hfsplus/dir.c:449
       vfs_symlink+0x140/0x2f0 fs/namei.c:4723
       do_symlinkat+0x1b1/0x3f0 fs/namei.c:4749
       __do_sys_symlink fs/namei.c:4770 [inline]
       __se_sys_symlink fs/namei.c:4768 [inline]
       __x64_sys_symlink+0x7a/0x90 fs/namei.c:4768
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&sbi->alloc_mutex){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3166 [inline]
       check_prevs_add kernel/locking/lockdep.c:3285 [inline]
       validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3909
       __lock_acquire+0xaac/0xd20 kernel/locking/lockdep.c:5235
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       __mutex_lock_common kernel/locking/mutex.c:601 [inline]
       __mutex_lock+0x182/0xe80 kernel/locking/mutex.c:746
       hfsplus_block_free+0xc3/0x4c0 fs/hfsplus/bitmap.c:182
       hfsplus_free_extents+0x176/0xae0 fs/hfsplus/extents.c:363
       hfsplus_file_truncate+0x736/0xb40 fs/hfsplus/extents.c:592
       hfsplus_setattr+0x1c4/0x270 fs/hfsplus/inode.c:264
       notify_change+0xb33/0xe40 fs/attr.c:552
       do_truncate+0x19a/0x220 fs/open.c:65
       vfs_truncate+0x493/0x520 fs/open.c:115
       do_sys_truncate+0xdb/0x190 fs/open.c:138
       __do_sys_truncate fs/open.c:150 [inline]
       __se_sys_truncate fs/open.c:148 [inline]
       __x64_sys_truncate+0x5b/0x70 fs/open.c:148
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&sbi->alloc_mutex);
                               lock(&HFSPLUS_I(inode)->extents_lock);
  lock(&sbi->alloc_mutex);

 *** DEADLOCK ***

3 locks held by syz.6.190/8502:
 #0: ffff88807e178420 (sb_writers#16){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:556
 #1: ffff888029a5b8f8 (&sb->s_type->i_mutex_key#23){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
 #1: ffff888029a5b8f8 (&sb->s_type->i_mutex_key#23){+.+.}-{4:4}, at: do_truncate+0x186/0x220 fs/open.c:63
 #2: ffff888029a5b708 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_truncate+0x294/0xb40 fs/hfsplus/extents.c:577

stack backtrace:
CPU: 1 UID: 0 PID: 8502 Comm: syz.6.190 Not tainted 6.15.0-rc5-syzkaller #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/29/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120
 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2079
 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2211
 check_prev_add kernel/locking/lockdep.c:3166 [inline]
 check_prevs_add kernel/locking/lockdep.c:3285 [inline]
 validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3909
 __lock_acquire+0xaac/0xd20 kernel/locking/lockdep.c:5235
 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
 __mutex_lock_common kernel/locking/mutex.c:601 [inline]
 __mutex_lock+0x182/0xe80 kernel/locking/mutex.c:746
 hfsplus_block_free+0xc3/0x4c0 fs/hfsplus/bitmap.c:182
 hfsplus_free_extents+0x176/0xae0 fs/hfsplus/extents.c:363
 hfsplus_file_truncate+0x736/0xb40 fs/hfsplus/extents.c:592
 hfsplus_setattr+0x1c4/0x270 fs/hfsplus/inode.c:264
 notify_change+0xb33/0xe40 fs/attr.c:552
 do_truncate+0x19a/0x220 fs/open.c:65
 vfs_truncate+0x493/0x520 fs/open.c:115
 do_sys_truncate+0xdb/0x190 fs/open.c:138
 __do_sys_truncate fs/open.c:150 [inline]
 __se_sys_truncate fs/open.c:148 [inline]
 __x64_sys_truncate+0x5b/0x70 fs/open.c:148
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f87f8d8e969
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f87f9b9b038 EFLAGS: 00000246 ORIG_RAX: 000000000000004c
RAX: ffffffffffffffda RBX: 00007f87f8fb6320 RCX: 00007f87f8d8e969
RDX: 0000000000000000 RSI: 0000000000000f00 RDI: 0000200000000000
RBP: 00007f87f8e10ab1 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f87f8fb6320 R15: 00007ffe85b05d48
 </TASK>
hfsplus: unable to mark blocks free: error -4
hfsplus: can't free extent