====================================================== WARNING: possible circular locking dependency detected 6.1.138-syzkaller #0 Not tainted ------------------------------------------------------ syz.4.297/5592 is trying to acquire lock: ffff0000e22d5108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] ffff0000e22d5108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x12c/0x3cd4 fs/ocfs2/suballoc.c:782 but task is already holding lock: ffff0000e2105c78 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x32c/0xe98 fs/ocfs2/xattr.c:3587 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #5 (&oi->ip_xattr_sem){++++}-{3:3}: down_read+0x64/0x304 kernel/locking/rwsem.c:1520 ocfs2_init_acl+0x258/0x5f0 fs/ocfs2/acl.c:365 ocfs2_mknod+0x1168/0x1f18 fs/ocfs2/namei.c:410 ocfs2_create+0x19c/0x4f0 fs/ocfs2/namei.c:674 lookup_open fs/namei.c:3482 [inline] open_last_lookups fs/namei.c:3550 [inline] path_openat+0x112c/0x2680 fs/namei.c:3780 do_filp_open+0x174/0x344 fs/namei.c:3810 do_sys_openat2+0x128/0x3d8 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __arm64_sys_openat+0x120/0x154 fs/open.c:1345 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #4 (jbd2_handle){++++}-{0:0}: start_this_handle+0xfe0/0x122c fs/jbd2/transaction.c:463 jbd2__journal_start+0x288/0x51c fs/jbd2/transaction.c:520 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:559 ocfs2_start_trans+0x380/0x6c4 fs/ocfs2/journal.c:354 ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline] ocfs2_reserve_local_alloc_bits+0xb8c/0x278c fs/ocfs2/localalloc.c:668 ocfs2_reserve_clusters_with_limit+0x198/0x9e0 fs/ocfs2/suballoc.c:1162 ocfs2_reserve_clusters+0x3c/0x50 fs/ocfs2/suballoc.c:1223 ocfs2_mknod+0xc2c/0x1f18 fs/ocfs2/namei.c:354 ocfs2_mkdir+0x19c/0x4f0 fs/ocfs2/namei.c:657 vfs_mkdir+0x314/0x4d4 fs/namei.c:4106 do_mkdirat+0x1b4/0x3e0 fs/namei.c:4131 __do_sys_mkdirat fs/namei.c:4146 [inline] __se_sys_mkdirat fs/namei.c:4144 [inline] __arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4144 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #3 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0x64/0x304 kernel/locking/rwsem.c:1520 ocfs2_start_trans+0x374/0x6c4 fs/ocfs2/journal.c:352 ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline] ocfs2_reserve_local_alloc_bits+0xb8c/0x278c fs/ocfs2/localalloc.c:668 ocfs2_reserve_clusters_with_limit+0x198/0x9e0 fs/ocfs2/suballoc.c:1162 ocfs2_reserve_clusters+0x3c/0x50 fs/ocfs2/suballoc.c:1223 ocfs2_mknod+0xc2c/0x1f18 fs/ocfs2/namei.c:354 ocfs2_mkdir+0x19c/0x4f0 fs/ocfs2/namei.c:657 vfs_mkdir+0x314/0x4d4 fs/namei.c:4106 do_mkdirat+0x1b4/0x3e0 fs/namei.c:4131 __do_sys_mkdirat fs/namei.c:4146 [inline] __se_sys_mkdirat fs/namei.c:4144 [inline] __arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4144 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #2 (sb_internal#6){.+.+}-{0:0}: percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1891 [inline] sb_start_intwrite include/linux/fs.h:2013 [inline] ocfs2_start_trans+0x20c/0x6c4 fs/ocfs2/journal.c:350 ocfs2_mknod+0xc7c/0x1f18 fs/ocfs2/namei.c:361 ocfs2_create+0x19c/0x4f0 fs/ocfs2/namei.c:674 lookup_open fs/namei.c:3482 [inline] open_last_lookups fs/namei.c:3550 [inline] path_openat+0x112c/0x2680 fs/namei.c:3780 do_filp_open+0x174/0x344 fs/namei.c:3810 do_sys_openat2+0x128/0x3d8 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __arm64_sys_openat+0x120/0x154 fs/open.c:1345 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}: down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_reserve_local_alloc_bits+0xf8/0x278c fs/ocfs2/localalloc.c:635 ocfs2_reserve_clusters_with_limit+0x198/0x9e0 fs/ocfs2/suballoc.c:1162 ocfs2_reserve_clusters+0x3c/0x50 fs/ocfs2/suballoc.c:1223 ocfs2_mknod+0xc2c/0x1f18 fs/ocfs2/namei.c:354 ocfs2_mkdir+0x19c/0x4f0 fs/ocfs2/namei.c:657 vfs_mkdir+0x314/0x4d4 fs/namei.c:4106 do_mkdirat+0x1b4/0x3e0 fs/namei.c:4131 __do_sys_mkdirat fs/namei.c:4146 [inline] __se_sys_mkdirat fs/namei.c:4144 [inline] __arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4144 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x293c/0x6544 kernel/locking/lockdep.c:5049 lock_acquire+0x20c/0x644 kernel/locking/lockdep.c:5662 down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_reserve_suballoc_bits+0x12c/0x3cd4 fs/ocfs2/suballoc.c:782 ocfs2_reserve_new_metadata_blocks+0x368/0x810 fs/ocfs2/suballoc.c:978 ocfs2_init_xattr_set_ctxt+0x300/0x7bc fs/ocfs2/xattr.c:3281 ocfs2_xattr_set+0x91c/0xe98 fs/ocfs2/xattr.c:3638 ocfs2_set_acl+0x3ec/0x4a0 fs/ocfs2/acl.c:254 ocfs2_iop_set_acl+0x174/0x240 fs/ocfs2/acl.c:285 set_posix_acl fs/posix_acl.c:1160 [inline] posix_acl_xattr_set+0x2f8/0x398 fs/posix_acl.c:1189 __vfs_setxattr+0x388/0x3a4 fs/xattr.c:182 __vfs_setxattr_noperm+0x120/0x564 fs/xattr.c:216 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277 vfs_setxattr+0x158/0x2ac fs/xattr.c:309 do_setxattr fs/xattr.c:594 [inline] setxattr+0x228/0x28c fs/xattr.c:617 __do_sys_fsetxattr fs/xattr.c:673 [inline] __se_sys_fsetxattr fs/xattr.c:662 [inline] __arm64_sys_fsetxattr+0x1a8/0x224 fs/xattr.c:662 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3 --> jbd2_handle --> &oi->ip_xattr_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->ip_xattr_sem); lock(jbd2_handle); lock(&oi->ip_xattr_sem); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3); *** DEADLOCK *** 3 locks held by syz.4.297/5592: #0: ffff0000dd084460 (sb_writers#23){.+.+}-{0:0}, at: mnt_want_write_file+0x64/0x1e8 fs/namespace.c:437 #1: ffff0000e2105f48 (&type->i_mutex_dir_key#15){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #1: ffff0000e2105f48 (&type->i_mutex_dir_key#15){++++}-{3:3}, at: vfs_setxattr+0x138/0x2ac fs/xattr.c:308 #2: ffff0000e2105c78 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x32c/0xe98 fs/ocfs2/xattr.c:3587 stack backtrace: CPU: 1 PID: 5592 Comm: syz.4.297 Not tainted 6.1.138-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack+0x30/0x40 lib/dump_stack.c:88 dump_stack_lvl+0xf8/0x160 lib/dump_stack.c:106 dump_stack+0x1c/0x5c lib/dump_stack.c:113 print_circular_bug+0x148/0x1b0 kernel/locking/lockdep.c:2048 check_noncircular+0x240/0x2d4 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x293c/0x6544 kernel/locking/lockdep.c:5049 lock_acquire+0x20c/0x644 kernel/locking/lockdep.c:5662 down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_reserve_suballoc_bits+0x12c/0x3cd4 fs/ocfs2/suballoc.c:782 ocfs2_reserve_new_metadata_blocks+0x368/0x810 fs/ocfs2/suballoc.c:978 ocfs2_init_xattr_set_ctxt+0x300/0x7bc fs/ocfs2/xattr.c:3281 ocfs2_xattr_set+0x91c/0xe98 fs/ocfs2/xattr.c:3638 ocfs2_set_acl+0x3ec/0x4a0 fs/ocfs2/acl.c:254 ocfs2_iop_set_acl+0x174/0x240 fs/ocfs2/acl.c:285 set_posix_acl fs/posix_acl.c:1160 [inline] posix_acl_xattr_set+0x2f8/0x398 fs/posix_acl.c:1189 __vfs_setxattr+0x388/0x3a4 fs/xattr.c:182 __vfs_setxattr_noperm+0x120/0x564 fs/xattr.c:216 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277 vfs_setxattr+0x158/0x2ac fs/xattr.c:309 do_setxattr fs/xattr.c:594 [inline] setxattr+0x228/0x28c fs/xattr.c:617 __do_sys_fsetxattr fs/xattr.c:673 [inline] __se_sys_fsetxattr fs/xattr.c:662 [inline] __arm64_sys_fsetxattr+0x1a8/0x224 fs/xattr.c:662 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585