ip_tables: iptables: counters copy to user failed while replacing table
hub 9-0:1.0: USB hub found
======================================================
WARNING: possible circular locking dependency detected
4.14.299-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.3/8016 is trying to acquire lock:
 (rtnl_mutex){+.+.}, at: [<ffffffff85c2f16e>] unregister_netdevice_notifier+0x5e/0x2b0 net/core/dev.c:1630

but task is already holding lock:
 (&xt[i].mutex){+.+.}, at: [<ffffffff85f1f908>] xt_find_table_lock+0x38/0x3d0 net/netfilter/x_tables.c:1088

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&xt[i].mutex){+.+.}:
       __mutex_lock_common kernel/locking/mutex.c:756 [inline]
       __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
       match_revfn+0x43/0x210 net/netfilter/x_tables.c:332
       xt_find_revision+0x8d/0x1d0 net/netfilter/x_tables.c:380
       nfnl_compat_get+0x1f7/0x870 net/netfilter/nft_compat.c:678
       nfnetlink_rcv_msg+0x9bb/0xc00 net/netfilter/nfnetlink.c:214
       netlink_rcv_skb+0x125/0x390 net/netlink/af_netlink.c:2454
       nfnetlink_rcv+0x1ab/0x1da0 net/netfilter/nfnetlink.c:515
       netlink_unicast_kernel net/netlink/af_netlink.c:1296 [inline]
       netlink_unicast+0x437/0x610 net/netlink/af_netlink.c:1322
       netlink_sendmsg+0x648/0xbc0 net/netlink/af_netlink.c:1893
       sock_sendmsg_nosec net/socket.c:646 [inline]
       sock_sendmsg+0xb5/0x100 net/socket.c:656
       ___sys_sendmsg+0x6c8/0x800 net/socket.c:2062
       __sys_sendmsg+0xa3/0x120 net/socket.c:2096
       SYSC_sendmsg net/socket.c:2107 [inline]
       SyS_sendmsg+0x27/0x40 net/socket.c:2103
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x5e/0xd3

-> #1 (&table[i].mutex){+.+.}:
       __mutex_lock_common kernel/locking/mutex.c:756 [inline]
       __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
       nf_tables_netdev_event+0x10d/0x4d0 net/netfilter/nf_tables_netdev.c:122
       notifier_call_chain+0x108/0x1a0 kernel/notifier.c:93
       call_netdevice_notifiers_info net/core/dev.c:1667 [inline]
       call_netdevice_notifiers net/core/dev.c:1683 [inline]
       rollback_registered_many+0x765/0xbb0 net/core/dev.c:7211
       rollback_registered+0xca/0x170 net/core/dev.c:7253
       unregister_netdevice_queue+0x1b4/0x360 net/core/dev.c:8274
       unregister_netdevice include/linux/netdevice.h:2444 [inline]
       __tun_detach+0xca2/0xf60 drivers/net/tun.c:584
       tun_detach drivers/net/tun.c:594 [inline]
       tun_chr_close+0x41/0x60 drivers/net/tun.c:2732
       __fput+0x25f/0x7a0 fs/file_table.c:210
       task_work_run+0x11f/0x190 kernel/task_work.c:113
       tracehook_notify_resume include/linux/tracehook.h:191 [inline]
       exit_to_usermode_loop+0x1ad/0x200 arch/x86/entry/common.c:164
       prepare_exit_to_usermode arch/x86/entry/common.c:199 [inline]
       syscall_return_slowpath arch/x86/entry/common.c:270 [inline]
       do_syscall_64+0x4a3/0x640 arch/x86/entry/common.c:297
       entry_SYSCALL_64_after_hwframe+0x5e/0xd3

-> #0 (rtnl_mutex){+.+.}:
       lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
       __mutex_lock_common kernel/locking/mutex.c:756 [inline]
       __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
       unregister_netdevice_notifier+0x5e/0x2b0 net/core/dev.c:1630
       tee_tg_destroy+0x5c/0xb0 net/netfilter/xt_TEE.c:123
       cleanup_entry+0x1fd/0x2d0 net/ipv4/netfilter/ip_tables.c:666
       __do_replace+0x38d/0x570 net/ipv4/netfilter/ip_tables.c:1086
       do_replace net/ipv4/netfilter/ip_tables.c:1142 [inline]
       do_ipt_set_ctl+0x256/0x3a0 net/ipv4/netfilter/ip_tables.c:1676
       nf_sockopt net/netfilter/nf_sockopt.c:106 [inline]
       nf_setsockopt+0x5f/0xb0 net/netfilter/nf_sockopt.c:115
       ip_setsockopt net/ipv4/ip_sockglue.c:1255 [inline]
       ip_setsockopt+0x94/0xb0 net/ipv4/ip_sockglue.c:1240
       tcp_setsockopt+0x7b/0xc0 net/ipv4/tcp.c:2831
       SYSC_setsockopt net/socket.c:1865 [inline]
       SyS_setsockopt+0x110/0x1e0 net/socket.c:1844
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x5e/0xd3

other info that might help us debug this:

Chain exists of:
  rtnl_mutex --> &table[i].mutex --> &xt[i].mutex

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&xt[i].mutex);
                               lock(&table[i].mutex);
                               lock(&xt[i].mutex);
  lock(rtnl_mutex);

 *** DEADLOCK ***

1 lock held by syz-executor.3/8016:
 #0:  (&xt[i].mutex){+.+.}, at: [<ffffffff85f1f908>] xt_find_table_lock+0x38/0x3d0 net/netfilter/x_tables.c:1088

stack backtrace:
CPU: 0 PID: 8016 Comm: syz-executor.3 Not tainted 4.14.299-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x1b2/0x281 lib/dump_stack.c:58
 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258
 check_prev_add kernel/locking/lockdep.c:1905 [inline]
 check_prevs_add kernel/locking/lockdep.c:2022 [inline]
 validate_chain kernel/locking/lockdep.c:2464 [inline]
 __lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491
 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
 __mutex_lock_common kernel/locking/mutex.c:756 [inline]
 __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
 unregister_netdevice_notifier+0x5e/0x2b0 net/core/dev.c:1630
 tee_tg_destroy+0x5c/0xb0 net/netfilter/xt_TEE.c:123
 cleanup_entry+0x1fd/0x2d0 net/ipv4/netfilter/ip_tables.c:666
 __do_replace+0x38d/0x570 net/ipv4/netfilter/ip_tables.c:1086
 do_replace net/ipv4/netfilter/ip_tables.c:1142 [inline]
 do_ipt_set_ctl+0x256/0x3a0 net/ipv4/netfilter/ip_tables.c:1676
 nf_sockopt net/netfilter/nf_sockopt.c:106 [inline]
 nf_setsockopt+0x5f/0xb0 net/netfilter/nf_sockopt.c:115
 ip_setsockopt net/ipv4/ip_sockglue.c:1255 [inline]
 ip_setsockopt+0x94/0xb0 net/ipv4/ip_sockglue.c:1240
 tcp_setsockopt+0x7b/0xc0 net/ipv4/tcp.c:2831
 SYSC_setsockopt net/socket.c:1865 [inline]
 SyS_setsockopt+0x110/0x1e0 net/socket.c:1844
 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
 entry_SYSCALL_64_after_hwframe+0x5e/0xd3
hub 9-0:1.0: 8 ports detected
usb usb9: usbfs: interface 0 claimed by hub while 'syz-executor.5' sets config #0
usb usb9: usbfs: interface 0 claimed by hub while 'syz-executor.4' sets config #0
usb usb9: usbfs: interface 0 claimed by usbfs while 'syz-executor.5' sets config #1
usb usb9: usbfs: interface 0 claimed by usbfs while 'syz-executor.4' sets config #1
ntfs: volume version 3.1.
ntfs: (device loop5): ntfs_cluster_alloc(): Failed to allocate clusters, aborting (error -28).
ntfs: (device loop5): ntfs_attr_extend_allocation(): Cannot extend allocation of inode 0x44, attribute type 0x80, because the allocation of clusters failed with error code -28.
Dev loop4: unable to read RDB block 1
 loop4:
loop4: partition table partially beyond EOD, truncated
ntfs: volume version 3.1.
ntfs: (device loop5): ntfs_cluster_alloc(): Failed to allocate clusters, aborting (error -28).
ntfs: (device loop5): ntfs_attr_extend_allocation(): Cannot extend allocation of inode 0x44, attribute type 0x80, because the allocation of clusters failed with error code -28.
Dev loop4: unable to read RDB block 1
 loop4:
loop4: partition table partially beyond EOD, truncated
ntfs: volume version 3.1.
Dev loop4: unable to read RDB block 1
 loop4:
ntfs: volume version 3.1.
loop4: partition table partially beyond EOD, truncated
ntfs: (device loop5): ntfs_cluster_alloc(): Failed to allocate clusters, aborting (error -28).
ntfs: (device loop5): ntfs_attr_extend_allocation(): Cannot extend allocation of inode 0x44, attribute type 0x80, because the allocation of clusters failed with error code -28.
unregister_netdevice: waiting for ip6gre0 to become free. Usage count = -1
Dev loop4: unable to read RDB block 1
 loop4:
loop4: partition table partially beyond EOD, truncated
BTRFS: device fsid 8ff932b8-f4e4-4b03-aed6-d7e5736fd60a devid 1 transid 8 /dev/loop4
BTRFS error (device loop4): unsupported checksum algorithm 1
BTRFS error (device loop4): superblock checksum mismatch
BTRFS error (device loop4): open_ctree failed