input: syz0 as /devices/virtual/input/input5 ====================================================== WARNING: possible circular locking dependency detected 6.15.0-rc1-syzkaller-00288-ge618ee89561b #0 Not tainted ------------------------------------------------------ syz.0.0/5326 is trying to acquire lock: ffff888012985870 (&newdev->mutex){+.+.}-{4:4}, at: uinput_request_send drivers/input/misc/uinput.c:151 [inline] ffff888012985870 (&newdev->mutex){+.+.}-{4:4}, at: uinput_request_submit+0x188/0x750 drivers/input/misc/uinput.c:182 but task is already holding lock: ffff888034f158b0 (&ff->mutex){+.+.}-{4:4}, at: class_mutex_constructor include/linux/mutex.h:201 [inline] ffff888034f158b0 (&ff->mutex){+.+.}-{4:4}, at: input_ff_upload+0x3f3/0xb30 drivers/input/ff-core.c:122 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&ff->mutex){+.+.}-{4:4}: lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866 __mutex_lock_common kernel/locking/mutex.c:601 [inline] __mutex_lock+0x1a5/0x10c0 kernel/locking/mutex.c:746 class_mutex_constructor include/linux/mutex.h:201 [inline] input_ff_flush+0x5e/0x150 drivers/input/ff-core.c:231 input_flush_device+0xb2/0xe0 drivers/input/input.c:627 evdev_release+0xf6/0x7d0 drivers/input/evdev.c:435 __fput+0x3e9/0x9f0 fs/file_table.c:465 fput_close_sync+0x1ef/0x270 fs/file_table.c:570 __do_sys_close fs/open.c:1581 [inline] __se_sys_close fs/open.c:1566 [inline] __x64_sys_close+0x7f/0x110 fs/open.c:1566 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (&dev->mutex#2){+.+.}-{4:4}: lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866 __mutex_lock_common kernel/locking/mutex.c:601 [inline] __mutex_lock+0x1a5/0x10c0 kernel/locking/mutex.c:746 class_mutex_intr_constructor include/linux/mutex.h:203 [inline] input_register_handle+0x1a5/0x500 drivers/input/input.c:2653 kbd_connect+0xbf/0x130 drivers/tty/vt/keyboard.c:1587 input_attach_handler drivers/input/input.c:993 [inline] input_register_device+0xce2/0x10c0 drivers/input/input.c:2412 acpi_button_add+0x6c6/0xb90 drivers/acpi/button.c:621 acpi_device_probe+0xa5/0x2b0 drivers/acpi/bus.c:1076 call_driver_probe drivers/base/dd.c:-1 [inline] really_probe+0x2b9/0xad0 drivers/base/dd.c:658 __driver_probe_device+0x1a2/0x390 drivers/base/dd.c:800 driver_probe_device+0x50/0x430 drivers/base/dd.c:830 __driver_attach+0x45f/0x710 drivers/base/dd.c:1216 bus_for_each_dev+0x23e/0x2b0 drivers/base/bus.c:370 bus_add_driver+0x346/0x670 drivers/base/bus.c:678 driver_register+0x23a/0x320 drivers/base/driver.c:249 do_one_initcall+0x24a/0x940 init/main.c:1257 do_initcall_level+0x157/0x210 init/main.c:1319 do_initcalls+0x71/0xd0 init/main.c:1335 kernel_init_freeable+0x432/0x5d0 init/main.c:1567 kernel_init+0x1d/0x2b0 init/main.c:1457 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:153 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245 -> #1 (input_mutex){+.+.}-{4:4}: lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866 __mutex_lock_common kernel/locking/mutex.c:601 [inline] __mutex_lock+0x1a5/0x10c0 kernel/locking/mutex.c:746 class_mutex_intr_constructor include/linux/mutex.h:203 [inline] input_register_device+0xa8f/0x10c0 drivers/input/input.c:2408 uinput_create_device+0x40e/0x630 drivers/input/misc/uinput.c:365 uinput_ioctl_handler+0x496/0x17f0 drivers/input/misc/uinput.c:918 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:906 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:892 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&newdev->mutex){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3166 [inline] check_prevs_add kernel/locking/lockdep.c:3285 [inline] validate_chain+0xa69/0x24e0 kernel/locking/lockdep.c:3909 __lock_acquire+0xad5/0xd80 kernel/locking/lockdep.c:5235 lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866 __mutex_lock_common kernel/locking/mutex.c:601 [inline] __mutex_lock+0x1a5/0x10c0 kernel/locking/mutex.c:746 uinput_request_send drivers/input/misc/uinput.c:151 [inline] uinput_request_submit+0x188/0x750 drivers/input/misc/uinput.c:182 uinput_dev_upload_effect+0x19b/0x240 drivers/input/misc/uinput.c:257 input_ff_upload+0x5fb/0xb30 drivers/input/ff-core.c:148 evdev_do_ioctl drivers/input/evdev.c:1181 [inline] evdev_ioctl_handler+0x17f2/0x2240 drivers/input/evdev.c:1270 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:906 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:892 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &newdev->mutex --> &dev->mutex#2 --> &ff->mutex Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ff->mutex); lock(&dev->mutex#2); lock(&ff->mutex); lock(&newdev->mutex); *** DEADLOCK *** 2 locks held by syz.0.0/5326: #0: ffff88804409a118 (&evdev->mutex){+.+.}-{4:4}, at: evdev_ioctl_handler+0x124/0x2240 drivers/input/evdev.c:1261 #1: ffff888034f158b0 (&ff->mutex){+.+.}-{4:4}, at: class_mutex_constructor include/linux/mutex.h:201 [inline] #1: ffff888034f158b0 (&ff->mutex){+.+.}-{4:4}, at: input_ff_upload+0x3f3/0xb30 drivers/input/ff-core.c:122 stack backtrace: CPU: 0 UID: 0 PID: 5326 Comm: syz.0.0 Not tainted 6.15.0-rc1-syzkaller-00288-ge618ee89561b #0 PREEMPT(full) Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2079 check_noncircular+0x142/0x160 kernel/locking/lockdep.c:2211 check_prev_add kernel/locking/lockdep.c:3166 [inline] check_prevs_add kernel/locking/lockdep.c:3285 [inline] validate_chain+0xa69/0x24e0 kernel/locking/lockdep.c:3909 __lock_acquire+0xad5/0xd80 kernel/locking/lockdep.c:5235 lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866 __mutex_lock_common kernel/locking/mutex.c:601 [inline] __mutex_lock+0x1a5/0x10c0 kernel/locking/mutex.c:746 uinput_request_send drivers/input/misc/uinput.c:151 [inline] uinput_request_submit+0x188/0x750 drivers/input/misc/uinput.c:182 uinput_dev_upload_effect+0x19b/0x240 drivers/input/misc/uinput.c:257 input_ff_upload+0x5fb/0xb30 drivers/input/ff-core.c:148 evdev_do_ioctl drivers/input/evdev.c:1181 [inline] evdev_ioctl_handler+0x17f2/0x2240 drivers/input/evdev.c:1270 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:906 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:892 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7ff97bb8d169 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ff97c95b038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007ff97bda5fa0 RCX: 00007ff97bb8d169 RDX: 0000200000000300 RSI: 0000000040304580 RDI: 0000000000000005 RBP: 00007ff97bc0e990 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007ff97bda5fa0 R15: 00007ffd51aa53c8