loop9: detected capacity change from 0 to 1024
======================================================
WARNING: possible circular locking dependency detected
6.13.0-rc3-next-20241220-syzkaller #0 Not tainted
------------------------------------------------------
syz.9.766/11200 is trying to acquire lock:
ffff88802888f0f8 (&sbi->alloc_mutex){+.+.}-{4:4}, at: hfsplus_block_allocate+0x9e/0x8c0 fs/hfsplus/bitmap.c:35

but task is already holding lock:
ffff888078e7b708 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:458

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}:
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
       __mutex_lock_common kernel/locking/mutex.c:585 [inline]
       __mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735
       hfsplus_get_block+0x383/0x14f0 fs/hfsplus/extents.c:260
       block_read_full_folio+0x3ee/0xae0 fs/buffer.c:2396
       filemap_read_folio+0x148/0x3b0 mm/filemap.c:2348
       do_read_cache_folio+0x373/0x5b0 mm/filemap.c:3893
       do_read_cache_page mm/filemap.c:3959 [inline]
       read_cache_page+0x5b/0x170 mm/filemap.c:3968
       read_mapping_page include/linux/pagemap.h:1026 [inline]
       hfsplus_block_allocate+0xee/0x8c0 fs/hfsplus/bitmap.c:37
       hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:469
       hfsplus_get_block+0x406/0x14f0 fs/hfsplus/extents.c:245
       __block_write_begin_int+0x692/0x19a0 fs/buffer.c:2116
       block_write_begin fs/buffer.c:2226 [inline]
       cont_write_begin+0x77f/0xb40 fs/buffer.c:2577
       hfsplus_write_begin+0x68/0xb0 fs/hfsplus/inode.c:46
       generic_perform_write+0x346/0x990 mm/filemap.c:4122
       generic_file_write_iter+0xae/0x310 mm/filemap.c:4249
       new_sync_write fs/read_write.c:586 [inline]
       vfs_write+0xacf/0xd10 fs/read_write.c:679
       ksys_write+0x18f/0x2b0 fs/read_write.c:731
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&sbi->alloc_mutex){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3161 [inline]
       check_prevs_add kernel/locking/lockdep.c:3280 [inline]
       validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904
       __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
       __mutex_lock_common kernel/locking/mutex.c:585 [inline]
       __mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735
       hfsplus_block_allocate+0x9e/0x8c0 fs/hfsplus/bitmap.c:35
       hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:469
       hfsplus_bmap_reserve+0x105/0x4e0 fs/hfsplus/btree.c:358
       hfsplus_create_cat+0x1b0/0x1b70 fs/hfsplus/catalog.c:272
       hfsplus_fill_super+0x1354/0x1be0 fs/hfsplus/super.c:561
       get_tree_bdev_flags+0x48c/0x5c0 fs/super.c:1636
       vfs_get_tree+0x90/0x2b0 fs/super.c:1814
       do_new_mount+0x2be/0xb40 fs/namespace.c:3556
       do_mount fs/namespace.c:3896 [inline]
       __do_sys_mount fs/namespace.c:4107 [inline]
       __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4084
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&sbi->alloc_mutex);
                               lock(&HFSPLUS_I(inode)->extents_lock);
  lock(&sbi->alloc_mutex);

 *** DEADLOCK ***

4 locks held by syz.9.766/11200:
 #0: ffff88814c96a0e0 (&type->s_umount_key#49/1){+.+.}-{4:4}, at: alloc_super+0x221/0x9d0 fs/super.c:344
 #1: ffff88802888f198 (&sbi->vh_mutex){+.+.}-{4:4}, at: hfsplus_fill_super+0x12ed/0x1be0 fs/hfsplus/super.c:554
 #2: ffff88805c8460b0 (&tree->tree_lock){+.+.}-{4:4}, at: hfsplus_find_init+0x14a/0x1c0 fs/hfsplus/bfind.c:28
 #3: ffff888078e7b708 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:458

stack backtrace:
CPU: 1 UID: 0 PID: 11200 Comm: syz.9.766 Not tainted 6.13.0-rc3-next-20241220-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074
 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206
 check_prev_add kernel/locking/lockdep.c:3161 [inline]
 check_prevs_add kernel/locking/lockdep.c:3280 [inline]
 validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904
 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226
 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
 __mutex_lock_common kernel/locking/mutex.c:585 [inline]
 __mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735
 hfsplus_block_allocate+0x9e/0x8c0 fs/hfsplus/bitmap.c:35
 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:469
 hfsplus_bmap_reserve+0x105/0x4e0 fs/hfsplus/btree.c:358
 hfsplus_create_cat+0x1b0/0x1b70 fs/hfsplus/catalog.c:272
 hfsplus_fill_super+0x1354/0x1be0 fs/hfsplus/super.c:561
 get_tree_bdev_flags+0x48c/0x5c0 fs/super.c:1636
 vfs_get_tree+0x90/0x2b0 fs/super.c:1814
 do_new_mount+0x2be/0xb40 fs/namespace.c:3556
 do_mount fs/namespace.c:3896 [inline]
 __do_sys_mount fs/namespace.c:4107 [inline]
 __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4084
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f933a1874ca
Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 de 1a 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f933aee5e68 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f933aee5ef0 RCX: 00007f933a1874ca
RDX: 0000000020000000 RSI: 0000000020002380 RDI: 00007f933aee5eb0
RBP: 0000000020000000 R08: 00007f933aee5ef0 R09: 000000000080000c
R10: 000000000080000c R11: 0000000000000246 R12: 0000000020002380
R13: 00007f933aee5eb0 R14: 00000000000006f6 R15: 0000000020000540
 </TASK>
hfsplus: inconsistency in B*Tree (1,0,1,0,1)
hfsplus: inconsistency in B*Tree (1,0,1,0,1)