EXT4-fs error (device loop0): __ext4_ext_dirty:202: inode #3: comm syz-executor354: mark_inode_dirty error
EXT4-fs error (device loop0): ext4_acquire_dquot:6801: comm syz-executor354: Failed to acquire dquot type 0
======================================================
WARNING: possible circular locking dependency detected
6.1.119-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor354/4815 is trying to acquire lock:
ffff0000e4489768 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_commit+0x54/0x240 fs/quota/dquot.c:507
but task is already holding lock:
ffff0000e45b3eb8 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_truncate+0x7e0/0x1178 fs/ext4/inode.c:4283
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (&ei->i_data_sem/2){++++}-{3:3}:
down_read+0x64/0x308 kernel/locking/rwsem.c:1520
ext4_map_blocks+0x2ac/0x1810 fs/ext4/inode.c:603
ext4_getblk+0x198/0x6ec fs/ext4/inode.c:889
ext4_bread+0x3c/0x1b0 fs/ext4/inode.c:945
ext4_quota_write+0x230/0x54c fs/ext4/super.c:7171
write_blk fs/quota/quota_tree.c:70 [inline]
get_free_dqblk+0x28c/0x598 fs/quota/quota_tree.c:136
do_insert_tree+0x204/0xec4 fs/quota/quota_tree.c:347
do_insert_tree+0x834/0xec4 fs/quota/quota_tree.c:402
do_insert_tree+0x834/0xec4 fs/quota/quota_tree.c:402
do_insert_tree+0x834/0xec4 fs/quota/quota_tree.c:402
dq_insert_tree fs/quota/quota_tree.c:432 [inline]
qtree_write_dquot+0x3c8/0x4d8 fs/quota/quota_tree.c:451
v2_write_dquot+0xf4/0x188 fs/quota/quota_v2.c:361
dquot_acquire+0x2c4/0x5c4 fs/quota/dquot.c:472
ext4_acquire_dquot+0x270/0x420 fs/ext4/super.c:6797
dqget+0x660/0xcec fs/quota/dquot.c:986
__dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1515
dquot_initialize+0x24/0x34 fs/quota/dquot.c:1577
ext4_process_orphan+0x5c/0x2b8 fs/ext4/orphan.c:329
ext4_orphan_cleanup+0x974/0x1134 fs/ext4/orphan.c:474
__ext4_fill_super fs/ext4/super.c:5534 [inline]
ext4_fill_super+0x6f04/0x7570 fs/ext4/super.c:5665
get_tree_bdev+0x360/0x54c fs/super.c:1366
ext4_get_tree+0x28/0x38 fs/ext4/super.c:5695
vfs_get_tree+0x90/0x274 fs/super.c:1573
do_new_mount+0x278/0x8fc fs/namespace.c:3056
path_mount+0x590/0xe5c fs/namespace.c:3386
do_mount fs/namespace.c:3399 [inline]
__do_sys_mount fs/namespace.c:3607 [inline]
__se_sys_mount fs/namespace.c:3584 [inline]
__arm64_sys_mount+0x45c/0x594 fs/namespace.c:3584
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
-> #1 (&s->s_dquot.dqio_sem){++++}-{3:3}:
down_read+0x64/0x308 kernel/locking/rwsem.c:1520
v2_read_dquot+0x50/0x11c fs/quota/quota_v2.c:335
dquot_acquire+0x130/0x5c4 fs/quota/dquot.c:463
ext4_acquire_dquot+0x270/0x420 fs/ext4/super.c:6797
dqget+0x660/0xcec fs/quota/dquot.c:986
__dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1515
dquot_initialize+0x24/0x34 fs/quota/dquot.c:1577
ext4_process_orphan+0x5c/0x2b8 fs/ext4/orphan.c:329
ext4_orphan_cleanup+0x974/0x1134 fs/ext4/orphan.c:474
__ext4_fill_super fs/ext4/super.c:5534 [inline]
ext4_fill_super+0x6f04/0x7570 fs/ext4/super.c:5665
get_tree_bdev+0x360/0x54c fs/super.c:1366
ext4_get_tree+0x28/0x38 fs/ext4/super.c:5695
vfs_get_tree+0x90/0x274 fs/super.c:1573
do_new_mount+0x278/0x8fc fs/namespace.c:3056
path_mount+0x590/0xe5c fs/namespace.c:3386
do_mount fs/namespace.c:3399 [inline]
__do_sys_mount fs/namespace.c:3607 [inline]
__se_sys_mount fs/namespace.c:3584 [inline]
__arm64_sys_mount+0x45c/0x594 fs/namespace.c:3584
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
-> #0 (&dquot->dq_lock){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain kernel/locking/lockdep.c:3825 [inline]
__lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
__mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
__mutex_lock kernel/locking/mutex.c:747 [inline]
mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
dquot_commit+0x54/0x240 fs/quota/dquot.c:507
ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6777
ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6837
mark_dquot_dirty fs/quota/dquot.c:372 [inline]
mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412
__dquot_free_space+0x840/0xce4 fs/quota/dquot.c:1940
dquot_free_space_nodirty include/linux/quotaops.h:379 [inline]
dquot_free_space include/linux/quotaops.h:384 [inline]
dquot_free_block include/linux/quotaops.h:395 [inline]
ext4_mb_clear_bb fs/ext4/mballoc.c:6143 [inline]
ext4_free_blocks+0x1b14/0x2b64 fs/ext4/mballoc.c:6273
ext4_remove_blocks fs/ext4/extents.c:2525 [inline]
ext4_ext_rm_leaf fs/ext4/extents.c:2691 [inline]
ext4_ext_remove_space+0x1bd0/0x4544 fs/ext4/extents.c:2939
ext4_ext_truncate+0x168/0x210 fs/ext4/extents.c:4469
ext4_truncate+0xa08/0x1178 fs/ext4/inode.c:4288
ext4_evict_inode+0xc3c/0x12cc fs/ext4/inode.c:286
evict+0x418/0x894 fs/inode.c:701
iput_final fs/inode.c:1830 [inline]
iput+0x7c0/0x8a4 fs/inode.c:1856
ext4_process_orphan+0x244/0x2b8 fs/ext4/orphan.c:360
ext4_orphan_cleanup+0x974/0x1134 fs/ext4/orphan.c:474
__ext4_fill_super fs/ext4/super.c:5534 [inline]
ext4_fill_super+0x6f04/0x7570 fs/ext4/super.c:5665
get_tree_bdev+0x360/0x54c fs/super.c:1366
ext4_get_tree+0x28/0x38 fs/ext4/super.c:5695
vfs_get_tree+0x90/0x274 fs/super.c:1573
do_new_mount+0x278/0x8fc fs/namespace.c:3056
path_mount+0x590/0xe5c fs/namespace.c:3386
do_mount fs/namespace.c:3399 [inline]
__do_sys_mount fs/namespace.c:3607 [inline]
__se_sys_mount fs/namespace.c:3584 [inline]
__arm64_sys_mount+0x45c/0x594 fs/namespace.c:3584
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
other info that might help us debug this:
Chain exists of:
&dquot->dq_lock --> &s->s_dquot.dqio_sem --> &ei->i_data_sem/2
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&ei->i_data_sem/2);
lock(&s->s_dquot.dqio_sem);
lock(&ei->i_data_sem/2);
lock(&dquot->dq_lock);
*** DEADLOCK ***
4 locks held by syz-executor354/4815:
#0: ffff0000dac060e0 (&type->s_umount_key#26/1){+.+.}-{3:3}, at: alloc_super+0x1b4/0x824 fs/super.c:228
#1: ffff0000dac06650 (sb_internal){.+.+}-{0:0}, at: __sb_start_write include/linux/fs.h:1891 [inline]
#1: ffff0000dac06650 (sb_internal){.+.+}-{0:0}, at: sb_start_intwrite include/linux/fs.h:2013 [inline]
#1: ffff0000dac06650 (sb_internal){.+.+}-{0:0}, at: ext4_evict_inode+0x408/0x12cc fs/ext4/inode.c:240
#2: ffff0000e45b3eb8 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_truncate+0x7e0/0x1178 fs/ext4/inode.c:4283
#3: ffff800015d88ac8 (dquot_srcu){....}-{0:0}, at: rcu_lock_acquire+0x10/0x4c include/linux/rcupdate.h:349
stack backtrace:
CPU: 0 PID: 4815 Comm: syz-executor354 Not tainted 6.1.119-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call trace:
dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x58 lib/dump_stack.c:113
print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048
check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain kernel/locking/lockdep.c:3825 [inline]
__lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
__mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
__mutex_lock kernel/locking/mutex.c:747 [inline]
mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
dquot_commit+0x54/0x240 fs/quota/dquot.c:507
ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6777
ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6837
mark_dquot_dirty fs/quota/dquot.c:372 [inline]
mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412
__dquot_free_space+0x840/0xce4 fs/quota/dquot.c:1940
dquot_free_space_nodirty include/linux/quotaops.h:379 [inline]
dquot_free_space include/linux/quotaops.h:384 [inline]
dquot_free_block include/linux/quotaops.h:395 [inline]
ext4_mb_clear_bb fs/ext4/mballoc.c:6143 [inline]
ext4_free_blocks+0x1b14/0x2b64 fs/ext4/mballoc.c:6273
ext4_remove_blocks fs/ext4/extents.c:2525 [inline]
ext4_ext_rm_leaf fs/ext4/extents.c:2691 [inline]
ext4_ext_remove_space+0x1bd0/0x4544 fs/ext4/extents.c:2939
ext4_ext_truncate+0x168/0x210 fs/ext4/extents.c:4469
ext4_truncate+0xa08/0x1178 fs/ext4/inode.c:4288
ext4_evict_inode+0xc3c/0x12cc fs/ext4/inode.c:286
evict+0x418/0x894 fs/inode.c:701
iput_final fs/inode.c:1830 [inline]
iput+0x7c0/0x8a4 fs/inode.c:1856
ext4_process_orphan+0x244/0x2b8 fs/ext4/orphan.c:360
ext4_orphan_cleanup+0x974/0x1134 fs/ext4/orphan.c:474
__ext4_fill_super fs/ext4/super.c:5534 [inline]
ext4_fill_super+0x6f04/0x7570 fs/ext4/super.c:5665
get_tree_bdev+0x360/0x54c fs/super.c:1366
ext4_get_tree+0x28/0x38 fs/ext4/super.c:5695
vfs_get_tree+0x90/0x274 fs/super.c:1573
do_new_mount+0x278/0x8fc fs/namespace.c:3056
path_mount+0x590/0xe5c fs/namespace.c:3386
do_mount fs/namespace.c:3399 [inline]
__do_sys_mount fs/namespace.c:3607 [inline]
__se_sys_mount fs/namespace.c:3584 [inline]
__arm64_sys_mount+0x45c/0x594 fs/namespace.c:3584
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
EXT4-fs (loop0): 1 orphan inode deleted