====================================================== WARNING: possible circular locking dependency detected 6.16.0-rc2-syzkaller-g9aa9b43d689e #0 Not tainted ------------------------------------------------------ syz.1.221/7805 is trying to acquire lock: ffff0000f4166d80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline] ffff0000f4166d80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{4:4}, at: ocfs2_reserve_local_alloc_bits+0x104/0x26a0 fs/ocfs2/localalloc.c:636 but task is already holding lock: ffff0000f4083ff8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x330/0xe9c fs/ocfs2/xattr.c:3583 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (&oi->ip_xattr_sem){++++}-{4:4}: down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 ocfs2_xattr_set_handle+0x2a8/0x5e4 fs/ocfs2/xattr.c:3501 ocfs2_init_security_set+0xb4/0xd8 fs/ocfs2/xattr.c:7307 ocfs2_mknod+0x106c/0x1cf0 fs/ocfs2/namei.c:419 ocfs2_create+0x190/0x474 fs/ocfs2/namei.c:673 lookup_open fs/namei.c:3708 [inline] open_last_lookups fs/namei.c:3807 [inline] path_openat+0x12d8/0x2c40 fs/namei.c:4043 do_filp_open+0x18c/0x36c fs/namei.c:4073 do_sys_openat2+0x11c/0x1b4 fs/open.c:1437 do_sys_open fs/open.c:1452 [inline] __do_sys_openat fs/open.c:1468 [inline] __se_sys_openat fs/open.c:1463 [inline] __arm64_sys_openat+0x120/0x158 fs/open.c:1463 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x17c arch/arm64/kernel/entry-common.c:767 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:786 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #3 (jbd2_handle){++++}-{0:0}: start_this_handle+0xe74/0x10dc fs/jbd2/transaction.c:444 jbd2__journal_start+0x288/0x51c fs/jbd2/transaction.c:501 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:540 ocfs2_start_trans+0x368/0x6b0 fs/ocfs2/journal.c:374 ocfs2_shutdown_local_alloc+0x1ac/0x7e4 fs/ocfs2/localalloc.c:417 ocfs2_dismount_volume+0x1ec/0x8cc fs/ocfs2/super.c:1825 ocfs2_put_super+0xec/0x320 fs/ocfs2/super.c:1553 generic_shutdown_super+0x12c/0x2b8 fs/super.c:643 kill_block_super+0x44/0x90 fs/super.c:1753 deactivate_locked_super+0xc4/0x12c fs/super.c:474 deactivate_super+0xe0/0x100 fs/super.c:507 cleanup_mnt+0x31c/0x3ac fs/namespace.c:1417 __cleanup_mnt+0x20/0x30 fs/namespace.c:1424 task_work_run+0x1dc/0x260 kernel/task_work.c:227 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline] do_notify_resume+0x16c/0x1ec arch/arm64/kernel/entry-common.c:151 exit_to_user_mode_prepare arch/arm64/kernel/entry-common.c:169 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:178 [inline] el0_svc+0xb4/0x17c arch/arm64/kernel/entry-common.c:768 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:786 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #2 (&journal->j_trans_barrier){.+.+}-{4:4}: down_read+0x58/0x2f8 kernel/locking/rwsem.c:1524 ocfs2_start_trans+0x35c/0x6b0 fs/ocfs2/journal.c:372 ocfs2_shutdown_local_alloc+0x1ac/0x7e4 fs/ocfs2/localalloc.c:417 ocfs2_dismount_volume+0x1ec/0x8cc fs/ocfs2/super.c:1825 ocfs2_put_super+0xec/0x320 fs/ocfs2/super.c:1553 generic_shutdown_super+0x12c/0x2b8 fs/super.c:643 kill_block_super+0x44/0x90 fs/super.c:1753 deactivate_locked_super+0xc4/0x12c fs/super.c:474 deactivate_super+0xe0/0x100 fs/super.c:507 cleanup_mnt+0x31c/0x3ac fs/namespace.c:1417 __cleanup_mnt+0x20/0x30 fs/namespace.c:1424 task_work_run+0x1dc/0x260 kernel/task_work.c:227 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline] do_notify_resume+0x16c/0x1ec arch/arm64/kernel/entry-common.c:151 exit_to_user_mode_prepare arch/arm64/kernel/entry-common.c:169 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:178 [inline] el0_svc+0xb4/0x17c arch/arm64/kernel/entry-common.c:768 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:786 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #1 (sb_internal#4){.+.+}-{0:0}: percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline] percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline] __sb_start_write include/linux/fs.h:1793 [inline] sb_start_intwrite include/linux/fs.h:1976 [inline] ocfs2_start_trans+0x1f4/0x6b0 fs/ocfs2/journal.c:370 ocfs2_mknod+0xc50/0x1cf0 fs/ocfs2/namei.c:361 ocfs2_create+0x190/0x474 fs/ocfs2/namei.c:673 lookup_open fs/namei.c:3708 [inline] open_last_lookups fs/namei.c:3807 [inline] path_openat+0x12d8/0x2c40 fs/namei.c:4043 do_filp_open+0x18c/0x36c fs/namei.c:4073 do_sys_openat2+0x11c/0x1b4 fs/open.c:1437 do_sys_open fs/open.c:1452 [inline] __do_sys_openat fs/open.c:1468 [inline] __se_sys_openat fs/open.c:1463 [inline] __arm64_sys_openat+0x120/0x158 fs/open.c:1463 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x17c arch/arm64/kernel/entry-common.c:767 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:786 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3168 [inline] check_prevs_add kernel/locking/lockdep.c:3287 [inline] validate_chain kernel/locking/lockdep.c:3911 [inline] __lock_acquire+0x1774/0x30a4 kernel/locking/lockdep.c:5240 lock_acquire+0x14c/0x2e0 kernel/locking/lockdep.c:5871 down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:867 [inline] ocfs2_reserve_local_alloc_bits+0x104/0x26a0 fs/ocfs2/localalloc.c:636 ocfs2_reserve_clusters_with_limit+0x198/0x9e0 fs/ocfs2/suballoc.c:1168 ocfs2_reserve_clusters+0x3c/0x50 fs/ocfs2/suballoc.c:1229 ocfs2_init_xattr_set_ctxt+0x37c/0x774 fs/ocfs2/xattr.c:3286 ocfs2_xattr_set+0x920/0xe9c fs/ocfs2/xattr.c:3634 ocfs2_xattr_trusted_set+0x4c/0x64 fs/ocfs2/xattr.c:7336 __vfs_setxattr+0x3d8/0x400 fs/xattr.c:200 __vfs_setxattr_noperm+0x120/0x5c4 fs/xattr.c:234 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:295 vfs_setxattr+0x158/0x2ac fs/xattr.c:321 ovl_do_setxattr fs/overlayfs/overlayfs.h:315 [inline] ovl_setxattr fs/overlayfs/overlayfs.h:327 [inline] ovl_make_workdir fs/overlayfs/super.c:715 [inline] ovl_get_workdir+0x958/0x11f4 fs/overlayfs/super.c:827 ovl_fill_super+0x1028/0x2c80 fs/overlayfs/super.c:1406 vfs_get_super fs/super.c:1323 [inline] get_tree_nodev+0xb4/0x144 fs/super.c:1342 ovl_get_tree+0x28/0x38 fs/overlayfs/params.c:701 vfs_get_tree+0x90/0x28c fs/super.c:1802 do_new_mount+0x228/0x814 fs/namespace.c:3885 path_mount+0x5b4/0xde0 fs/namespace.c:4209 do_mount fs/namespace.c:4222 [inline] __do_sys_mount fs/namespace.c:4433 [inline] __se_sys_mount fs/namespace.c:4410 [inline] __arm64_sys_mount+0x3e8/0x468 fs/namespace.c:4410 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x17c arch/arm64/kernel/entry-common.c:767 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:786 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6 --> jbd2_handle --> &oi->ip_xattr_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->ip_xattr_sem); lock(jbd2_handle); lock(&oi->ip_xattr_sem); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6); *** DEADLOCK *** 4 locks held by syz.1.221/7805: #0: ffff0000d17ea0e0 (&type->s_umount_key#60/1){+.+.}-{4:4}, at: alloc_super+0x1a0/0x80c fs/super.c:345 #1: ffff0000f7b94428 (sb_writers#27){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:557 #2: ffff0000f40842c0 (&sb->s_type->i_mutex_key#41){++++}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline] #2: ffff0000f40842c0 (&sb->s_type->i_mutex_key#41){++++}-{4:4}, at: vfs_setxattr+0x138/0x2ac fs/xattr.c:320 #3: ffff0000f4083ff8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x330/0xe9c fs/ocfs2/xattr.c:3583 stack backtrace: CPU: 1 UID: 0 PID: 7805 Comm: syz.1.221 Not tainted 6.16.0-rc2-syzkaller-g9aa9b43d689e #0 PREEMPT Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025 Call trace: show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:501 (C) __dump_stack+0x30/0x40 lib/dump_stack.c:94 dump_stack_lvl+0xd8/0x12c lib/dump_stack.c:120 dump_stack+0x1c/0x28 lib/dump_stack.c:129 print_circular_bug+0x324/0x32c kernel/locking/lockdep.c:2046 check_noncircular+0x154/0x174 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3168 [inline] check_prevs_add kernel/locking/lockdep.c:3287 [inline] validate_chain kernel/locking/lockdep.c:3911 [inline] __lock_acquire+0x1774/0x30a4 kernel/locking/lockdep.c:5240 lock_acquire+0x14c/0x2e0 kernel/locking/lockdep.c:5871 down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:867 [inline] ocfs2_reserve_local_alloc_bits+0x104/0x26a0 fs/ocfs2/localalloc.c:636 ocfs2_reserve_clusters_with_limit+0x198/0x9e0 fs/ocfs2/suballoc.c:1168 ocfs2_reserve_clusters+0x3c/0x50 fs/ocfs2/suballoc.c:1229 ocfs2_init_xattr_set_ctxt+0x37c/0x774 fs/ocfs2/xattr.c:3286 ocfs2_xattr_set+0x920/0xe9c fs/ocfs2/xattr.c:3634 ocfs2_xattr_trusted_set+0x4c/0x64 fs/ocfs2/xattr.c:7336 __vfs_setxattr+0x3d8/0x400 fs/xattr.c:200 __vfs_setxattr_noperm+0x120/0x5c4 fs/xattr.c:234 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:295 vfs_setxattr+0x158/0x2ac fs/xattr.c:321 ovl_do_setxattr fs/overlayfs/overlayfs.h:315 [inline] ovl_setxattr fs/overlayfs/overlayfs.h:327 [inline] ovl_make_workdir fs/overlayfs/super.c:715 [inline] ovl_get_workdir+0x958/0x11f4 fs/overlayfs/super.c:827 ovl_fill_super+0x1028/0x2c80 fs/overlayfs/super.c:1406 vfs_get_super fs/super.c:1323 [inline] get_tree_nodev+0xb4/0x144 fs/super.c:1342 ovl_get_tree+0x28/0x38 fs/overlayfs/params.c:701 vfs_get_tree+0x90/0x28c fs/super.c:1802 do_new_mount+0x228/0x814 fs/namespace.c:3885 path_mount+0x5b4/0xde0 fs/namespace.c:4209 do_mount fs/namespace.c:4222 [inline] __do_sys_mount fs/namespace.c:4433 [inline] __se_sys_mount fs/namespace.c:4410 [inline] __arm64_sys_mount+0x3e8/0x468 fs/namespace.c:4410 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x17c arch/arm64/kernel/entry-common.c:767 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:786 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 overlayfs: upper fs missing required features.