====================================================== WARNING: possible circular locking dependency detected 6.16.0-rc4-syzkaller-g3c795c3404e8 #0 Not tainted ------------------------------------------------------ syz.4.181/7384 is trying to acquire lock: ffff0000f75189c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline] ffff0000f75189c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: ocfs2_reserve_local_alloc_bits+0x104/0x26a0 fs/ocfs2/localalloc.c:636 but task is already holding lock: ffff0000dedfb1b8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x330/0xe9c fs/ocfs2/xattr.c:3583 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (&oi->ip_xattr_sem){++++}-{4:4}: down_read+0x58/0x2f8 kernel/locking/rwsem.c:1524 ocfs2_init_acl+0x258/0x5f0 fs/ocfs2/acl.c:366 ocfs2_mknod+0x1028/0x1cf0 fs/ocfs2/namei.c:410 ocfs2_create+0x190/0x474 fs/ocfs2/namei.c:673 lookup_open fs/namei.c:3717 [inline] open_last_lookups fs/namei.c:3816 [inline] path_openat+0x12d8/0x2c40 fs/namei.c:4052 do_filp_open+0x18c/0x36c fs/namei.c:4082 do_sys_openat2+0x11c/0x1b4 fs/open.c:1437 do_sys_open fs/open.c:1452 [inline] __do_sys_openat fs/open.c:1468 [inline] __se_sys_openat fs/open.c:1463 [inline] __arm64_sys_openat+0x120/0x158 fs/open.c:1463 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x180 arch/arm64/kernel/entry-common.c:771 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:790 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #3 (jbd2_handle){++++}-{0:0}: start_this_handle+0xe74/0x10dc fs/jbd2/transaction.c:444 jbd2__journal_start+0x288/0x51c fs/jbd2/transaction.c:501 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:540 ocfs2_start_trans+0x368/0x6b0 fs/ocfs2/journal.c:374 ocfs2_modify_bh+0xe4/0x43c fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x104c/0x1364 fs/ocfs2/quota_local.c:767 dquot_load_quota_sb+0x6bc/0xa90 fs/quota/dquot.c:2459 dquot_load_quota_inode+0x274/0x4e4 fs/quota/dquot.c:2496 ocfs2_enable_quotas+0x17c/0x3b4 fs/ocfs2/super.c:930 ocfs2_fill_super+0x4018/0x5340 fs/ocfs2/super.c:1140 get_tree_bdev_flags+0x360/0x414 fs/super.c:1681 get_tree_bdev+0x2c/0x3c fs/super.c:1704 ocfs2_get_tree+0x28/0x38 fs/ocfs2/super.c:1184 vfs_get_tree+0x90/0x28c fs/super.c:1804 do_new_mount+0x228/0x814 fs/namespace.c:3902 path_mount+0x5b4/0xde0 fs/namespace.c:4226 do_mount fs/namespace.c:4239 [inline] __do_sys_mount fs/namespace.c:4450 [inline] __se_sys_mount fs/namespace.c:4427 [inline] __arm64_sys_mount+0x3e8/0x468 fs/namespace.c:4427 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x180 arch/arm64/kernel/entry-common.c:771 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:790 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #2 (&journal->j_trans_barrier){.+.+}-{4:4}: down_read+0x58/0x2f8 kernel/locking/rwsem.c:1524 ocfs2_start_trans+0x35c/0x6b0 fs/ocfs2/journal.c:372 ocfs2_modify_bh+0xe4/0x43c fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x104c/0x1364 fs/ocfs2/quota_local.c:767 dquot_load_quota_sb+0x6bc/0xa90 fs/quota/dquot.c:2459 dquot_load_quota_inode+0x274/0x4e4 fs/quota/dquot.c:2496 ocfs2_enable_quotas+0x17c/0x3b4 fs/ocfs2/super.c:930 ocfs2_fill_super+0x4018/0x5340 fs/ocfs2/super.c:1140 get_tree_bdev_flags+0x360/0x414 fs/super.c:1681 get_tree_bdev+0x2c/0x3c fs/super.c:1704 ocfs2_get_tree+0x28/0x38 fs/ocfs2/super.c:1184 vfs_get_tree+0x90/0x28c fs/super.c:1804 do_new_mount+0x228/0x814 fs/namespace.c:3902 path_mount+0x5b4/0xde0 fs/namespace.c:4226 do_mount fs/namespace.c:4239 [inline] __do_sys_mount fs/namespace.c:4450 [inline] __se_sys_mount fs/namespace.c:4427 [inline] __arm64_sys_mount+0x3e8/0x468 fs/namespace.c:4427 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x180 arch/arm64/kernel/entry-common.c:771 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:790 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #1 (sb_internal#4){.+.+}-{0:0}: percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline] percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline] __sb_start_write include/linux/fs.h:1795 [inline] sb_start_intwrite include/linux/fs.h:1978 [inline] ocfs2_start_trans+0x1f4/0x6b0 fs/ocfs2/journal.c:370 ocfs2_mknod+0xc50/0x1cf0 fs/ocfs2/namei.c:361 ocfs2_create+0x190/0x474 fs/ocfs2/namei.c:673 lookup_open fs/namei.c:3717 [inline] open_last_lookups fs/namei.c:3816 [inline] path_openat+0x12d8/0x2c40 fs/namei.c:4052 do_filp_open+0x18c/0x36c fs/namei.c:4082 do_sys_openat2+0x11c/0x1b4 fs/open.c:1437 do_sys_open fs/open.c:1452 [inline] __do_sys_openat fs/open.c:1468 [inline] __se_sys_openat fs/open.c:1463 [inline] __arm64_sys_openat+0x120/0x158 fs/open.c:1463 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x180 arch/arm64/kernel/entry-common.c:771 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:790 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3168 [inline] check_prevs_add kernel/locking/lockdep.c:3287 [inline] validate_chain kernel/locking/lockdep.c:3911 [inline] __lock_acquire+0x1774/0x30a4 kernel/locking/lockdep.c:5240 lock_acquire+0x14c/0x2e0 kernel/locking/lockdep.c:5871 down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:869 [inline] ocfs2_reserve_local_alloc_bits+0x104/0x26a0 fs/ocfs2/localalloc.c:636 ocfs2_reserve_clusters_with_limit+0x198/0x9e0 fs/ocfs2/suballoc.c:1168 ocfs2_reserve_clusters+0x3c/0x50 fs/ocfs2/suballoc.c:1229 ocfs2_init_xattr_set_ctxt+0x37c/0x774 fs/ocfs2/xattr.c:3286 ocfs2_xattr_set+0x920/0xe9c fs/ocfs2/xattr.c:3634 ocfs2_xattr_trusted_set+0x4c/0x64 fs/ocfs2/xattr.c:7336 __vfs_setxattr+0x3d8/0x400 fs/xattr.c:200 __vfs_setxattr_noperm+0x120/0x5c4 fs/xattr.c:234 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:295 vfs_setxattr+0x158/0x2ac fs/xattr.c:321 do_setxattr fs/xattr.c:636 [inline] filename_setxattr+0x20c/0x4f8 fs/xattr.c:665 path_setxattrat+0x2e8/0x320 fs/xattr.c:713 __do_sys_setxattr fs/xattr.c:747 [inline] __se_sys_setxattr fs/xattr.c:743 [inline] __arm64_sys_setxattr+0xc0/0xdc fs/xattr.c:743 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x180 arch/arm64/kernel/entry-common.c:771 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:790 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> jbd2_handle --> &oi->ip_xattr_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->ip_xattr_sem); lock(jbd2_handle); lock(&oi->ip_xattr_sem); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7); *** DEADLOCK *** 3 locks held by syz.4.181/7384: #0: ffff0000f6248428 (sb_writers#26){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:557 #1: ffff0000dedfb480 (&sb->s_type->i_mutex_key#30){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline] #1: ffff0000dedfb480 (&sb->s_type->i_mutex_key#30){+.+.}-{4:4}, at: vfs_setxattr+0x138/0x2ac fs/xattr.c:320 #2: ffff0000dedfb1b8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x330/0xe9c fs/ocfs2/xattr.c:3583 stack backtrace: CPU: 1 UID: 0 PID: 7384 Comm: syz.4.181 Not tainted 6.16.0-rc4-syzkaller-g3c795c3404e8 #0 PREEMPT Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025 Call trace: show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:501 (C) __dump_stack+0x30/0x40 lib/dump_stack.c:94 dump_stack_lvl+0xd8/0x12c lib/dump_stack.c:120 dump_stack+0x1c/0x28 lib/dump_stack.c:129 print_circular_bug+0x324/0x32c kernel/locking/lockdep.c:2046 check_noncircular+0x154/0x174 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3168 [inline] check_prevs_add kernel/locking/lockdep.c:3287 [inline] validate_chain kernel/locking/lockdep.c:3911 [inline] __lock_acquire+0x1774/0x30a4 kernel/locking/lockdep.c:5240 lock_acquire+0x14c/0x2e0 kernel/locking/lockdep.c:5871 down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:869 [inline] ocfs2_reserve_local_alloc_bits+0x104/0x26a0 fs/ocfs2/localalloc.c:636 ocfs2_reserve_clusters_with_limit+0x198/0x9e0 fs/ocfs2/suballoc.c:1168 ocfs2_reserve_clusters+0x3c/0x50 fs/ocfs2/suballoc.c:1229 ocfs2_init_xattr_set_ctxt+0x37c/0x774 fs/ocfs2/xattr.c:3286 ocfs2_xattr_set+0x920/0xe9c fs/ocfs2/xattr.c:3634 ocfs2_xattr_trusted_set+0x4c/0x64 fs/ocfs2/xattr.c:7336 __vfs_setxattr+0x3d8/0x400 fs/xattr.c:200 __vfs_setxattr_noperm+0x120/0x5c4 fs/xattr.c:234 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:295 vfs_setxattr+0x158/0x2ac fs/xattr.c:321 do_setxattr fs/xattr.c:636 [inline] filename_setxattr+0x20c/0x4f8 fs/xattr.c:665 path_setxattrat+0x2e8/0x320 fs/xattr.c:713 __do_sys_setxattr fs/xattr.c:747 [inline] __se_sys_setxattr fs/xattr.c:743 [inline] __arm64_sys_setxattr+0xc0/0xdc fs/xattr.c:743 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x180 arch/arm64/kernel/entry-common.c:771 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:790 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600