====================================================== WARNING: possible circular locking dependency detected 6.15.0-rc1-syzkaller-00333-g5aaaedb0cb54 #0 Not tainted ------------------------------------------------------ syz-executor112/5314 is trying to acquire lock: ffff888045aded80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline] ffff888045aded80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x18d/0x4f30 fs/ocfs2/suballoc.c:786 but task is already holding lock: ffff888045ae3ff8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x635/0x1940 fs/ocfs2/xattr.c:3583 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #5 (&oi->ip_xattr_sem){++++}-{4:4}: lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866 down_read+0xb3/0xa50 kernel/locking/rwsem.c:1524 ocfs2_init_acl+0x39d/0x960 fs/ocfs2/acl.c:366 ocfs2_mknod+0x1c09/0x2b30 fs/ocfs2/namei.c:410 ocfs2_create+0x1ad/0x480 fs/ocfs2/namei.c:673 lookup_open fs/namei.c:3666 [inline] open_last_lookups fs/namei.c:3765 [inline] path_openat+0x194b/0x35d0 fs/namei.c:4001 do_filp_open+0x284/0x4e0 fs/namei.c:4031 do_sys_openat2+0x12b/0x1d0 fs/open.c:1429 do_sys_open fs/open.c:1444 [inline] __do_sys_openat fs/open.c:1460 [inline] __se_sys_openat fs/open.c:1455 [inline] __x64_sys_openat+0x249/0x2a0 fs/open.c:1455 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #4 (jbd2_handle){.+.+}-{0:0}: lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866 start_this_handle+0x1ee4/0x21a0 fs/jbd2/transaction.c:444 jbd2__journal_start+0x2da/0x5d0 fs/jbd2/transaction.c:501 jbd2_journal_start+0x29/0x40 fs/jbd2/transaction.c:540 ocfs2_start_trans+0x3cd/0x710 fs/ocfs2/journal.c:352 ocfs2_mknod+0x1510/0x2b30 fs/ocfs2/namei.c:361 ocfs2_create+0x1ad/0x480 fs/ocfs2/namei.c:673 lookup_open fs/namei.c:3666 [inline] open_last_lookups fs/namei.c:3765 [inline] path_openat+0x194b/0x35d0 fs/namei.c:4001 do_filp_open+0x284/0x4e0 fs/namei.c:4031 do_sys_openat2+0x12b/0x1d0 fs/open.c:1429 do_sys_open fs/open.c:1444 [inline] __do_sys_openat fs/open.c:1460 [inline] __se_sys_openat fs/open.c:1455 [inline] __x64_sys_openat+0x249/0x2a0 fs/open.c:1455 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #3 (&journal->j_trans_barrier){.+.+}-{4:4}: lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866 down_read+0xb3/0xa50 kernel/locking/rwsem.c:1524 ocfs2_start_trans+0x3c2/0x710 fs/ocfs2/journal.c:350 ocfs2_mknod+0x1510/0x2b30 fs/ocfs2/namei.c:361 ocfs2_create+0x1ad/0x480 fs/ocfs2/namei.c:673 lookup_open fs/namei.c:3666 [inline] open_last_lookups fs/namei.c:3765 [inline] path_openat+0x194b/0x35d0 fs/namei.c:4001 do_filp_open+0x284/0x4e0 fs/namei.c:4031 do_sys_openat2+0x12b/0x1d0 fs/open.c:1429 do_sys_open fs/open.c:1444 [inline] __do_sys_openat fs/open.c:1460 [inline] __se_sys_openat fs/open.c:1455 [inline] __x64_sys_openat+0x249/0x2a0 fs/open.c:1455 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (sb_internal#2){.+.+}-{0:0}: lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866 percpu_down_read include/linux/percpu-rwsem.h:52 [inline] __sb_start_write include/linux/fs.h:1783 [inline] sb_start_intwrite include/linux/fs.h:1966 [inline] ocfs2_start_trans+0x2bd/0x710 fs/ocfs2/journal.c:348 ocfs2_mknod+0x1510/0x2b30 fs/ocfs2/namei.c:361 ocfs2_create+0x1ad/0x480 fs/ocfs2/namei.c:673 lookup_open fs/namei.c:3666 [inline] open_last_lookups fs/namei.c:3765 [inline] path_openat+0x194b/0x35d0 fs/namei.c:4001 do_filp_open+0x284/0x4e0 fs/namei.c:4031 do_sys_openat2+0x12b/0x1d0 fs/open.c:1429 do_sys_open fs/open.c:1444 [inline] __do_sys_openat fs/open.c:1460 [inline] __se_sys_openat fs/open.c:1455 [inline] __x64_sys_openat+0x249/0x2a0 fs/open.c:1455 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}: lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866 down_write+0x9c/0x220 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:867 [inline] ocfs2_reserve_local_alloc_bits+0x12b/0x2800 fs/ocfs2/localalloc.c:636 ocfs2_reserve_clusters_with_limit+0x1ba/0xb60 fs/ocfs2/suballoc.c:1166 ocfs2_mknod+0x148a/0x2b30 fs/ocfs2/namei.c:354 ocfs2_create+0x1ad/0x480 fs/ocfs2/namei.c:673 lookup_open fs/namei.c:3666 [inline] open_last_lookups fs/namei.c:3765 [inline] path_openat+0x194b/0x35d0 fs/namei.c:4001 do_filp_open+0x284/0x4e0 fs/namei.c:4031 do_sys_openat2+0x12b/0x1d0 fs/open.c:1429 do_sys_open fs/open.c:1444 [inline] __do_sys_openat fs/open.c:1460 [inline] __se_sys_openat fs/open.c:1455 [inline] __x64_sys_openat+0x249/0x2a0 fs/open.c:1455 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3166 [inline] check_prevs_add kernel/locking/lockdep.c:3285 [inline] validate_chain+0xa69/0x24e0 kernel/locking/lockdep.c:3909 __lock_acquire+0xad5/0xd80 kernel/locking/lockdep.c:5235 lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866 down_write+0x9c/0x220 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:867 [inline] ocfs2_reserve_suballoc_bits+0x18d/0x4f30 fs/ocfs2/suballoc.c:786 ocfs2_reserve_new_metadata_blocks+0x41c/0x9b0 fs/ocfs2/suballoc.c:982 ocfs2_init_xattr_set_ctxt+0x3bb/0x900 fs/ocfs2/xattr.c:3277 ocfs2_xattr_set+0xf52/0x1940 fs/ocfs2/xattr.c:3634 __vfs_setxattr+0x468/0x4a0 fs/xattr.c:200 __vfs_setxattr_noperm+0x12e/0x660 fs/xattr.c:234 vfs_setxattr+0x223/0x430 fs/xattr.c:321 do_setxattr fs/xattr.c:636 [inline] filename_setxattr+0x2dd/0x480 fs/xattr.c:665 path_setxattrat+0x3f7/0x4c0 fs/xattr.c:713 __do_sys_setxattr fs/xattr.c:747 [inline] __se_sys_setxattr fs/xattr.c:743 [inline] __x64_sys_setxattr+0xbc/0xe0 fs/xattr.c:743 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3 --> jbd2_handle --> &oi->ip_xattr_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->ip_xattr_sem); lock(jbd2_handle); lock(&oi->ip_xattr_sem); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3); *** DEADLOCK *** 3 locks held by syz-executor112/5314: #0: ffff888011de6420 (sb_writers#8){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:556 #1: ffff888045ae42c0 (&sb->s_type->i_mutex_key#15){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline] #1: ffff888045ae42c0 (&sb->s_type->i_mutex_key#15){+.+.}-{4:4}, at: vfs_setxattr+0x1e3/0x430 fs/xattr.c:320 #2: ffff888045ae3ff8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x635/0x1940 fs/ocfs2/xattr.c:3583 stack backtrace: CPU: 0 UID: 0 PID: 5314 Comm: syz-executor112 Not tainted 6.15.0-rc1-syzkaller-00333-g5aaaedb0cb54 #0 PREEMPT(full) Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2079 check_noncircular+0x142/0x160 kernel/locking/lockdep.c:2211 check_prev_add kernel/locking/lockdep.c:3166 [inline] check_prevs_add kernel/locking/lockdep.c:3285 [inline] validate_chain+0xa69/0x24e0 kernel/locking/lockdep.c:3909 __lock_acquire+0xad5/0xd80 kernel/locking/lockdep.c:5235 lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866 down_write+0x9c/0x220 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:867 [inline] ocfs2_reserve_suballoc_bits+0x18d/0x4f30 fs/ocfs2/suballoc.c:786 ocfs2_reserve_new_metadata_blocks+0x41c/0x9b0 fs/ocfs2/suballoc.c:982 ocfs2_init_xattr_set_ctxt+0x3bb/0x900 fs/ocfs2/xattr.c:3277 ocfs2_xattr_set+0xf52/0x1940 fs/ocfs2/xattr.c:3634 __vfs_setxattr+0x468/0x4a0 fs/xattr.c:200 __vfs_setxattr_noperm+0x12e/0x660 fs/xattr.c:234 vfs_setxattr+0x223/0x430 fs/xattr.c:321 do_setxattr fs/xattr.c:636 [inline] filename_setxattr+0x2dd/0x480 fs/xattr.c:665 path_setxattrat+0x3f7/0x4c0 fs/xattr.c:713 __do_sys_setxattr fs/xattr.c:747 [inline] __se_sys_setxattr fs/xattr.c:743 [inline] __x64_sys_setxattr+0xbc/0xe0 fs/xattr.c:743 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f1c981971d9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fff33806d08 EFLAGS: 00000246 ORIG_RAX: 00000000000000bc RAX: ffffffffffffffda RBX: 00002000000000c0 RCX: 00007f1c981971d9 RDX: 00002000000003c0 RSI: 0000200000000340 RDI: 0000200000000180 RBP: 0000200000000040 R08: 0000000000000000 R09: 000020000000e480 R10: 0000000000001001 R11: 0000000000000246 R12: 0000200000000240 R13: 00007fff33806f68 R14: 431bde82d7b634db R15: 00007f1c981e003b