======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.4.2360/12235 is trying to acquire lock:
ffff88805c169538 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_init_acl+0x30a/0x770 fs/ocfs2/acl.c:366

but task is already holding lock:
ffff888026b514e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x3a8/0x6f0 fs/ocfs2/journal.c:372

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x3a8/0x6f0 fs/ocfs2/journal.c:372
       ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline]
       ocfs2_reserve_local_alloc_bits+0xb39/0x2620 fs/ocfs2/localalloc.c:668
       ocfs2_reserve_clusters_with_limit+0x1ba/0xc20 fs/ocfs2/suballoc.c:1184
       ocfs2_mknod+0xed1/0x2310 fs/ocfs2/namei.c:354
       ocfs2_mkdir+0x196/0x430 fs/ocfs2/namei.c:657
       vfs_mkdir+0x2a5/0x470 fs/namei.c:4168
       do_mkdirat+0x1dc/0x450 fs/namei.c:4191
       __do_sys_mkdirat fs/namei.c:4206 [inline]
       __se_sys_mkdirat fs/namei.c:4204 [inline]
       __x64_sys_mkdirat+0x89/0xa0 fs/namei.c:4204
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (sb_internal#3){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1633 [inline]
       sb_start_intwrite include/linux/fs.h:1755 [inline]
       ocfs2_start_trans+0x2a9/0x6f0 fs/ocfs2/journal.c:370
       ocfs2_xattr_set+0xe98/0x13a0 fs/ocfs2/xattr.c:3643
       ocfs2_set_acl+0x4d4/0x580 fs/ocfs2/acl.c:254
       ocfs2_acl_chmod+0x253/0x340 fs/ocfs2/acl.c:341
       ocfs2_setattr+0x13e7/0x1bf0 fs/ocfs2/file.c:1296
       notify_change+0xb05/0xde0 fs/attr.c:499
       chmod_common+0x257/0x400 fs/open.c:643
       do_fchmodat+0x10c/0x1e0 fs/open.c:691
       __do_sys_chmod fs/open.c:715 [inline]
       __se_sys_chmod fs/open.c:713 [inline]
       __x64_sys_chmod+0x62/0x70 fs/open.c:713
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&oi->ip_xattr_sem){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x37ef/0x7d80 kernel/locking/lockdep.c:5137
       lock_acquire+0x19e/0x420 kernel/locking/lockdep.c:5754
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ocfs2_init_acl+0x30a/0x770 fs/ocfs2/acl.c:366
       ocfs2_mknod+0x1427/0x2310 fs/ocfs2/namei.c:410
       vfs_mknod+0x325/0x360 fs/namei.c:4046
       do_mknodat+0x386/0x500 fs/namei.c:-1
       __do_sys_mknod fs/namei.c:4129 [inline]
       __se_sys_mknod fs/namei.c:4127 [inline]
       __x64_sys_mknod+0x8e/0xa0 fs/namei.c:4127
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &oi->ip_xattr_sem --> sb_internal#3 --> &journal->j_trans_barrier

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(&journal->j_trans_barrier);
                               lock(sb_internal#3);
                               lock(&journal->j_trans_barrier);
  rlock(&oi->ip_xattr_sem);

 *** DEADLOCK ***

8 locks held by syz.4.2360/12235:
 #0: ffff888077f14418 (sb_writers#21){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:412
 #1: ffff88805c169818 (&type->i_mutex_dir_key#16/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:839 [inline]
 #1: ffff88805c169818 (&type->i_mutex_dir_key#16/1){+.+.}-{3:3}, at: filename_create+0x20f/0x450 fs/namei.c:3937
 #2: ffff88805a5b6d98 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #2: ffff88805a5b6d98 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x171/0x44a0 fs/ocfs2/suballoc.c:804
 #3: ffff88805a5b5118 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #3: ffff88805a5b5118 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x171/0x44a0 fs/ocfs2/suballoc.c:804
 #4: ffff88805a5b09d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #4: ffff88805a5b09d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0x120/0x2620 fs/ocfs2/localalloc.c:635
 #5: ffff888077f14608 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_mknod+0xf33/0x2310 fs/ocfs2/namei.c:361
 #6: ffff888026b514e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x3a8/0x6f0 fs/ocfs2/journal.c:372
 #7: ffff888028426990 (jbd2_handle#2){.+.+}-{0:0}, at: start_this_handle+0x1f3f/0x2170 fs/jbd2/transaction.c:448

stack backtrace:
CPU: 1 PID: 12235 Comm: syz.4.2360 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/24/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x18c/0x250 lib/dump_stack.c:106
 check_noncircular+0x2fc/0x400 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x37ef/0x7d80 kernel/locking/lockdep.c:5137
 lock_acquire+0x19e/0x420 kernel/locking/lockdep.c:5754
 down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
 ocfs2_init_acl+0x30a/0x770 fs/ocfs2/acl.c:366
 ocfs2_mknod+0x1427/0x2310 fs/ocfs2/namei.c:410
 vfs_mknod+0x325/0x360 fs/namei.c:4046
 do_mknodat+0x386/0x500 fs/namei.c:-1
 __do_sys_mknod fs/namei.c:4129 [inline]
 __se_sys_mknod fs/namei.c:4127 [inline]
 __x64_sys_mknod+0x8e/0xa0 fs/namei.c:4127
 do_syscall_x64 arch/x86/entry/common.c:46 [inline]
 do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f9245f9e0d9
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f9246dc2028 EFLAGS: 00000246 ORIG_RAX: 0000000000000085
RAX: ffffffffffffffda RBX: 00007f9246225fa0 RCX: 00007f9245f9e0d9
RDX: 0000000000000708 RSI: 000000000000c000 RDI: 0000200000000100
RBP: 00007f9246035024 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f9246226038 R14: 00007f9246225fa0 R15: 00007ffe33ac03a8
 </TASK>
syz.4.2360 (12235) used greatest stack depth: 18712 bytes left