loop5: detected capacity change from 0 to 1024
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.5.3452/19848 is trying to acquire lock:
ffff888031c4e648 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_get_block+0x398/0x15d0 fs/hfsplus/extents.c:260

but task is already holding lock:
ffff88805ffe08f8 (&sbi->alloc_mutex){+.+.}-{4:4}, at: hfsplus_block_allocate+0xa7/0xc40 fs/hfsplus/bitmap.c:35

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&sbi->alloc_mutex){+.+.}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
       __mutex_lock_common kernel/locking/mutex.c:598 [inline]
       __mutex_lock+0x187/0x1350 kernel/locking/mutex.c:760
       hfsplus_block_allocate+0xa7/0xc40 fs/hfsplus/bitmap.c:35
       hfsplus_file_extend+0xa9a/0x1ba0 fs/hfsplus/extents.c:464
       hfsplus_bmap_reserve+0x122/0x500 fs/hfsplus/btree.c:358
       hfsplus_create_cat+0x18e/0x1120 fs/hfsplus/catalog.c:272
       hfsplus_fill_super+0x12f5/0x1b50 fs/hfsplus/super.c:580
       get_tree_bdev_flags+0x40e/0x4d0 fs/super.c:1691
       vfs_get_tree+0x92/0x2b0 fs/super.c:1751
       fc_mount fs/namespace.c:1208 [inline]
       do_new_mount_fc fs/namespace.c:3651 [inline]
       do_new_mount+0x302/0xa10 fs/namespace.c:3727
       do_mount fs/namespace.c:4050 [inline]
       __do_sys_mount fs/namespace.c:4238 [inline]
       __se_sys_mount+0x313/0x410 fs/namespace.c:4215
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0xfa0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3908
       __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5237
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
       __mutex_lock_common kernel/locking/mutex.c:598 [inline]
       __mutex_lock+0x187/0x1350 kernel/locking/mutex.c:760
       hfsplus_get_block+0x398/0x15d0 fs/hfsplus/extents.c:260
       block_read_full_folio+0x29f/0x830 fs/buffer.c:2420
       filemap_read_folio+0x117/0x380 mm/filemap.c:2444
       do_read_cache_folio+0x350/0x590 mm/filemap.c:4024
       do_read_cache_page mm/filemap.c:4090 [inline]
       read_cache_page+0x5d/0x170 mm/filemap.c:4099
       read_mapping_page include/linux/pagemap.h:993 [inline]
       hfsplus_block_allocate+0xf3/0xc40 fs/hfsplus/bitmap.c:37
       hfsplus_file_extend+0xa9a/0x1ba0 fs/hfsplus/extents.c:464
       hfsplus_get_block+0x40a/0x15d0 fs/hfsplus/extents.c:245
       __block_write_begin_int+0x6b5/0x1900 fs/buffer.c:2145
       block_write_begin fs/buffer.c:2256 [inline]
       cont_write_begin+0x789/0xb50 fs/buffer.c:2594
       hfsplus_write_begin+0x66/0xb0 fs/hfsplus/inode.c:48
       page_symlink+0x26f/0x430 fs/namei.c:5598
       hfsplus_symlink+0xca/0x260 fs/hfsplus/dir.c:449
       vfs_symlink+0x143/0x2f0 fs/namei.c:4817
       do_symlinkat+0x1b1/0x3f0 fs/namei.c:4843
       __do_sys_symlink fs/namei.c:4864 [inline]
       __se_sys_symlink fs/namei.c:4862 [inline]
       __x64_sys_symlink+0x7a/0x90 fs/namei.c:4862
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0xfa0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&sbi->alloc_mutex);
                               lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&sbi->alloc_mutex);
  lock(&HFSPLUS_I(inode)->extents_lock);

 *** DEADLOCK ***

5 locks held by syz.5.3452/19848:
 #0: ffff888078b14420 (sb_writers#33){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:508
 #1: ffff888031c49738 (&type->i_mutex_dir_key#24/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:1025 [inline]
 #1: ffff888031c49738 (&type->i_mutex_dir_key#24/1){+.+.}-{4:4}, at: filename_create+0x1f8/0x3c0 fs/namei.c:4226
 #2: ffff88805ffe0998 (&sbi->vh_mutex){+.+.}-{4:4}, at: hfsplus_symlink+0x81/0x260 fs/hfsplus/dir.c:444
 #3: ffff888031c4df88 (&hip->extents_lock){+.+.}-{4:4}, at: hfsplus_file_extend+0x1f8/0x1ba0 fs/hfsplus/extents.c:453
 #4: ffff88805ffe08f8 (&sbi->alloc_mutex){+.+.}-{4:4}, at: hfsplus_block_allocate+0xa7/0xc40 fs/hfsplus/bitmap.c:35

stack backtrace:
CPU: 0 UID: 0 PID: 19848 Comm: syz.5.3452 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120
 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2043
 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3908
 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5237
 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
 __mutex_lock_common kernel/locking/mutex.c:598 [inline]
 __mutex_lock+0x187/0x1350 kernel/locking/mutex.c:760
 hfsplus_get_block+0x398/0x15d0 fs/hfsplus/extents.c:260
 block_read_full_folio+0x29f/0x830 fs/buffer.c:2420
 filemap_read_folio+0x117/0x380 mm/filemap.c:2444
 do_read_cache_folio+0x350/0x590 mm/filemap.c:4024
 do_read_cache_page mm/filemap.c:4090 [inline]
 read_cache_page+0x5d/0x170 mm/filemap.c:4099
 read_mapping_page include/linux/pagemap.h:993 [inline]
 hfsplus_block_allocate+0xf3/0xc40 fs/hfsplus/bitmap.c:37
 hfsplus_file_extend+0xa9a/0x1ba0 fs/hfsplus/extents.c:464
 hfsplus_get_block+0x40a/0x15d0 fs/hfsplus/extents.c:245
 __block_write_begin_int+0x6b5/0x1900 fs/buffer.c:2145
 block_write_begin fs/buffer.c:2256 [inline]
 cont_write_begin+0x789/0xb50 fs/buffer.c:2594
 hfsplus_write_begin+0x66/0xb0 fs/hfsplus/inode.c:48
 page_symlink+0x26f/0x430 fs/namei.c:5598
 hfsplus_symlink+0xca/0x260 fs/hfsplus/dir.c:449
 vfs_symlink+0x143/0x2f0 fs/namei.c:4817
 do_symlinkat+0x1b1/0x3f0 fs/namei.c:4843
 __do_sys_symlink fs/namei.c:4864 [inline]
 __se_sys_symlink fs/namei.c:4862 [inline]
 __x64_sys_symlink+0x7a/0x90 fs/namei.c:4862
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xfa/0xfa0 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f6e7198efc9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f6e727e2038 EFLAGS: 00000246 ORIG_RAX: 0000000000000058
RAX: ffffffffffffffda RBX: 00007f6e71be5fa0 RCX: 00007f6e7198efc9
RDX: 0000000000000000 RSI: 0000200000000cc0 RDI: 00002000000003c0
RBP: 00007f6e71a11f91 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f6e71be6038 R14: 00007f6e71be5fa0 R15: 00007ffe85ec4478
 </TASK>