hfsplus: invalid extended attribute record ====================================================== WARNING: possible circular locking dependency detected 6.15.0-rc2-syzkaller-00488-g6fea5fabd332 #0 Not tainted ------------------------------------------------------ syz.0.0/5327 is trying to acquire lock: ffff88805338b8f8 (&sbi->alloc_mutex){+.+.}-{4:4}, at: hfsplus_block_free+0xbb/0x4e0 fs/hfsplus/bitmap.c:182 but task is already holding lock: ffff8880404e3708 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_truncate+0x2fa/0xc70 fs/hfsplus/extents.c:577 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}: lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866 __mutex_lock_common kernel/locking/mutex.c:601 [inline] __mutex_lock+0x1a5/0x10c0 kernel/locking/mutex.c:746 hfsplus_get_block+0x385/0x14f0 fs/hfsplus/extents.c:260 block_read_full_folio+0x2d3/0x850 fs/buffer.c:2392 filemap_read_folio+0x14a/0x3b0 mm/filemap.c:2401 do_read_cache_folio+0x373/0x5b0 mm/filemap.c:3885 do_read_cache_page mm/filemap.c:3951 [inline] read_cache_page+0x5b/0x170 mm/filemap.c:3960 read_mapping_page include/linux/pagemap.h:989 [inline] hfsplus_block_allocate+0xee/0x8c0 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0xae0/0x1b70 fs/hfsplus/extents.c:469 hfsplus_get_block+0x408/0x14f0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x691/0x1930 fs/buffer.c:2116 block_write_begin fs/buffer.c:2227 [inline] cont_write_begin+0x781/0xb40 fs/buffer.c:2566 hfsplus_write_begin+0x68/0xb0 fs/hfsplus/inode.c:46 generic_perform_write+0x329/0xa10 mm/filemap.c:4103 generic_file_write_iter+0x10e/0x5e0 mm/filemap.c:4246 new_sync_write fs/read_write.c:591 [inline] vfs_write+0x70f/0xd10 fs/read_write.c:684 ksys_write+0x19d/0x2d0 fs/read_write.c:736 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xf3/0x210 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&sbi->alloc_mutex){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3166 [inline] check_prevs_add kernel/locking/lockdep.c:3285 [inline] validate_chain+0xa69/0x24e0 kernel/locking/lockdep.c:3909 __lock_acquire+0xad5/0xd80 kernel/locking/lockdep.c:5235 lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866 __mutex_lock_common kernel/locking/mutex.c:601 [inline] __mutex_lock+0x1a5/0x10c0 kernel/locking/mutex.c:746 hfsplus_block_free+0xbb/0x4e0 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x17a/0xb00 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0x86a/0xc70 fs/hfsplus/extents.c:592 hfsplus_delete_inode fs/hfsplus/inode.c:-1 [inline] hfsplus_file_release+0x305/0x3e0 fs/hfsplus/inode.c:237 __fput+0x3e9/0x9f0 fs/file_table.c:465 task_work_run+0x251/0x310 kernel/task_work.c:227 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline] exit_to_user_mode_loop kernel/entry/common.c:114 [inline] exit_to_user_mode_prepare include/linux/entry-common.h:329 [inline] __syscall_exit_to_user_mode_work kernel/entry/common.c:207 [inline] syscall_exit_to_user_mode+0x13f/0x340 kernel/entry/common.c:218 do_syscall_64+0x100/0x210 arch/x86/entry/syscall_64.c:100 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 2 locks held by syz.0.0/5327: #0: ffff8880404e38f8 (&sb->s_type->i_mutex_key#20){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline] #0: ffff8880404e38f8 (&sb->s_type->i_mutex_key#20){+.+.}-{4:4}, at: hfsplus_file_release+0xef/0x3e0 fs/hfsplus/inode.c:232 #1: ffff8880404e3708 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_truncate+0x2fa/0xc70 fs/hfsplus/extents.c:577 stack backtrace: CPU: 0 UID: 0 PID: 5327 Comm: syz.0.0 Not tainted 6.15.0-rc2-syzkaller-00488-g6fea5fabd332 #0 PREEMPT(full) Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2079 check_noncircular+0x142/0x160 kernel/locking/lockdep.c:2211 check_prev_add kernel/locking/lockdep.c:3166 [inline] check_prevs_add kernel/locking/lockdep.c:3285 [inline] validate_chain+0xa69/0x24e0 kernel/locking/lockdep.c:3909 __lock_acquire+0xad5/0xd80 kernel/locking/lockdep.c:5235 lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866 __mutex_lock_common kernel/locking/mutex.c:601 [inline] __mutex_lock+0x1a5/0x10c0 kernel/locking/mutex.c:746 hfsplus_block_free+0xbb/0x4e0 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x17a/0xb00 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0x86a/0xc70 fs/hfsplus/extents.c:592 hfsplus_delete_inode fs/hfsplus/inode.c:-1 [inline] hfsplus_file_release+0x305/0x3e0 fs/hfsplus/inode.c:237 __fput+0x3e9/0x9f0 fs/file_table.c:465 task_work_run+0x251/0x310 kernel/task_work.c:227 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline] exit_to_user_mode_loop kernel/entry/common.c:114 [inline] exit_to_user_mode_prepare include/linux/entry-common.h:329 [inline] __syscall_exit_to_user_mode_work kernel/entry/common.c:207 [inline] syscall_exit_to_user_mode+0x13f/0x340 kernel/entry/common.c:218 do_syscall_64+0x100/0x210 arch/x86/entry/syscall_64.c:100 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fa95318e169 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffc32de28e8 EFLAGS: 00000246 ORIG_RAX: 00000000000001b4 RAX: 0000000000000000 RBX: 0000000000010ba6 RCX: 00007fa95318e169 RDX: 0000000000000000 RSI: 000000000000001e RDI: 0000000000000003 RBP: 00007fa9533b7ba0 R08: 0000000000000001 R09: 0000000f32de2bdf R10: 00007fa952fff02c R11: 0000000000000246 R12: 00007fa9533b5fac R13: 00007fa9533b5fa0 R14: ffffffffffffffff R15: 00007ffc32de2a00 hfsplus: unable to mark blocks free: error -5 hfsplus: can't free extent