====================================================== WARNING: possible circular locking dependency detected 6.1.142-syzkaller #0 Not tainted ------------------------------------------------------ syz.8.1562/12619 is trying to acquire lock: ffff8880780642c8 ( &ocfs2_sysfile_lock_key[args->fi_sysfile_type] #3 ){+.+.}-{3:3} , at: inode_lock include/linux/fs.h:758 [inline] , at: ocfs2_reserve_suballoc_bits+0x162/0x4630 fs/ocfs2/suballoc.c:782 but task is already holding lock: ffff888078065c78 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x40c/0x11e0 fs/ocfs2/xattr.c:3587 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #5 (&oi->ip_xattr_sem){++++}-{3:3}: down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520 ocfs2_init_acl+0x2fb/0x720 fs/ocfs2/acl.c:365 ocfs2_mknod+0x1463/0x2350 fs/ocfs2/namei.c:410 ocfs2_create+0x1b6/0x4a0 fs/ocfs2/namei.c:674 vfs_create+0x2db/0x460 fs/namei.c:3184 do_mknodat+0x399/0x4c0 fs/namei.c:4035 __do_sys_mknod fs/namei.c:4068 [inline] __se_sys_mknod fs/namei.c:4066 [inline] __x64_sys_mknod+0x8a/0xa0 fs/namei.c:4066 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #4 (jbd2_handle){++++}-{0:0}: start_this_handle+0x1f49/0x2150 fs/jbd2/transaction.c:463 jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:520 jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:559 ocfs2_start_trans+0x372/0x6c0 fs/ocfs2/journal.c:376 ocfs2_mknod+0xe6a/0x2350 fs/ocfs2/namei.c:361 ocfs2_mkdir+0x1b6/0x4a0 fs/ocfs2/namei.c:657 vfs_mkdir+0x387/0x570 fs/namei.c:4106 do_mkdirat+0x1d0/0x430 fs/namei.c:4131 __do_sys_mkdirat fs/namei.c:4146 [inline] __se_sys_mkdirat fs/namei.c:4144 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #3 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520 ocfs2_start_trans+0x366/0x6c0 fs/ocfs2/journal.c:374 ocfs2_mknod+0xe6a/0x2350 fs/ocfs2/namei.c:361 ocfs2_mkdir+0x1b6/0x4a0 fs/ocfs2/namei.c:657 vfs_mkdir+0x387/0x570 fs/namei.c:4106 do_mkdirat+0x1d0/0x430 fs/namei.c:4131 __do_sys_mkdirat fs/namei.c:4146 [inline] __se_sys_mkdirat fs/namei.c:4144 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #2 (sb_internal#7){.+.+}-{0:0}: percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1891 [inline] sb_start_intwrite include/linux/fs.h:2013 [inline] ocfs2_start_trans+0x267/0x6c0 fs/ocfs2/journal.c:372 ocfs2_mknod+0xe6a/0x2350 fs/ocfs2/namei.c:361 ocfs2_mkdir+0x1b6/0x4a0 fs/ocfs2/namei.c:657 vfs_mkdir+0x387/0x570 fs/namei.c:4106 do_mkdirat+0x1d0/0x430 fs/namei.c:4131 __do_sys_mkdirat fs/namei.c:4146 [inline] __se_sys_mkdirat fs/namei.c:4144 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}: down_write+0x36/0x60 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_reserve_local_alloc_bits+0x122/0x2670 fs/ocfs2/localalloc.c:635 ocfs2_reserve_clusters_with_limit+0x1bb/0xba0 fs/ocfs2/suballoc.c:1162 ocfs2_mknod+0xe18/0x2350 fs/ocfs2/namei.c:354 ocfs2_mkdir+0x1b6/0x4a0 fs/ocfs2/namei.c:657 vfs_mkdir+0x387/0x570 fs/namei.c:4106 do_mkdirat+0x1d0/0x430 fs/namei.c:4131 __do_sys_mkdirat fs/namei.c:4146 [inline] __se_sys_mkdirat fs/namei.c:4144 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049 lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662 down_write+0x36/0x60 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_reserve_suballoc_bits+0x162/0x4630 fs/ocfs2/suballoc.c:782 ocfs2_reserve_new_metadata_blocks+0x400/0x940 fs/ocfs2/suballoc.c:978 ocfs2_init_xattr_set_ctxt+0x2f8/0x750 fs/ocfs2/xattr.c:3281 ocfs2_xattr_set+0xb69/0x11e0 fs/ocfs2/xattr.c:3638 ocfs2_set_acl+0x4e1/0x590 fs/ocfs2/acl.c:254 ocfs2_iop_set_acl+0x16f/0x270 fs/ocfs2/acl.c:285 set_posix_acl fs/posix_acl.c:1160 [inline] posix_acl_xattr_set+0x387/0x3f0 fs/posix_acl.c:1189 __vfs_setxattr+0x3e0/0x420 fs/xattr.c:182 __vfs_setxattr_noperm+0x129/0x5e0 fs/xattr.c:216 vfs_setxattr+0x168/0x2f0 fs/xattr.c:309 do_setxattr fs/xattr.c:594 [inline] setxattr+0x2b2/0x2d0 fs/xattr.c:617 __do_sys_fsetxattr fs/xattr.c:673 [inline] __se_sys_fsetxattr+0x15e/0x1d0 fs/xattr.c:662 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3 --> jbd2_handle --> &oi->ip_xattr_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->ip_xattr_sem); lock(jbd2_handle); lock(&oi->ip_xattr_sem); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3); *** DEADLOCK *** 3 locks held by syz.8.1562/12619: #0: ffff888079192460 (sb_writers#30){.+.+}-{0:0}, at: mnt_want_write_file+0x5c/0x200 fs/namespace.c:437 #1: ffff888078065f48 (&type->i_mutex_dir_key#26){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #1: ffff888078065f48 (&type->i_mutex_dir_key#26){++++}-{3:3}, at: vfs_setxattr+0x141/0x2f0 fs/xattr.c:308 #2: ffff888078065c78 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x40c/0x11e0 fs/ocfs2/xattr.c:3587 stack backtrace: CPU: 0 PID: 12619 Comm: syz.8.1562 Not tainted 6.1.142-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025 Call Trace: dump_stack_lvl+0x168/0x22e lib/dump_stack.c:106 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049 lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662 down_write+0x36/0x60 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_reserve_suballoc_bits+0x162/0x4630 fs/ocfs2/suballoc.c:782 ocfs2_reserve_new_metadata_blocks+0x400/0x940 fs/ocfs2/suballoc.c:978 ocfs2_init_xattr_set_ctxt+0x2f8/0x750 fs/ocfs2/xattr.c:3281 ocfs2_xattr_set+0xb69/0x11e0 fs/ocfs2/xattr.c:3638 ocfs2_set_acl+0x4e1/0x590 fs/ocfs2/acl.c:254 ocfs2_iop_set_acl+0x16f/0x270 fs/ocfs2/acl.c:285 set_posix_acl fs/posix_acl.c:1160 [inline] posix_acl_xattr_set+0x387/0x3f0 fs/posix_acl.c:1189 __vfs_setxattr+0x3e0/0x420 fs/xattr.c:182 __vfs_setxattr_noperm+0x129/0x5e0 fs/xattr.c:216 vfs_setxattr+0x168/0x2f0 fs/xattr.c:309 do_setxattr fs/xattr.c:594 [inline] setxattr+0x2b2/0x2d0 fs/xattr.c:617 __do_sys_fsetxattr fs/xattr.c:673 [inline] __se_sys_fsetxattr+0x15e/0x1d0 fs/xattr.c:662 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7f83f618e929 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f83f7006038 EFLAGS: 00000246 ORIG_RAX: 00000000000000be RAX: ffffffffffffffda RBX: 00007f83f63b5fa0 RCX: 00007f83f618e929 RDX: 0000200000000080 RSI: 0000200000000000 RDI: 0000000000000004 RBP: 00007f83f6210b39 R08: 0000000000000003 R09: 0000000000000000 R10: 0000000000000024 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f83f63b5fa0 R15: 00007fff5f49ecc8