======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.6.1002/17383 is trying to acquire lock:
ffff888040134800 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_setattr+0x9eb/0x1d10 fs/ocfs2/file.c:1275

but task is already holding lock:
ffff88803cd4db90 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0x9dc/0x1d10 fs/ocfs2/file.c:1274

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_alloc_sem){+.+.}-{4:4}:
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1631
       ocfs2_try_remove_refcount_tree+0xb6/0x360 fs/ocfs2/refcounttree.c:932
       ocfs2_xattr_set+0x639/0x13a0 fs/ocfs2/xattr.c:3713
       ocfs2_set_acl+0x6fd/0x7b0 fs/ocfs2/acl.c:255
       ocfs2_iop_set_acl+0x1b1/0x2b0 fs/ocfs2/acl.c:287
       set_posix_acl fs/posix_acl.c:960 [inline]
       vfs_remove_acl+0x56e/0x870 fs/posix_acl.c:1247
       ovl_do_remove_acl fs/overlayfs/overlayfs.h:362 [inline]
       ovl_workdir_create+0x53a/0x8b0 fs/overlayfs/super.c:369
       ovl_make_workdir fs/overlayfs/super.c:678 [inline]
       ovl_get_workdir+0x339/0x1980 fs/overlayfs/super.c:836
       ovl_fill_super_creds fs/overlayfs/super.c:1449 [inline]
       ovl_fill_super+0x1702/0x4360 fs/overlayfs/super.c:1561
       vfs_get_super fs/super.c:1405 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1424
       vfs_get_tree+0x92/0x2a0 fs/super.c:1947
       fc_mount fs/namespace.c:1198 [inline]
       do_new_mount_fc fs/namespace.c:3772 [inline]
       do_new_mount+0x319/0xdc0 fs/namespace.c:3848
       do_mount fs/namespace.c:4181 [inline]
       __do_sys_mount fs/namespace.c:4397 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4374
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&oi->ip_xattr_sem){++++}-{4:4}:
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1631
       ocfs2_xattr_set_handle+0x3f7/0x820 fs/ocfs2/xattr.c:3545
       ocfs2_init_security_set+0xbd/0xe0 fs/ocfs2/xattr.c:7365
       ocfs2_mknod+0x16c8/0x2240 fs/ocfs2/namei.c:423
       ocfs2_mkdir+0x180/0x430 fs/ocfs2/namei.c:660
       vfs_mkdir+0x408/0x620 fs/namei.c:5410
       filename_mkdirat+0x289/0x520 fs/namei.c:5443
       __do_sys_mkdirat fs/namei.c:5464 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5461
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x97/0x200 kernel/locking/rwsem.c:1574
       ocfs2_start_trans+0x3af/0x700 fs/ocfs2/journal.c:369
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:801 [inline]
       ocfs2_reserve_suballoc_bits+0x7b7/0x4850 fs/ocfs2/suballoc.c:950
       ocfs2_reserve_new_metadata_blocks+0x415/0x9a0 fs/ocfs2/suballoc.c:1100
       ocfs2_mknod+0x10e1/0x2240 fs/ocfs2/namei.c:351
       ocfs2_mkdir+0x180/0x430 fs/ocfs2/namei.c:660
       vfs_mkdir+0x408/0x620 fs/namei.c:5410
       filename_mkdirat+0x289/0x520 fs/namei.c:5443
       __do_sys_mkdirat fs/namei.c:5464 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5461
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (sb_internal#3){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3181 [inline]
       check_prevs_add kernel/locking/lockdep.c:3300 [inline]
       validate_chain kernel/locking/lockdep.c:3924 [inline]
       __lock_acquire+0x1520/0x2ce0 kernel/locking/lockdep.c:5253
       lock_acquire+0x106/0x350 kernel/locking/lockdep.c:5886
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs/super.h:19 [inline]
       sb_start_intwrite include/linux/fs/super.h:177 [inline]
       ocfs2_start_trans+0x2ac/0x700 fs/ocfs2/journal.c:367
       ocfs2_setattr+0x9eb/0x1d10 fs/ocfs2/file.c:1275
       notify_change+0xbb8/0xec0 fs/attr.c:556
       ovl_do_notify_change fs/overlayfs/overlayfs.h:209 [inline]
       ovl_workdir_create+0x69c/0x8b0 fs/overlayfs/super.c:379
       ovl_make_workdir fs/overlayfs/super.c:678 [inline]
       ovl_get_workdir+0x339/0x1980 fs/overlayfs/super.c:836
       ovl_fill_super_creds fs/overlayfs/super.c:1449 [inline]
       ovl_fill_super+0x1702/0x4360 fs/overlayfs/super.c:1561
       vfs_get_super fs/super.c:1405 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1424
       vfs_get_tree+0x92/0x2a0 fs/super.c:1947
       fc_mount fs/namespace.c:1198 [inline]
       do_new_mount_fc fs/namespace.c:3772 [inline]
       do_new_mount+0x319/0xdc0 fs/namespace.c:3848
       do_mount fs/namespace.c:4181 [inline]
       __do_sys_mount fs/namespace.c:4397 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4374
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  sb_internal#3 --> &oi->ip_xattr_sem --> &oi->ip_alloc_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_alloc_sem);
                               lock(&oi->ip_xattr_sem);
                               lock(&oi->ip_alloc_sem);
  rlock(sb_internal#3);

 *** DEADLOCK ***

locks held by syz.6.1002/17383: 4, last CPU#0:
 #0: ffff88803a4180e0 (&type->s_umount_key#57/1){+.+.}-{4:4}, at: alloc_super fs/super.c:365 [inline]
 #0: ffff88803a4180e0 (&type->s_umount_key#57/1){+.+.}-{4:4}, at: sget_fc+0x97c/0x1a60 fs/super.c:889
 #1: ffff888040134510 (sb_writers#23){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:494
 #2: ffff88803cd4df40 (&sb->s_type->i_mutex_key#44){++++}-{4:4}, at: inode_lock include/linux/fs.h:1025 [inline]
 #2: ffff88803cd4df40 (&sb->s_type->i_mutex_key#44){++++}-{4:4}, at: ovl_workdir_create+0x63d/0x8b0 fs/overlayfs/super.c:378
 #3: ffff88803cd4db90 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0x9dc/0x1d10 fs/ocfs2/file.c:1274

stack backtrace:
CPU: 0 UID: 0 PID: 17383 Comm: syz.6.1002 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/24/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2059
 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2191
 check_prev_add kernel/locking/lockdep.c:3181 [inline]
 check_prevs_add kernel/locking/lockdep.c:3300 [inline]
 validate_chain kernel/locking/lockdep.c:3924 [inline]
 __lock_acquire+0x1520/0x2ce0 kernel/locking/lockdep.c:5253
 lock_acquire+0x106/0x350 kernel/locking/lockdep.c:5886
 percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
 percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
 __sb_start_write include/linux/fs/super.h:19 [inline]
 sb_start_intwrite include/linux/fs/super.h:177 [inline]
 ocfs2_start_trans+0x2ac/0x700 fs/ocfs2/journal.c:367
 ocfs2_setattr+0x9eb/0x1d10 fs/ocfs2/file.c:1275
 notify_change+0xbb8/0xec0 fs/attr.c:556
 ovl_do_notify_change fs/overlayfs/overlayfs.h:209 [inline]
 ovl_workdir_create+0x69c/0x8b0 fs/overlayfs/super.c:379
 ovl_make_workdir fs/overlayfs/super.c:678 [inline]
 ovl_get_workdir+0x339/0x1980 fs/overlayfs/super.c:836
 ovl_fill_super_creds fs/overlayfs/super.c:1449 [inline]
 ovl_fill_super+0x1702/0x4360 fs/overlayfs/super.c:1561
 vfs_get_super fs/super.c:1405 [inline]
 get_tree_nodev+0xbb/0x150 fs/super.c:1424
 vfs_get_tree+0x92/0x2a0 fs/super.c:1947
 fc_mount fs/namespace.c:1198 [inline]
 do_new_mount_fc fs/namespace.c:3772 [inline]
 do_new_mount+0x319/0xdc0 fs/namespace.c:3848
 do_mount fs/namespace.c:4181 [inline]
 __do_sys_mount fs/namespace.c:4397 [inline]
 __se_sys_mount+0x31d/0x420 fs/namespace.c:4374
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fe6f36be0d9
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe6f1916028 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007fe6f3945fa0 RCX: 00007fe6f36be0d9
RDX: 0000200000000b80 RSI: 0000200000000400 RDI: 0000000000000000
RBP: 00007fe6f3755024 R08: 0000200000000380 R09: 0000000000000000
R10: 0000000000200008 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fe6f3946038 R14: 00007fe6f3945fa0 R15: 00007ffc179db3e8
 </TASK>
overlayfs: upper fs does not support tmpfile.
(syz.6.1002,17383,1):ocfs2_check_dir_entry:339 ERROR: bad entry in directory #72: rec_len is smaller than minimal - offset=0, inode=72, rec_len=1, name_len=1
(syz.6.1002,17383,1):ocfs2_prepare_dir_for_insert:4343 ERROR: status = -2
(syz.6.1002,17383,1):__ocfs2_prepare_orphan_dir:2180 ERROR: status = -2
(syz.6.1002,17383,1):ocfs2_prepare_orphan_dir:2224 ERROR: status = -2
(syz.6.1002,17383,1):ocfs2_prepare_orphan_dir:2240 ERROR: status = -2
(syz.6.1002,17383,1):ocfs2_unlink:967 ERROR: status = -2
overlayfs: cleanup of 'work/#f' failed (-2)
overlayfs: upper fs does not support RENAME_WHITEOUT.
overlayfs: upper fs missing required features.
ocfs2: Unmounting device (7,6) on (node local)