hfsplus: xattr searching failed hfsplus: xattr searching failed ====================================================== WARNING: possible circular locking dependency detected 6.14.0-rc5-syzkaller-g14d05f12084d #0 Not tainted ------------------------------------------------------ syz.1.546/8691 is trying to acquire lock: ffff0000db9fb8f8 (&sbi->alloc_mutex){+.+.}-{4:4}, at: hfsplus_block_free+0xcc/0x414 fs/hfsplus/bitmap.c:182 but task is already holding lock: ffff0000f063d8c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_truncate+0x24c/0xa18 fs/hfsplus/extents.c:577 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}: __mutex_lock_common+0x1f0/0x24b8 kernel/locking/mutex.c:585 __mutex_lock kernel/locking/mutex.c:730 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:782 hfsplus_get_block+0x2c4/0x1168 fs/hfsplus/extents.c:260 block_read_full_folio+0x368/0x914 fs/buffer.c:2396 hfsplus_read_folio+0x28/0x38 fs/hfsplus/inode.c:28 filemap_read_folio+0x108/0x318 mm/filemap.c:2390 do_read_cache_folio+0x368/0x5c0 mm/filemap.c:3960 do_read_cache_page mm/filemap.c:4026 [inline] read_cache_page+0x6c/0x15c mm/filemap.c:4035 read_mapping_page include/linux/pagemap.h:1017 [inline] hfsplus_block_allocate+0xe4/0x728 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0x7b4/0x1544 fs/hfsplus/extents.c:469 hfsplus_get_block+0x398/0x1168 fs/hfsplus/extents.c:245 __block_write_begin_int+0x4c4/0x1610 fs/buffer.c:2116 block_write_begin fs/buffer.c:2226 [inline] cont_write_begin+0x634/0x984 fs/buffer.c:2577 hfsplus_write_begin+0x7c/0xc4 fs/hfsplus/inode.c:46 generic_perform_write+0x29c/0x868 mm/filemap.c:4189 __generic_file_write_iter+0xfc/0x204 mm/filemap.c:4290 generic_file_write_iter+0x108/0x4b4 mm/filemap.c:4316 new_sync_write fs/read_write.c:586 [inline] vfs_write+0x704/0xa9c fs/read_write.c:679 ksys_write+0x15c/0x26c fs/read_write.c:731 __do_sys_write fs/read_write.c:742 [inline] __se_sys_write fs/read_write.c:739 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:739 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #0 (&sbi->alloc_mutex){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3163 [inline] check_prevs_add kernel/locking/lockdep.c:3282 [inline] validate_chain kernel/locking/lockdep.c:3906 [inline] __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5228 lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5851 __mutex_lock_common+0x1f0/0x24b8 kernel/locking/mutex.c:585 __mutex_lock kernel/locking/mutex.c:730 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:782 hfsplus_block_free+0xcc/0x414 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x148/0x8d4 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0x674/0xa18 fs/hfsplus/extents.c:592 hfsplus_setattr+0x184/0x24c fs/hfsplus/inode.c:264 notify_change+0x9f0/0xca0 fs/attr.c:552 do_truncate+0x1c0/0x28c fs/open.c:65 handle_truncate fs/namei.c:3451 [inline] do_open fs/namei.c:3834 [inline] path_openat+0x249c/0x2b1c fs/namei.c:3989 do_filp_open+0x1e8/0x404 fs/namei.c:4016 do_sys_openat2+0x124/0x1b8 fs/open.c:1428 do_sys_open fs/open.c:1443 [inline] __do_sys_openat fs/open.c:1459 [inline] __se_sys_openat fs/open.c:1454 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1454 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 3 locks held by syz.1.546/8691: #0: ffff0000cefb4420 (sb_writers#12){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:547 #1: ffff0000f063dab8 (&sb->s_type->i_mutex_key#27){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:877 [inline] #1: ffff0000f063dab8 (&sb->s_type->i_mutex_key#27){+.+.}-{4:4}, at: do_truncate+0x1ac/0x28c fs/open.c:63 #2: ffff0000f063d8c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_truncate+0x24c/0xa18 fs/hfsplus/extents.c:577 stack backtrace: CPU: 1 UID: 0 PID: 8691 Comm: syz.1.546 Not tainted 6.14.0-rc5-syzkaller-g14d05f12084d #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025 Call trace: show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:466 (C) __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0xe4/0x150 lib/dump_stack.c:120 dump_stack+0x1c/0x28 lib/dump_stack.c:129 print_circular_bug+0x154/0x1c0 kernel/locking/lockdep.c:2076 check_noncircular+0x310/0x404 kernel/locking/lockdep.c:2208 check_prev_add kernel/locking/lockdep.c:3163 [inline] check_prevs_add kernel/locking/lockdep.c:3282 [inline] validate_chain kernel/locking/lockdep.c:3906 [inline] __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5228 lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5851 __mutex_lock_common+0x1f0/0x24b8 kernel/locking/mutex.c:585 __mutex_lock kernel/locking/mutex.c:730 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:782 hfsplus_block_free+0xcc/0x414 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x148/0x8d4 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0x674/0xa18 fs/hfsplus/extents.c:592 hfsplus_setattr+0x184/0x24c fs/hfsplus/inode.c:264 notify_change+0x9f0/0xca0 fs/attr.c:552 do_truncate+0x1c0/0x28c fs/open.c:65 handle_truncate fs/namei.c:3451 [inline] do_open fs/namei.c:3834 [inline] path_openat+0x249c/0x2b1c fs/namei.c:3989 do_filp_open+0x1e8/0x404 fs/namei.c:4016 do_sys_openat2+0x124/0x1b8 fs/open.c:1428 do_sys_open fs/open.c:1443 [inline] __do_sys_openat fs/open.c:1459 [inline] __se_sys_openat fs/open.c:1454 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1454 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600