overlayfs: upper fs does not support tmpfile. ====================================================== WARNING: possible circular locking dependency detected 6.14.0-rc3-syzkaller-00079-g87a132e73910 #0 Not tainted ------------------------------------------------------ syz.4.1024/12370 is trying to acquire lock: ffff8880535d1800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:877 [inline] ffff8880535d1800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: ocfs2_remove_inode+0x15c/0x8a0 fs/ocfs2/inode.c:669 but task is already holding lock: ffff8880535d3480 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:877 [inline] ffff8880535d3480 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: ocfs2_wipe_inode+0x2e6/0x1220 fs/ocfs2/inode.c:790 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}: down_write+0x93/0x200 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:877 [inline] ocfs2_del_inode_from_orphan+0x112/0x700 fs/ocfs2/namei.c:2727 ocfs2_dio_end_io_write+0x2cc/0xf30 fs/ocfs2/aops.c:2310 ocfs2_dio_end_io+0x139/0x2a0 fs/ocfs2/aops.c:2408 dio_complete+0x21b/0x980 fs/direct-io.c:281 __blockdev_direct_IO+0x3412/0x40b0 fs/direct-io.c:1303 ocfs2_direct_IO+0x263/0x360 fs/ocfs2/aops.c:2445 generic_file_direct_write+0x19a/0x410 mm/filemap.c:4112 __generic_file_write_iter+0x11b/0x240 mm/filemap.c:4276 ocfs2_file_write_iter+0xbd0/0x21d0 fs/ocfs2/file.c:2469 iter_file_splice_write+0x912/0x10b0 fs/splice.c:743 do_splice_from fs/splice.c:941 [inline] direct_splice_actor+0x192/0x6c0 fs/splice.c:1164 splice_direct_to_actor+0x349/0xa40 fs/splice.c:1108 do_splice_direct_actor fs/splice.c:1207 [inline] do_splice_direct+0x178/0x250 fs/splice.c:1233 do_sendfile+0xafb/0xe40 fs/read_write.c:1363 __do_sys_sendfile64 fs/read_write.c:1424 [inline] __se_sys_sendfile64 fs/read_write.c:1410 [inline] __x64_sys_sendfile64+0x1da/0x220 fs/read_write.c:1410 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}: down_write+0x93/0x200 kernel/locking/rwsem.c:1577 ocfs2_create_local_dquot+0x158/0xb40 fs/ocfs2/quota_local.c:1232 ocfs2_acquire_dquot+0x628/0xaf0 fs/ocfs2/quota_global.c:883 dqget+0x694/0x1160 fs/quota/dquot.c:977 dquot_set_dqblk+0x2b/0x1230 fs/quota/dquot.c:2820 quota_setquota+0x4c8/0x5f0 fs/quota/quota.c:310 do_quotactl+0xb00/0x13d0 fs/quota/quota.c:802 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl fs/quota/quota.c:917 [inline] __x64_sys_quotactl+0x1b4/0x440 fs/quota/quota.c:917 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&dquot->dq_lock){+.+.}-{4:4}: __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x19b/0xb10 kernel/locking/mutex.c:730 wait_on_dquot fs/quota/dquot.c:354 [inline] dqget+0x5f2/0x1160 fs/quota/dquot.c:972 __dquot_initialize+0x588/0xd50 fs/quota/dquot.c:1505 ocfs2_get_init_inode+0xe8/0x1b0 fs/ocfs2/namei.c:202 ocfs2_mknod+0x93f/0x2440 fs/ocfs2/namei.c:310 ocfs2_mkdir+0x185/0x450 fs/ocfs2/namei.c:656 vfs_mkdir+0x580/0x860 fs/namei.c:4313 do_mkdirat+0x301/0x3a0 fs/namei.c:4336 __do_sys_mkdirat fs/namei.c:4351 [inline] __se_sys_mkdirat fs/namei.c:4349 [inline] __x64_sys_mkdirat+0x83/0xb0 fs/namei.c:4349 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3163 [inline] check_prevs_add kernel/locking/lockdep.c:3282 [inline] validate_chain kernel/locking/lockdep.c:3906 [inline] __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5228 lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5851 down_write+0x93/0x200 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:877 [inline] ocfs2_remove_inode+0x15c/0x8a0 fs/ocfs2/inode.c:669 ocfs2_wipe_inode+0x455/0x1220 fs/ocfs2/inode.c:832 ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline] ocfs2_evict_inode+0x6da/0x1610 fs/ocfs2/inode.c:1230 evict+0x40c/0x960 fs/inode.c:796 iput_final fs/inode.c:1946 [inline] iput fs/inode.c:1972 [inline] iput+0x52a/0x890 fs/inode.c:1958 ocfs2_dentry_iput+0x13a/0x340 fs/ocfs2/dcache.c:407 dentry_unlink_inode+0x282/0x480 fs/dcache.c:438 __dentry_kill+0x1d0/0x600 fs/dcache.c:643 dput.part.0+0x4b1/0x9b0 fs/dcache.c:885 dput+0x1f/0x30 fs/dcache.c:875 ovl_check_rename_whiteout fs/overlayfs/super.c:604 [inline] ovl_make_workdir fs/overlayfs/super.c:703 [inline] ovl_get_workdir fs/overlayfs/super.c:826 [inline] ovl_fill_super+0x1321/0x6750 fs/overlayfs/super.c:1394 vfs_get_super fs/super.c:1280 [inline] get_tree_nodev+0xdd/0x190 fs/super.c:1299 vfs_get_tree+0x8e/0x340 fs/super.c:1814 do_new_mount fs/namespace.c:3560 [inline] path_mount+0x14e6/0x1f10 fs/namespace.c:3887 do_mount fs/namespace.c:3900 [inline] __do_sys_mount fs/namespace.c:4111 [inline] __se_sys_mount fs/namespace.c:4088 [inline] __x64_sys_mount+0x28f/0x310 fs/namespace.c:4088 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4 --> &ocfs2_quota_ip_alloc_sem_key --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type] Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]); lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4); *** DEADLOCK *** 5 locks held by syz.4.1024/12370: #0: ffff88804ccf80e0 (&type->s_umount_key#57/1){+.+.}-{4:4}, at: alloc_super+0x23d/0xbd0 fs/super.c:344 #1: ffff88801b792420 (sb_writers#21){.+.+}-{0:0}, at: ovl_make_workdir fs/overlayfs/super.c:664 [inline] #1: ffff88801b792420 (sb_writers#21){.+.+}-{0:0}, at: ovl_get_workdir fs/overlayfs/super.c:826 [inline] #1: ffff88801b792420 (sb_writers#21){.+.+}-{0:0}, at: ovl_fill_super+0xe3c/0x6750 fs/overlayfs/super.c:1394 #2: ffff888053756d80 (&sb->s_type->i_mutex_key#29/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:912 [inline] #2: ffff888053756d80 (&sb->s_type->i_mutex_key#29/1){+.+.}-{4:4}, at: ovl_check_rename_whiteout fs/overlayfs/super.c:566 [inline] #2: ffff888053756d80 (&sb->s_type->i_mutex_key#29/1){+.+.}-{4:4}, at: ovl_make_workdir fs/overlayfs/super.c:703 [inline] #2: ffff888053756d80 (&sb->s_type->i_mutex_key#29/1){+.+.}-{4:4}, at: ovl_get_workdir fs/overlayfs/super.c:826 [inline] #2: ffff888053756d80 (&sb->s_type->i_mutex_key#29/1){+.+.}-{4:4}, at: ovl_fill_super+0x11bb/0x6750 fs/overlayfs/super.c:1394 #3: ffff888026ef0bd0 (&osb->nfs_sync_rwlock){.+.+}-{4:4}, at: ocfs2_nfs_sync_lock+0xe5/0x2e0 fs/ocfs2/dlmglue.c:2875 #4: ffff8880535d3480 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:877 [inline] #4: ffff8880535d3480 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: ocfs2_wipe_inode+0x2e6/0x1220 fs/ocfs2/inode.c:790 stack backtrace: CPU: 0 UID: 0 PID: 12370 Comm: syz.4.1024 Not tainted 6.14.0-rc3-syzkaller-00079-g87a132e73910 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120 print_circular_bug+0x490/0x760 kernel/locking/lockdep.c:2076 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2208 check_prev_add kernel/locking/lockdep.c:3163 [inline] check_prevs_add kernel/locking/lockdep.c:3282 [inline] validate_chain kernel/locking/lockdep.c:3906 [inline] __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5228 lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5851 down_write+0x93/0x200 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:877 [inline] ocfs2_remove_inode+0x15c/0x8a0 fs/ocfs2/inode.c:669 ocfs2_wipe_inode+0x455/0x1220 fs/ocfs2/inode.c:832 ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline] ocfs2_evict_inode+0x6da/0x1610 fs/ocfs2/inode.c:1230 evict+0x40c/0x960 fs/inode.c:796 iput_final fs/inode.c:1946 [inline] iput fs/inode.c:1972 [inline] iput+0x52a/0x890 fs/inode.c:1958 ocfs2_dentry_iput+0x13a/0x340 fs/ocfs2/dcache.c:407 dentry_unlink_inode+0x282/0x480 fs/dcache.c:438 __dentry_kill+0x1d0/0x600 fs/dcache.c:643 dput.part.0+0x4b1/0x9b0 fs/dcache.c:885 dput+0x1f/0x30 fs/dcache.c:875 ovl_check_rename_whiteout fs/overlayfs/super.c:604 [inline] ovl_make_workdir fs/overlayfs/super.c:703 [inline] ovl_get_workdir fs/overlayfs/super.c:826 [inline] ovl_fill_super+0x1321/0x6750 fs/overlayfs/super.c:1394 vfs_get_super fs/super.c:1280 [inline] get_tree_nodev+0xdd/0x190 fs/super.c:1299 vfs_get_tree+0x8e/0x340 fs/super.c:1814 do_new_mount fs/namespace.c:3560 [inline] path_mount+0x14e6/0x1f10 fs/namespace.c:3887 do_mount fs/namespace.c:3900 [inline] __do_sys_mount fs/namespace.c:4111 [inline] __se_sys_mount fs/namespace.c:4088 [inline] __x64_sys_mount+0x28f/0x310 fs/namespace.c:4088 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f100a18cde9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f100afdf038 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007f100a3a5fa0 RCX: 00007f100a18cde9 RDX: 0000400000000000 RSI: 0000400000000080 RDI: 0000000000000000 RBP: 00007f100a20e2a0 R08: 00004000000002c0 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f100a3a5fa0 R15: 00007ffe47be77d8 overlayfs: upper fs does not support RENAME_WHITEOUT. overlayfs: failed to set xattr on upper overlayfs: ...falling back to redirect_dir=nofollow. overlayfs: ...falling back to index=off. overlayfs: ...falling back to uuid=null. overlayfs: upper fs missing required features. ocfs2: Unmounting device (7,4) on (node local)